Add 2 performance revisions for ovs_packet_cmd_execute
1.Stores mainbody of sw_flow(600+ bytes) in stack
Benifit: avoid kmem cache alloc/free caused by ovs_flow_alloc/free
2.Define sw_flow_without_stats_init to initialize mainbody of
struct sw_flow, which does not provides memory for sw_flow_
Thanks Dumitru,
I added my sign-off and pushed this to main.
On 2/17/23 16:07, Dumitru Ceara wrote:
On 2/17/23 14:32, Mark Michelson wrote:
---
NEWS | 3 +++
configure.ac | 2 +-
debian/changelog | 6 ++
3 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/NE
Thanks Dumitru,
I added the date placeholder to NEWS, added my sign-off, and pushed the
change to main, and created branch-23.03 from main on this commit.
On 2/17/23 16:06, Dumitru Ceara wrote:
On 2/17/23 14:32, Mark Michelson wrote:
---
NEWS | 2 +-
configure.ac | 2 +-
On 2/17/23 14:32, Mark Michelson wrote:
> ---
> NEWS | 3 +++
> configure.ac | 2 +-
> debian/changelog | 6 ++
> 3 files changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/NEWS b/NEWS
> index 74510866e..39e567a36 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -1,3 +1,6 @@
> +Po
On 2/17/23 14:32, Mark Michelson wrote:
> ---
> NEWS | 2 +-
> configure.ac | 2 +-
> debian/changelog | 4 ++--
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/NEWS b/NEWS
> index fd0fee75c..74510866e 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -1,4 +1,4 @@
> -Post
On 2/17/23 18:50, Lorenzo Bianconi wrote:
> Add Similar to IPv4 counterpart, introduce IPv6 load-balancer health
> check support.
>
> Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2136094
> Reviewed-by: Ales Musil
> Acked-by: Mark Michelson
> Signed-off-by: Lorenzo Bianconi
> ---
Th
On 2/17/23 18:50, Lorenzo Bianconi wrote:
> Add Similar to IPv4 counterpart, introduce IPv6 load-balancer health
> check support.
>
> Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2136094
> Reviewed-by: Ales Musil
> Acked-by: Mark Michelson
> Signed-off-by: Lorenzo Bianconi
> ---
Th
As mentioned in the structure definition in lb.h, northd should never
use 'vip_port' instead it should always use 'port_str'. That's because
it might not always be possible to evaluate the port value in northd,
e.g., when using LB templates.
This commit also updates other occurrences of 'vip_port
Flow lookup doesn't include masks of the final stage in a resulted
flow wildcards in case that stage had L4 ports match. Only the result
of ports trie lookup is added to the mask. It might be sufficient in
many cases, but it's not correct, because ports trie is not how we
decided that the packet
Add Similar to IPv4 counterpart, introduce IPv6 load-balancer health
check support.
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2136094
Reviewed-by: Ales Musil
Acked-by: Mark Michelson
Signed-off-by: Lorenzo Bianconi
---
Changes since v3:
- improve code parsing in ovn_lb_svc_create
> On 2/10/23 12:18, Lorenzo Bianconi wrote:
> > Add Similar to IPv4 counterpart, introduce IPv6 load-balancer health
> > check support.
> >
> > Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2136094
> > Acked-by: Mark Michelson
> > Signed-off-by: Lorenzo Bianconi
> > ---
> > Changes si
On 2/17/23 11:38, Ales Musil wrote:
> Bump ovs submodule to cd1cf6a2 which is after
> 0a758703 ("conntrack: Properly unNAT inner header of related traffic.").
> This patch is needed for "LB - ICMP related traffic" system test to work
> with OvS userspace netdev.
>
> Signed-off-by: Ales Musil
> --
Function is_gratuitous_arp() and function is_garp() are all used to judge
whether the flow is gratuitous arp. It is not necessary to use two functions
to do the same thing and just keep one.
Gratuitous ARP message is a generally link-level broadcast messages and
carry the same IP in sender and tar
Ilya Maximets writes:
> On 2/14/23 14:54, Eelco Chaudron wrote:
>> Run "make check-offloads" as part of the GitHub actions tests.
>>
>> This test was run 25 times using GitHub actions, and the
>> failing rerun test cases where excluded. There are quite some
>> first-run failures, but unfortunate
Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Author Mark Michelson needs to sign off.
Lines checked: 53, Warnings: 0, Errors: 1
Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Author Mark Michelson needs to sign off.
Lines checked: 53, Warnings: 0, Errors: 1
---
NEWS | 3 +++
configure.ac | 2 +-
debian/changelog | 6 ++
3 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/NEWS b/NEWS
index 74510866e..39e567a36 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,6 @@
+Post v23.03.0
+-
+
OVN v23.03.0
-
- o
---
NEWS | 2 +-
configure.ac | 2 +-
debian/changelog | 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/NEWS b/NEWS
index fd0fee75c..74510866e 100644
--- a/NEWS
+++ b/NEWS
@@ -1,4 +1,4 @@
-Post v22.12.0
+OVN v23.03.0
-
- ovn-controller: Exper
On Fri, Feb 17, 2023 at 1:04 PM Dumitru Ceara wrote:
> On 2/16/23 17:43, Mark Michelson wrote:
> > Thanks Ales,
> >
> > Acked-by: Mark Michelson
> >
>
> Thanks, Ales and Mark! I applied this to the main branch. But I do
> have one concern: I think we need to start using this in CI upstream to
On 2/16/23 17:43, Mark Michelson wrote:
> Thanks Ales,
>
> Acked-by: Mark Michelson
>
Thanks, Ales and Mark! I applied this to the main branch. But I do
have one concern: I think we need to start using this in CI upstream to
avoid the script/dockerfile going stale. Ales, do you have some cyc
On 2/16/23 20:20, Mark Michelson wrote:
> Thanks Ales,
>
> Acked-by: Mark Michelson
>
Thanks, Mark and Ales!
I applied this to the main branch with a minor change. Please see
below.
Regards,
Dumitru
diff --git a/lib/lb.c b/lib/lb.c
index a5cd0eced9..e941434c4e 100644
--- a/lib/lb.c
+++ b/li
On 2/16/23 20:04, Mark Michelson wrote:
> The "local_datapths" typo is still present in this version of the patch.
> However, since that's the only thing holding it back,
>
> Acked-by: Mark Michelson
>
> I think whoever commits this can correct the typo.
>
Thanks, Mark and Ales! I applied it
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 81 characters long (recommended limit is 79)
#27 FILE: .github/workflows/test.ym
Add support for running system tests with
OvS userspace netdev.
Signed-off-by: Ales Musil
---
.ci/linux-build.sh | 69 ++
1 file changed, 46 insertions(+), 23 deletions(-)
diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh
index d7a49b6c0..2e38358a2
The dpctl/del-flows shouldn't be used on running
ofproto layer, use revalidator/purge instead.
Signed-off-by: Ales Musil
---
tests/system-ovn.at | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/system-ovn.at b/tests/system-ovn.at
index f2a0b7b33..29671690f 100644
--- a/t
The ADD_INT does not work very well with userspace datapath.
To avoid any warnings that might fail the tests
use ADD_VETH instead. Also encourage this in
documentation for ADD_INT, because there should
be good reasoning behind using internal interface.
Signed-off-by: Ales Musil
---
tests/system-
The test with jemalloc and clang is redundant as
we are already testing jemalloc with gcc. Replace
it with system-test-userspace which runs system tests
over userspace OvS datapath.
Signed-off-by: Ales Musil
---
.github/workflows/test.yml | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(
Newer versions of ping6 print some info to
stderr when specified with -v flag. This info
causes tests to fail. Do not use the verbose
output.
Signed-off-by: Ales Musil
---
tests/system-ovn.at | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/system-ovn.at b/tests/syst
There is a bug in userspace datapath that causes
failures within the LB affinity test [0].
Skip the test until the bug is fixed.
[0] https://bugzilla.redhat.com/2170828
Signed-off-by: Ales Musil
---
tests/system-kmod-macros.at | 6 ++
tests/system-ovn.at | 2 ++
tests/syste
Bump ovs submodule to cd1cf6a2 which is after
0a758703 ("conntrack: Properly unNAT inner header of related traffic.").
This patch is needed for "LB - ICMP related traffic" system test to work
with OvS userspace netdev.
Signed-off-by: Ales Musil
---
ovs | 2 +-
1 file changed, 1 insertion(+), 1 d
In order to allow there are ome fixes done to the
tests itself. The LB affinity needs a fix from OvS
side so it is marked as skip for the time being.
To save some on the CI the last patch replaces
unit tests with Clang and Jemalloc with the
userspace system tests, the Jemalloc still
run with GCC.
31 matches
Mail list logo
