Re: [ovs-dev] [PATCH v3] utilities/ofctl: add-meters for save and restore

2023-02-24 Thread Adrian Moreno
Hi Wan, Sorry for the delay in the review. I've started looking at this patch. Please see some initial comments below. I'll continue on Monday. Thanks. On 11/15/22 05:16, Wan Junjie wrote: put dump-meters' result in one line so add-meters can handle. save and restore meters when restart

Re: [ovs-dev] [PATCH] ipfix: make template and stats interval configurable

2023-02-24 Thread Simon Horman
On Fri, Feb 24, 2023 at 04:08:46PM +0100, Adrian Moreno wrote: > > > On 2/24/23 14:09, Simon Horman wrote: > > On Fri, Feb 24, 2023 at 12:05:45PM +0100, Adrian Moreno wrote: > > > Please ignore this patch that was sent without the correct version. > > > > Is the "v4" posting the correct

Re: [ovs-dev] [PATCH] ipfix: make template and stats interval configurable

2023-02-24 Thread Adrian Moreno
On 2/24/23 14:09, Simon Horman wrote: On Fri, Feb 24, 2023 at 12:05:45PM +0100, Adrian Moreno wrote: Please ignore this patch that was sent without the correct version. Is the "v4" posting the correct revision? https://mail.openvswitch.org/pipermail/ovs-dev/2023-February/402308.html

Re: [ovs-dev] [PATCH] ipfix: make template and stats interval configurable

2023-02-24 Thread Simon Horman
On Fri, Feb 24, 2023 at 12:05:45PM +0100, Adrian Moreno wrote: > Please ignore this patch that was sent without the correct version. Is the "v4" posting the correct revision? https://mail.openvswitch.org/pipermail/ovs-dev/2023-February/402308.html ___

Re: [ovs-dev] [PATCH] ofproto: Fix re-creation of tunnel backing interfaces on restart.

2023-02-24 Thread Simon Horman
On Thu, Feb 23, 2023 at 05:39:27PM +0100, Ilya Maximets wrote: > Tunnel OpenFlow ports do not exist in the datapath, instead there is a > tunnel backing interface that serves all the tunnels of the same type. > For example, if the geneve port 'my_tunnel' is added to OVS, it will > create

[ovs-dev] [PATCH v2] test: move check for tc ingress pps support to test script

2023-02-24 Thread Simon Horman
Move check for tc ingress pps support to from aclocal to test script This has several problems: 1. Stderror from failing commands is output when executing various make targets. 2. There are various failure conditions that lead to veth0 and veth1 being created by not cleaned up. 3. The

Re: [ovs-dev] [PATCH ovn] northd: add router broadcast option to logical switch

2023-02-24 Thread 0-day Robot
Bleep bloop. Greetings Felix Hüttner, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Felix Hüttner needs to sign off. WARNING: Unexpected sign-offs from developers

Re: [ovs-dev] [PATCH ovn] northd: fix comments on functions

2023-02-24 Thread 0-day Robot
Bleep bloop. Greetings Felix Hüttner, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Felix Hüttner needs to sign off. WARNING: Unexpected sign-offs from developers

Re: [ovs-dev] [PATCH] ipfix: make template and stats interval configurable

2023-02-24 Thread Adrian Moreno
Please ignore this patch that was sent without the correct version. On 2/24/23 12:03, Adrián Moreno wrote: From: Adrian Moreno Add options to the IPFIX table configure the interval to send statistics and template information. Reviewed-by: Simon Horman Signed-off-by: Adrian Moreno --- -

[ovs-dev] [PATCH v4] ipfix: make template and stats interval configurable

2023-02-24 Thread Adrián Moreno
From: Adrian Moreno Add options to the IPFIX table configure the interval to send statistics and template information. Reviewed-by: Simon Horman Signed-off-by: Adrian Moreno --- - v4: - Bump vswitchd's schema version to 8.4.0. - v3: - Removed unit tests which generate errors in Intel

[ovs-dev] [PATCH ovn] northd: add router broadcast option to logical switch

2023-02-24 Thread Felix Hüttner via dev
Assume the following setup: ++ | Logical Router | | lr001 +-+ ++ | | ++ | | Logical Router | | ++ +--+ | lr002 +-+-+ Logical Switch +-+ Phyiscal Network | ++ | |

[ovs-dev] [PATCH] ipfix: make template and stats interval configurable

2023-02-24 Thread Adrián Moreno
From: Adrian Moreno Add options to the IPFIX table configure the interval to send statistics and template information. Reviewed-by: Simon Horman Signed-off-by: Adrian Moreno --- - v4: - Bump vswitchd's schema version to 8.4.0. - v3: - Removed unit tests which generate errors in Intel

[ovs-dev] [PATCH ovn] northd: fix comments on functions

2023-02-24 Thread Felix Hüttner via dev
the comments did refer to tables 1 below the actual table number. Signed-off-by: Felix Huettner --- northd/northd.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/northd/northd.c b/northd/northd.c index 770a5b50e..c366b545e 100644 ---

[ovs-dev] [PATCH 0/1] usdt-scripts: use ebpf to track upcall_cost

2023-02-24 Thread Adrián Moreno
I've been recently looking into upcall tracing inside OVS and its current challenges. The current implementation is available in utilities/usdt-scripts/upcall_cost.py. Essentially it collects all the events and collelates them in userspace after the data collection has ended. I have been