Re: [ovs-dev] [PATCH v2 ovn 1/2] northd: move defrag router pipeline stage forward

On Fri, Mar 17, 2023 at 5:35 PM Numan Siddique wrote: > > On Wed, Mar 8, 2023 at 6:45 AM Simon Horman wrote: > > > > On Mon, Feb 27, 2023 at 02:52:53PM +0100, Lorenzo Bianconi wrote: > > > Introduce a post_defrag router ingress pipeline stage and move current > > > defrag > > > code in

Re: [ovs-dev] [PATCH v2 ovn 2/2] northd: add flows to defrag IP traffic

On Wed, Mar 8, 2023 at 6:45 AM Simon Horman wrote: > > On Mon, Feb 27, 2023 at 02:52:54PM +0100, Lorenzo Bianconi wrote: > > Introduce a priority-100 flow in the ingress router defrag stage in > > order to just perform IP traffic defragmentation without doing any dnat > > operation. This change

Re: [ovs-dev] [PATCH v2 ovn 1/2] northd: move defrag router pipeline stage forward

On Wed, Mar 8, 2023 at 6:45 AM Simon Horman wrote: > > On Mon, Feb 27, 2023 at 02:52:53PM +0100, Lorenzo Bianconi wrote: > > Introduce a post_defrag router ingress pipeline stage and move current > > defrag > > code in post_defrag stage. This is a preliminary patch to just defrag IP > > fragment

[ovs-dev] [PATCH ovn] ovn-nbctl: Fix documentation typo

Typo fix in the ovn-nbctl man page. According to the ovn-nbctl man8 (NAT): [--may-exist] [--stateless] [--gateway_port=GATEWAY_PORT] lr-nat-add router type external_ip logical_ip [logical_port external_mac] Result using man page syntax: ovn-nbctl: unrecognized option '--gateway_port' The option

Re: [ovs-dev] [PATCH ovn] ovn-nbctl: Fix documentation typo

Bleep bloop. Greetings Roberto Bartzen Acosta, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: corrupt patch at line 23 error: could not build fake ancestor hint: Use 'git am

Re: [ovs-dev] [PATCH v5] ofproto-dpif-upcall: Don't set statistics to 0 when they jump back

Send from my phone > Op 17 mrt. 2023 om 21:11 heeft Marcelo Ricardo Leitner > het volgende geschreven: > > On Thu, Mar 16, 2023 at 09:51:34AM +0100, Eelco Chaudron wrote: >> >> >>> On 22 Dec 2022, at 13:32, Eelco Chaudron wrote: >>> On 22 Dec 2022, at 10:26, Balazs Nemeth wrote: >>>

[ovs-dev] [PATCH ovn] ovn-nbctl: Fix documentation typo

Typo fix in the ovn-nbctl man page. According to the ovn-nbctl man8: * NAT command [--may-exist] [--stateless] [--gateway_port=GATEWAY_PORT] lr-nat-add router type external_ip logical_ip [logical_port external_mac] Result using man page sintax: ovn-nbctl: unrecognized option '--gateway_port' The

Re: [ovs-dev] [PATCH v5] ofproto-dpif-upcall: Don't set statistics to 0 when they jump back

On Thu, Mar 16, 2023 at 09:51:34AM +0100, Eelco Chaudron wrote: > > > On 22 Dec 2022, at 13:32, Eelco Chaudron wrote: > > > On 22 Dec 2022, at 10:26, Balazs Nemeth wrote: > > > >> The only way that stats->{n_packets,n_bytes} would decrease is due to an > >> overflow, or if there are bugs in how

[ovs-dev] [RFC ovn 2/3] controller: configure qos through ovs qos table and do not run tc directly

Rework OVN QoS implementation in order to configure it through OVS QoS table instead of running tc command directly bypassing OVS. Signed-off-by: Lorenzo Bianconi --- controller/binding.c| 316 ++-- controller/ovn-controller.c | 5 +

[ovs-dev] [RFC ovn 3/3] controller: get rid of egress_ifaces

Remove sset egress_ifaces processing since it is no longer used. Signed-off-by: Lorenzo Bianconi --- controller/binding.c| 55 - controller/binding.h| 1 - controller/ovn-controller.c | 10 ++- tests/ovn-performance.at| 5 4

[ovs-dev] [RFC ovn 1/3] controller: fix interface qos aliasing

In the current codebase it is not possible to specify two different QoS rules for two different localnet ports, even if they are running on two different datapaths. Both ports will be configured with the latest QoS rule in the hashmap since it is not possible to link the QoS rule to the

[ovs-dev] [RFC ovn 0/3] rework OVN QoS implementation

Rework OVN QoS implementation in order to configure it through OVS QoS table instead of running tc command directly bypassing OVS. Lorenzo Bianconi (3): controller: fix interface qos aliasing controller: configure qos through ovs qos table and do not run tc directly controller: get rid

Re: [ovs-dev] [RFC ovn 0/2] ACL Sampling using per-flow IPFIX

On Tue, Oct 18, 2022 at 12:00 PM Adrian Moreno wrote: > > Based on the introduction of the OVN "sample" action (still WIP) [1], > the proposal of this RFC is to use per-flow IPFIX sampling to increase > visibility on ACLs. > > The idea of ACL sampling is very similar to the already existing ACL >

Re: [ovs-dev] [PATCH ovn] northd: add router broadcast option to logical switch

On Fri, Feb 24, 2023 at 6:04 AM Felix Hüttner via dev wrote: > > Assume the following setup: > > ++ > | Logical Router | > | lr001 +-+ > ++ | >| > ++ | > | Logical Router | | ++ +--+ > |

Re: [ovs-dev] [PATCH ovn] expr: Remove supersets from OR expressions.

On 3/17/23 20:25, Ilya Maximets wrote: > While crushing OR expressions, OVN removes exact replicas of sub > expressions. However, there could be many CMP expressions that are > supersets of each other. These are most likely to be created as a > result of cross-product while expanding brackets in

Re: [ovs-dev] [PATCH ovn v2] northd, controller: Commit flows dropped by ACLs to conntrack

On Mon, Feb 13, 2023 at 11:36 AM Abhiram Sangana wrote: > > This patch adds support to commit connections dropped/rejected by > ACLs to the connection tracking table. Dropped connections are > committed to conntrack only if NB_Global options:ct_commit_acl_drop > is set to true (false by default)

[ovs-dev] [PATCH ovn] expr: Remove supersets from OR expressions.

While crushing OR expressions, OVN removes exact replicas of sub expressions. However, there could be many CMP expressions that are supersets of each other. These are most likely to be created as a result of cross-product while expanding brackets in the AND expression in crush_and_numeric(),

Re: [ovs-dev] [PATCH] ovs-tcpdump:Stdout is shutdown before ovs-tcpdump exit

On 11/24/22 02:26, Songtao Zhan wrote: To: d...@openvswitch.org If there is a pipe behind ovs-tcpdump(such as ovs-tcpdump -i eth0 | grep "192.168.1.1"), the child process (grep "192.168.1.1") may exit first and close the pipe when received SIGTERM. When farther process(ovs-tcpdump) exit,

Re: [ovs-dev] [PATCH ovn v3] controller: Add config option per LB to enable/disable CT flush

On Fri, Mar 17, 2023 at 11:06 AM Dumitru Ceara wrote: > > On 3/17/23 16:04, Ilya Maximets wrote: > > On 3/17/23 11:48, Ales Musil wrote: > >> The CT flush was enabled by default for every LB, add > >> config option called "ct_flush" that allows > >> users to enable/disable the CT flush. The CT

Re: [ovs-dev] [PATCH ovn v3] controller: Add config option per LB to enable/disable CT flush

On 3/17/23 16:04, Ilya Maximets wrote: > On 3/17/23 11:48, Ales Musil wrote: >> The CT flush was enabled by default for every LB, add >> config option called "ct_flush" that allows >> users to enable/disable the CT flush. The CT flush option >> is set to "false" by default. >> >> Reported-at:

Re: [ovs-dev] [PATCH ovn v3] controller: Add config option per LB to enable/disable CT flush

On 3/17/23 11:48, Ales Musil wrote: > The CT flush was enabled by default for every LB, add > config option called "ct_flush" that allows > users to enable/disable the CT flush. The CT flush option > is set to "false" by default. > > Reported-at: https://bugzilla.redhat.com/2178962 >

[ovs-dev] [PATCH v2] backtrace: Extent the backtrace functionality

Use the backtrace functions that is provided by libc, this allows us to get backtrace that is independent of the current memory map of the process. Which in turn can be used for debugging/tracing purpose. The backtrace is not 100% accurate due to various optimizations, most notably

Re: [ovs-dev] [PATCH] backtrace: Replace usage of libunwind with libc backtrace

On 3/17/23 14:49, Ales Musil wrote: > > > On Fri, Mar 17, 2023 at 2:42 PM Ilya Maximets > wrote: > > On 3/17/23 14:03, Ales Musil wrote: > > Use the backtrace functions that is provided by libc > > this allows us to get backtrace that is independent of >

Re: [ovs-dev] [PATCH] backtrace: Replace usage of libunwind with libc backtrace

On Fri, Mar 17, 2023 at 2:42 PM Ilya Maximets wrote: > On 3/17/23 14:03, Ales Musil wrote: > > Use the backtrace functions that is provided by libc > > this allows us to get backtrace that is independent of > > the current memory ap of the process. Which in turn can > > be used for

Re: [ovs-dev] [PATCH] backtrace: Replace usage of libunwind with libc backtrace

On 3/17/23 14:03, Ales Musil wrote: > Use the backtrace functions that is provided by libc > this allows us to get backtrace that is independent of > the current memory ap of the process. Which in turn can > be used for debugging/tracing purpose. The backtrace > is not 100% accurate due to various

Re: [ovs-dev] [PATCH] backtrace: Replace usage of libunwind with libc backtrace

Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 81 characters long (recommended limit is 79) #205 FILE: lib/backtrace.h:38: *

[ovs-dev] [PATCH] backtrace: Replace usage of libunwind with libc backtrace

Use the backtrace functions that is provided by libc this allows us to get backtrace that is independent of the current memory ap of the process. Which in turn can be used for debugging/tracing purpose. The backtrace is not 100% accurate due to various optimizations, most notably

Re: [ovs-dev] [PATCH ovn v3] controller: Add config option per LB to enable/disable CT flush

On 3/17/23 11:48, Ales Musil wrote: > The CT flush was enabled by default for every LB, add > config option called "ct_flush" that allows > users to enable/disable the CT flush. The CT flush option > is set to "false" by default. > > Reported-at: https://bugzilla.redhat.com/2178962 >

[ovs-dev] [PATCH ovn v3] controller: Add config option per LB to enable/disable CT flush

The CT flush was enabled by default for every LB, add config option called "ct_flush" that allows users to enable/disable the CT flush. The CT flush option is set to "false" by default. Reported-at: https://bugzilla.redhat.com/2178962 Signed-off-by: Ales Musil --- v2: Make the feature opt-in.

Re: [ovs-dev] [PATCH ovn v2] controller: Add config option per LB to enable/disable CT flush

On Fri, Mar 17, 2023 at 10:33 AM Dumitru Ceara wrote: > On 3/17/23 08:14, Ales Musil wrote: > > The CT flush was enabled by default for every LB, add > > config option called "ct_flush" that allows > > users to enable/disable the CT flush. The CT flush option > > is set to "false" by default. >

Re: [ovs-dev] [PATCH ovn v2] controller: Add config option per LB to enable/disable CT flush

On 3/17/23 08:14, Ales Musil wrote: > The CT flush was enabled by default for every LB, add > config option called "ct_flush" that allows > users to enable/disable the CT flush. The CT flush option > is set to "false" by default. > > Reported-at: https://bugzilla.redhat.com/2178962 >

Re: [ovs-dev] [PATCH ovn] controller: Add config option per LB to enable/disable CT flush

On 3/16/23 21:00, Ilya Maximets wrote: > On 3/16/23 20:44, Dumitru Ceara wrote: >>> diff --git a/ovn-nb.xml b/ovn-nb.xml >>> index 73f707aa0..c5dbebd1d 100644 >>> --- a/ovn-nb.xml >>> +++ b/ovn-nb.xml >>> @@ -2041,6 +2041,13 @@ or >>> the affinity timeslot. Max supported affinity_timeout

Re: [ovs-dev] [PATCH ovn v2] northd, controller: Commit flows dropped by ACLs to conntrack

On 3/3/23 13:20, Abhiram Sangana wrote: > > >> On 13 Feb 2023, at 16:35, Abhiram Sangana >> wrote: >> >> This patch adds support to commit connections dropped/rejected by >> ACLs to the connection tracking table. Dropped connections are >> committed to conntrack only if NB_Global

[ovs-dev] [PATCH ovn v2] controller: Add config option per LB to enable/disable CT flush

The CT flush was enabled by default for every LB, add config option called "ct_flush" that allows users to enable/disable the CT flush. The CT flush option is set to "false" by default. Reported-at: https://bugzilla.redhat.com/2178962 Signed-off-by: Ales Musil --- v2: Make the feature opt-in.