Re: [ovs-dev] [RFC v2 ovn 0/4] rework OVN QoS implementation

On Tue, Apr 4, 2023 at 12:57 PM Ihar Hrachyshka wrote: > > Hi, > > thanks for v2. I will leave general comments to the series here, and I > will post some specific comments to corresponding patches where > appropriate. > > -- > > The series claims that VIF support for QoS was not present before.

Re: [ovs-dev] [PATCH ovn v4 0/2] expr: Optimize OR expressions.

On 4/5/23 21:48, Ilya Maximets wrote: > This patch set covers removal of expressions which are subsets of other > wider expressions. This allows to avoid flow explosion in case of > negative matches. More details are in commit messages. > > Version 2: > * Became a patch set. > * Added tests

[ovs-dev] [PATCH ovn v4 1/2] expr: Remove supersets from OR expressions.

While crushing OR expressions, OVN removes exact replicas of sub expressions. However, there could be many CMP expressions that are supersets of each other. These are most likely to be created as a result of cross-product while expanding brackets in the AND expression in crush_and_numeric(),

[ovs-dev] [PATCH ovn v4 2/2] expr: Avoid crash if all sub-expressions crushed down to 'true'.

expr_sort() can potentially return NULL if all sub-expressions got crushed into 'true'. This didn't happen before, but can happen with more aggressive optimizations in crush_or(). Acked-by: Han Zhou Signed-off-by: Ilya Maximets --- lib/expr.c | 2 +- 1 file changed, 1 insertion(+), 1

[ovs-dev] [PATCH ovn v4 0/2] expr: Optimize OR expressions.

This patch set covers removal of expressions which are subsets of other wider expressions. This allows to avoid flow explosion in case of negative matches. More details are in commit messages. Version 2: * Became a patch set. * Added tests and missing bitmap.h include. * Code switched to

[ovs-dev] [PATCH v2] github: Test building Fedora RPMs.

Testing that RPMs can be built to catch possible spec file issues like missing dependencies. GitHub seems to have an agreement with Docker Hub about rate limiting of image downloads, so it should not affect us. We may switch to quay.io if that will ever become a problem in the future.

Re: [ovs-dev] [PATCH] github: Test building Fedora RPMs.

On 4/5/23 15:51, David Marchand wrote: > On Thu, Jan 19, 2023 at 2:15 PM Ilya Maximets wrote: >> >> Testing that RPMs can be built to catch possible spec file >> issues like missing dependencies. >> >> GitHub seems to have an agreement with Docker Hub about rate >> limiting of image downloads, so

Re: [ovs-dev] [PATCH ovn v3 1/2] expr: Remove supersets from OR expressions.

On 3/31/23 23:30, Han Zhou wrote: > > > On Fri, Mar 31, 2023 at 5:34 AM Ilya Maximets > wrote: >> >> On 3/31/23 06:39, Han Zhou wrote: >> > >> > >> > On Wed, Mar 29, 2023 at 9:05 AM Ilya Maximets > > > >

Re: [ovs-dev] [PATCH ovn v2 4/9] ci: Add Ubuntu based Dockerfile

On Wed, Mar 15, 2023 at 7:29 AM Ales Musil wrote: > > Add Dockerfile based on Ubuntu that contains all > dependencies and can be later on used by CI. > > Signed-off-by: Ales Musil > --- > utilities/automake.mk | 1 + > utilities/containers/Makefile | 11 ++--- >

Re: [ovs-dev] [PATCH v1 0/2] Add netdev-dpdk support for ingress and egress pkts policer.

Hi Simon, : ) Thanks for your reply. There are some explanations about your comments. Best regards, Huang Lin. > -Original Message- > From: Simon Horman > Sent: Wednesday, April 5, 2023 8:28 PM > To: lin huang > Cc: d...@openvswitch.org; i.maxim...@ovn.org > Subject: Re: [ovs-dev]

Re: [ovs-dev] [RFC ovn 1/2] northd: add ACL Sampling

On 4/5/23 09:20, Adrian Moreno wrote: > Thanks for the comments Dumitru! > > On 3/30/23 12:02, Dumitru Ceara wrote: >> On 10/18/22 17:59, Adrian Moreno wrote: >>> Introduce a new table called Sample where per-flow IPFIX configuration >>> can be specified. >>> Also, reference rows from such table

Re: [ovs-dev] [PATCH ovn v2 1/9] ci: Add missing packages to the container

On Wed, Mar 29, 2023 at 12:58 PM Ilya Maximets wrote: > > On 3/29/23 12:36, Dumitru Ceara wrote: > > On 3/29/23 12:32, Ales Musil wrote: > >> On Wed, Mar 29, 2023 at 9:55 AM Dumitru Ceara wrote: > >> > >>> On 3/29/23 09:43, Dumitru Ceara wrote: > On 3/29/23 07:29, Ales Musil wrote: > >

Re: [ovs-dev] [PATCH] github: Test building Fedora RPMs.

On Thu, Jan 19, 2023 at 2:15 PM Ilya Maximets wrote: > > Testing that RPMs can be built to catch possible spec file > issues like missing dependencies. > > GitHub seems to have an agreement with Docker Hub about rate > limiting of image downloads, so it should not affect us. > We may switch to

Re: [ovs-dev] [PATCH ovn v2] controller: Clear tunnels from old integration bridge

Thank you for v2! All good now. Acked-By: Ihar Hrachyshka On Mon, Apr 3, 2023 at 5:50 AM Ales Musil wrote: > > After integration bridge change the tunnels would > stay on the old bridge preventing new tunnels creation > and disrupting traffic. Detect the bridge change > and clear the tunnels

Re: [ovs-dev] [PATCH v2] util: fix an issue that thread name cannot be set

On 31 Mar 2023, at 10:11, Songtao Zhan wrote: > To: d...@openvswitch.org, > i.maxim...@ovn.org > > The name of the current thread consists of a name with a maximum > length of 16 bytes and a thread ID. The final name may be longer > than 16 bytes. If the name is longer than 16 bytes, the

Re: [ovs-dev] [RFC v2 ovn 0/4] rework OVN QoS implementation

Hello: I've made a copy in my personal google account to be able to share the doc link to anyone: https://docs.google.com/document/d/1Q4IV4tTahPfAwEj5lenYzskpEk1Sp2zIYY1ZL_ws0DM/edit?usp=sharing. This link has commenter permissions. Regards. On Tue, Apr 4, 2023 at 6:57 PM Ihar Hrachyshka

Re: [ovs-dev] [RFC ovn 0/3] rework OVN QoS implementation

I don't think that will be a problem because: * The number of external interfaces will be one or two (each interface is an expensive network card). * We'll have as many TC rules as ports. If we have 100 ports (for example) in a compute node, that will be 100 rules (max). That is not a big deal for

Re: [ovs-dev] [External] Re: [PATCH v5] utilities/ofctl: add-meters for save and restore

Hi Wan Junjie, On Tue, Apr 04, 2023 at 03:42:47PM +0800, Wan Junjie wrote: > Hi Simon, > > On Wed, Mar 29, 2023 at 11:57 PM Simon Horman > wrote: > > On Fri, Mar 10, 2023 at 09:03:48PM +0800, Wan Junjie wrote: ... > > > @@ -805,5 +831,73 @@ ofputil_format_meter_mod(struct ds *s, const struct

Re: [ovs-dev] [PATCH ovn] northd: rever ct.inv drop flows

On Tue, Apr 04, 2023 at 08:13:05PM +0200, Lorenzo Bianconi wrote: > Partially revert the following commit since it introduces a regression > when we want to directly connect to a backend ip from a client outside > the cluster for gw-router-port scenario. > > commit

Re: [ovs-dev] [PATCH ovn] northd: take into account qos_min_rate in port_has_qos_params

On Tue, Apr 04, 2023 at 11:01:26PM +0200, Lorenzo Bianconi wrote: > Similar to qos_max_rate and qos_burst, take into account qos_min_rate in > port_has_qos_params routine. > > Fixes: dbf12e5fe1f7 ("qos: add support for port minimum bandwidth guarantee") > Signed-off-by: Lorenzo Bianconi Hi

Re: [ovs-dev] [PATCH v1 0/2] Add netdev-dpdk support for ingress and egress pkts policer.

On Tue, Apr 04, 2023 at 01:46:05PM +, lin huang wrote: > Hi Ilya, > > Pls review my code. > > I want to add a new policer which is pps-based in netdev-dpdk module. > The policer is divided into ingress and egress part. Both use the ovs native > tocken bucket library as the counter. >

[ovs-dev] [PATCH net v3] net: openvswitch: fix race on port output

assume the following setup on a single machine: 1. An openvswitch instance with one bridge and default flows 2. two network namespaces "server" and "client" 3. two ovs interfaces "server" and "client" on the bridge 4. for each ovs interface a veth pair with a matching name and 32 rx and tx

Re: [ovs-dev] [RFC ovn 0/2] ACL Sampling using per-flow IPFIX

On 3/30/23 12:03, Dumitru Ceara wrote: On 3/21/23 10:48, Adrian Moreno wrote: On 3/17/23 20:59, Numan Siddique wrote: On Tue, Oct 18, 2022 at 12:00 PM Adrian Moreno wrote: Based on the introduction of the OVN "sample" action (still WIP) [1], the proposal of this RFC is to use per-flow

Re: [ovs-dev] [RFC ovn 1/2] northd: add ACL Sampling

Thanks for the comments Dumitru! On 3/30/23 12:02, Dumitru Ceara wrote: On 10/18/22 17:59, Adrian Moreno wrote: Introduce a new table called Sample where per-flow IPFIX configuration can be specified. Also, reference rows from such table from the ACL table to enable the configuration of ACL