Re: [ovs-dev] [PATCH ovn 2/2] northd.c: Avoid sending ICMP time exceeded for multicast packets.

2023-04-13 Thread Han Zhou
On Thu, Apr 13, 2023 at 12:44 PM Han Zhou wrote: > > > > On Thu, Apr 13, 2023 at 12:35 PM Dumitru Ceara wrote: > > > > On 4/13/23 21:21, Han Zhou wrote: > > > On Thu, Apr 13, 2023 at 8:37 AM Dumitru Ceara wrote: > > >> > > >> On 4/13/23 17:34, Han Zhou wrote: > > >>> On Thu, Apr 13, 2023 at

[ovs-dev] [PATCH ovn v2 1/2] tests: define fmt_pkt function to construct packets with scapy

2023-04-13 Thread Ihar Hrachyshka
Scapy allows to define packets in descriptive form that is easier to digest and debug. Signed-off-by: Ihar Hrachyshka --- v1: initial version v2: use .decode() instead of sed to truncate b'...' v2: remove unnecessary backspaces in example of use v2: use $PYTHON3 --- tests/ovn-macros.at | 23

[ovs-dev] [PATCH ovn v2 2/2] Omit ACLs for nd || nd_ra || nd_rs || mldv1 || mldv2

2023-04-13 Thread Ihar Hrachyshka
When setting flows for LS, OVN distinguishes between two states: where there’s a stateful ACL present in its list (has_stateful == true *) and when it’s missing (all ACLs are stateless). When has_stateful == true, the following is done (among other things): - ct handling flows are set; - they are

Re: [ovs-dev] [PATCH ovn 2/2] Omit ACLs for nd || nd_ra || nd_rs || mldv1 || mldv2

2023-04-13 Thread Ihar Hrachyshka
I'm not sure but maybe it's something to do with the difference between python3 paths in github CI and locally in my env? I see python3 in github is /opt/hostedtoolcache/Python/3.11.2/x64/bin/python3. I will try $PYTHON3 in the function definition and see if it works better. On Thu, Apr 13, 2023

Re: [ovs-dev] [PATCH ovn] Expose distributed gateway port information in NB DB

2023-04-13 Thread Dumitru Ceara
On 4/13/23 21:42, Han Zhou wrote: > On Thu, Apr 13, 2023 at 10:01 AM Dumitru Ceara wrote: >> >> On 4/13/23 18:26, Han Zhou wrote: >> >> I suggest a different approach if we want to go ahead and propagate >>> such >> information to the NB: can't we store the "active chassis" >

Re: [ovs-dev] [PATCH ovn 2/2] northd.c: Avoid sending ICMP time exceeded for multicast packets.

2023-04-13 Thread Han Zhou
On Thu, Apr 13, 2023 at 12:35 PM Dumitru Ceara wrote: > > On 4/13/23 21:21, Han Zhou wrote: > > On Thu, Apr 13, 2023 at 8:37 AM Dumitru Ceara wrote: > >> > >> On 4/13/23 17:34, Han Zhou wrote: > >>> On Thu, Apr 13, 2023 at 12:54 AM Dumitru Ceara > > wrote: > > On 4/13/23 07:07, Han

Re: [ovs-dev] [PATCH ovn] Expose distributed gateway port information in NB DB

2023-04-13 Thread Han Zhou
On Thu, Apr 13, 2023 at 10:01 AM Dumitru Ceara wrote: > > On 4/13/23 18:26, Han Zhou wrote: > > I suggest a different approach if we want to go ahead and propagate > > such > information to the NB: can't we store the "active chassis" information > per

Re: [ovs-dev] [PATCH ovn 2/2] northd.c: Avoid sending ICMP time exceeded for multicast packets.

2023-04-13 Thread Dumitru Ceara
On 4/13/23 21:21, Han Zhou wrote: > On Thu, Apr 13, 2023 at 8:37 AM Dumitru Ceara wrote: >> >> On 4/13/23 17:34, Han Zhou wrote: >>> On Thu, Apr 13, 2023 at 12:54 AM Dumitru Ceara > wrote: On 4/13/23 07:07, Han Zhou wrote: > In RFC1812 section 5.3.1, it is mentioned that: >

Re: [ovs-dev] [PATCH ovn 2/2] northd.c: Avoid sending ICMP time exceeded for multicast packets.

2023-04-13 Thread Han Zhou
On Thu, Apr 13, 2023 at 8:37 AM Dumitru Ceara wrote: > > On 4/13/23 17:34, Han Zhou wrote: > > On Thu, Apr 13, 2023 at 12:54 AM Dumitru Ceara wrote: > >> > >> On 4/13/23 07:07, Han Zhou wrote: > >>> In RFC1812 section 5.3.1, it is mentioned that: > >>> > >>>If the TTL is reduced to zero (or

Re: [ovs-dev] [PATCH ovn] Expose distributed gateway port information in NB DB

2023-04-13 Thread Mark Michelson
Hi all, I just caught up on this discussion and wanted to complicate things further by suggesting another idea. I think the Red Hat folks have heard this before, but I'm not sure if it has been brought up on this list before. Aside from this issue, there is also this high-priority issue from

Re: [ovs-dev] [PATCH net] selftests: openvswitch: adjust datapath NL message declaration

2023-04-13 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Wed, 12 Apr 2023 07:58:28 -0400 you wrote: > The netlink message for creating a new datapath takes an array > of ports for the PID creation. This shouldn't cause much issue > but correct it for future cases where we

Re: [ovs-dev] [PATCH ovn] Expose distributed gateway port information in NB DB

2023-04-13 Thread Dumitru Ceara
On 4/13/23 18:26, Han Zhou wrote: I suggest a different approach if we want to go ahead and propagate > such information to the NB: can't we store the "active chassis" information per Gateway_chassis/HA_Chassis_group instead? That's O(number-of-chassis) records that we

Re: [ovs-dev] [PATCH ovn] Expose distributed gateway port information in NB DB

2023-04-13 Thread Han Zhou
On Thu, Apr 13, 2023 at 6:33 AM Lucas Martins wrote: > > Hi Han, Dumitru and Luis, > > Thanks for the discussion and ideas so far. My reply is inline: > > On Thu, Apr 13, 2023 at 10:45 AM Luis Tomas Bolivar wrote: > > > > > > > > On Thu, Apr 13, 2023 at 9:33 AM Dumitru Ceara wrote: > >> > >> On

Re: [ovs-dev] [PATCH ovn] ci: Don't install gcc-multilib in Ubuntu images.

2023-04-13 Thread Dumitru Ceara
On 4/13/23 17:19, Ales Musil wrote: > On Thu, Apr 13, 2023 at 5:16 PM Dumitru Ceara wrote: > >> The package is not available for ARM: >> E: Package 'gcc-multilib' has no installation candidate. >> >> It's needed for the 32-bit tests and will be addressed separately when >> CI starts using the

Re: [ovs-dev] [PATCH ovn 2/2] northd.c: Avoid sending ICMP time exceeded for multicast packets.

2023-04-13 Thread Dumitru Ceara
On 4/13/23 17:34, Han Zhou wrote: > On Thu, Apr 13, 2023 at 12:54 AM Dumitru Ceara wrote: >> >> On 4/13/23 07:07, Han Zhou wrote: >>> In RFC1812 section 5.3.1, it is mentioned that: >>> >>>If the TTL is reduced to zero (or less), the packet MUST be >>>discarded, and if the destination is

Re: [ovs-dev] [PATCH ovn 2/2] northd.c: Avoid sending ICMP time exceeded for multicast packets.

2023-04-13 Thread Han Zhou
On Thu, Apr 13, 2023 at 12:54 AM Dumitru Ceara wrote: > > On 4/13/23 07:07, Han Zhou wrote: > > In RFC1812 section 5.3.1, it is mentioned that: > > > >If the TTL is reduced to zero (or less), the packet MUST be > >discarded, and if the destination is not a multicast address the > >

Re: [ovs-dev] [PATCH ovn] ci: Don't install gcc-multilib in Ubuntu images.

2023-04-13 Thread Ales Musil
On Thu, Apr 13, 2023 at 5:16 PM Dumitru Ceara wrote: > The package is not available for ARM: > E: Package 'gcc-multilib' has no installation candidate. > > It's needed for the 32-bit tests and will be addressed separately when > CI starts using the pre-built container images. > > Fixes:

Re: [ovs-dev] [PATCH ovn v2 0/9] Use containers on CI

2023-04-13 Thread Dumitru Ceara
On 4/13/23 17:03, Ales Musil wrote: > On Thu, Apr 13, 2023 at 4:53 PM Dumitru Ceara wrote: > >> On 3/15/23 07:29, Ales Musil wrote: >>> The containers will bring some benefits >>> to the overall CI proccess: >>> >>> 1) Reproducibility, there is high chance >>> that if the test is failing

[ovs-dev] [PATCH ovn] ci: Don't install gcc-multilib in Ubuntu images.

2023-04-13 Thread Dumitru Ceara
The package is not available for ARM: E: Package 'gcc-multilib' has no installation candidate. It's needed for the 32-bit tests and will be addressed separately when CI starts using the pre-built container images. Fixes: f89f5664259b ("ci: Add Ubuntu based Dockerfile") Signed-off-by: Dumitru

Re: [ovs-dev] [PATCH ovn v2 0/9] Use containers on CI

2023-04-13 Thread Ales Musil
On Thu, Apr 13, 2023 at 4:53 PM Dumitru Ceara wrote: > On 3/15/23 07:29, Ales Musil wrote: > > The containers will bring some benefits > > to the overall CI proccess: > > > > 1) Reproducibility, there is high chance > > that if the test is failing constantly on CI > > users can reproduce it by

Re: [ovs-dev] [PATCH ovn v2 0/9] Use containers on CI

2023-04-13 Thread Dumitru Ceara
On 3/15/23 07:29, Ales Musil wrote: > The containers will bring some benefits > to the overall CI proccess: > > 1) Reproducibility, there is high chance > that if the test is failing constantly on CI > users can reproduce it by getting the same image > and running the affect test. > > 2) Ease of

[ovs-dev] [PATCH v3 ovn 5/7] controller: use unsigned long long int fro qos_max_rate/qos_min_rate/qos_burst

2023-04-13 Thread Lorenzo Bianconi
This patch allow to configure max/min rate greater than 4Gbps https://bugzilla.redhat.com/show_bug.cgi?id=2129742 Tested-by: Rodolfo Alonso Signed-off-by: Lorenzo Bianconi --- controller/binding.c | 30 ++ 1 file changed, 18 insertions(+), 12 deletions(-) diff

[ovs-dev] [PATCH v3 ovn 7/7] controller: get rid of ovn-egress-iface parameter

2023-04-13 Thread Lorenzo Bianconi
Remove ovn-egress-iface paramter since it is no longer used. https://bugzilla.redhat.com/show_bug.cgi?id=2129742 Tested-by: Rodolfo Alonso Signed-off-by: Lorenzo Bianconi --- controller/binding.c | 23 +-- northd/ovn-northd.8.xml | 6 -- tests/ovn-performance.at |

[ovs-dev] [PATCH v3 ovn 6/7] northd: introduce qos_physical_network in port_binding other_config column

2023-04-13 Thread Lorenzo Bianconi
This patch allows to apply QoS rules on the localnet port related to logical switch ports running on the same datapath. Considering the following netowrk configuration: LSP{0,1} -- LogicalSwitch -- Localnet0 It is possible to apply the following QoS rules on Localnet0 on egress traffic entering

[ovs-dev] [PATCH v3 ovn 4/7] controller: improve ovs port lookup by name and qos

2023-04-13 Thread Lorenzo Bianconi
Introduce ovsport_lookup_by_name and ovsport_lookup_by_qos routines in order to speed-up ovs port lookup based on port name or qos. https://bugzilla.redhat.com/show_bug.cgi?id=2129742 Tested-by: Rodolfo Alonso Signed-off-by: Lorenzo Bianconi --- controller/binding.c| 45

[ovs-dev] [PATCH v3 ovn 3/7] controller: configure qos through ovs qos table and do not run tc directly

2023-04-13 Thread Lorenzo Bianconi
Rework OVN QoS implementation in order to configure it through OVS QoS table instead of running tc command directly bypassing OVS. https://bugzilla.redhat.com/show_bug.cgi?id=2129742 Tested-by: Rodolfo Alonso Signed-off-by: Lorenzo Bianconi --- controller/binding.c| 421

[ovs-dev] [PATCH v3 ovn 1/7] controller: remove tunnel interfaces from egress_ifaces sset

2023-04-13 Thread Lorenzo Bianconi
Remove tunnel interfaces from egress list in order to not shape them. Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2129742 Tested-by: Rodolfo Alonso Signed-off-by: Lorenzo Bianconi --- controller/binding.c | 9 - 1 file changed, 9 deletions(-) diff --git

[ovs-dev] [PATCH v3 ovn 2/7] controller: convert egress_ifaces to smap

2023-04-13 Thread Lorenzo Bianconi
This is a preliminary patch to allow OVN to configure QoS through OvS db instead of running tc directly. https://bugzilla.redhat.com/show_bug.cgi?id=2129742 Tested-by: Rodolfo Alonso Signed-off-by: Lorenzo Bianconi --- controller/binding.c| 56 ++---

[ovs-dev] [PATCH v3 ovn 0/7] Configure OVN QoS thorugh OvS db

2023-04-13 Thread Lorenzo Bianconi
Rework OVN QoS implementation in order to configure it through OVS QoS table instead of running tc command directly bypassing OVS. This series allows to apply QoS rules on the localnet port related to logical switch ports running on the same datapath. Considering the following netowrk

Re: [ovs-dev] [PATCH ovn] Expose distributed gateway port information in NB DB

2023-04-13 Thread Lucas Martins
Hi Han, Dumitru and Luis, Thanks for the discussion and ideas so far. My reply is inline: On Thu, Apr 13, 2023 at 10:45 AM Luis Tomas Bolivar wrote: > > > > On Thu, Apr 13, 2023 at 9:33 AM Dumitru Ceara wrote: >> >> On 4/12/23 23:07, Han Zhou wrote: >> > On Wed, Apr 12, 2023 at 8:01 AM wrote:

Re: [ovs-dev] [PATCH ovn v2 4/4] acls: Add "pass" ACL action.

2023-04-13 Thread Ales Musil
On Mon, Apr 10, 2023 at 7:26 PM Mark Michelson wrote: > This allows for evaluating ACLs at the current tier to stop, and to > start evaluating ACLs at the next tier. If not using tiers, or if we > match on the final ACL tier, then a "pass" verdict results in the > default ACL action being

Re: [ovs-dev] [PATCH ovn v2 3/4] ovn-nbctl: Add tier ACL options.

2023-04-13 Thread Ales Musil
On Mon, Apr 10, 2023 at 7:26 PM Mark Michelson wrote: > This modifies the acl-add and acl-del commands so that an ACL > tier can be specified when adding or deleting ACLs. > > For acl-add, if the tier is specified, then the ACL created by the > command will have that tier set. > > For acl-del,

Re: [ovs-dev] [PATCH ovn v2 2/4] northd: Add tiered ACL support.

2023-04-13 Thread Ales Musil
On Mon, Apr 10, 2023 at 7:26 PM Mark Michelson wrote: > With this commit, ACLs can now be arranged in hierarchical tiers. A tier > number can be assigned to an ACL. When evaluating ACLs, we first will > consider ACLs at tier 0. If no matching ACL is found, then we move to > tier 1. This

Re: [ovs-dev] [PATCH ovn] Expose distributed gateway port information in NB DB

2023-04-13 Thread Luis Tomas Bolivar
On Thu, Apr 13, 2023 at 9:33 AM Dumitru Ceara wrote: > On 4/12/23 23:07, Han Zhou wrote: > > On Wed, Apr 12, 2023 at 8:01 AM wrote: > >> > >> From: Lucas Alvares Gomes > >> > >> In order for the CMS to know which Chassis a distributed gateway port > >> is bond to, this patch updates the

Re: [ovs-dev] [PATCH ovn] utilities: disable OVSDB inactivity probes for non-daemon ovn-nbctl

2023-04-13 Thread Dumitru Ceara
Hi Vladislav, On 4/3/23 12:08, Ilya Maximets wrote: > On 3/31/23 17:17, Dumitru Ceara wrote: >> On 3/31/23 16:51, Vladislav Odintsov wrote: >>> As I understood from Ilya, in case of one-command run of ovn-sbctl >>> (non-daemon mode), it doesn’t make sense to have client -> server >>> inactivity

Re: [ovs-dev] [PATCH ovn 1/2] tests: define fmt_pkt function to construct packets with scapy

2023-04-13 Thread Ales Musil
On Thu, Apr 13, 2023 at 10:30 AM Dumitru Ceara wrote: > On 4/12/23 03:29, Ihar Hrachyshka wrote: > > Scapy allows to define packets in descriptive form that is easier to > > digest and debug. > > > > Signed-off-by: Ihar Hrachyshka > > --- > > tests/ovn-macros.at | 23 +++ >

Re: [ovs-dev] [PATCH ovn 2/2] Omit ACLs for nd || nd_ra || nd_rs || mldv1 || mldv2

2023-04-13 Thread Dumitru Ceara
On 4/13/23 10:28, Dumitru Ceara wrote: > One is because the tests fail to run scapy: > > Traceback (most recent call last): > File "", line 1, in > ModuleNotFoundError: No module named 'scapy' > "netdev-dummy/receive" command requires at least 2 arguments > ovs-appctl: ovs-vswitchd: server

Re: [ovs-dev] [PATCH ovn 1/2] tests: define fmt_pkt function to construct packets with scapy

2023-04-13 Thread Dumitru Ceara
On 4/12/23 03:29, Ihar Hrachyshka wrote: > Scapy allows to define packets in descriptive form that is easier to > digest and debug. > > Signed-off-by: Ihar Hrachyshka > --- > tests/ovn-macros.at | 23 +++ > 1 file changed, 23 insertions(+) > > diff --git

Re: [ovs-dev] [PATCH ovn 2/2] Omit ACLs for nd || nd_ra || nd_rs || mldv1 || mldv2

2023-04-13 Thread Dumitru Ceara
On 4/12/23 03:29, Ihar Hrachyshka wrote: > When setting flows for LS, OVN distinguishes between two states: where > there’s a stateful ACL present in its list (has_stateful == true *) > and when it’s missing (all ACLs are stateless). > > When has_stateful == true, the following is done (among

[ovs-dev] [PATCH v2] ci: Separate DPDK from OVS build.

2023-04-13 Thread David Marchand
Let's separate DPDK compilation from the rest of OVS build: - this avoids multiple jobs building DPDK in parallel, which especially affects builds in the dpdk-latest branch, - we separate concerns about DPDK build requirements from OVS build requirements, like python dependencies, - building

Re: [ovs-dev] [PATCH ovn 2/2] northd.c: Avoid sending ICMP time exceeded for multicast packets.

2023-04-13 Thread Dumitru Ceara
On 4/13/23 07:07, Han Zhou wrote: > In RFC1812 section 5.3.1, it is mentioned that: > >If the TTL is reduced to zero (or less), the packet MUST be >discarded, and if the destination is not a multicast address the >router MUST send an ICMP Time Exceeded message ... > The code itself

Re: [ovs-dev] [PATCH ovn 1/2] northd.c: TTL discard flow should support for both ipv4 and ipv6.

2023-04-13 Thread Dumitru Ceara
On 4/13/23 07:07, Han Zhou wrote: > Remove 'ip4' from the match condition for this flow. > > Signed-off-by: Han Zhou > --- > northd/northd.c | 2 +- > tests/ovn-northd.at | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/northd/northd.c b/northd/northd.c > index

Re: [ovs-dev] [PATCH ovn] Expose distributed gateway port information in NB DB

2023-04-13 Thread Dumitru Ceara
On 4/12/23 23:07, Han Zhou wrote: > On Wed, Apr 12, 2023 at 8:01 AM wrote: >> >> From: Lucas Alvares Gomes >> >> In order for the CMS to know which Chassis a distributed gateway port >> is bond to, this patch updates the ovn-northd daemon to populate the >> Logical_Router_Port table with that