Re: [ovs-dev] [PATCH v2] tc: fix crash on EAGAIN return from recvmsg on netlink socket.

2023-05-12 Thread Simon Horman
On Thu, May 11, 2023 at 12:03:50PM +0200, Frode Nordahl wrote: > The tc module combines the use of the `tc_transact` helper > function for communication with the in-kernel tc infrastructure > with assertions on the reply data by `ofpbuf_at_assert` on the > received data prior to further processing.

Re: [ovs-dev] [PATCH v2] tests dpdk: Allow passing in dpdk-extra arguments.

2023-05-12 Thread Frode Nordahl
On Thu, May 11, 2023 at 11:07 PM Ilya Maximets wrote: > > On 5/11/23 18:13, Frode Nordahl wrote: > > At present, the system-dpdk-testsuite makes assumptions about > > environment configuration, and will error out if DPDK compatible > > interfaces not configured for DPDK are present in the system w

Re: [ovs-dev] [PATCH v2] tc: fix crash on EAGAIN return from recvmsg on netlink socket.

2023-05-12 Thread Frode Nordahl
On Fri, May 12, 2023 at 10:35 AM Simon Horman wrote: > > On Thu, May 11, 2023 at 12:03:50PM +0200, Frode Nordahl wrote: > > The tc module combines the use of the `tc_transact` helper > > function for communication with the in-kernel tc infrastructure > > with assertions on the reply data by `ofpbu

Re: [ovs-dev] [PATCH v2] tc: fix crash on EAGAIN return from recvmsg on netlink socket.

2023-05-12 Thread Simon Horman
On Fri, May 12, 2023 at 11:25:02AM +0200, Frode Nordahl wrote: > On Fri, May 12, 2023 at 10:35 AM Simon Horman > wrote: > > > > On Thu, May 11, 2023 at 12:03:50PM +0200, Frode Nordahl wrote: > > > The tc module combines the use of the `tc_transact` helper > > > function for communication with the

[ovs-dev] [PATCH v3] tests dpdk: Pass `--no-pci` to tests that do not use physical ports.

2023-05-12 Thread Frode Nordahl
At present, the system-dpdk-testsuite makes assumptions about environment configuration, and will error out if DPDK compatible interfaces not configured for DPDK are present in the system with a message like: EAL: Probe PCI driver: net_virtio (1af4:1000) device: :00:03.0 (socket -1) eth_virtio

[ovs-dev] ovs-vsctl Bridge IPFIX enable_input_sampling, enable_ouput_sampling and enable_tunnel_sampling returning unexpected values

2023-05-12 Thread Sayali Naval (sanaval) via dev
As per the Open vSwitch Manual (http://www.openvswitch.org/support/dist-docs/ovs-vsctl.8.txt) the Bridge IPFIX parameters can be passed as follows: ovs-vsctl -- set Bridge br0 ipfix=@i \ -- --id=@i create IPFIX targets=\"192.168.0.34:4739\" obs_do‐ main_id=123

[ovs-dev] [PATCH ovn 00/14] ovn-northd incremental processing for VIF changes

2023-05-12 Thread Han Zhou
This series implements incremental processing for VIF (regular logical switch ports of VM/pod) changes in ovn-northd. The performance gains of a single logical switch port creation has improved significantly. Below are the performance test results simulating an ovn-k8s topology of 500 nodes x 50 l

[ovs-dev] [PATCH ovn 01/14] northd: Remove bfd_connections from northd_data.

2023-05-12 Thread Han Zhou
bfd_connections isn't related to the I-P engine node "northd". So move it from the northd_data to a local variable of en_lflow_run(). Signed-off-by: Han Zhou --- northd/en-lflow.c | 9 ++--- northd/northd.c | 2 -- northd/northd.h | 1 - 3 files changed, 6 insertions(+), 6 deletions(-)

[ovs-dev] [PATCH ovn 03/14] inc-proc-eng.h: Refactor I-P engine node macros.

2023-05-12 Thread Han Zhou
Refactor so that ENGINE_NODE_WITH_CLEAR_TRACK_DATA_IS_VALID can be used outside of functions. Signed-off-by: Han Zhou --- lib/inc-proc-eng.h | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/lib/inc-proc-eng.h b/lib/inc-proc-eng.h index 5f515f1eaf50..c7e

[ovs-dev] [PATCH ovn 04/14] ovn.at: Fix test case: delete mac bindings.

2023-05-12 Thread Han Zhou
MAC_Binding table is to store neighbour cache for logical router datapaths to resolve unknown IP addresses to MAC. The datapath field is always logical router and the logical_port feild is always logical router port. The test case used logical switch and logical switch ports by mistake. Correct it

[ovs-dev] [PATCH ovn 02/14] northd: Enable persistence of logical flows between engine runs.

2023-05-12 Thread Han Zhou
This patch ensures logical flows remain persistent between engine runs, given there are no changes. In case of any change, it will deconstruct and reconstruct the hmap during recompute. This functionality is needed for future incremental processing, particularly when logical flows need to be remov

[ovs-dev] [PATCH ovn 05/14] northd: Avoid triggering unnecesary recompute for nb_global changes.

2023-05-12 Thread Han Zhou
For changes such as nb_cfg related columns, don't trigger recompute. Signed-off-by: Han Zhou --- northd/en-northd.c | 26 ++ northd/en-northd.h | 1 + northd/inc-proc-northd.c | 3 ++- tests/ovn-northd.at | 6 +++--- 4 files changed, 32 insertions(+),

[ovs-dev] [PATCH ovn 06/14] northd: Track lsp names referenced by LB health-check.

2023-05-12 Thread Han Zhou
Maintain a set of lsp names that are referenced in the column "ip_port_mappings" of load_balancer records (used for health check purpose), which will be used for lsp incremental processing. Signed-off-by: Han Zhou --- northd/northd.c | 21 ++--- northd/northd.h | 1 + 2 files ch

[ovs-dev] [PATCH ovn 08/14] northd: Refactor the logic related to "unknown" mc_group.

2023-05-12 Thread Han Zhou
This patch moves the logic responsible for adding ports to the 'unknown' multicast group. This logic is now part of the build_mcast_groups() function. This not only improves readability but also removes the unnecessary dependency of mcast_groups from build_lflows(). Signed-off-by: Han Zhou ---

[ovs-dev] [PATCH ovn 07/14] northd: Incremental processing of VIF changes in 'northd' node.

2023-05-12 Thread Han Zhou
This patch introduces a change handler for NB logical_switch within the 'northd' node. It specifically handles cases where logical switch ports in the tracked logical switches are changed (added/updated/deleted). Only regular logical switch ports - which are common for VMs/Pods - are addressed. For

[ovs-dev] [PATCH ovn 10/14] northd: Omit alerts for SB lflow and mc-group table.

2023-05-12 Thread Han Zhou
The SB logical_flow table and multicast_group tables should be updated by northd only. Omitting the alerts (making them write-only) avoids unnecessary recompute triggered in northd. Signed-off-by: Han Zhou --- northd/ovn-northd.c | 8 1 file changed, 8 insertions(+) diff --git a/northd

[ovs-dev] [PATCH ovn 12/14] northd: Avoid another round-trip for clearing additional-chassis-activated.

2023-05-12 Thread Han Zhou
When a LSP has multiple requested-chassis specified, northd will set requested_additional_chassis column in SB port_binding, and ovn-controller on one or more chassis will claim the LSP and update the SB port_binding record's options:additional-chassis-activated. When the LSP is updated with only

[ovs-dev] [PATCH ovn 11/14] northd: Split a new node "sync-from-sb" from the "northd" node.

2023-05-12 Thread Han Zhou
The ovnsb_db_run() handles changes from SB DB and then updates NB/SB accordingly. These changes are not directly related to the rest part of the "northd" node, so split as a new node from it. This node doesn't maintain any data, but simply output to NB/SB DBs. It is similar to the sync-to-sb node b

[ovs-dev] [PATCH ovn 09/14] northd: Incremental processing of VIF additions in 'lflow' node.

2023-05-12 Thread Han Zhou
This patch introduces a change handler for 'northd' input within the 'lflow' node. It specifically handles cases when VIFs are created, which is an easier start for lflow incremental processing. Support for update/delete will be added later. Below are the performance test results simulating an ovn

[ovs-dev] [PATCH ovn 13/14] northd: Incremental processing of SB port_binding in "northd" node.

2023-05-12 Thread Han Zhou
Most SB port_binding changes do not need to be handled by "northd" node, because they are either result of SB transactions from northd itself, or changes already handled by sync-from-sb node. This change reduces number of recompute of both "northd" and "lflow" nodes that would have been triggered b

[ovs-dev] [PATCH ovn 14/14] northd: Ignore "up" column change if ignore_lsp_down is true.

2023-05-12 Thread Han Zhou
This change avoids the unnecessary change handling in "lflow" when NB_Global:options:ignore_lsp_down is true (default) if the only change of the LSP is the column "up". This further reduces the number of recompute of "lflow" to zero for the VIF creation-and-binding scenario. Signed-off-by: Han Zho

Re: [ovs-dev] [PATCH ovn 07/14] northd: Incremental processing of VIF changes in 'northd' node.

2023-05-12 Thread 0-day Robot
Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Comment with 'xxx' marker #761 FILE: northd/northd.c:4716: /* XXX: Add tag_alloc_table

Re: [ovs-dev] [PATCH ovn 09/14] northd: Incremental processing of VIF additions in 'lflow' node.

2023-05-12 Thread 0-day Robot
Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Comment with 'xxx' marker #209 FILE: northd/northd.c:5697: * XXX: this mechanism is tempor