Re: [ovs-dev] [PATCH v4] tc: fix crash on EAGAIN return from recvmsg on netlink socket.

2023-05-29 Thread Ilya Maximets
On 5/28/23 11:05, Frode Nordahl wrote: > > > lør. 27. mai 2023, 14:51 skrev Ilya Maximets >: > > On 5/27/23 09:21, Frode Nordahl wrote: > > On Fri, May 26, 2023 at 10:31 PM Ilya Maximets > wrote: > >> > >> On 5/26/23 22:07,

[ovs-dev] [PATCH ovn 1/2] system-tests: Prevent flakiness in Tiered ACLS

2023-05-29 Thread Ales Musil
The "Tiered ACLs" test was syncing on sb and in one case it wasn't syncing at all. That could lead to some packets passing/being dropped due to race between the northd creating the flows and controller installing them. Fixes: 119f14e05cb4 ("northd: Add tiered ACL support.") Signed-off-by: Ales Mus

[ovs-dev] [PATCH ovn 2/2] system-tests: Prevent flakiness in ovn mirroring

2023-05-29 Thread Ales Musil
The "ovn mirroring" test wasn't waiting for the flows to be properly installed. That could lead to smaller number of packets being mirrored thus failing the test. Fixes: a88b62025a8d ("mirror: fix ovn mirror support with IPv6") Signed-off-by: Ales Musil --- tests/system-ovn.at | 12

Re: [ovs-dev] [PATCH v4 ovn] northd: centralized reply lb traffic even if FIP is defined

2023-05-29 Thread Ilya Maximets
On 5/26/23 10:21, Lorenzo Bianconi wrote: > In the current codebase for distributed gw router port use-case, > it is not possible to add a load balancer that redirects the traffic > to a back-end if it is used as internal IP of a FIP NAT rule since > the reply traffic is never centralized. Fix the

Re: [ovs-dev] [PATCH v10] netdev-dpdk: add control plane protection support

2023-05-29 Thread Ilya Maximets
On 5/25/23 11:25, Robin Jarry wrote: > Hey Ilya, > > Ilya Maximets, May 24, 2023 at 17:05: >> I had a '+' because rss and lacp are two different entities and I looked >> at it as a mode of operation. i.e. RSS plus special handling for LACP. >> RSS looks strange in a comma-separated list, IMO. > >

Re: [ovs-dev] [PATCH ovn 09/14] northd: Incremental processing of VIF additions in 'lflow' node.

2023-05-29 Thread Ilya Maximets
On 5/13/23 02:03, Han Zhou wrote: > This patch introduces a change handler for 'northd' input within the > 'lflow' node. It specifically handles cases when VIFs are created, which > is an easier start for lflow incremental processing. Support for > update/delete will be added later. > > Below are

Re: [ovs-dev] [PATCH v5] backtrace: Extend the backtrace functionality

2023-05-29 Thread Ilya Maximets
On 5/25/23 08:33, Ales Musil wrote: > Use the backtrace functions that is provided by libc, > this allows us to get backtrace that is independent of > the current memory map of the process. Which in turn can > be used for debugging/tracing purpose. The backtrace > is not 100% accurate due to variou

Re: [ovs-dev] [PATCH ovn 09/14] northd: Incremental processing of VIF additions in 'lflow' node.

2023-05-29 Thread Han Zhou
On Mon, May 29, 2023 at 9:24 AM Ilya Maximets wrote: > > On 5/13/23 02:03, Han Zhou wrote: > > This patch introduces a change handler for 'northd' input within the > > 'lflow' node. It specifically handles cases when VIFs are created, which > > is an easier start for lflow incremental processing.

Re: [ovs-dev] [PATCH] netdev-offload-dpdk: Fix crash in debug log.

2023-05-29 Thread Ilya Maximets
On 5/26/23 22:32, Mike Pattrick wrote: > On Fri, May 26, 2023 at 11:05 AM David Marchand > wrote: >> >> The offload thread calling ufid_to_rte_flow_disassociate() may be the >> last one holding a reference on the netdev and physdev. >> So displaying informations about them might trigger a crash wh

Re: [ovs-dev] [PATCH v2 1/1] utilities/bashcomp: Fix PS1 generation on new bash

2023-05-29 Thread Ilya Maximets
On 5/26/23 19:16, Timothy Redaelli wrote: > The current implementation used to extract PS1 prompt for ovs-vsctl is > broken on recent Bash releases. > Starting from Bash 4.4 it's possible to use @P expansion in order to get > the quoted PS1 directly. > > This commit makes the 2 bash completion fil

Re: [ovs-dev] [PATCH v13 4/4] userspace: Enable L4 checksum offloading by default.

2023-05-29 Thread Mike Pattrick
On Wed, May 24, 2023 at 8:56 AM Ilya Maximets wrote: > > On 5/17/23 05:11, Mike Pattrick wrote: > > From: Flavio Leitner > > > > The netdev receiving packets is supposed to provide the flags > > indicating if the L4 checksum was verified and it is OK or BAD, > > otherwise the stack will check whe

[ovs-dev] [PATCH v5 ovn] northd: centralized reply lb traffic even if FIP is defined

2023-05-29 Thread Lorenzo Bianconi
In the current codebase for distributed gw router port use-case, it is not possible to add a load balancer that redirects the traffic to a back-end if it is used as internal IP of a FIP NAT rule since the reply traffic is never centralized. Fix the issue centralizing the traffic if it is the reply