[ovs-dev] [PATCH v3 1/2] debian: Build package with AF_XDP.

2023-06-26 Thread Frode Nordahl
Build the upstream Open vSwitch deb package with AF_XDP datapath enabled when required dependencies are available. Signed-off-by: Frode Nordahl --- Documentation/intro/install/debian.rst | 13 debian/automake.mk | 45 ++ debian/control.in

Re: [ovs-dev] [PATCH] ovs-vsctl: Exit with error if postdb checks report errors.

2023-06-26 Thread Aaron Conole
Flavio Leitner writes: > Today the exit code refers to the execution of the change > in the database. However, when not using parameter --no-wait > (default), the ovs-vsctl also checks if OVSDB transactions > are successfully recorded and reload by ovs-vswitchd. In this > case, an error message i

Re: [ovs-dev] [PATCH v15 4/4] userspace: Enable L4 checksum offloading by default.

2023-06-26 Thread David Marchand
On Mon, Jun 26, 2023 at 4:05 PM David Marchand wrote: > > On Mon, Jun 26, 2023 at 3:19 PM Ilya Maximets wrote: > > > - if the UFO feature is "restored" in the master branch, OVS can't > > > expose CSUM if the guest negotiated UFO. > > > > Yep. IIUC, that will require un-doing/re-wrking some of t

Re: [ovs-dev] [PATCH v2 1/2] debian: Conditionally build package with AF_XDP.

2023-06-26 Thread Frode Nordahl
On Thu, Jun 22, 2023 at 11:58 AM Frode Nordahl wrote: > > On Tue, Jun 20, 2023 at 6:03 PM Ilya Maximets wrote: > > > > On 6/20/23 16:13, Frode Nordahl wrote: > > > On Tue, Jun 20, 2023 at 3:44 PM Ilya Maximets wrote: > > >> > > >> On 6/20/23 10:08, Frode Nordahl wrote: > > >>> Allow building the

Re: [ovs-dev] [PATCH ovn 2/3] northd.c: Maintain links between ovn_port and lflow.

2023-06-26 Thread Han Zhou
On Mon, Jun 26, 2023 at 7:25 AM Numan Siddique wrote: > > On Sun, Jun 18, 2023 at 11:48 AM Han Zhou wrote: > > > > For incremental processing, it is important to maintain relationship > > between the inputs and the logical flows generated. This patch creates > > the links between ovn_port and log

Re: [ovs-dev] [PATCH v1] ofproto-dpif-xlate: ovs-tcpdump cannot capture incomming vxlan packets

2023-06-26 Thread Simon Horman
On Fri, Oct 09, 2020 at 08:15:03PM +0800, hepeng.0320 wrote: > when running ovs-tcpdump -i ethX and the port is used as the incomming port > for a vxlan port. > > The callstack for the upcall: > > mirror_ingress_packet > mirror_packet > output_normal > compose_output_action > compose_output_acti

Re: [ovs-dev] [PATCH 3/3] netdev-offload-tc: Add VxLAN encap support.

2023-06-26 Thread Simon Horman
On Wed, Jul 08, 2020 at 09:10:36AM -0700, William Tu wrote: > The patch adds VxLAN encap tc-offload support. The userspace datapath, > dpif-netdev, > flow format differs than the kernel datapath in case of tunnel encap. Unlike > kernel, > the dpif-netdev does not use set and output action, but

Re: [ovs-dev] [PATCH] dpif-netdev: Lockless meters.

2023-06-26 Thread Simon Horman
On Thu, Jun 22, 2023 at 12:32:20AM +0200, Ilya Maximets wrote: > Current implementation of meters in the userspace datapath takes > the meter lock for every packet batch. If more than one thread > hits the flow with the same meter, they will lock each other. > > Replace the critical section with

Re: [ovs-dev] [PATCH] flow: Consistent VXLAN UDP src ports for fragmented packets

2023-06-26 Thread Ilya Maximets
On 6/26/23 08:59, Hemanth Aramadaka via dev wrote: > Hi Simon, > > Sorry for the late response. Yes, the changes are specific to IPV6 protocol > only. Please, fix the flow_hash_5tuple() function as well. All variants of the same hash function should give the same result. For some reason you jus

Re: [ovs-dev] [PATCH ovn 2/3] northd.c: Maintain links between ovn_port and lflow.

2023-06-26 Thread Numan Siddique
On Sun, Jun 18, 2023 at 11:48 AM Han Zhou wrote: > > For incremental processing, it is important to maintain relationship > between the inputs and the logical flows generated. This patch creates > the links between ovn_port and logical flows. The same data structure > may be expanded to maintain l

Re: [ovs-dev] [PATCH v15 4/4] userspace: Enable L4 checksum offloading by default.

2023-06-26 Thread Ilya Maximets
On 6/26/23 16:05, David Marchand wrote: > On Mon, Jun 26, 2023 at 3:19 PM Ilya Maximets wrote: >>> - if the UFO feature is "restored" in the master branch, OVS can't >>> expose CSUM if the guest negotiated UFO. >> >> Yep. IIUC, that will require un-doing/re-wrking some of the changes Mike >> did

Re: [ovs-dev] [PATCH v15 4/4] userspace: Enable L4 checksum offloading by default.

2023-06-26 Thread David Marchand
On Mon, Jun 26, 2023 at 3:19 PM Ilya Maximets wrote: > > - if the UFO feature is "restored" in the master branch, OVS can't > > expose CSUM if the guest negotiated UFO. > > Yep. IIUC, that will require un-doing/re-wrking some of the changes Mike > did in order to restore ability to disable advert

[ovs-dev] [PATCH v3] ofproto-dpif-upcall: Mirror packets that are modified

2023-06-26 Thread Mike Pattrick
Currently OVS keeps track of which mirrors that each packet has been sent to for the purpose of deduplication. However, this doesn't consider that openflow rules can make significant changes to packets after ingress. For example, OVN can create OpenFlow rules that turn an echo request into an echo

Re: [ovs-dev] [PATCH v15 4/4] userspace: Enable L4 checksum offloading by default.

2023-06-26 Thread Ilya Maximets
On 6/26/23 11:37, David Marchand wrote: > On Fri, Jun 23, 2023 at 11:52 PM Ilya Maximets wrote: But we can't really do that from the OVS side, can we? DPDK will clear the bit even if we enable it... >>> >>> Hum, I did not test it yet, but I was thinking of calling >>> rte_vhost_driver_en

Re: [ovs-dev] [PATCH v2] ofproto-dpif-upcall: Mirror packets that are modified

2023-06-26 Thread Mike Pattrick
On Mon, Jun 26, 2023 at 5:42 AM Eelco Chaudron wrote: > > > > On 23 Jun 2023, at 19:07, Mike Pattrick wrote: > > > Currently OVS keeps track of which mirrors that each packet has been > > sent to for the purpose of deduplication. However, this doesn't consider > > that openflow rules can make sign

Re: [ovs-dev] [ovs-dev v3] dpif-netdev: fix dpif_netdev_flow_put

2023-06-26 Thread Peng He
Ilya Maximets 于2023年6月24日周六 04:26写道: > On 6/15/23 04:51, Peng He wrote: > > OVS allows overlapping megaflows, as long as the actions of these > > megaflows are equal. However, the current implementation of action > > modification relies on flow_lookup instead of ufid, this could result > > in loo

Re: [ovs-dev] [PATCH v15 4/4] userspace: Enable L4 checksum offloading by default.

2023-06-26 Thread David Marchand
On Mon, Jun 26, 2023 at 11:37 AM David Marchand wrote: > > Currently possible configurations: > > > > 1. CSUM + TSO + ___ + ___ OVS 3.1 with userspace-tso=true > > 2. + TSO + ECN + ___ OVS 3.1 with userspace-tso=false > > 3. + ___ + ECN + UFO OVS 2.11 > > [snip] > I don't thi

Re: [ovs-dev] [PATCH v2] ofproto-dpif-upcall: Mirror packets that are modified

2023-06-26 Thread Eelco Chaudron
On 23 Jun 2023, at 19:07, Mike Pattrick wrote: > Currently OVS keeps track of which mirrors that each packet has been > sent to for the purpose of deduplication. However, this doesn't consider > that openflow rules can make significant changes to packets after > ingress. > > For example, OVN ca

Re: [ovs-dev] [PATCH v15 4/4] userspace: Enable L4 checksum offloading by default.

2023-06-26 Thread David Marchand
On Fri, Jun 23, 2023 at 11:52 PM Ilya Maximets wrote: > >> But we can't really do that from the OVS side, can we? > >> DPDK will clear the bit even if we enable it... > > > > Hum, I did not test it yet, but I was thinking of calling > > rte_vhost_driver_enable_features. > > Now that I look at the

Re: [ovs-dev] [PATCH v15 4/4] userspace: Enable L4 checksum offloading by default.

2023-06-26 Thread Maxime Coquelin
On 6/23/23 23:52, Ilya Maximets wrote: On 6/23/23 19:33, David Marchand wrote: On Fri, Jun 23, 2023 at 5:14 PM Ilya Maximets wrote: On 6/23/23 15:16, David Marchand wrote: On Wed, Jun 21, 2023 at 12:13 AM Ilya Maximets wrote: On 6/14/23 21:03, Mike Pattrick wrote: The netdev receiving p

Re: [ovs-dev] [PATCH] flow: Consistent VXLAN UDP src ports for fragmented packets

2023-06-26 Thread Hemanth Aramadaka via dev
Hi Simon, Sorry for the late response. Yes, the changes are specific to IPV6 protocol only. Thanks, Hemanth. -Original Message- From: Simon Horman Sent: Friday, January 20, 2023 8:52 PM To: ovs-dev@openvswitch.org Cc: Hemanth Aramadaka Subject: Re: [ovs-dev] [PATCH] flow: Consistent V