[ovs-dev] [PATCH v2] conntrack: Fix icmp_id conflicts in snat

2023-07-02 Thread wushaohua
From: Shaohua Wu The icmp_id maybe conflicts in snat Description: If multiple devices send icmp packets with the same icmp_id, the sip of the packets changes to the same source ip address after the snat operation, and the packets are sent to the same destination ip address. Only one ct entry is

Re: [ovs-dev] [PATCH v2] conntrack: Fix icmp_id conflicts in snat

2023-07-02 Thread wushao...@chinatelecom.cn
Hi Mike, Thank you for your review. I have followed your advice and added unit tests as suggested. Best wishes shaohua From: Mike Pattrick Date: 2023-06-06 03:18 To: wushaohua CC: dev; ctyun-rd1-INF-Network Subject: Re: [ovs-dev] [PATCH v2] conntrack: Fix icmp_id conflicts in snat On Wed, De

[ovs-dev] [PATCH 1/2] ovn-controller.c: Fix assertion failure during address set update.

2023-07-02 Thread Tao Liu
From: Han Zhou When an address set is deleted and a new one is created immediately with the same name, the OVSDB deletion and creation notifications can come to ovn-controller within the same message, and the order of the deletion and addition in the IDL is undefined. In this case, if the deletio

Re: [ovs-dev] [PATCH 1/2] ovn-controller.c: Fix assertion failure during address set update.

2023-07-02 Thread Tao Liu
Sorry to send wrong patch. On 7/2/23 5:57 PM, Tao Liu wrote: From: Han Zhou When an address set is deleted and a new one is created immediately with the same name, the OVSDB deletion and creation notifications can come to ovn-controller within the same message, and the order of the deletion an

[ovs-dev] [PATCH] ovsdb-idl: Reparse reference src before dst is deleted

2023-07-02 Thread Tao Liu
Commit 02f31a1262fc has fixed the row references when insertion and deletion execute in one IDL run. However, we can still hit ovn-controller crash in pressure test where pb->datapath == NULL. It is triggered by reference dst deletion in same IDL run: idl run: update1: insert port_bind

[ovs-dev] [PATCH v2] conntrack: Fix icmp_id conflicts in snat

2023-07-02 Thread wushaohua
From: Shaohua Wu The icmp_id maybe conflicts in snat Description: If multiple devices send icmp packets with the same icmp_id, the sip of the packets changes to the same source ip address after the snat operation, and the packets are sent to the same destination ip address. Only one ct entry is

Re: [ovs-dev] [PATCH] ovs-tcpdump: Bugfix-of-ovs-tcpdump

2023-07-02 Thread Simon Jones
Ok, thanks for the clarification. I will modify and send this patch again by another email named as gangyewei. Simon Jones Ilya Maximets 于2023年6月29日周四 22:55写道: > On 6/28/23 03:12, Simon Jones wrote: > > This patch is same as MR: https://github.com/openvswitch/ovs/pull/415 > > > > Thi