On 7/10/23 16:54, Kevin Traynor wrote:
> Extend 'pmd-sleep-max' so that individual PMD thread cores
> may have a specified max sleep request value.
>
> Any PMD thread core without a value will use the datapath default
> (no sleep request) or datapath global value set by the user.
>
> To set PMD
On 7/10/23 16:54, Kevin Traynor wrote:
> Signed-off-by: Kevin Traynor
> Reviewed-by: David Marchand
> ---
> Documentation/topics/dpdk/pmd.rst | 4 ++--
> NEWS | 1 +
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git
On 7/10/23 16:54, Kevin Traynor wrote:
> Max requested sleep time and status for a PMD thread
> is logged at start up or when changed, but it can be
> convenient to have a command to dump this information
> explicitly.
>
> It is envisaged that this will be expanded when future
> additions are
On 7/10/23 16:54, Kevin Traynor wrote:
> other_config:pmd-maxsleep is a config option to allow
> PMD thread cores to sleep under low or no load conditions.
>
> Rename it to 'pmd-sleep-max' to allow a more structured
> name and so that additional options or command can follow
> the 'pmd-sleep-xyz'
On 7/13/23 18:01, Ihar Hrachyshka wrote:
> Reviewed-By: Ihar Hrachyshka
>
> +1. Removing IHAR from OVN? Long overdue. :)
>
I'm sure you know I didn't mean anything like that. I hope to see many
more contributions from IHAR in the future! :D
Thanks for the review, I pushed this to main and
On 7/7/23 10:59, Ales Musil wrote:
> On Tue, Jun 20, 2023 at 4:26 PM Xavier Simonart wrote:
>
>> If an interface with an qos option is deleted at the same
>> time as an ofport notification from ovs (causing runtime_data recompute)
>> is received, the binding module was trying to delete twice the
On 7/12/23 11:16, Paolo Valerio wrote:
> since a27d70a89 ("conntrack: add generic IP protocol support") all
> the unrecognized IP protocols get handled using ct_proto_other ops
> and are managed as L3 using 3 tuples.
>
> This patch stores L4 information for SCTP in the conn_key so that
> multiple
On 7/13/23 14:57, Eelco Chaudron wrote:
>
>
> On 12 Jul 2023, at 0:34, Ilya Maximets wrote:
>
>> On 7/11/23 12:05, Eelco Chaudron wrote:
>>>
>>>
>>> On 13 Jun 2023, at 20:34, James Raphael Tiovalen wrote:
>>>
This commit adds assertions in the functions `shash_count`,
`simap_count`,
On 7/13/23 10:55, Viacheslav Galaktionov via dev wrote:
> The set_error function is now used regardless of whether experimental APIs
> are allowed or not, so it must be defined unconditionally.
>
> Fixes: fc06ea9a1883 ("netdev-dpdk: Add custom rx-steering configuration.")
> Signed-off-by:
Reviewed-By: Ihar Hrachyshka
+1. Removing IHAR from OVN? Long overdue. :)
On Thu, Jul 13, 2023 at 11:30 AM Dumitru Ceara wrote:
> Remove what seems to be an accidental test debug echo command.
>
> Fixes: ab7b0eb8ca05 ("Add connectivity test for 2 controllers on the same
> host")
>
Remove what seems to be an accidental test debug echo command.
Fixes: ab7b0eb8ca05 ("Add connectivity test for 2 controllers on the same host")
Signed-off-by: Dumitru Ceara
---
tests/ovn-macros.at | 1 -
1 file changed, 1 deletion(-)
diff --git a/tests/ovn-macros.at b/tests/ovn-macros.at
index
Regular dp-hash is not a canonical L4 hash (at least with the netlink
datapath). If the datapath supports l4 symmetrical dp-hash use that one
instead.
Reported-at: https://github.com/ovn-org/ovn/issues/112
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2188679
Signed-off-by: Dumitru
On 13 Jul 2023, at 15:15, Eelco Chaudron wrote:
> On 13 Jul 2023, at 15:10, Ilya Maximets wrote:
>
>> On 7/12/23 15:37, Mike Pattrick wrote:
>>> Several xlate actions used in recursive translation currently store a
>>> large amount of information on the stack. This can result in handler
>>>
On 13 Jul 2023, at 15:10, Ilya Maximets wrote:
> On 7/12/23 15:37, Mike Pattrick wrote:
>> Several xlate actions used in recursive translation currently store a
>> large amount of information on the stack. This can result in handler
>> threads quickly running out of stack space despite before
On 7/12/23 15:37, Mike Pattrick wrote:
> Several xlate actions used in recursive translation currently store a
> large amount of information on the stack. This can result in handler
> threads quickly running out of stack space despite before
> xlate_resubmit_resource_check() is able to terminate
On 12 Jul 2023, at 0:34, Ilya Maximets wrote:
> On 7/11/23 12:05, Eelco Chaudron wrote:
>>
>>
>> On 13 Jun 2023, at 20:34, James Raphael Tiovalen wrote:
>>
>>> This commit adds assertions in the functions `shash_count`,
>>> `simap_count`, and `smap_count` to ensure that the corresponding input
Tests was randomly failing as missing some packets (e.g
from Second arrives to hv2:Migrator)
Signed-off-by: Xavier Simonart
---
tests/ovn.at | 5 +
1 file changed, 5 insertions(+)
diff --git a/tests/ovn.at b/tests/ovn.at
index 2ce8478f8..3b705db54 100644
--- a/tests/ovn.at
+++
Signed-off-by: Xavier Simonart
---
tests/ovn.at | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/tests/ovn.at b/tests/ovn.at
index 4ae33567f..2ce8478f8 100644
--- a/tests/ovn.at
+++ b/tests/ovn.at
@@ -11726,10 +11726,9 @@ grep actions=mod_dl_dst:f0:00:00:01:02:04 | wc
Signed-off-by: Xavier Simonart
---
tests/ovn.at | 22 +-
1 file changed, 17 insertions(+), 5 deletions(-)
diff --git a/tests/ovn.at b/tests/ovn.at
index cd6d4b9ff..4ae33567f 100644
--- a/tests/ovn.at
+++ b/tests/ovn.at
@@ -17058,7 +17058,7 @@ rtr_l2_ip=$(ip_to_hex 172 16 1
Xavier Simonart (4):
tests: fixed "Mirror - remote" and "Mirror - local"
tests: fixed flaky "4 HV, 3 LS, 2 LR, packet test with HA distributed
router gateway port"
tests: fixed "basic connectivity with multiple requested-chassis"
tests: fixed "Tiered ACLs"
tests/ovn.at| 34
Signed-off-by: Xavier Simonart
---
tests/system-ovn.at | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/system-ovn.at b/tests/system-ovn.at
index f0999..cf3b272ec 100644
--- a/tests/system-ovn.at
+++ b/tests/system-ovn.at
@@ -11353,7 +11353,7 @@ check ovn-nbctl
Signed-off-by: Dexia Li
---
lib/dp-packet.h | 7 +++---
lib/netdev-dpdk.c | 45 +-
lib/netdev-native-tnl.c | 48 +
lib/netdev.c| 17 +--
4 files changed, 97 insertions(+), 20
Bleep bloop. Greetings Dumitru Ceara, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 85 characters long (recommended limit is 79)
#171 FILE:
On 7/11/23 11:59, Dumitru Ceara wrote:
> On 7/11/23 10:30, Ales Musil wrote:
>> On Tue, Jul 11, 2023 at 7:14 AM Ales Musil wrote:
>>
>>>
>>>
>>> On Mon, Jul 10, 2023 at 5:26 PM Dumitru Ceara wrote:
>>>
If we want to catch new failures faster we have a better chance if CI
doesn't
If we want to catch new failures faster we have a better chance if CI
doesn't auto-retry (once).
There are some tests that are still "unstable" and fail every now and
then. In order to reduce the number of false negatives keep the
--recheck for them. To achieve that we use a new macro,
On 7/12/23 07:29, Mike Pattrick wrote:
> From: Flavio Leitner
>
> This provides a software implementation in the case
> the egress netdev doesn't support segmentation in hardware.
>
> The challenge here is to guarantee packet ordering in the
> original batch that may be full of TSO packets.
Currently, if the user wants to track related connections, they have to
specify a helper in all CT actions, which contradicts the behaviour
described in the documentation.
Fix this by using the helper committed along with the connection whenever
a given CT action does not specify a helper of its
The set_error function is now used regardless of whether experimental APIs
are allowed or not, so it must be defined unconditionally.
Fixes: fc06ea9a1883 ("netdev-dpdk: Add custom rx-steering configuration.")
Signed-off-by: Viacheslav Galaktionov
Acked-by: Ivan Malov
---
lib/netdev-dpdk.h | 22
On 7/13/23 08:48, Priyankar Jain wrote:
> Hi Dumitru,
>
> On 12/07/23 4:12 pm, Dumitru Ceara wrote:
>> On 6/6/23 14:10, Xavier Simonart wrote:
>>> Hi Priyankar, Mark
>>>
>>> Thanks for the patch. I agree with Mark - the description is really
>>> great !
>>> Based on your description, I tried
The requested and acked seqno values are allowed
to be uint64_t, however the values that were added
to the hmap were truncated to uint32_t. This would
lead to loss of information when the value is bigger.
Use uin64_t for the function signatures and for the
hash to prevent truncation.
Hi Dumitru,
On 12/07/23 4:12 pm, Dumitru Ceara wrote:
On 6/6/23 14:10, Xavier Simonart wrote:
Hi Priyankar, Mark
Thanks for the patch. I agree with Mark - the description is really great !
Based on your description, I tried creating a unit-test reproducing the
issue, and checking that your
31 matches
Mail list logo
