Hi Eelco,
On 7/14/2023 9:18 PM, Eelco Chaudron wrote:
On 14 Jul 2023, at 13:34, Ilya Maximets wrote:
On 7/14/23 12:42, Eelco Chaudron wrote:
On 1 Jul 2023, at 16:40, mit...@outlook.com wrote:
From: Lin Huang
Now, token-bucket 'last_fill' is updated by token_bucket_withdraw() itself.
Add
Thank you for your reply.
On 7/14/2023 11:01 PM, Ilya Maximets wrote:
On 7/14/23 14:20, Eelco Chaudron wrote:
On 14 Jul 2023, at 13:52, Eelco Chaudron wrote:
On 1 Jul 2023, at 16:40, mit...@outlook.com wrote:
From: Lin Huang
OvS has supported packet-per-second policer which can be set at
On 7/12/23 05:55, Terry Wilson wrote:
> This adds a Python version of the async DNS support added in:
>
> 771680d96 DNS: Add basic support for asynchronous DNS resolving
>
> The above version uses the unbound C library, and this
> implimentation uses the SWIG-wrapped Python version of that.
>
>
On 7/14/23 17:17, Lorenzo Bianconi wrote:
>> It's specified in RFC 8415. This also avoids having to free/realloc the
>> pfd->uuid.data memory. That part was not correct anyway and was flagged
>> by ASAN as a memleak:
>>
>> Direct leak of 42 byte(s) in 3 object(s) allocated from:
>> #0 0x5
On 7/14/23 09:19, Xavier Simonart wrote:
> On Wed, Jul 12, 2023 at 8:20 PM Dumitru Ceara wrote:
>
>> On 7/7/23 10:46, Ales Musil wrote:
>>> On Wed, Jul 5, 2023 at 5:57 PM Xavier Simonart
>> wrote:
>>>
Usually, when cleaning up a system test we execute (for the ovn-vswitchd
process):
>>
Signed-off-by: Kevin Traynor
Reviewed-by: David Marchand
---
Documentation/topics/dpdk/pmd.rst | 4 ++--
NEWS | 1 +
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/Documentation/topics/dpdk/pmd.rst
b/Documentation/topics/dpdk/pmd.rst
index affd64cc9.
other_config:pmd-maxsleep is a config option to allow
PMD thread cores to sleep under low or no load conditions.
Rename it to 'pmd-sleep-max' to allow a more structured
name and so that additional options or command can follow
the 'pmd-sleep-xyz' pattern.
Use of other_config:pmd-maxsleep is depre
Max requested sleep time and status for a PMD thread
is logged at start up or when changed, but it can be
convenient to have a command to dump this information
explicitly.
It is envisaged that this will be expanded for individual
pmds in the future, hence adding to dpif_netdev_pmd_info().
Signed-
This is just cosmetic. There is no change to the tests.
Signed-off-by: Kevin Traynor
Reviewed-by: David Marchand
---
tests/pmd.at | 39 ---
1 file changed, 24 insertions(+), 15 deletions(-)
diff --git a/tests/pmd.at b/tests/pmd.at
index 374ad7217..4dd775bd3
Patches are about adding some visiblity and preparing for
new functionality in a later series.
Patch 1 renames 'pmd-maxsleep' to 'pmd-sleep-max'. To soften
the change over, 'pmd-maxsleep' is deprecated and may still be used.
v4
- Drop patches 5-6 (per-pmd control) from this series to split into
On 6/13/23 14:33, Vladislav Odintsov wrote:
> Hi Ilya,
>
> thanks for the attention on this patchset.
>
>> On 13 Jun 2023, at 14:58, Ilya Maximets wrote:
>>
>> On 6/7/23 08:33, Vladislav Odintsov wrote:
>>> Default is yes (current behavior). This means that after start process
>>> will be run i
On 7/13/23 13:01, Dexia Li via dev wrote:
> Signed-off-by: Dexia Li
> ---
> lib/dp-packet.h | 7 +++---
> lib/netdev-dpdk.c | 45 +-
> lib/netdev-native-tnl.c | 48 +
> lib/netdev.c| 17
On 6/30/23 04:46, Ivan Malov wrote:
> Action PORT_ID has been deprecated. Use REPRESENTED_PORT instead.
>
> Signed-off-by: Ivan Malov
I'll mark this one as Deferred for now, according to the conversation
in a previous version. We'll need to re-visit this change during
upgrade to DPDK 23.11.
Be
On 6/30/23 04:46, Ivan Malov wrote:
> This may be required by some PMDs in offload scenarios.
>
> Signed-off-by: Ivan Malov
Hi, Ivan. Thanks for the patch!
I suppose, it can be considered as a bug fix. Could you add
a Fixes tag to the commit message?
> ---
> lib/netdev-dpdk.c | 51 ++
Introduce ls_datapath_group column in the load_balancer table of the SB
sb and deprecate datapath_group one. This patch make the table symmetric
with lr_datapath_group column in the load_balancer table of SB db.
Signed-off-by: Lorenzo Bianconi
---
controller/chassis.c| 8
contr
Introduce lr_datapath_group column in the load_balancer table of the SB
db.
Sync load_balancers applied to logical_routers to Load_Balancer table in
the SouthBound database.
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2193323
Signed-off-by: Lorenzo Bianconi
---
controller/local_data
Changes since v1:
- rebase on top of ovn main branch
- cosmetics
Changes since RFC v2:
- introduce ls_datapath_group column and deprecate datapath_group one.
Changes since RFC v1:
- get rid of patch 1/2: northd: rename table datapath_group in
ls_datapath_group in load_balancer sb db table
Lorenz
> On Mon, Jun 19, 2023 at 4:43 PM Lorenzo Bianconi <
> lorenzo.bianc...@redhat.com> wrote:
>
> > Introduce ls_datapath_group column in the load_balancer table of the SB
> > db and deprecate datapath_group one. This patch make the table symmetric
> > with lr_datapath_group column in the load_balanc
> It's specified in RFC 8415. This also avoids having to free/realloc the
> pfd->uuid.data memory. That part was not correct anyway and was flagged
> by ASAN as a memleak:
>
> Direct leak of 42 byte(s) in 3 object(s) allocated from:
> #0 0x55e5b6354c9e in malloc
> (/workspace/ovn-tmp/co
On 7/13/23 11:26, Viacheslav Galaktionov via dev wrote:
> Currently, if the user wants to track related connections, they have to
> specify a helper in all CT actions, which contradicts the behaviour
> described in the documentation.
>
> Fix this by using the helper committed along with the connec
On 7/14/23 15:21, Eelco Chaudron wrote:
>
>
> On 14 Jul 2023, at 13:46, Ilya Maximets wrote:
>
>> On 7/14/23 13:03, Eelco Chaudron wrote:
>>>
>>>
>>> On 1 Jul 2023, at 16:40, mit...@outlook.com wrote:
>>>
From: Lin Huang
Now srtcm_policer will free pkts, if packets are exceed rat
On 7/14/23 14:20, Eelco Chaudron wrote:
>
>
> On 14 Jul 2023, at 13:52, Eelco Chaudron wrote:
>
>> On 1 Jul 2023, at 16:40, mit...@outlook.com wrote:
>>
>>> From: Lin Huang
>>>
>>> OvS has supported packet-per-second policer which can be set at ingress
>>> and egress side in kernel datapath. Bu
[...]
>
> There is a comment above that should be adjusted.
> "Delete any SB load balancer entries that refer to NB load balancers
> that don't exist anymore or are not applied to switches anymore."
> ->
> "Delete any SB load balancer entries that refer to NB load balancers
> that don't exist anym
On 1 Jul 2023, at 16:40, mit...@outlook.com wrote:
> From: Lin Huang
>
> OvS has supported packet-per-second policer which can be set at ingress
> and egress side in kernel datapath. But the userspace datapath dosen't
> support for ingress and egress packet-per-second policing now.
>
> So, thi
On Wed, Jul 12, 2023 at 9:26 PM Han Zhou wrote:
>
> On Sat, Jul 8, 2023 at 3:57 AM Mark Michelson wrote:
> >
> > Hi Numan,
> >
> > I have one small nit below.
> >
> > On 7/7/23 01:53, num...@ovn.org wrote:
> > > From: Numan Siddique
> > >
> > > Any changes to load balancers and load balancer gro
On 14 Jul 2023, at 13:46, Ilya Maximets wrote:
> On 7/14/23 13:03, Eelco Chaudron wrote:
>>
>>
>> On 1 Jul 2023, at 16:40, mit...@outlook.com wrote:
>>
>>> From: Lin Huang
>>>
>>> Now srtcm_policer will free pkts, if packets are exceed rate limit.
>>> This patch change srtcm_policer not to fre
On 14 Jul 2023, at 13:34, Ilya Maximets wrote:
> On 7/14/23 12:42, Eelco Chaudron wrote:
>>
>>
>> On 1 Jul 2023, at 16:40, mit...@outlook.com wrote:
>>
>>> From: Lin Huang
>>>
>>> Now, token-bucket 'last_fill' is updated by token_bucket_withdraw() itself.
>>> Add a new function parameter 'now'
On 13/07/2023 23:45, Ilya Maximets wrote:
On 7/10/23 16:54, Kevin Traynor wrote:
Extend 'pmd-sleep-max' so that individual PMD thread cores
may have a specified max sleep request value.
Any PMD thread core without a value will use the datapath default
(no sleep request) or datapath global value
On Thu, Jul 13, 2023 at 7:40 AM Han Zhou wrote:
>
> On Wed, Jul 12, 2023 at 11:54 PM Han Zhou wrote:
> >
> >
> >
> > On Sat, Jul 8, 2023 at 3:57 AM Mark Michelson wrote:
> > >
> > > Hi Numan,
> > >
> > > I have one small nit below.
> >
> > +1
> > Acked-by: Han Zhou
> >
>
> Sorry that I forgot o
On 13/07/2023 22:14, Ilya Maximets wrote:
On 7/10/23 16:54, Kevin Traynor wrote:
Signed-off-by: Kevin Traynor
Reviewed-by: David Marchand
---
Documentation/topics/dpdk/pmd.rst | 4 ++--
NEWS | 1 +
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/
On 13/07/2023 22:14, Ilya Maximets wrote:
On 7/10/23 16:54, Kevin Traynor wrote:
Max requested sleep time and status for a PMD thread
is logged at start up or when changed, but it can be
convenient to have a command to dump this information
explicitly.
It is envisaged that this will be expanded
On 13/07/2023 21:48, Ilya Maximets wrote:
On 7/10/23 16:54, Kevin Traynor wrote:
other_config:pmd-maxsleep is a config option to allow
PMD thread cores to sleep under low or no load conditions.
Rename it to 'pmd-sleep-max' to allow a more structured
name and so that additional options or comman
Bleep bloop. Greetings Dumitru Ceara, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Unexpected sign-offs from developers who are not authors or co-authors
or committers
On Fri, Jul 14, 2023 at 2:44 PM Dumitru Ceara wrote:
> On 7/14/23 14:39, Dumitru Ceara wrote:
> > It's specified in RFC 8415. This also avoids having to free/realloc the
> > pfd->uuid.data memory. That part was not correct anyway and was flagged
> > by ASAN as a memleak:
> >
> > Direct leak o
On 7/14/23 14:39, Dumitru Ceara wrote:
> It's specified in RFC 8415. This also avoids having to free/realloc the
> pfd->uuid.data memory. That part was not correct anyway and was flagged
> by ASAN as a memleak:
>
> Direct leak of 42 byte(s) in 3 object(s) allocated from:
> #0 0x55e5b6354
It's specified in RFC 8415. This also avoids having to free/realloc the
pfd->uuid.data memory. That part was not correct anyway and was flagged
by ASAN as a memleak:
Direct leak of 42 byte(s) in 3 object(s) allocated from:
#0 0x55e5b6354c9e in malloc
(/workspace/ovn-tmp/controller/ovn-c
On 14 Jul 2023, at 13:52, Eelco Chaudron wrote:
> On 1 Jul 2023, at 16:40, mit...@outlook.com wrote:
>
>> From: Lin Huang
>>
>> OvS has supported packet-per-second policer which can be set at ingress
>> and egress side in kernel datapath. But the userspace datapath doesn't
>> support for ingres
On 1 Jul 2023, at 16:40, mit...@outlook.com wrote:
> From: Lin Huang
>
> OvS has supported packet-per-second policer which can be set at ingress
> and egress side in kernel datapath. But the userspace datapath doesn't
> support for ingress and egress packet-per-second policing now.
>
> So, this
On 7/14/23 13:03, Eelco Chaudron wrote:
>
>
> On 1 Jul 2023, at 16:40, mit...@outlook.com wrote:
>
>> From: Lin Huang
>>
>> Now srtcm_policer will free pkts, if packets are exceed rate limit.
>> This patch change srtcm_policer not to free pkts, just count dropped packets.
>>
>
> Thanks for thi
On 7/14/23 12:42, Eelco Chaudron wrote:
>
>
> On 1 Jul 2023, at 16:40, mit...@outlook.com wrote:
>
>> From: Lin Huang
>>
>> Now, token-bucket 'last_fill' is updated by token_bucket_withdraw() itself.
>> Add a new function parameter 'now' to update timestamp by caller.
>>
>> Signed-off-by: Lin H
On 7/11/23 14:46, Eelco Chaudron wrote:
>
>
> On 10 Jul 2023, at 17:34, Mike Pattrick wrote:
>
>> Currently OVS keeps track of which mirrors that each packet has been
>> sent to for the purpose of deduplication. However, this doesn't consider
>> that openflow rules can make significant changes t
On 7/14/23 11:19, wangchuanlei wrote:
> Hi, Dumitru
>
Hi, wangchuanlei,
> Thank you for review, i don't have performance measurements yet.
> In real physical switch, if flows hit dynimic/static route, or policy route,
> the flows will skip other route entries, it's more reasonable on logic
On Mon, Jun 19, 2023 at 4:43 PM Lorenzo Bianconi <
lorenzo.bianc...@redhat.com> wrote:
> Introduce ls_datapath_group column in the load_balancer table of the SB
> db and deprecate datapath_group one. This patch make the table symmetric
> with lr_datapath_group column in the load_balancer table of
On 1 Jul 2023, at 16:40, mit...@outlook.com wrote:
> From: Lin Huang
>
> Now srtcm_policer will free pkts, if packets are exceed rate limit.
> This patch change srtcm_policer not to free pkts, just count dropped packets.
>
Thanks for this patch Lin, however, this patch is wrongly freeing pack
On Mon, Jun 19, 2023 at 4:43 PM Lorenzo Bianconi <
lorenzo.bianc...@redhat.com> wrote:
> Introduce lr_datapath_group column in the load_balancer table of the SB
> db.
> Sync load_balancers applied to logical_routers to Load_Balancer table in
> the SouthBound database.
>
> Reported-at: https://bugz
On 1 Jul 2023, at 16:40, mit...@outlook.com wrote:
> From: Lin Huang
>
> Now, token-bucket 'last_fill' is updated by token_bucket_withdraw() itself.
> Add a new function parameter 'now' to update timestamp by caller.
>
> Signed-off-by: Lin Huang
Thank for the patch Lin,
However what about u
On Fri, Jul 7, 2023 at 11:25 AM wrote:
>
> From: Numan Siddique
>
> For every a given load balancer group 'A', northd engine data maintains
> a bitmap of datapaths associated to this lb group. So when lb group 'A'
> gets associated to a logical switch 's1', the bitmap index of 's1' is set
> in i
On Fri, Jul 14, 2023 at 11:39 AM Xavier Simonart
wrote:
> Hi Ales
>
> Thanks for looking into this.
>
> On Fri, Jul 14, 2023 at 8:17 AM Ales Musil wrote:
>
>>
>>
>> On Thu, Jul 13, 2023 at 1:08 PM Xavier Simonart
>> wrote:
>>
>>> Signed-off-by: Xavier Simonart
>>> ---
>>>
>>
>> Hi Xavier,
>>
>
Hi Ales
Thanks for looking into this.
On Fri, Jul 14, 2023 at 8:17 AM Ales Musil wrote:
>
>
> On Thu, Jul 13, 2023 at 1:08 PM Xavier Simonart
> wrote:
>
>> Signed-off-by: Xavier Simonart
>> ---
>>
>
> Hi Xavier,
>
>
>> tests/ovn.at | 22 +-
>> 1 file changed, 17 insertion
Hi, Dumitru
Thank you for review, i don't have performance measurements yet.
In real physical switch, if flows hit dynimic/static route, or policy route,
the flows will skip other route entries, it's more reasonable on logic.
For ovn, in table of ip route, there is no default route entry
On 7/14/23 09:19, Felix Huettner wrote:
> On Wed, Jul 12, 2023 at 09:38:23PM +0200, Dumitru Ceara wrote:
>> On 7/12/23 14:42, Frode Nordahl wrote:
>>> On Wed, Jul 12, 2023 at 2:31 PM Felix Huettner
>>> wrote:
On Wed, Jul 12, 2023 at 01:57:18PM +0200, Dumitru Ceara wrote:
> On 7/12/23
On Wed, Jul 12, 2023 at 11:32 PM Ilya Maximets wrote:
>
> On 6/27/23 12:11, Frode Nordahl wrote:
> > The autopkgtests [0][1] are relevant in an upstream context
> > because an Open vSwitch contributor may want to have a quick
> > way of running the upstream system testsuites on recent
> > Debian/U
On Wed, Jul 12, 2023 at 10:06 PM Ilya Maximets wrote:
>
> On 6/27/23 12:11, Frode Nordahl wrote:
> > Build the upstream Open vSwitch deb package with AF_XDP datapath
>
> s/datapath/ports/
Ack.
> > enabled when required dependencies are available.
> >
> > Signed-off-by: Frode Nordahl
> > ---
> >
On Wed, Jul 12, 2023 at 8:20 PM Dumitru Ceara wrote:
> On 7/7/23 10:46, Ales Musil wrote:
> > On Wed, Jul 5, 2023 at 5:57 PM Xavier Simonart
> wrote:
> >
> >> Usually, when cleaning up a system test we execute (for the ovn-vswitchd
> >> process):
> >> - OVS_TRAFFIC_VSWITCHD_STOP (i.e. ovs-appctl
On Wed, Jul 12, 2023 at 09:38:23PM +0200, Dumitru Ceara wrote:
> On 7/12/23 14:42, Frode Nordahl wrote:
> > On Wed, Jul 12, 2023 at 2:31 PM Felix Huettner
> > wrote:
> >>
> >> On Wed, Jul 12, 2023 at 01:57:18PM +0200, Dumitru Ceara wrote:
> >>> On 7/12/23 13:00, Felix Huettner wrote:
> Hi eve
55 matches
Mail list logo
