Re: [ovs-dev] [PATCH v7 1/2] netdev-dpdk: negotiate delivery of per-packet Rx metadata

2023-07-16 Thread Ivan Malov via dev
Hi Ilya, Thanks for reviewing this. PSB. On Fri, 14 Jul 2023, Ilya Maximets wrote: On 6/30/23 04:46, Ivan Malov wrote: This may be required by some PMDs in offload scenarios. Signed-off-by: Ivan Malov Hi, Ivan. Thanks for the patch! I suppose, it can be considered as a bug fix. Could yo

[ovs-dev] [PATCH 1/1] netdev-dpdk: negotiate delivery of per-packet Rx metadata

2023-07-16 Thread Ivan Malov via dev
This may be required by some PMDs in offload scenarios. Fixes: e8a2b5bf92bb ("netdev-dpdk: implement flow offload with rte flow") Signed-off-by: Ivan Malov --- lib/netdev-dpdk.c | 54 +++ 1 file changed, 54 insertions(+) diff --git a/lib/netdev-dpdk.c

[ovs-dev] [PATCH v2 1/1] netdev-dpdk: negotiate delivery of per-packet Rx metadata

2023-07-16 Thread Ivan Malov via dev
This may be required by some PMDs in offload scenarios. Fixes: e8a2b5bf92bb ("netdev-dpdk: implement flow offload with rte flow") Signed-off-by: Ivan Malov --- v2: add missing experimental api ifdef lib/netdev-dpdk.c | 56 +++ 1 file changed, 56 inse

Re: [ovs-dev] [PATCH v7 1/2] netdev-dpdk: negotiate delivery of per-packet Rx metadata

2023-07-16 Thread Ivan Malov via dev
Hi Ilya, A quick follow-up from me: I made a new version of this patch [1]. [1] https://patchwork.ozlabs.org/project/openvswitch/patch/20230716115720.6789-1-ivan.ma...@arknetworks.am/ Thank you. On Fri, 14 Jul 2023, Ilya Maximets wrote: On 6/30/23 04:46, Ivan Malov wrote: This may be requir

[ovs-dev] [PATCH net-next 0/3] net: handle the exp removal problem with ovs upcall properly

2023-07-16 Thread Xin Long
With the OVS upcall, the original ct in the skb will be dropped, and when the skb comes back from userspace it has to create a new ct again through nf_conntrack_in() in either OVS __ovs_ct_lookup() or TC tcf_ct_act(). However, the new ct will not be able to have the exp as the original ct has take

[ovs-dev] [PATCH net-next 1/3] netfilter: allow exp not to be removed in nf_ct_find_expectation

2023-07-16 Thread Xin Long
Currently nf_conntrack_in() calling nf_ct_find_expectation() will remove the exp from the hash table. However, in some scenario, we expect the exp not to be removed when the created ct will not be confirmed, like in OVS and TC conntrack in the following patches. This patch allows exp not to be rem

[ovs-dev] [PATCH net-next 3/3] openvswitch: set IPS_CONFIRMED in tmpl status only when commit is set in conntrack

2023-07-16 Thread Xin Long
By not setting IPS_CONFIRMED in tmpl that allows the exp not to be removed from the hashtable when lookup, we can simplify the exp processing code a lot in openvswitch conntrack. Signed-off-by: Xin Long --- net/openvswitch/conntrack.c | 78 + 1 file changed, 1

[ovs-dev] [PATCH net-next 2/3] net: sched: set IPS_CONFIRMED in tmpl status only when commit is set in act_ct

2023-07-16 Thread Xin Long
With the following flows, the packets will be dropped if OVS TC offload is enabled. 'ip,ct_state=-trk,in_port=1 actions=ct(zone=1)' 'ip,ct_state=+trk+new+rel,in_port=1 actions=ct(commit,zone=1)' 'ip,ct_state=+trk+new+rel,in_port=1 actions=ct(commit,zone=2),normal' In the 1st flow, it finds

[ovs-dev] 答复: [PATCH] [PATCH] userspace: support vxlan and geneve tunnel tso

2023-07-16 Thread Dexia Li via dev
Ok,thanks for your opinions, I will try to correct it. Best regards,Dexia -邮件原件- 发件人: Ilya Maximets 发送时间: 2023年7月15日 0:33 收件人: Dexia Li ; ovs-dev@openvswitch.org 抄送: i.maxim...@ovn.org 主题: Re: [ovs-dev] [PATCH] [PATCH] userspace: support vxlan and geneve tunnel tso On 7/13/23 13:01, D

Re: [ovs-dev] [PATCH ovn v2 5/8] northd: Handle load balancer changes for a logical switch.

2023-07-16 Thread Han Zhou
On Fri, Jul 7, 2023 at 1:54 PM wrote: > > From: Numan Siddique > > Logical switch change handler of the 'northd' engine node > now also handles changes to load balancers. > > Signed-off-by: Numan Siddique > --- > lib/lb.c| 17 +++- > lib/lb.h| 2 + > northd/northd.c

Re: [ovs-dev] [PATCH v4] ofproto-dpif-upcall: Mirror packets that are modified

2023-07-16 Thread Mike Pattrick
On Fri, Jul 14, 2023 at 7:31 AM Ilya Maximets wrote: > > On 7/11/23 14:46, Eelco Chaudron wrote: > > > > > > On 10 Jul 2023, at 17:34, Mike Pattrick wrote: > > > >> Currently OVS keeps track of which mirrors that each packet has been > >> sent to for the purpose of deduplication. However, this doe

Re: [ovs-dev] [PATCH v3 1/7] netdev: add netdev_get_speed() to nedev API

2023-07-16 Thread Adrian Moreno
On 7/12/23 17:28, Eelco Chaudron wrote: On 12 Jul 2023, at 9:02, Adrian Moreno wrote: Currently, the netdev's speed is being calculated by taking the link's feature bits (using netdev_get_features()) and transforming them into bps. This mechanism can be both inaccurate and difficult to mai