Re: [ovs-dev] [PATCH ovn] controller: make garp_max_timeout configurable

2023-07-19 Thread Numan Siddique
On Mon, Jun 5, 2023 at 5:54 PM Lorenzo Bianconi wrote: > > When using VLAN backed networks and OVN routers leveraging the > 'ovn-chassis-mac-mappings' option for east-west traffic, the eth.src field is > replaced by the chassis mac address in order to not expose the router mac > address from diffe

Re: [ovs-dev] [PATCH ovn 0/5] Unit and System tests fixes

2023-07-19 Thread Mark Michelson
For the series, Acked-by: Mark Michelson On 7/18/23 18:11, Xavier Simonart wrote: Xavier Simonart (5): tests: fixed another flake in "send gratuitous ARP for NAT rules on HA distributed router" tests: increased bfd-mult to 15 tests: fixed missing HAVE_SCAPY tests: fixed "ECMP

Re: [ovs-dev] [PATCH ovn 0/3] ovn-installed

2023-07-19 Thread Mark Michelson
Thank you Ales and Xavier. I pushed the changes to main, branch-23.06, branch-23.03, branch-22.12, and branch-22.09. Beyond that, OVN does not have the multichassis MTU patch series, so patch 2 does not apply. Patch 3 applies, but calls a function that does not exist in if-status.c. If this sh

Re: [ovs-dev] [PATCH] daemon.at: Correctly terminate ovsdb process in a backtrace test.

2023-07-19 Thread Ilya Maximets
On 7/19/23 13:58, Eelco Chaudron wrote: > > > On 19 Jul 2023, at 12:33, Ilya Maximets wrote: > >> In a backtrace test with monitor the child process will be re-started >> after being killed. The test doesn't wait for that to happen, so it >> is possible that during the test cleanup the pid in a

Re: [ovs-dev] [PATCH net-next 2/3] net: sched: set IPS_CONFIRMED in tmpl status only when commit is set in act_ct

2023-07-19 Thread Davide Caratti
On Sun, Jul 16, 2023 at 05:09:18PM -0400, Xin Long wrote: > With the following flows, the packets will be dropped if OVS TC offload is > enabled. [...] > > The simple and clear fix is to not remove the exp at the 1st flow, namely, > not set IPS_CONFIRMED in tmpl when commit is not set in act_ct.

[ovs-dev] [PATCH v6] ofproto-dpif-upcall: Mirror packets that are modified

2023-07-19 Thread Mike Pattrick
Currently OVS keeps track of which mirrors that each packet has been sent to for the purpose of deduplication. However, this doesn't consider that openflow rules can make significant changes to packets after ingress. For example, OVN can create OpenFlow rules that turn an echo request into an echo

[ovs-dev] [PATCH] ofproto-dpif: Fix removal of renamed datapath ports.

2023-07-19 Thread Ilya Maximets
OVS configuration is based on port names and OpenFlow port numbers. Names are stored in the database and translated later to OF ports. On the datapath level, each port has a name and a datapath port number. Port name in the database has to match datapath port name, unless it's a tunnel port. If a

Re: [ovs-dev] [PATCH net-next 0/3] net: handle the exp removal problem with ovs upcall properly

2023-07-19 Thread Florian Westphal
Florian Westphal wrote: > Jakub Kicinski wrote: > > On Sun, 16 Jul 2023 17:09:16 -0400 Xin Long wrote: > > > With the OVS upcall, the original ct in the skb will be dropped, and when > > > the skb comes back from userspace it has to create a new ct again through > > > nf_conntrack_in() in either

Re: [ovs-dev] [PATCH net-next 3/3] openvswitch: set IPS_CONFIRMED in tmpl status only when commit is set in conntrack

2023-07-19 Thread Aaron Conole
Xin Long writes: > By not setting IPS_CONFIRMED in tmpl that allows the exp not to be removed > from the hashtable when lookup, we can simplify the exp processing code a > lot in openvswitch conntrack. > > Signed-off-by: Xin Long > --- Acked-by: Aaron Conole __

Re: [ovs-dev] [PATCH net-next 1/3] netfilter: allow exp not to be removed in nf_ct_find_expectation

2023-07-19 Thread Aaron Conole
Xin Long writes: > Currently nf_conntrack_in() calling nf_ct_find_expectation() will > remove the exp from the hash table. However, in some scenario, we > expect the exp not to be removed when the created ct will not be > confirmed, like in OVS and TC conntrack in the following patches. > > This

Re: [ovs-dev] [PATCH net-next 2/3] net: sched: set IPS_CONFIRMED in tmpl status only when commit is set in act_ct

2023-07-19 Thread Aaron Conole
Xin Long writes: > With the following flows, the packets will be dropped if OVS TC offload is > enabled. > > 'ip,ct_state=-trk,in_port=1 actions=ct(zone=1)' > 'ip,ct_state=+trk+new+rel,in_port=1 actions=ct(commit,zone=1)' > 'ip,ct_state=+trk+new+rel,in_port=1 actions=ct(commit,zone=2),norma

[ovs-dev] [PATCH] netdev-tc-offload: Fix ip protocols not offloaded in ip rewrite

2023-07-19 Thread Faicker Mo via dev
The warning message is |1|tc(handler4)|WARN|can't offload rewrite of IP/IPV6 with ip_proto: X. Some ip protocols like ipip, gre and so on do not need the recalculation of the checksum of themself except for the ip header checksum recalculation in the ip header rewrite case. The tc csum action

Re: [ovs-dev] [PATCH net-next 0/3] net: handle the exp removal problem with ovs upcall properly

2023-07-19 Thread Aaron Conole
Xin Long writes: > With the OVS upcall, the original ct in the skb will be dropped, and when > the skb comes back from userspace it has to create a new ct again through > nf_conntrack_in() in either OVS __ovs_ct_lookup() or TC tcf_ct_act(). > > However, the new ct will not be able to have the exp

Re: [ovs-dev] [PATCH] daemon.at: Correctly terminate ovsdb process in a backtrace test.

2023-07-19 Thread Eelco Chaudron
On 19 Jul 2023, at 12:33, Ilya Maximets wrote: > In a backtrace test with monitor the child process will be re-started > after being killed. The test doesn't wait for that to happen, so it > is possible that during the test cleanup the pid in a pid file is not > updated yet. Hence, the on-exi

[ovs-dev] [PATCH] daemon.at: Correctly terminate ovsdb process in a backtrace test.

2023-07-19 Thread Ilya Maximets
In a backtrace test with monitor the child process will be re-started after being killed. The test doesn't wait for that to happen, so it is possible that during the test cleanup the pid in a pid file is not updated yet. Hence, the on-exit hook will not kill the process. This is causing issues i

Re: [ovs-dev] [PATCH] daemon.at: Correctly terminate ovsdb process in a backtrace test.

2023-07-19 Thread Ales Musil
On Wed, Jul 19, 2023 at 12:32 PM Ilya Maximets wrote: > In a backtrace test with monitor the child process will be re-started > after being killed. The test doesn't wait for that to happen, so it > is possible that during the test cleanup the pid in a pid file is not > updated yet. Hence, the o

Re: [ovs-dev] [PATCH ovn v2 6/8] northd: Handle load balancer group changes for a logical switch.

2023-07-19 Thread Numan Siddique
On Tue, Jul 18, 2023 at 9:39 PM Ilya Maximets wrote: > > On 7/18/23 15:17, Ilya Maximets wrote: > > On 7/18/23 05:32, Han Zhou wrote: > >> > >> > >> On Fri, Jul 7, 2023 at 1:55 PM mailto:num...@ovn.org>> > >> wrote: > >>> > >>> From: Numan Siddique mailto:num...@ovn.org>> > >>> > >>> For every a

Re: [ovs-dev] [PATCH ovn v2 8/8] northd: Handle load balancer changes for a logical router.

2023-07-19 Thread Numan Siddique
On Tue, Jul 18, 2023 at 11:08 AM Han Zhou wrote: > > On Fri, Jul 7, 2023 at 1:56 PM wrote: > > > > From: Numan Siddique > > > > When a logical router gets updated due to load balancer > > or load balancer groups changes, it is now incrementally > > handled in the 'northd' engine node. Other log