If a subject is missing, then a command like
utilities/checkpatch.py -S file.patch will write in the new subject
to file.patch itself.
Signed-off-by: Chandan Somani
---
utilities/checkpatch.py | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/utilities/checkpatch.py
Subject spellcheck on git-based patches is now included in commands like
utilities/checkpatch.py -S -2. Additionally, a block of code that is
used to call ovs_checkpatch_parse() has been deleted since
ovs_checkpatch_file() calls ovs_checkpatch_parse() anyways. This
prevents duplicate WARNINGS and
Several xlate actions used in recursive translation currently store a
large amount of information on the stack. This can result in handler
threads quickly running out of stack space despite before
xlate_resubmit_resource_check() is able to terminate translation. This
patch reduces stack usage by
I have applied this patch to all branches between 22.03 and main.
Thanks, Ales.
On 8/2/23 09:31, Ales Musil wrote:
The "SNAT in gateway router mode" could occasionally
fail, because the ext1 IPv6 address wasn't ready and
the NA packet arrived too late for the ping to succeed.
Signed-off-by:
Signed-off-by: Eric Garver
---
tests/system-traffic.at | 31 +++
1 file changed, 31 insertions(+)
diff --git a/tests/system-traffic.at b/tests/system-traffic.at
index 945037ec0571..e06c0e316ff4 100644
--- a/tests/system-traffic.at
+++ b/tests/system-traffic.at
@@
Kernel support is being added for this action. As such, we need to probe
the datapath for support.
Signed-off-by: Eric Garver
---
include/linux/openvswitch.h | 2 +-
lib/dpif.c | 6 --
lib/dpif.h | 1 -
ofproto/ofproto-dpif.c | 41
Signed-off-by: Eric Garver
---
tests/system-common-macros.at | 4
1 file changed, 4 insertions(+)
diff --git a/tests/system-common-macros.at b/tests/system-common-macros.at
index 0077a8609c02..afc0df00a329 100644
--- a/tests/system-common-macros.at
+++ b/tests/system-common-macros.at
@@
This is prep for adding a different OVS_ACTION_ATTR_ enum value. This
action, OVS_ACTION_ATTR_DEC_TTL, is not actually implemented. However,
to make -Werror happy we must add a case to all existing switches.
Signed-off-by: Eric Garver
---
include/linux/openvswitch.h | 1 +
lib/dpif-netdev.c
Probe the datapath implementation for support of OVS_ACTION_ATTR_DROP.
Also add a new test case.
v4:
- avoid passing action to datapath if TC offload in use
v3:
- alter test such that it's reliable, different xlate_error
- better commit message in patch 2
- reordered _DEC_TTL value in
Bleep bloop. Greetings Colin Watson, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 128 characters long (recommended limit is 79)
#39 FILE:
From: Numan Siddique
When adding the arp req lflows in the 'ls_in_l2_lkup' stage for the
load balancer VIPs associated to a logical router we iterate through
the lb_ips sset of the router datapath. For each ip of this sset we
check if this is reachable or not from any of the router ports.
We
Thank you Xavier and Ales.
I applied all four patches to main.
I applied patches 1-3 to branch-23.03.
I applied patches 1 and 2 to branch-22.12.
I applied patch 2 to branch-22.09, branch-22.06 and branch-22.03.
On 8/3/23 06:26, Ales Musil wrote:
On Thu, Aug 3, 2023 at 8:59 AM Xavier Simonart
Thank you Xavier and Ales.
I applied all four patches to main.
I applied patches 1-3 to branch-23.03.
I applied patches 1 and 2 to branch-22.12.
I applied patch 2 to branch-22.09, branch-22.06 and branch-22.03.
On 8/3/23 06:26, Ales Musil wrote:
On Thu, Aug 3, 2023 at 8:59 AM Xavier Simonart
Several xlate actions used in recursive translation currently store a
large amount of information on the stack. This can result in handler
threads quickly running out of stack space despite before
xlate_resubmit_resource_check() is able to terminate translation. This
patch reduces stack usage
If we omit this, groff 1.23.0 warns:
tbl preprocessor failed, or it or soelim was not run; table(s) likely
not rendered (TE macro called with TW register undefined)
Reported-by: Lucas Nussbaum
Reported-at: https://bugs.debian.org/1042358
Signed-off-by: Colin Watson
---
Makefile.am | 2 +-
tbl defaults to expecting table entries to be separated by tab
characters. However, commit 5a0e4aec1af5cf7741c490bce704577e51e536b9
converted these to spaces and inadvertently broke the rendering. Use
semicolons as separators instead; these are less prone to being broken
by tree-wide changes,
Using "NXM/OXM Support" makes these tables a little too wide to fit well
when rendered in 80 columns, causing warnings from groff. There's
already some abbreviation going on here (e.g. "RW?"), so "NXM/OXM?"
seems acceptable.
Reported-by: Lucas Nussbaum
Reported-at:
groff 1.23.0 has difficulty with hyphenating a number of the entries in
the name column of these tables when rendering in 80-column terminals.
Setting a minimum width for this column gives it an easier time.
Reported-by: Lucas Nussbaum
Reported-at: https://bugs.debian.org/1042358
Signed-off-by:
This fixes a number of "table wider than line length minus indentation"
warnings from tbl. The table cells are too narrow for centered text to
look good, so left-align the contents of the text blocks.
Reported-by: Lucas Nussbaum
Reported-at: https://bugs.debian.org/1042358
Signed-off-by: Colin
https://bugs.debian.org/1042358 reported a manpage-check failure with
groff 1.23.0 in Debian testing/unstable. Fixing the immediate mistake
here exposed a few other issues in how the tables in ovs-fields(7) are
rendered.
Colin Watson (5):
docs: Wrap more table entries in text blocks
docs:
On Wed, Aug 02, 2023 at 05:00:05PM +0800, Faicker Mo via dev wrote:
> The warning message is
> |1|tc(handler4)|WARN|can't offload rewrite of IP/IPV6 with ip_proto: X.
>
> IPIP and GRE only need the checksum recalculation of the IP header if the
> IP header is rewritten.
>
> Fixes:
On Wed, Aug 02, 2023 at 11:40:10AM +0200, Ales Musil wrote:
> The SCTP protocol ports were excluded from
> the netlink encoding. Which resulted in the
> lookup failure in kernel, leading to the entry
> not being flushed. Allow the flush of SCTP protocol
> based on port numbers.
>
> Signed-off-by:
On Wed, Aug 02, 2023 at 04:59:35PM +0800, Faicker Mo via dev wrote:
> Add tc csum offload support of protocols IGMP/UDPLITE/SCTP
>
> Signed-off-by: Faicker Mo
UDPLite will be deprecated in the Linux kernel from v6.4 [1].
Are you sure that we want to increase it's support in OvS at this time?
On Wed, Aug 02, 2023 at 04:06:51PM -0400, Mike Pattrick wrote:
> Diagnosing connectivity issues involving a bond can be complicated by a
> lack of logging in LACP. It is difficult to determine the health of
> sending and receving LACP packets. This is further complicated by the
> tendency of some
https://bugs.debian.org/1042358 reported a manpage-check failure with
groff 1.23.0 in Debian testing/unstable. Fixing the immediate mistake
here exposed a few other issues in how the tables in ovs-fields(7) are
rendered.
Colin Watson (3):
docs: Wrap more table entries in text blocks
docs:
If we omit this, groff 1.23.0 warns:
tbl preprocessor failed, or it or soelim was not run; table(s) likely
not rendered (TE macro called with TW register undefined)
Reported-by: Lucas Nussbaum
Reported-at: https://bugs.debian.org/1042358
Signed-off-by: Colin Watson
---
Makefile.am | 2 +-
This fixes a number of "table wider than line length minus indentation"
warnings from tbl.
Reported-by: Lucas Nussbaum
Reported-at: https://bugs.debian.org/1042358
Signed-off-by: Colin Watson
---
build-aux/extract-ofp-fields | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
tbl defaults to expecting table entries to be separated by tab
characters. However, commit 5a0e4aec1af5cf7741c490bce704577e51e536b9
converted these to spaces and inadvertently broke the rendering. Use
semicolons as separators instead; these are less prone to being broken
by tree-wide changes,
Excellent work, Ales. For the entire series,
Acked-by: Mark Michelson
On 7/31/23 09:35, Ales Musil wrote:
The timestamp refresh mechanism is based on
separate table. The new thread will collect
flow statistics from this table and based on
"idle_age" data we can decide whether we should
bump
Diagnosing connectivity issues involving a bond can be complicated by a
lack of logging in LACP. It is difficult to determine the health of
sending and receving LACP packets. This is further complicated by the
tendency of some switches to toggle the carrier on interfaces that
experience issues
On Wed, Aug 2, 2023 at 4:31 AM Robin Jarry wrote:
> Quoting Paul Ganssle, setuptools maintainer:
> > * The setuptools project has stopped maintaining all direct
> > invocations of setup.py years ago, and distutils is deprecated.
> > There are undoubtedly many ways that your setup.py-based
On Wed, Aug 2, 2023 at 4:31 AM Robin Jarry wrote:
> setup.py upload is now deprecated. When used, pypi.org returns an error:
>
> > Upload failed (400): Invalid value for blake2_256_digest. Error: Use
> > a valid, hex-encoded, BLAKE2 message digest.
>
> Use twine which is the recommended
On Wed, Aug 2, 2023 at 4:32 AM Robin Jarry wrote:
> The python/build folder contents are completely unrelated to the ovs
> python bindings. These files are only used during the build for various
> subsystems (docs, man pages, code generation, etc.).
>
> Having that folder in that location
On Fri, Aug 4, 2023 at 11:38 AM Simon Horman wrote:
> On Wed, Aug 02, 2023 at 04:06:51PM -0400, Mike Pattrick wrote:
> > Diagnosing connectivity issues involving a bond can be complicated by a
> > lack of logging in LACP. It is difficult to determine the health of
> > sending and receving LACP
Bleep bloop. Greetings miter, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 80 characters long (recommended limit is 79)
#126 FILE: lib/netdev-dpdk.c:629:
Bleep bloop. Greetings miter, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 84 characters long (recommended limit is 79)
#84 FILE: NEWS:66:
* Added new Qos
From: Lin Huang
OvS has supported packet-per-second policer which can be set at ingress
and egress side in kernel datapath. But the userspace datapath dosen't
support for ingress and egress packet-per-second policing now.
So, this patch add support for userspace ingress pps policing by using
From: Lin Huang
OvS has supported packet-per-second policer which can be set at ingress
and egress side in kernel datapath. But the userspace datapath doesn't
support for ingress and egress packet-per-second policing now.
So, this patch add support for userspace egress pps policing by using
From: Lin Huang
Currently srtcm_policer free packet one by one, if packets are exceed rate
limit.
This patch change srtcm_policer to free pkts by bulk using
rte_pktmbuf_free_bulk().
Signed-off-by: Lin Huang
---
lib/netdev-dpdk.c | 11 +++
1 file changed, 7 insertions(+), 4
From: Lin Huang
Now, token-bucket 'last_fill' is updated by token_bucket_withdraw() itself.
Add a new function parameter 'now' to update timestamp by caller.
Signed-off-by: Lin Huang
---
include/openvswitch/token-bucket.h | 3 ++-
lib/token-bucket.c | 4 ++--
lib/vlog.c
From: Lin Huang
v7->v8: fix cody by reviewing.
v6->v7: split pps and bps policer.
v5->v6: fix code by reviewing.
v5->v4: police pkts bps and pps at the same time.
Get the maximum from the number of dropped packets, and drop that.
v4->v3: rewrite egress_policer_details_to_param func.
Paolo Abeni writes:
> On Tue, 2023-08-01 at 17:22 -0400, Aaron Conole wrote:
>> The openvswitch selftests currently contain a few cases for managing the
>> datapath, which includes creating datapath instances, adding interfaces,
>> and doing some basic feature / upcall tests. This is useful to
On 8/4/23 09:12, David Marchand wrote:
> On Thu, Aug 3, 2023 at 4:22 PM Ilya Maximets wrote:
>>
>> Before GHA, OPTS were always passed as an argument for a *-build.sh
>> script. But that changed. Linux builds are using the OPTS variable
>> from the environment, but OSX script does not, so the
On 8/4/23 03:45, Simon Jones wrote:
> OK.
>
> At last, I think this patch is done, nothing need I do. Is that?
Right. The patch is already applied:
https://github.com/openvswitch/ovs/commit/20a7654d240f2af5da73a32c1791442e6aac0101
No actions needed from your side.
Best regards, Ilya
On Thu, Aug 3, 2023 at 4:22 PM Ilya Maximets wrote:
>
> Before GHA, OPTS were always passed as an argument for a *-build.sh
> script. But that changed. Linux builds are using the OPTS variable
> from the environment, but OSX script does not, so the options are
> currently ignored.
>
> That
45 matches
Mail list logo
