On Mon, Aug 14, 2023 at 10:02 PM Mark Michelson wrote:
> Hi Ales, I have a couple of notes below.
>
> On 8/14/23 05:21, Ales Musil wrote:
> > Add various missing sync calls which caused the
> > tests to be flaky due to sometimes missed on various
> > checks or packets.
> >
> > Signed-off-by: Ales
Thanks！
Ilya Maximets 于2023年8月15日 周二02:02写道：
> On 8/14/23 04:37, Peng He wrote:
> > OVS allows overlapping megaflows, as long as the actions of these
> > megaflows are equal. However, the current implementation of action
> > modification relies on flow_lookup instead of ufid, this could result
>
Only three families use info->userhdr today and going forward
we discourage using fixed headers in new families.
So having the pointer to user header in struct genl_info
is an overkill. Compute the header pointer at runtime.
Reviewed-by: Johannes Berg
Reviewed-by: Jiri Pirko
Signed-off-by: Jakub
Recent changes in net-next (commit 759ab1edb56c ("net: store netdevs
in an xarray")) refactored the handling of pre-assigned ifindexes
and let syzbot surface a latent problem in ovs. ovs does not validate
ifindex, making it possible to create netdev ports with negative
ifindex values. It's easy to
On 8/14/23 21:01, Mark Michelson wrote:
> On 8/14/23 12:25, Han Zhou wrote:
>> On Mon, Aug 14, 2023 at 6:54 AM Dumitru Ceara wrote:
>>>
>>> Fixes: 596ea7acbe68 ("ovn-controller: Detect and use L4_SYM dp-hash if
>> available.")
>>> Signed-off-by: Dumitru Ceara
>>> ---
>>> NEWS | 3 +++
>>> 1 fi
On 8/9/23 20:01, Mark Michelson wrote:
> Thanks Mohammad and Ales. I have pushed the change to main and all
> branches back to 22.03.
>
Hi Mark, Mohammad,
It seems this change broke 22.03:
https://github.com/ovn-org/ovn/actions/runs/5812479357
> On 8/3/23 04:46, Ales Musil wrote:
>> On Mon, Ju
Hi Ales, I have a couple of notes below.
On 8/14/23 05:21, Ales Musil wrote:
Add various missing sync calls which caused the
tests to be flaky due to sometimes missed on various
checks or packets.
Signed-off-by: Ales Musil
---
tests/ovn-controller.at | 10 +-
tests/ovn-ic.at
Acked-by: Mark Michelson
On 8/14/23 05:21, Ales Musil wrote:
The port group name consists of DP key and NB PG name.
Use first PG that is avaiable to avoid flakes when
neither of the logical switches has DP key 2.
Signed-off-by: Ales Musil
---
tests/ovn.at | 4 ++--
1 file changed, 2 insert
Thanks Ales,
Acked-by: Mark Michelson
On 8/14/23 05:21, Ales Musil wrote:
The test was assuming that the DP key and Port keys are
always fixed. Make sure that we use proper values for the
flow check.
Signed-off-by: Ales Musil
---
tests/ovn.at | 67 +++---
Acked-by: Mark Michelson
On 8/14/23 05:21, Ales Musil wrote:
Make sure the CT entries are sorted, otherwise the check
sometimes fails depending on the order from OvS.
Signed-off-by: Ales Musil
---
tests/system-ovn.at | 16
1 file changed, 8 insertions(+), 8 deletions(-)
d
On 8/14/23 12:25, Han Zhou wrote:
On Mon, Aug 14, 2023 at 6:54 AM Dumitru Ceara wrote:
Fixes: 596ea7acbe68 ("ovn-controller: Detect and use L4_SYM dp-hash if
available.")
Signed-off-by: Dumitru Ceara
---
NEWS | 3 +++
1 file changed, 3 insertions(+)
diff --git a/NEWS b/NEWS
index 827587
On 8/14/23 15:37, Eelco Chaudron wrote:
>
>
> On 11 Aug 2023, at 19:23, Ilya Maximets wrote:
>
>> It's fairly common to have veth0/veth1 interfaces on a system,
>> but that breaks SRv6 tests that are trying to create them.
>>
>> Adding ovs- prefix to avoid name collision.
>>
>> Fixes: 03fc1ad785
On 8/14/23 04:37, Peng He wrote:
> OVS allows overlapping megaflows, as long as the actions of these
> megaflows are equal. However, the current implementation of action
> modification relies on flow_lookup instead of ufid, this could result
> in looking up a wrong megaflow and make the ukeys and m
Thank you Igor.
Acked-by: Mark Michelson
Since this is such a small change, I went ahead and applied it to all
OVN branches from main back to 22.03.
On 8/12/23 09:37, Igor Zhukov wrote:
The server returns 404 for the previous link.
Signed-off-by: Igor Zhukov
---
ovn-architecture.7.xml |
On Mon, Aug 14, 2023 at 9:54 AM Ilya Maximets wrote:
>
> On 8/11/23 15:07, Dumitru Ceara wrote:
> > On 8/10/23 18:38, Ilya Maximets wrote:
> >> On 8/10/23 17:34, Dumitru Ceara wrote:
> >>> On 8/10/23 17:20, Han Zhou wrote:
> On Thu, Aug 10, 2023 at 6:36 AM Dumitru Ceara
wrote:
> >
>
On 8/11/23 15:07, Dumitru Ceara wrote:
> On 8/10/23 18:38, Ilya Maximets wrote:
>> On 8/10/23 17:34, Dumitru Ceara wrote:
>>> On 8/10/23 17:20, Han Zhou wrote:
On Thu, Aug 10, 2023 at 6:36 AM Dumitru Ceara wrote:
>
> On 8/10/23 15:34, Han Zhou wrote:
>> On Thu, Aug 10, 2023 at 2:2
On Mon, Aug 14, 2023 at 4:46 AM Dumitru Ceara wrote:
>
> On 8/12/23 07:08, Han Zhou wrote:
> > On Fri, Aug 11, 2023 at 6:07 AM Dumitru Ceara wrote:
> >>
> >> On 8/10/23 18:38, Ilya Maximets wrote:
> >>> On 8/10/23 17:34, Dumitru Ceara wrote:
> On 8/10/23 17:20, Han Zhou wrote:
> > On Thu
On Mon, Aug 14, 2023 at 6:54 AM Dumitru Ceara wrote:
>
> Fixes: 596ea7acbe68 ("ovn-controller: Detect and use L4_SYM dp-hash if
available.")
> Signed-off-by: Dumitru Ceara
> ---
> NEWS | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/NEWS b/NEWS
> index 8275877f99..f99334c1b8 100644
>
On 8/12/23 07:19, Han Zhou wrote:
> On Fri, Aug 11, 2023 at 6:23 AM Dumitru Ceara wrote:
>>
>> On 8/1/23 12:51, Han Zhou wrote:
>>> On Tue, Jul 18, 2023 at 6:16 AM Dumitru Ceara wrote:
On 7/18/23 12:14, Han Zhou wrote:
> On Mon, Jul 17, 2023 at 9:51 PM Dumitru Ceara
> wrote:
>>
Fixes: 596ea7acbe68 ("ovn-controller: Detect and use L4_SYM dp-hash if
available.")
Signed-off-by: Dumitru Ceara
---
NEWS | 3 +++
1 file changed, 3 insertions(+)
diff --git a/NEWS b/NEWS
index 8275877f99..f99334c1b8 100644
--- a/NEWS
+++ b/NEWS
@@ -10,6 +10,9 @@ Post v23.06.0
- To allow opt
On 11 Aug 2023, at 19:23, Ilya Maximets wrote:
> It's fairly common to have veth0/veth1 interfaces on a system,
> but that breaks SRv6 tests that are trying to create them.
>
> Adding ovs- prefix to avoid name collision.
>
> Fixes: 03fc1ad78521 ("userspace: Add SRv6 tunnel support.")
> Signed-o
Bleep bloop. Greetings Paolo Valerio, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Author hepeng needs to sign off.
WARNING: Unexpected sign-offs from developers who are
From: hepeng
The patch avoids the extra allocation for nat_conn.
Currently, when doing NAT, the userspace conntrack will use an extra
conn for the two directions in a flow. However, each conn has actually
the two keys for both orig and rev directions. This patch introduces a
key_node[CT_DIRS] mem
On Mon, Aug 14, 2023 at 1:46 PM Dumitru Ceara wrote:
> On 8/12/23 07:08, Han Zhou wrote:
> > On Fri, Aug 11, 2023 at 6:07 AM Dumitru Ceara wrote:
> >>
> >> On 8/10/23 18:38, Ilya Maximets wrote:
> >>> On 8/10/23 17:34, Dumitru Ceara wrote:
> On 8/10/23 17:20, Han Zhou wrote:
> > On Thu,
On 8/14/23 12:39, Ilya Maximets wrote:
> On 8/12/23 10:07, Simon Horman wrote:
>> Aaron Conole was recently elected by the Open vSwitch committers.
>> This formalizes his status as an Open vSwitch committer.
>>
>> Welcome Aaron!
>
> Welcome!
>
Congrats, Aaron, well deserved!
___
On 8/12/23 07:08, Han Zhou wrote:
> On Fri, Aug 11, 2023 at 6:07 AM Dumitru Ceara wrote:
>>
>> On 8/10/23 18:38, Ilya Maximets wrote:
>>> On 8/10/23 17:34, Dumitru Ceara wrote:
On 8/10/23 17:20, Han Zhou wrote:
> On Thu, Aug 10, 2023 at 6:36 AM Dumitru Ceara
> wrote:
>>
>> On 8/1
On 8/12/23 10:07, Simon Horman wrote:
> Aaron Conole was recently elected by the Open vSwitch committers.
> This formalizes his status as an Open vSwitch committer.
>
> Welcome Aaron!
Welcome!
>
> Signed-off-by: Simon Horman
Applied. Thanks!
Best regards, Ilya Maximets.
> ---
> MAINTAINER
Add various missing sync calls which caused the
tests to be flaky due to sometimes missed on various
checks or packets.
Signed-off-by: Ales Musil
---
tests/ovn-controller.at | 10 +-
tests/ovn-ic.at | 7 ---
tests/ovn-northd.at | 14 +-
tests/ovn.at
Make sure the CT entries are sorted, otherwise the check
sometimes fails depending on the order from OvS.
Signed-off-by: Ales Musil
---
tests/system-ovn.at | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/tests/system-ovn.at b/tests/system-ovn.at
index 766a250
The test was assuming that the DP key and Port keys are
always fixed. Make sure that we use proper values for the
flow check.
Signed-off-by: Ales Musil
---
tests/ovn.at | 67 +++-
1 file changed, 35 insertions(+), 32 deletions(-)
diff --git a/test
The port group name consists of DP key and NB PG name.
Use first PG that is avaiable to avoid flakes when
neither of the logical switches has DP key 2.
Signed-off-by: Ales Musil
---
tests/ovn.at | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/ovn.at b/tests/ovn.at
i
From: Numan Siddique
When changes to port bindings corresponding to router ports are
handled by northd engine node, incorrect warning logs (like below)
are logged.
northd|WARN|A port-binding for lrp0 is created but the LSP is not found.
Fix these warnings.
Since we are preserving the
Hello:
This series was applied to netdev/net-next.git (main)
by David S. Miller :
On Fri, 11 Aug 2023 16:12:47 +0200 you wrote:
> There is currently a gap in drop visibility in the openvswitch module.
> This series tries to improve this by adding a new drop reason subsystem
> for OVS.
>
> Apart
33 matches
Mail list logo
