On Fri, Aug 18, 2023 at 2:33 PM Numan Siddique wrote:
>
> On Fri, Aug 18, 2023 at 11:38 AM Han Zhou wrote:
> >
> > On Wed, Aug 9, 2023 at 9:38 AM wrote:
> > >
> > > From: Numan Siddique
> > >
> > Thanks Numan for the enhancement.
> >
> > > Instead of maintaing the lport to lflow references
The warning message is
|1|tc(handler4)|WARN|can't offload rewrite of IP/IPV6 with ip_proto: X.
IPIP and GRE only need the checksum recalculation of the IP header if the
IP header is rewritten.
Fixes: d6118e628988 ("netdev-tc-offloads: Verify csum flags on dump from tc")
Signed-off-by:
v3:
- add test case for 1/2.
- more verbose commit message.
v2:
- seperated into two commits.
- add the specific protocols to offload in ip rewrite.
Faicker Mo (2):
netdev-tc-offload: Add csum offload of IGMP/UDPLITE/SCTP in ip rewrite
netdev-tc-offload: Add IPIP/GRE protocols to
When the IP header is rewritten like NAT or ttl/tos changed,
the csum of IP header need recalculation. The UDPLITE checksum
needs recalculation if src or dst changed in IP header.
The tc-csum action is for this.
Signed-off-by: Faicker Mo
---
lib/tc.c | 7 ++-
Fixes: 30b79363b967 ("Makefile.am: Add clang static analysis support")
Signed-off-by: Nobuhiro MIKI
---
tests/.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/.gitignore b/tests/.gitignore
index 83b1cb3b489e..3a8c45975645 100644
--- a/tests/.gitignore
+++ b/tests/.gitignore
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Comment with 'xxx' marker
#229 FILE: northd/northd.c:4796:
/* XXX
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line has non-spaces leading whitespace
WARNING: Line has trailing whitespace
#3073
On Fri, Aug 18, 2023 at 11:38 AM Han Zhou wrote:
>
> On Wed, Aug 9, 2023 at 9:38 AM wrote:
> >
> > From: Numan Siddique
> >
> Thanks Numan for the enhancement.
>
> > Instead of maintaing the lport to lflow references using
> > 'struct lflow_ref_list', this patch makes use of the existing
> >
From: Numan Siddique
This patch adds the I-P support for any changes to router NATs
in both the northd and lflow engine nodes.
Signed-off-by: Numan Siddique
---
northd/en-lflow.c| 10 +
northd/en-northd.c | 30 ++-
northd/en-northd.h | 4 +-
northd/inc-proc-northd.c |
From: Numan Siddique
With this we don't fall back to recompute of northd engine node
when SB port bindings (of router ports) updates from SB ovsdb-server
are received.
Signed-off-by: Numan Siddique
---
northd/en-northd.c | 2 +-
northd/en-sync-sb.c | 3 +-
northd/northd.c | 197
From: Numan Siddique
If a load balancer or load balancer group is changed, then the
lflow engine handles these changes incrementally. This is
possible because we maintain lb to lflow references (using objdep_mgr)
for each lb in the 'struct lb_datapaths'.
northd engine adds the changed load
From: Numan Siddique
Previous commits made of objdep_mgr to store the lflow references
for ovn_port, ovn_datapath and load balancers. This patch refactors
the northd change tracking to make it easier to pass the northd
changed data to lflow engine for lflow generation.
In order to
From: Numan Siddique
This will help in handling the lflows for logical switch ports
or router ports incrementally. Upcoming patch will make use of
this separtion.
Signed-off-by: Numan Siddique
---
northd/northd.c | 333
1 file changed, 221
From: Numan Siddique
The flows to allow DHCP response from ovn-controller were missing
if a logical VIF port had dhcp v4/v6 options set and were handled
incrementally.
Fixes: 8bbd67891f68 ("northd: Incremental processing of VIF additions in
'lflow' node.")
Signed-off-by: Numan Siddique
---
From: Numan Siddique
When a logical router gets updated due to load balancer or load balancer
groups changes, it is now incrementally handled first in 'lb_data'
engine node similar to how logical switch changes are handled. The
tracking data of 'lb_data' is updated similarly so that northd
From: Numan Siddique
A new engine node 'sync_to_sb_pb' is added within 'sync_to_sb'
node to sync NAT column of Port bindings table. This separation
is required in order to add load balancer group I-P handling
in 'northd' engine node (which is handled in the next commit).
'sync_to_sb_pb' engine
From: Numan Siddique
For every a given load balancer group 'A', northd engine data maintains
a bitmap of datapaths associated to this lb group. So when lb group 'A'
gets associated to a logical switch 's1', the bitmap index of 's1' is set
in its bitmap.
In order to handle the load balancer
From: Numan Siddique
'lb_data' engine node now also handles logical switch changes.
Its data maintains ls to lb related information. i.e if a
logical switch sw0 has lb1, lb2 and lb3 associated then
it stores this info in its data. And when a new load balancer
lb4 is associated to it, it stores
From: Numan Siddique
This will help in handling other column changes of a logical switch.
Acked-by: Han Zhou
Signed-off-by: Numan Siddique
---
northd/en-lb-data.c | 2 +-
northd/northd.c | 356 ++--
2 files changed, 209 insertions(+), 149
From: Numan Siddique
Any changes to load balancers and load balancer groups
are handled incrementally in the newly added 'lb_data'
engine node. 'lb_data' is input to 'northd' node
and the handler - northd_lb_data_handler in 'northd'
node handles the changes.
If a load balancer or load balancer
From: Numan Siddique
This patch separates out the 'lbs' and 'lb_groups' from the 'northd' engine
node data into a new engine node 'lb_data'. This new node becomes
an input to the 'northd' node.
This makes handling the NB load balancer and load balancer group changes
easier.
Prior to this
From: Numan Siddique
Similar to the commit [1], a new sub-engine node "sync_to_sb_lb"
is added with-in the "sync_to_sb" to sync the SB load balancers.
Its main input nodes are "northd" (to access the "lbs" hmap built
by this node) and "sb_load_balancer" to access the SB load balancer.
From: Numan Siddique
This patch series adds the support to handle load balancer and
load balancer group changes incrementally in the "northd" engine
node and "lflow" engine node. Changes to logical switches and router's load
balancer and load balancer group columns are also handled
No, I'll add a test case with this patch 1/2.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Wed, Aug 9, 2023 at 9:38 AM wrote:
>
> From: Numan Siddique
>
Thanks Numan for the enhancement.
> Instead of maintaing the lport to lflow references using
> 'struct lflow_ref_list', this patch makes use of the existing
> objdep APIs. Since objdep_mgr is not thread safe, an instance
> of
25 matches
Mail list logo
