Re: [ovs-dev] [PATCH ovn] northd: Allow need frag to be SNATed

On Mon, Oct 9, 2023 at 5:29 PM Dumitru Ceara wrote: > On 9/20/23 09:37, Ales Musil wrote: > > On Wed, Sep 20, 2023 at 8:21 AM Ales Musil wrote: > > > >> Considering following topology: > >> client - sw0 - lrp0 - lr - lrp1 - sw1 - server > >> sw0 in subnet 192.168.0.0/24 > >> sw1 in subnet 172.16

Re: [ovs-dev] [PATCH net-next 2/2] net: openvswitch: Annotate struct mask_array with __counted_byUse struct_size()

Le 02/10/2023 à 18:51, Ilya Maximets a écrit : On 10/1/23 13:07, Christophe JAILLET wrote: Prepare for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time checking via CONF

Re: [ovs-dev] [PATCH V3 1/2] netdev-offload-dpdk: Fix flushing of a physdev

On 6/29/23 16:08, Simon Horman wrote: > On Sun, Jun 11, 2023 at 06:58:26PM +0300, Eli Britstein via dev wrote: >> Vport's offloads are done on the tracked orig-in-port, but the flow itself >> is associated in the vport's map. >> >> Removing the physdev will flush all the ports that are on its map,

Re: [ovs-dev] [PATCH V3 2/2] dpif-netdev: Fix flushing of a vport

On 6/11/23 17:58, Eli Britstein wrote: > When using a userspace vport ("vxlan0"), dpif-netdev adds an additional > netdev ("vxlan_sys_4789"). The dpif netdev ("vxlan0") is added to the > netdev-offload ports map, thus flows are associated on this netdev. > > However, flushing is done on the dpif-n

Re: [ovs-dev] [PATCH ovn v2] controller: Don't artificially limit group and meter IDs to 16bit.

On 10/9/23 17:39, Ilya Maximets wrote: > On 10/4/23 18:33, Dumitru Ceara wrote: >> OVS actually supports way more. Use the real numbers instead. >> To avoid preallocating huge bitmaps for the group/meter IDs, switch to >> id-pool instead (as suggested by Ilya). >> >> Reported-at: https://issues.re

Re: [ovs-dev] [PATCH ovn v2] controller: Don't artificially limit group and meter IDs to 16bit.

On 10/4/23 18:33, Dumitru Ceara wrote: > OVS actually supports way more. Use the real numbers instead. > To avoid preallocating huge bitmaps for the group/meter IDs, switch to > id-pool instead (as suggested by Ilya). > > Reported-at: https://issues.redhat.com/browse/FDP-70 > Suggested-by: Ilya M

Re: [ovs-dev] [PATCH ovn] northd: Allow need frag to be SNATed

On 9/20/23 09:37, Ales Musil wrote: > On Wed, Sep 20, 2023 at 8:21 AM Ales Musil wrote: > >> Considering following topology: >> client - sw0 - lrp0 - lr - lrp1 - sw1 - server >> sw0 in subnet 192.168.0.0/24 >> sw1 in subnet 172.168.0.0/24 >> SNAT configured for sw0 subnet >> gateway_mtu=1400 conf

Re: [ovs-dev] [PATCH ovn] controller: have I+P assigning ct_zones for l3gateway ports

On 9/18/23 18:46, Xavier Simonart wrote: > When l3gateway ports get added, ct_zones were assigned during > (ct_zones) recomputes, but not by I+P. > Before this patch, test "Migration of CT zone from UUID to name" > was randomly failing, as ct_zone was not assigned by I+P but > a ct_zone recompute h

[ovs-dev] [PATCH] ofproto-dpif-upcall: Pause revalidators when purging.

A main thread executing the 'revalidator/purge' command could race with revalidator threads that can be dumping/sweeping the purged flows at the same time. This race can be reproduced (with dpif debug logs) by running the conntrack - ICMP related unit tests with the userspace datapath: 2023-10-09

Re: [ovs-dev] [PATCH ovn] northd: Avoid snat on reply packets for dgw

On 9/12/23 13:57, liuxie...@163.com wrote: > From: shylou > > OVN had fix the issue[1] that avoid snat on reply packets for > gateway router. It is also needed to be dealt with for dgw. > > [1]https://github.com/ovn-org/ovn/commit/8b3e1afc30 > > Signed-off-by: Xie Liu > --- Hi, Xie Liu, Sorr

Re: [ovs-dev] [PATCH ovn] DNS: allow defining records that owned by OVN only

On 10/1/23 21:27, Mohammad Heib wrote: > Currently OVN allows users to create DNS records > and define domains within these records. > > These domains can be associated with IPV4 or IPv6 > or both, when the user creates a domain with both > IPv4 and IPv6 ovn will answer each query for this > domai

Re: [ovs-dev] [PATCH, v4] netdev: Sync'ed and cleaned {get, set}_config().

On 10/8/23 10:00, Jakob Meng wrote: > > > On 06.10.23 20:00, Ilya Maximets wrote: >> On 10/6/23 09:49, Jakob Meng wrote: >>> On 05.10.23 21:08, Ilya Maximets wrote: On 10/4/23 14:21, jm...@redhat.com wrote: > diff --git a/tests/pmd.at b/tests/pmd.at > index 7bdaca9e7..fb838286b 10064

Re: [ovs-dev] [PATCH v3 2/3] tests/tunnel.at: Add geneve options mirror test.

On 09/10/2023 15:05, Roi Dayan wrote: > Test geneve options mirror flow doesn't add redundant mirror. > > Signed-off-by: Roi Dayan > --- > > Notes: > v3: > - use AT_CHECK for configuring the mirror port. > > v2: > - add dot in title. > > tests/tunnel.at | 29

[ovs-dev] [PATCH v3 3/3] tests: Update some tests title prefix print.

Use test title prefix according to filename the test is in for tunnel.at and ofproto-dpif.at. Signed-off-by: Roi Dayan Acked-by: Simon Horman Acked-by: Eelco Chaudron --- Notes: v2: - add prefix to bond cases. tests/ofproto-dpif.at | 10 +- tests/tunnel.at | 2 +- 2 fi

[ovs-dev] [PATCH v3 1/3] ofproto-dpif-upcall: Fix redundant mirror on geneve tunnel options.

The cited commit fixed missing mirror packets by reset mirror when packets are modified but setting geneve options was also treated as a modified packet but should be treated as a part of set_tunnel which doesn't reset mirror. Fixes: feed7f677505 ("ofproto-dpif-upcall: Mirror packets that are modi

[ovs-dev] [PATCH v3 2/3] tests/tunnel.at: Add geneve options mirror test.

Test geneve options mirror flow doesn't add redundant mirror. Signed-off-by: Roi Dayan --- Notes: v3: - use AT_CHECK for configuring the mirror port. v2: - add dot in title. tests/tunnel.at | 29 + 1 file changed, 29 insertions(+) diff --git a/

[ovs-dev] [PATCH v3 0/3] Fix redundant mirror with tunnel options.

Hi, The first commit removing the redundant mirror when using tunnel options. The second is a test to verify it stays like this and doesn't break again. The third commit is just updating prefixes of tests to match the file their in. Thanks, Roi Roi Dayan (3): ofproto-dpif-upcall: Fix redundan

Re: [ovs-dev] [PATCH v2 2/3] tests/tunnel.at: Add geneve options mirror test.

On 9 Oct 2023, at 13:40, Roi Dayan wrote: > On 09/10/2023 12:56, Eelco Chaudron wrote: >> >> >> On 8 Oct 2023, at 9:08, Roi Dayan wrote: >> >>> On 05/10/2023 15:36, Eelco Chaudron wrote: On 4 Oct 2023, at 12:09, Roi Dayan via dev wrote: > Test geneve options mirror flow

Re: [ovs-dev] [PATCH v2 2/3] tests/tunnel.at: Add geneve options mirror test.

On 09/10/2023 12:56, Eelco Chaudron wrote: > > > On 8 Oct 2023, at 9:08, Roi Dayan wrote: > >> On 05/10/2023 15:36, Eelco Chaudron wrote: >>> >>> >>> On 4 Oct 2023, at 12:09, Roi Dayan via dev wrote: >>> Test geneve options mirror flow doesn't add redundant mirror. Signed-off-by

Re: [ovs-dev] [PATCH V3 2/2] dpif-netdev: Fix flushing of a vport

On Thu, Jun 29, 2023 at 04:08:47PM +0200, Simon Horman wrote: > On Sun, Jun 11, 2023 at 06:58:27PM +0300, Eli Britstein via dev wrote: > > When using a userspace vport ("vxlan0"), dpif-netdev adds an additional > > netdev ("vxlan_sys_4789"). The dpif netdev ("vxlan0") is added to the > > netdev-off

Re: [ovs-dev] [PATCH] system-dpdk: Negotiation Tests for TSO

On Tue, Jun 15, 2021 at 09:50:24AM +, root wrote: > From: Meher Chinwala > > system-dpdk: Negotiation Tests for TSO > > This patch adds negotiation tests for checking whether TSO is enabled or not > in OVS and in TestPMD for 4 diferent scenarios. > > Signed-off-by: Meher Chinwala Hi, Th

Re: [ovs-dev] [PATCH v2] conntrack: fix incorrect check nat_action_info in check_orig_tuple

On Fri, Jul 09, 2021 at 01:37:12PM +0800, we...@ucloud.cn wrote: > From: wenxu > > A case for client A 10.0.0.2 snat to 1.1.1.2 with following flows. > > rule1: ovs-ofctl add-flow manbr "table=0,ct_state=-trk,ip,in_port=dpdk2, > actions=ct(table=1, nat)" > rule2: ovs-ofctl add-flow manbr > "ta

Re: [ovs-dev] [PATCH v1] conntrack: Add state and sequence validation

On Thu, Jun 17, 2021 at 04:21:19PM -0400, Aaron Conole wrote: > During testing, there was an edge condition that was found during > packet pickup where userspace can improperly advance the TCP state > machine during connection exstablishment and bypass the 3whs. This > can pollute the TCP sequence

Re: [ovs-dev] [PATCH v2] ofproto-dpif-upcall: Fix race condition while purging

On Thu, May 27, 2021 at 10:29:14AM +, Jianbo Liu wrote: > There is a race condidtion between purger and handler in dpif-netlink. > Handler may create new ukey and install it while executing 'ovs-appctl > revalidator/purge' command. However, before handler calls > transition_ukey() in handle_upc

Re: [ovs-dev] [PATCH v2] Add support for gdbserver in ovs-sandbox script

On Thu, May 27, 2021 at 05:08:45AM +, Guzowski Adrian wrote: > Using gdbserver instead of plain gdb allows two new use cases: > 1. Ability to debug vSwitch running on remote/virtual machines > 2. Ability to debug vSwitch with IDE (tested on CLion) > > Signed-off-by: Guzowski Adrian Hi Guzows

Re: [ovs-dev] [PATCH v2 2/3] tests/tunnel.at: Add geneve options mirror test.

On 8 Oct 2023, at 9:08, Roi Dayan wrote: > On 05/10/2023 15:36, Eelco Chaudron wrote: >> >> >> On 4 Oct 2023, at 12:09, Roi Dayan via dev wrote: >> >>> Test geneve options mirror flow doesn't add redundant mirror. >>> >>> Signed-off-by: Roi Dayan >> >> In general this patch looks good, some sm

Re: [ovs-dev] [PATCH] netdev: Remove modulo operation in dpdk/vhost/afxdp tx path

On Sat, Oct 07, 2023 at 06:06:56AM +, Li,Rongqing wrote: > > > > -Original Message- > > From: Simon Horman > > Sent: Friday, October 6, 2023 6:52 PM > > To: Li,Rongqing > > Cc: d...@openvswitch.org > > Subject: Re: [ovs-dev] [PATCH] netdev: Remove modulo operation in > > dpdk/vhost/

Re: [ovs-dev] [PATCH v3 3/3] netlink, netdev: Enforce CT limit protection.

On 10/6/23 07:31, Ales Musil wrote: > > > On Thu, Oct 5, 2023 at 8:49 PM Ilya Maximets > wrote: > > On 10/2/23 12:33, Ales Musil wrote: > > Enforce the CT limit protection, it ensures that > > any CT limit value that was set by forced operation, > > cu