Re: [ovs-dev] [PATCH 0/7] net: openvswitch: Reduce stack usage

2023-10-24 Thread Nicholas Piggin
On Sat Oct 21, 2023 at 3:04 AM AEST, Aaron Conole wrote: > "Nicholas Piggin" writes: > > > On Wed Oct 11, 2023 at 11:23 PM AEST, Aaron Conole wrote: > >> Nicholas Piggin writes: > >> > >> > Hi, > >> > > >> > I'll post this out again to keep discussion going. Thanks all for the > >> > testing and

Re: [ovs-dev] [PATCH v3 3/3] openflow: Allow CT flush to match on mark and labels.

2023-10-24 Thread Ilya Maximets
On 10/18/23 08:28, Ales Musil wrote: > Extend the current NX_CT_FLUSH with four additional fields, > that allow to match on CT entry "mark" or "labels". This > is encoded as separate TLV values which is backward compatible. > Versions that do not support them will simply ignore it. Hmm. Just noti

Re: [ovs-dev] [PATCH v3 1/3] ofp-prop: Add helper for parsing and storing of ovs_u128.

2023-10-24 Thread Ilya Maximets
On 10/18/23 08:28, Ales Musil wrote: > Add helper methods that allow us to store and parse the > ovs_u128 type. > > Signed-off-by: Ales Musil > --- > v3: Rebase on top of current master. > v2: Add missing ofpprop_parse_be128() function. > --- > include/openvswitch/ofp-prop.h | 5 > lib/ofp

Re: [ovs-dev] [PATCH v3 1/1] ofproto-dpif-trace: Improve conjunctive match tracing.

2023-10-24 Thread Ilya Maximets
On 10/3/23 09:41, Nobuhiro MIKI wrote: > On 2023/10/02 20:41, Simon Horman wrote: >> + Mike Pattrick >> >> On Mon, Sep 25, 2023 at 06:09:00PM +0900, Nobuhiro MIKI wrote: >>> A conjunctive flow consists of two or more multiple flows with >>> conjunction actions. When input to the ofproto/trace comm

Re: [ovs-dev] [PATCH v3 1/1] ofproto-dpif-trace: Improve conjunctive match tracing.

2023-10-24 Thread Ilya Maximets
On 9/25/23 11:09, Nobuhiro MIKI wrote: > A conjunctive flow consists of two or more multiple flows with > conjunction actions. When input to the ofproto/trace command > matches a conjunctive flow, it outputs flows of all dimensions. > > Signed-off-by: Nobuhiro MIKI > --- > v3: > * Remove struct f

Re: [ovs-dev] [PATCH ovn] northd: Support CIDR-based MAC binding aging threshold.

2023-10-24 Thread 0-day Robot
Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Comment with 'xxx' marker #438 FILE: northd/northd.c:1172: * XXX: This approach si

[ovs-dev] [PATCH ovn] northd: Support CIDR-based MAC binding aging threshold.

2023-10-24 Thread Han Zhou
Enhance MAC_Binding aging to allow CIDR-based threshold configurations. This enables distinct threshold settings for different IP ranges, applying the longest prefix matching for overlapping ranges. A common use case involves setting a default threshold for all IPs, while disabling aging for a spe

[ovs-dev] [PATCH v4] Implement compose-packet --hexified [--bad-csum].

2023-10-24 Thread Ihar Hrachyshka
With --hexified, it will produce a bare hexified payload with no spaces or offset indicators inserted, which is useful in tests to produce frames to pass to e.g. `receive`. With --bad-csum, it will produce a frame that has an invalid IP checksum (applicable to IPv4 only because IPv6 doesn't have c

Re: [ovs-dev] [PATCH v7 1/8] system-dpdk: Introduce helpers for testpmd.

2023-10-24 Thread David Marchand
On Mon, Oct 23, 2023 at 10:20 AM David Marchand wrote: > +# OVS_DPDK_CHECK_TESTPMD() > +# > +# Check dpdk-testpmd availability. > +# > +m4_define([OVS_DPDK_CHECK_TESTPMD], > + [AT_SKIP_IF([! which dpdk-testpmd >/dev/null 2>/dev/null]) > +]) > + > + > +# OVS_DPDK_START_TESTPMD() > +# > +# Start dp

[ovs-dev] [PATCH ovn] northd: forward arp request to lrp snat on.

2023-10-24 Thread Daniel Ding
If the router has a snat rule and it's external ip isn't lrp address, when the arp request from other router for this external ip, will be drop, because of this external ip use same mac address as lrp, so can not forward to MC_FLOOD. Fixes: 32f5ebb06226 ("ovn-northd: Limit ARP/ND broadcast domain

Re: [ovs-dev] [PATCH] readthedocs: Add the configuration file.

2023-10-24 Thread Ilya Maximets
On 10/23/23 20:56, Jakob Meng wrote: > On 23.10.23 20:52, Jakob Meng wrote: >> On 23.10.23 15:31, Ilya Maximets wrote: >>> Since last month ReadTheDocs only supports building with a new >>> configuration file provided in the repository itself: >>> https://blog.readthedocs.com/migrate-configuratio

Re: [ovs-dev] [PATCH v6 0/3] netdev: Sync and clean {get, set}_config() callbacks.

2023-10-24 Thread Kevin Traynor
Using correct email for Simon this time On 24/10/2023 10:19, Kevin Traynor wrote: On 23/10/2023 10:11, Jakob Meng wrote: On 20.10.23 12:02, Kevin Traynor wrote: On 13/10/2023 10:07, jm...@redhat.com wrote: From: Jakob Meng For better usability, the function pairs get_config() and set_config

Re: [ovs-dev] [PATCH v6 0/3] netdev: Sync and clean {get, set}_config() callbacks.

2023-10-24 Thread Kevin Traynor
On 23/10/2023 10:11, Jakob Meng wrote: On 20.10.23 12:02, Kevin Traynor wrote: On 13/10/2023 10:07, jm...@redhat.com wrote: From: Jakob Meng For better usability, the function pairs get_config() and set_config() for netdevs should be symmetric: Options which are accepted by set_config() shoul

Re: [ovs-dev] OVN weekly community meeting

2023-10-24 Thread Vladislav Odintsov
> On 24 Oct 2023, at 12:01, Dumitru Ceara wrote: > > On 10/24/23 10:57, Vladislav Odintsov wrote: >> Hi Dumitru! >> >>> On 24 Oct 2023, at 10:34, Dumitru Ceara wrote: >>> >>> On 10/23/23 11:58, Dumitru Ceara wrote: > In the meantime, as discussed, I sent out an invite to the people in >>

Re: [ovs-dev] OVN weekly community meeting

2023-10-24 Thread Dumitru Ceara
On 10/24/23 10:57, Vladislav Odintsov wrote: > Hi Dumitru! > >> On 24 Oct 2023, at 10:34, Dumitru Ceara wrote: >> >> On 10/23/23 11:58, Dumitru Ceara wrote: In the meantime, as discussed, I sent out an invite to the people in this thread but I'm also sharing it here for anyone from the

Re: [ovs-dev] OVN weekly community meeting

2023-10-24 Thread Vladislav Odintsov
Hi Dumitru! > On 24 Oct 2023, at 10:34, Dumitru Ceara wrote: > > On 10/23/23 11:58, Dumitru Ceara wrote: >>> In the meantime, as discussed, I sent out an invite to the people in >>> this thread but I'm also sharing it here for anyone from the community >>> to join if they like it. >>> >>> Date/

Re: [ovs-dev] OVN weekly community meeting

2023-10-24 Thread Dumitru Ceara
On 10/23/23 11:58, Dumitru Ceara wrote: >> In the meantime, as discussed, I sent out an invite to the people in >> this thread but I'm also sharing it here for anyone from the community >> to join if they like it. >> >> Date/Time: Monday October 23rd 15:00 UTC >> Video Link: https://meet.google.com

Re: [ovs-dev] [PATCH v2] tests/system-traffic: Allow warn log on revalidator purge.

2023-10-24 Thread David Marchand
Hello Frode, On Tue, Oct 24, 2023 at 6:47 AM Frode Nordahl wrote: > > > I recently submitted a change on this topic, that got applied last Friday. > > > https://github.com/openvswitch/ovs/commit/bd86266ea9ab > > > > > > Could you have a look with the current master branch and confirm if > > > you