On 30 Oct 2023, at 21:10, Ilya Maximets wrote:
> A few general style issues like extra spacing and lines being too long.
> Also, unused variables 'error_types' and 'comments'. And a few invalid
> escape sequences, which are not actual escape sequences, but cause
> actual syntax warnings starti
On 30 Oct 2023, at 21:10, Ilya Maximets wrote:
> Otherwise it's hard to keep track of all the scripts we have.
>
> Signed-off-by: Ilya Maximets
Thanks for fixing this, and the changes look good to me.
Acked-by: Eelco Chaudron
___
dev mailing list
On 30 Oct 2023, at 21:10, Ilya Maximets wrote:
> A few general style issues like extra spacing and lines being too long,
> unused variable 'error_types', passing more arguments than a format
> string has. And a few invalid escape sequences, which are not actual
> escape sequences, but cause ac
On 30 Oct 2023, at 21:10, Ilya Maximets wrote:
> A few general style issues like extra spacing and block comment format.
> And a few invalid escape sequences, which are not actual escape
> sequences, but cause actual syntax warnings starting python 3.12 and
> will eventually become syntax error
On 30 Oct 2023, at 21:10, Ilya Maximets wrote:
> A few general style issues like extra spacing and line length,
> semicolons at the end of the line and unused variable 'raw_types'.
> And a few invalid escape sequences, which are not actual escape
> sequences, but cause actual syntax warnings st
On 30 Oct 2023, at 21:10, Ilya Maximets wrote:
> These were recently updated to pass the checks, so should be
> added to the list in order to avoid regressions in the future.
> While at it, fixing the indentation.
>
> Signed-off-by: Ilya Maximets
Thanks for fixing this, and the changes look g
On 30 Oct 2023, at 15:00, Ilya Maximets wrote:
> There is no TCA_TUNNEL_KEY_ENC_SRC_PORT in the kernel, so the offload
> should not be attempted if OVS_TUNNEL_KEY_ATTR_TP_SRC is requested
> by OVS. Current code just ignores the attribute in the tunnel(set())
> action leading to a flow mismatch
Raft election timers for NB and SB DB clusters are configurable via
ovn-ctl but the options are not mention on the man page.
Signed-off-by: Martin Kalcok
---
utilities/ovn-ctl.8.xml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/utilities/ovn-ctl.8.xml b/utilities/ovn-ctl.8.xml
index 828
On 10/26/23 13:37, Dumitru Ceara wrote:
> OVS actually supports way more. Detect the real number of groups and
> meters instead. To avoid preallocating huge bitmaps for the IDs,
> switch to id-pool instead (as suggested by Ilya).
>
> Reported-at: https://issues.redhat.com/browse/FDP-70
> Suggeste
Bleep bloop. Greetings , I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
git-am:
error: corrupt patch at line 10
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff
On Mon, Oct 30, 2023 at 7:43 AM Simon Horman wrote:
>
> On Mon, Oct 30, 2023 at 02:58:36AM -0400, Mike Pattrick wrote:
> > Currently when userspace-tso is enabled, netdev-linux interfaces will
> > indicate support for all offload flags regardless of interface
> > configuration. This patch checks f
In case there is no match on GRE key, avoid adding the key match item.
Fixes: 7617d0583c73 ("netdev-offload-dpdk: Add support for matching on gre
fields.")
Signed-off-by: Salem Sol
---
lib/netdev-offload-dpdk.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/l
Bleep bloop. Greetings Salem Sol, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
git-am:
error: sha1 information is lacking or useless (lib/netdev-offload-dpdk.c).
error: could not build fake
In case there is no match on GRE key, avoid adding the key match item.
Fixes: 7617d0583c73 ("netdev-offload-dpdk: Add support for matching on gre
fields.")
Signed-off-by: Salem Sol
---
lib/netdev-offload-dpdk.c | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/
Bleep bloop. Greetings Salem Sol, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: The subject summary should end with a dot.
Subject: netdev-offload-dpdk: Fix GRE without a
In case there is no match on GRE key, avoid adding the key match item.
Fixes: 7617d0583c73 ("netdev-offload-dpdk: Add support for matching on gre
fields.")
Signed-off-by: Salem Sol
---
lib/netdev-offload-dpdk.c | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/
On Mon, Oct 23, 2023 at 10:41:12AM +0100, Kevin Traynor wrote:
> Add group for dpdkvhostuser(/client) netdev.
>
> Adding as a single group as they display the same status,
> one of which is 'mode' to indicate if it's client or server.
>
> Fixes: b2e8b12f8a82 ("netdev-dpdk: add vhost-user get_stat
On Mon, Oct 23, 2023 at 04:21:53PM +0200, Eelco Chaudron wrote:
> This series fixes some of Clang's scan-build warnings reported.
>
> v2:
>- Split patch two into two, i.e. put the actual fix in a separate patch.
>- Updated commit messages.
>
> Eelco Chaudron (5):
> general: Fix Clan
On Mon, Oct 30, 2023 at 10:02:59AM +0100, jm...@redhat.com wrote:
> From: Jakob Meng
>
> The unixctl implementation in Python has been split into three parts in
> the past. During this process the UnixctlClient was duplicated, in
> python/ovs/unixctl/client.py and python/ovs/unixctl/server.py. Th
On 31/10/2023 15:17, Simon Horman wrote:
On Mon, Oct 23, 2023 at 10:41:12AM +0100, Kevin Traynor wrote:
Add group for dpdkvhostuser(/client) netdev.
Adding as a single group as they display the same status,
one of which is 'mode' to indicate if it's client or server.
Fixes: b2e8b12f8a82 ("netd
On 10/31/23 16:21, Simon Horman wrote:
> On Mon, Oct 23, 2023 at 04:21:53PM +0200, Eelco Chaudron wrote:
>> This series fixes some of Clang's scan-build warnings reported.
>>
>> v2:
>>- Split patch two into two, i.e. put the actual fix in a separate patch.
>>- Updated commit messages.
>>
>>
On Tue, Oct 31, 2023 at 10:29:47AM -0400, Mike Pattrick wrote:
> On Mon, Oct 30, 2023 at 7:43 AM Simon Horman wrote:
> >
> > On Mon, Oct 30, 2023 at 02:58:36AM -0400, Mike Pattrick wrote:
> > > Currently when userspace-tso is enabled, netdev-linux interfaces will
> > > indicate support for all off
OVS actually supports way more. Detect the real number of groups and
meters instead. To avoid preallocating huge bitmaps for the IDs,
switch to id-pool instead (as suggested by Ilya).
Reported-at: https://issues.redhat.com/browse/FDP-70
Suggested-by: Ilya Maximets
Signed-off-by: Dumitru Ceara
A
On 10/31/23 15:11, Ilya Maximets wrote:
> On 10/26/23 13:37, Dumitru Ceara wrote:
>> OVS actually supports way more. Detect the real number of groups and
>> meters instead. To avoid preallocating huge bitmaps for the IDs,
>> switch to id-pool instead (as suggested by Ilya).
>>
>> Reported-at: http
E721: "do not compare types, for exact checks use `is` / `is not`, for
instance checks use `isinstance()`"
This fixes `make flake8-check` target when running with
pycodestyle>=1.2.
Signed-off-by: Ihar Hrachyshka
---
python/ovs/jsonrpc.py | 2 +-
tests/test-jsonrpc.py | 4 ++--
tests/test-ovsd
Bleep bloop. Greetings Ihar Hrachyshka, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: The subject summary should start with a capital.
Subject: flake8: fix E721 check fa
This is the standard clang JSON Compilation Database file name, as
documented in:
https://clang.llvm.org/docs/JSONCompilationDatabase.html#build-system-integration
FYI the file is used by Language Server Protocol implementations and
other AST tools.
Signed-off-by: Ihar Hrachyshka
---
.gitignor
This is the standard clang JSON Compilation Database file name, as
documented in:
https://clang.llvm.org/docs/JSONCompilationDatabase.html#build-system-integration
FYI the file is used by Language Server Protocol implementations and
other AST tools.
Signed-off-by: Ihar Hrachyshka
---
.gitignor
On 10/31/23 17:05, Kevin Traynor wrote:
> On 31/10/2023 15:17, Simon Horman wrote:
>> On Mon, Oct 23, 2023 at 10:41:12AM +0100, Kevin Traynor wrote:
>>> Add group for dpdkvhostuser(/client) netdev.
>>>
>>> Adding as a single group as they display the same status,
>>> one of which is 'mode' to indic
+1 for the series.
Reviewed-By: Ihar Hrachyshka
On Mon, Oct 30, 2023 at 4:10 PM Ilya Maximets wrote:
> The main goal of this patch set is to enable builds without warnings
> on systems with Python 3.12. Python 3.12 turned having invalid escape
> sequences into a SyntaxWarning. In the future
On 10/27/23 23:16, Stéphane Graber via dev wrote:
> Hello,
>
> I'm currently working on re-enabling our daily OVN tests in Incus (the
> LXD fork).
>
> Unfortunately I'm not having much luck getting our testsuite to go all
> the way through as it's triggering kernel panics.
>
> Here is the stack
From: Flavio Leitner
Currently OVS will calculate the segment size based on the
MTU of the egress port. That usually happens to be correct
when the ports share the same MTU, but that is not always true.
Therefore, if the segment size is provided, then use that and
make sure the over sized packet
Currently when userspace-tso is enabled, netdev-linux interfaces will
indicate support for all offload flags regardless of interface
configuration. This patch checks for which offload features are enabled
during netdev construction.
Signed-off-by: Mike Pattrick
--
v6:
- Removed legacy comment
From: Flavio Leitner
This provides a software implementation in the case
the egress netdev doesn't support segmentation in hardware.
The challenge here is to guarantee packet ordering in the
original batch that may be full of TSO packets. Each TSO
packet can go up to ~64kB, so with segment size
34 matches
Mail list logo
