Re: [ovs-dev] [PATCH 2/2] checkpatch: Fix personal word list storage.

2023-11-08 Thread Roi Dayan via dev
On 08/11/2023 20:50, Aaron Conole wrote: > Eelco Chaudron writes: > >> On 2 Nov 2023, at 14:20, Roi Dayan via dev wrote: >> >>> From: Gaetan Rivet >>> >>> The enchant dictionary synchronizes additions to the source file. >>> Keep the two word source separate by adding the extra words only

Re: [ovs-dev] [PATCH 1/2] checkpatch.py: Load personal words list.

2023-11-08 Thread Aaron Conole
Roi Dayan via dev writes: > On 02/11/2023 16:11, Eelco Chaudron wrote: >> >> On 2 Nov 2023, at 14:20, Roi Dayan via dev wrote: >> >>> Add personal words list as spellcheck.txt and load it >>> into enchant spell checker. This file is generated from >>> codespell dictionary.txt and contains

Re: [ovs-dev] [PATCH 2/2] checkpatch: Fix personal word list storage.

2023-11-08 Thread Aaron Conole
Eelco Chaudron writes: > On 2 Nov 2023, at 14:20, Roi Dayan via dev wrote: > >> From: Gaetan Rivet >> >> The enchant dictionary synchronizes additions to the source file. >> Keep the two word source separate by adding the extra words only >> to the current session. >> >> Signed-off-by: Gaetan

Re: [ovs-dev] [PATCH ovn 2/2] pinctrl: reset success and failures n_count regardless of svc state

2023-11-08 Thread Mark Michelson
Thank you for the detailed explanation. It makes perfect sense to me. Acked-by: Mark Michelson On 11/7/23 09:39, Evgenii Kovalev wrote: This patch adds reset n_count regardless of svc state and does only if n_count >= configured_count. The behavior hc with windows server as backend in load

Re: [ovs-dev] [PATCH ovn 1/2] pinctrl: send RST instead of RST_ACK bit for lb hc

2023-11-08 Thread Mark Michelson
Thank you for the submission Evgenii, Acked-by: Mark Michelson I have one minor nit below. Whoever merges this change can correct it. On 11/7/23 09:39, Evgenii Kovalev wrote: Currently an ovn-controller send RST_ACK after receive SYN_ACK in load balancer health check, but for a windows as

Re: [ovs-dev] [PATCH] netdev-offload-tc: Fix offload of tunnel key tp_src.

2023-11-08 Thread Vladislav Odintsov
Hi Ilya, Eelco, I’ve tried this patch against 3.1 and latest master branch. There are no warnings anymore, but it seems that in my installation it has broken offload capability. In tcpdump I see packets, which I expect to be offloaded, so not to appear in tcpdump output, also there is an empty

Re: [ovs-dev] [PATCH ovn] controller: disable OpenFlow inactivity probing

2023-11-08 Thread Vladislav Odintsov
Thanks Numan! > On 2 Nov 2023, at 23:44, Numan Siddique wrote: > > On Fri, Sep 22, 2023 at 2:40 PM Han Zhou > wrote: >> >> On Mon, Sep 11, 2023 at 7:31 AM Vladislav Odintsov >> wrote: >>> >>> Hi Dumitru, >>> >>> if eventually this patch got merged, please remove next

[ovs-dev] [PATCH v2] reconnect: Set defaults from environment variables.

2023-11-08 Thread Felix Huettner via dev
this exposes the old constants regarding min backoff, max backoff and probe interval using environment variables. In case previously users wanted to tune the probe interval for all connections this required setting this setting in multiple locations. E.g. to configure the probe interval from a