Re: [ovs-dev] [PATCH ovn v2 06/18] northd: Add a new engine 'lr-lb-nat-data' to manage routers' lb data.

2023-11-23 Thread Dumitru Ceara
On 11/23/23 21:45, Dumitru Ceara wrote: > On 10/26/23 20:15, num...@ovn.org wrote: >> From: Numan Siddique >> >> This new engine now maintains the load balancer and NAT data of a >> logical router which was earlier part of northd engine node data. >> The main inputs to this engine are: >>-

Re: [ovs-dev] [PATCH ovn v2 08/18] northd: Don't commit dhcp response flows in the conntrack.

2023-11-23 Thread Dumitru Ceara
On 11/15/23 07:45, Han Zhou wrote: > On Thu, Oct 26, 2023 at 11:16 AM wrote: >> >> From: Numan Siddique >> >> This is not required. >> > Thanks Numan for the fix. Could you provide a little more detail why this > is not required: > - Is it a bug fix? What's the impact? > - Shall we update the

Re: [ovs-dev] [PATCH ovn v2 07/18] northd: Generate logical router's LB and NAT flows using lr_lbnat_data.

2023-11-23 Thread Dumitru Ceara
On 10/26/23 20:15, num...@ovn.org wrote: > From: Numan Siddique > > Previous commits added new engine nodes to store logical router's lb > and NAT data. Make use of the data stored by these engine nodes > to generate logical flows related to router's LBs and NATs. > > Signed-off-by: Numan

Re: [ovs-dev] [PATCH ovn v2 06/18] northd: Add a new engine 'lr-lb-nat-data' to manage routers' lb data.

2023-11-23 Thread Dumitru Ceara
On 10/26/23 20:15, num...@ovn.org wrote: > From: Numan Siddique > > This new engine now maintains the load balancer and NAT data of a > logical router which was earlier part of northd engine node data. > The main inputs to this engine are: >- northd node >- lr-nat node > > A record for

Re: [ovs-dev] [PATCH ovn] pinctrl: Fix up comments about sending RST packets for healthcheck.

2023-11-23 Thread Ales Musil
On Mon, Nov 20, 2023 at 8:45 PM Dumitru Ceara wrote: > We're sending TCP RST not RST-ACK as the comment suggests. > > Reported-at: > https://mail.openvswitch.org/pipermail/ovs-dev/2023-November/409288.html > Reported-by: Mark Michelson > Fixes: a35725a7a24b ("pinctrl: send RST instead of

Re: [ovs-dev] [PATCH ovn v2 05/18] northd: Add a new engine 'lr-nat' to manage lr NAT data.

2023-11-23 Thread Dumitru Ceara
On 11/17/23 23:05, Numan Siddique wrote: > On Wed, Nov 15, 2023 at 1:27 AM Han Zhou wrote: >> >> On Thu, Oct 26, 2023 at 11:15 AM wrote: >>> >>> From: Numan Siddique >>> >>> This new engine now maintains the NAT related data for each >>> logical router which was earlier maintained by the northd

Re: [ovs-dev] [PATCH ovn v2 04/18] northd: Move router ports SB PB options sync to sync_to_sb_pb node.

2023-11-23 Thread Dumitru Ceara
On 10/26/23 20:14, num...@ovn.org wrote: > From: Numan Siddique > > It also moves the logical router port IPv6 prefix delegation > updates to "sync-from-sb" engine node. > > Signed-off-by: Numan Siddique > --- I think I agree in general with the patch; I'd like to see the new revision however

Re: [ovs-dev] [PATCH ovn v2 03/18] tests: Add a couple of tests in ovn-northd for I-P.

2023-11-23 Thread Dumitru Ceara
On 10/26/23 20:14, num...@ovn.org wrote: > From: Numan Siddique > > These tests cover scenarios for load balancers and NATs > and check for the 'northd' and 'lflow' engine node > recompute and compute stats. > > Signed-off-by: Numan Siddique > --- > tests/ovn-northd.at | 274

Re: [ovs-dev] [PATCH ovn v2 1/3] ci: Switch Cirrus CI to the Ubuntu image

2023-11-23 Thread Ales Musil
On Thu, Nov 23, 2023 at 11:11 AM Dumitru Ceara wrote: > On 11/22/23 14:28, Ales Musil wrote: > > Switch the Cirrus CI to use the Ubuntu image, > > so it is unified with the GH actions. That is > > useful for various dependency pinnings. > > > > Signed-off-by: Ales Musil > > --- > > Hi Ales,

Re: [ovs-dev] [PATCH ovn v2 2/3] ci: Build container image before very job

2023-11-23 Thread Ales Musil
On Thu, Nov 23, 2023 at 11:13 AM Dumitru Ceara wrote: > On 11/22/23 14:28, Ales Musil wrote: > > Build the image before every job to allow more > > fine-grained dependency pinning. This is especially > > useful for stable branches as they might need to stay > > on specific distribution or Python

Re: [ovs-dev] [PATCH ovn v2 3/3] ci: Cover more container posibilities

2023-11-23 Thread Ales Musil
On Thu, Nov 23, 2023 at 11:15 AM Dumitru Ceara wrote: > On 11/22/23 14:28, Ales Musil wrote: > > Add more conditions to the image prepare process. > > This allows us to test the prebuilt images for both > > Fedora and Ubuntu. > > > > Run the weekly image on main branch with the > > use of Fedora

[ovs-dev] [PATCH ovn v3 1/3] ci: Build container image before very job

2023-11-23 Thread Ales Musil
Build the image before every job to allow more fine-grained dependency pinning. This is especially useful for stable branches as they might need to stay on specific distribution or Python version. This also allows us to switch to Ubuntu instead of Fedora in the Cirrus CI for consistency reasons.

[ovs-dev] [PATCH ovn v3 3/3] Documentation: Add note about pinning the container after release

2023-11-23 Thread Ales Musil
Add note that one the patches after branching should pin the container to the current LTS version so the CI on that branch remains stable as long as possible. Signed-off-by: Ales Musil --- Documentation/internals/release-process.rst | 4 1 file changed, 4 insertions(+) diff --git

[ovs-dev] [PATCH ovn v3 2/3] ci: Cover more container posibilities

2023-11-23 Thread Ales Musil
Add more conditions to the image prepare process. This allows us to test the prebuilt images for both Fedora and Ubuntu. Run the weekly image on main branch with the use of Fedora for the weekly runs. Reported-at: https://issues.redhat.com/browse/FDP-149 Signed-off-by: Ales Musil --- v3: Add

[ovs-dev] [PATCH ovn v3 0/3] Allow to use different container images per branch

2023-11-23 Thread Ales Musil
This series allows different branches to use different images. This is needed for stability reasons as it is hard to keep up with new Ubuntu/Fedora releases for all stable branches. We will still use the prebuilt images for main branch which is completely fine. Ales Musil (3): ci: Build

[ovs-dev] [PATCH branch-3.2] dpdk: Use DPDK 22.11.3 release for OVS 3.2.

2023-11-23 Thread Kevin Traynor
Update the CI and docs to use DPDK 22.11.3. Signed-off-by: Kevin Traynor --- .github/workflows/build-and-test.yml | 2 +- Documentation/faq/releases.rst | 8 Documentation/intro/install/dpdk.rst | 8 NEWS | 3 +++ 4 files changed, 12

[ovs-dev] [PATCH branch-3.1] dpdk: Use DPDK 22.11.3 release for OVS 3.1.

2023-11-23 Thread Kevin Traynor
Update the CI and docs to use DPDK 22.11.3. Signed-off-by: Kevin Traynor --- .github/workflows/build-and-test.yml | 2 +- Documentation/faq/releases.rst | 6 +++--- Documentation/intro/install/dpdk.rst | 8 NEWS | 3 +++ 4 files changed, 11

[ovs-dev] [PATCH branch-3.0] dpdk: Use DPDK 21.11.5 release for OVS 3.0.

2023-11-23 Thread Kevin Traynor
Update the CI and docs to use DPDK 21.11.5. Signed-off-by: Kevin Traynor --- .ci/linux-build.sh | 2 +- Documentation/faq/releases.rst | 4 ++-- Documentation/intro/install/dpdk.rst | 8 NEWS | 3 +++ 4 files changed, 10

[ovs-dev] [PATCH branch-2.17] dpdk: Use DPDK 21.11.5 release for OVS 2.17.

2023-11-23 Thread Kevin Traynor
Update the CI and docs to use DPDK 21.11.5. Signed-off-by: Kevin Traynor --- .ci/linux-build.sh | 2 +- Documentation/faq/releases.rst | 2 +- Documentation/intro/install/dpdk.rst | 8 NEWS | 3 +++ 4 files changed, 9

Re: [ovs-dev] [PATCH ovn v2 02/18] northd: Track ovn_datapaths in northd engine track data.

2023-11-23 Thread Dumitru Ceara
On 11/15/23 06:30, Han Zhou wrote: > On Thu, Oct 26, 2023 at 11:14 AM wrote: >> >> From: Numan Siddique >> >> northd engine tracked data now also stores the logical switches >> and logical routers that got updated due to the changed load balancers. >> >> Eg 1. For this command 'ovn-nbctl

Re: [ovs-dev] [PATCH ovn v2 01/18] northd: Refactor the northd change tracking.

2023-11-23 Thread Dumitru Ceara
On 11/15/23 19:22, Numan Siddique wrote: > On Wed, Nov 15, 2023 at 12:12 AM Han Zhou wrote: >> >> On Thu, Oct 26, 2023 at 11:14 AM wrote: >>> >>> From: Numan Siddique >>> >>> northd engine tracking data now has the following tracking data >>> - changed ovn_ports (right now only changed

Re: [ovs-dev] [dpdk-latest 2/2] ci: Reduce optional libraries in DPDK.

2023-11-23 Thread Simon Horman
On Wed, Nov 22, 2023 at 01:16:12PM +0100, David Marchand wrote: > Since DPDK v23.11, it is possible to select more easily which optional > library is enabled. > > OVS needs the vhost library (and its dependencies). > The net/tap DPDK driver needs the gso library. > Other optional library can be

Re: [ovs-dev] [dpdk-latest 1/2] ci: Cache DPDK installed libraries only.

2023-11-23 Thread Simon Horman
On Wed, Nov 22, 2023 at 01:16:11PM +0100, David Marchand wrote: > Rather than save the whole DPDK sources and build artefacts, checkout > sources in a separate directory and build DPDK there. > Only the installed artefacts are then going to the cache. > Example sources in the share/dpdk installed

[ovs-dev] [PATCH 8/8] ci: Exclude tests that show random failures through GitHub actions.

2023-11-23 Thread Eelco Chaudron
I ran 80 series of full tests, and the following tests showed failures: 802.1ad - vlan_limit +2023-11-20T10:32:11.245Z|1|dpif_netdev(revalidator5)|ERR|internal error parsing flow key recirc_id(0),dp_hash(0),skb_priority(0),

[ovs-dev] [PATCH 7/8] ci: Add make check-afxdp to GitHub actions ci.

2023-11-23 Thread Eelco Chaudron
Signed-off-by: Eelco Chaudron --- .github/workflows/build-and-test.yml |4 1 file changed, 4 insertions(+) diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml index 7cbb8d956..92282edb4 100644 --- a/.github/workflows/build-and-test.yml +++

[ovs-dev] [PATCH 6/8] ci: Allow make check-dpdk to run more tests.

2023-11-23 Thread Eelco Chaudron
Install additional packages and drivers required by make check-dpdk. Signed-off-by: Eelco Chaudron --- .ci/dpdk-build.sh|2 +- .github/workflows/build-and-test.yml |2 +- python/test_requirements.txt |1 + 3 files changed, 3 insertions(+), 2 deletions(-)

[ovs-dev] [PATCH 5/8] ci: Add make check-system-tso to GitHub actions ci.

2023-11-23 Thread Eelco Chaudron
Signed-off-by: Eelco Chaudron --- .github/workflows/build-and-test.yml |4 1 file changed, 4 insertions(+) diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml index db0a1ac39..d74668f61 100644 --- a/.github/workflows/build-and-test.yml +++

[ovs-dev] [PATCH 4/8] ci: Add make check-system-userspace to GitHub actions ci.

2023-11-23 Thread Eelco Chaudron
Signed-off-by: Eelco Chaudron --- .github/workflows/build-and-test.yml |4 1 file changed, 4 insertions(+) diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml index 586b0cdd9..db0a1ac39 100644 --- a/.github/workflows/build-and-test.yml +++

[ovs-dev] [PATCH 3/8] ci: Add make check-offloads to GitHub actions ci.

2023-11-23 Thread Eelco Chaudron
This patch also adds the 'CHECK_GITHUB_ACTION' macro to skip tests that won't execute successfully through GitHub actions. We could not use the -k !keyword option, as it can not be combined with a range of tests. Signed-off-by: Eelco Chaudron --- .ci/linux-build.sh |2 +-

[ovs-dev] [PATCH 2/8] ci: Add make check-kernel to GitHub actions ci.

2023-11-23 Thread Eelco Chaudron
Signed-off-by: Eelco Chaudron --- .ci/linux-build.sh |8 ++-- .github/workflows/build-and-test.yml | 15 --- python/test_requirements.txt |4 +++- 3 files changed, 21 insertions(+), 6 deletions(-) diff --git a/.ci/linux-build.sh

[ovs-dev] [PATCH 1/8] ci: Add make check-ovsdb-cluster tests to GitHub action ci.

2023-11-23 Thread Eelco Chaudron
Signed-off-by: Eelco Chaudron --- .ci/linux-build.sh |9 + .github/workflows/build-and-test.yml |3 +++ 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh index aa2ecc505..e9e1e24b5 100755 ---

[ovs-dev] [PATCH 0/8] ci: Add remaining check tests to GitHub actions.

2023-11-23 Thread Eelco Chaudron
This set of patches incorporates the remaining make check tests into the GitHub action run. Notably, this inclusion does not appear to extend the overall run time, as the newly added tests complete prior to the existing ones. Eelco Chaudron (8): ci: Add make check-ovsdb-cluster tests to

Re: [ovs-dev] [PATCH ovn v2 3/3] ci: Cover more container posibilities

2023-11-23 Thread Dumitru Ceara
On 11/22/23 14:28, Ales Musil wrote: > Add more conditions to the image prepare process. > This allows us to test the prebuilt images for both > Fedora and Ubuntu. > > Run the weekly image on main branch with the > use of Fedora for the weekly runs. > > Reported-at:

Re: [ovs-dev] [PATCH ovn v2 2/3] ci: Build container image before very job

2023-11-23 Thread Dumitru Ceara
On 11/22/23 14:28, Ales Musil wrote: > Build the image before every job to allow more > fine-grained dependency pinning. This is especially > useful for stable branches as they might need to stay > on specific distribution or Python version. > > Signed-off-by: Ales Musil > --- > .cirrus.yml

Re: [ovs-dev] [PATCH ovn v2 1/3] ci: Switch Cirrus CI to the Ubuntu image

2023-11-23 Thread Dumitru Ceara
On 11/22/23 14:28, Ales Musil wrote: > Switch the Cirrus CI to use the Ubuntu image, > so it is unified with the GH actions. That is > useful for various dependency pinnings. > > Signed-off-by: Ales Musil > --- Hi Ales, I think I'd just remove this patch. We don't use the container image in