Re: [ovs-dev] [PATCH OVN 2/2] tests: Move SCTP test from kernel only to general OVN system tests.

2023-12-04 Thread Eelco Chaudron
On 4 Dec 2023, at 19:57, Mark Michelson wrote: > Thanks for the updates, Eelco. What is the minimum OVS version required for > the SCTP load balancer test to pass when using the userspace datapath? This > will help me to backport this series to the proper OVN branches. Hi Mark, It’s in 3.2 a

[ovs-dev] [PATCH ovn v3] northd: forward arp request to lrp snat on.

2023-12-04 Thread Daniel Ding
If the router has a snat rule and it's external ip isn't lrp address, when the arp request from other router for this external ip, will be drop, because of this external ip use same mac address as lrp, so can not forward to MC_FLOOD. Fixes: 32f5ebb06226 ("ovn-northd: Limit ARP/ND broadcast domain

Re: [ovs-dev] [PATCH ovn] northd: forward arp request to lrp snat on.

2023-12-04 Thread Daniel Ding
On Fri, 10 Nov 2023 at 22:51, Dumitru Ceara wrote: > On 10/24/23 09:39, Daniel Ding wrote: > > If the router has a snat rule and it's external ip isn't lrp address, > > when the arp request from other router for this external ip, will > > be drop, because of this external ip use same mac address

[ovs-dev] [PATCH ovn] system-test: Fix tcpdump usage in LB template tests.

2023-12-04 Thread Dumitru Ceara
Make sure the capture is up before continuing the test. A similar fix was committed earlier via 6c4ffe5f111f ("system-test: Use OVS_WAIT_UNTIL for tcpdump start instead fo sleep") but other tests were added in the meantime. Suggested-by: Xavier Simonart Fixes: 086744a645a7 ("northd: Use LB port_s

Re: [ovs-dev] [PATCH ovn v2 0/4] misc fmt_pkt improvements

2023-12-04 Thread Mark Michelson
I merged this series to main and all branches back to 22.03. On 11/28/23 12:43, Ihar Hrachyshka wrote: This series, combined with ovs series [1], will allow to execute fmt_pkt in parallel. This will allow to revert back to parallel execution of test_ip in a test conversion patch from Mark [2], a

Re: [ovs-dev] [PATCH ovn 3/3] perf-northd.at: Add ovn-northd recompute statistics.

2023-12-04 Thread Mark Michelson
Thanks, Dumitru. Acked-by: Mark Michelson On 11/24/23 10:20, Dumitru Ceara wrote: Trigger a full recompute after each DB build run and record the results. Signed-off-by: Dumitru Ceara --- tests/perf-northd.at | 29 - 1 file changed, 20 insertions(+), 9 deleti

Re: [ovs-dev] [PATCH ovn 2/3] perf-northd.at: Parse and display more stopwatch data.

2023-12-04 Thread Mark Michelson
Thanks Dumitru, Acked-by: Mark Michelson On 11/24/23 10:20, Dumitru Ceara wrote: Signed-off-by: Dumitru Ceara --- tests/perf-northd.at |6 ++ 1 file changed, 6 insertions(+) diff --git a/tests/perf-northd.at b/tests/perf-northd.at index eb579bf19b..16f1bcf453 100644 --- a/tests/pe

Re: [ovs-dev] [PATCH ovn 1/3] perf-northd.at: Don't start ovn-controllers.

2023-12-04 Thread Mark Michelson
Thanks Dumitru, Acked-by: Mark Michelson On 11/24/23 10:20, Dumitru Ceara wrote: The goal is to test northd performance so there's no point to start hypervisors. Signed-off-by: Dumitru Ceara --- tests/perf-northd.at |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [ovs-dev] [PATCH OVN 2/2] tests: Move SCTP test from kernel only to general OVN system tests.

2023-12-04 Thread Mark Michelson
Thanks for the updates, Eelco. What is the minimum OVS version required for the SCTP load balancer test to pass when using the userspace datapath? This will help me to backport this series to the proper OVN branches. On 11/30/23 09:18, Eelco Chaudron wrote: This patch moves the SCTP test from

Re: [ovs-dev] [PATCH v2] ofp-ct: Return error for unknown property in CT flush.

2023-12-04 Thread Aaron Conole
Ales Musil writes: > CT flush extension would silently ignore unknown properties, > which could lead to potential surprise by deleting more than > it was requested to. Return error on unknown property instead > to avoid this problem and at the same time inform the user > that the specified proper

Re: [ovs-dev] [PATCH 1/2] ofp-ct: Return error for unknown property in CT flush.

2023-12-04 Thread Aaron Conole
Ales Musil writes: > CT flush extension would silently ignore unknown properties, > which could lead to potential surprise by deleting more than > it was requested to. Return error on unknown property instead > to avoid this problem and at the same time inform the user > that the specified proper

Re: [ovs-dev] [PATCH v2] netdev-offload-tc: Fix offload of tunnel key tp_src.

2023-12-04 Thread Vladislav Odintsov
Thanks Ilya for the clarification. I didn’t know about check_logs logic. Tested-by: Vladislav Odintsov > On 4 Dec 2023, at 15:59, Ilya Maximets wrote: > > On 12/2/23 16:16, Vladislav Odintsov wrote: >> Hi Ilya, thanks for the added test! >> >> I’ve got one question about it, psb. >> >>> On 2

Re: [ovs-dev] [PATCH] tunnel: Do not carry source port from a previous tunnel.

2023-12-04 Thread Eelco Chaudron
On 1 Dec 2023, at 22:04, Ilya Maximets wrote: > If a packet is received from a UDP tunnel, it has a source port > populated in the tunnel metadata. This field cannot be read or > changed with OpenFlow or the tunnel configuration. However, while > sending this packet to a different tunnel, the

Re: [ovs-dev] [PATCH v10 3/4] netdev-dpdk: Add support for egress packet-per-second policing.

2023-12-04 Thread miter
Hi Eelco, On 12/4/2023 5:01 PM, Eelco Chaudron wrote: On 3 Dec 2023, at 15:19, miter wrote: Hi Eelco, Some comments below. On 9/19/2023 10:58 PM, Eelco Chaudron wrote: On 26 Aug 2023, at 8:01, mit...@outlook.com wrote: From: Lin Huang OvS has supported packet-per-second policer which

Re: [ovs-dev] [PATCH ovn v2] controller: fix group_table and meter_table allocation

2023-12-04 Thread Dumitru Ceara
On 12/1/23 17:25, Xavier Simonart wrote: > Hi Dumitru > > Thanks for the detailed review. > All comments make sense to me. Thanks for checking, Xavier! I squashed the changes in and applied the patch to main and backported it to all stable branches down to 22.03. Regards, Dumitru > Thanks > Xa

[ovs-dev] HWOL with Nvidia ConnectX-6 Dx v2: OVN NAT functionality

2023-12-04 Thread Vladislav Odintsov
Hi! I’m starting this thread as continuation after its first version, which was about OVN Interconnection usecase [0] ;) Tests are performed with OVN 22.09.x and latest OVS master branch with applied [1] and [2] patches. OVS configuration: ┌───┐ │ O

Re: [ovs-dev] [PATCH v3] editorconfig: Remove [*] section and trim_trailing_whitespace.

2023-12-04 Thread Aaron Conole
jm...@redhat.com writes: > From: Jakob Meng > > Wildcard sections [*] and [**] are unsafe because properties cannot be > applied safely to any filetype in general. For example, IDEs like > Visual Studio Code and KDevelop store configuration files in subfolders > like .vscode or .kdev4. Properties

Re: [ovs-dev] [PATCH v9 3/3] userspace: Add Generic Segmentation Offloading.

2023-12-04 Thread Mike Pattrick
On Fri, Dec 1, 2023 at 7:39 PM Ilya Maximets wrote: > > On 11/22/23 11:16, Simon Horman wrote: > > On Tue, Nov 21, 2023 at 02:26:52PM -0500, Mike Pattrick wrote: > >> From: Flavio Leitner > >> > >> This provides a software implementation in the case > >> the egress netdev doesn't support segmenta

Re: [ovs-dev] [PATCH v2] netdev-offload-tc: Fix offload of tunnel key tp_src.

2023-12-04 Thread Marcelo Leitner
On Mon, Dec 04, 2023 at 01:57:50PM +0100, Ilya Maximets wrote: > On 12/4/23 13:40, Marcelo Leitner wrote: > > On Sat, Dec 02, 2023 at 12:06:59AM +0100, Ilya Maximets wrote: > > ... > >> Adding a test case that demonstrates a scenario where the issue > >> occurs - bridging of two tunnels. > > > > I

Re: [ovs-dev] [PATCH v2] netdev-offload-tc: Fix offload of tunnel key tp_src.

2023-12-04 Thread Ilya Maximets
On 12/2/23 16:16, Vladislav Odintsov wrote: > Hi Ilya, thanks for the added test! > > I’ve got one question about it, psb. > >> On 2 Dec 2023, at 02:06, Ilya Maximets wrote: >> >> There is no TCA_TUNNEL_KEY_ENC_SRC_PORT in the kernel, so the offload >> should not be attempted if OVS_TUNNEL_KEY_A

Re: [ovs-dev] [PATCH v2] netdev-offload-tc: Fix offload of tunnel key tp_src.

2023-12-04 Thread Ilya Maximets
On 12/4/23 13:40, Marcelo Leitner wrote: > On Sat, Dec 02, 2023 at 12:06:59AM +0100, Ilya Maximets wrote: > ... >> Adding a test case that demonstrates a scenario where the issue >> occurs - bridging of two tunnels. > > I get the fix and it LGTM. What I don't get is the test case. > Considering th

Re: [ovs-dev] [PATCH v2] netdev-offload-tc: Fix offload of tunnel key tp_src.

2023-12-04 Thread Marcelo Leitner
On Sat, Dec 02, 2023 at 12:06:59AM +0100, Ilya Maximets wrote: ... > Adding a test case that demonstrates a scenario where the issue > occurs - bridging of two tunnels. I get the fix and it LGTM. What I don't get is the test case. Considering that the attr was getting simply ignored, wouldn't the

[ovs-dev] [PATCH v4] reconnect: Set defaults from environment variables.

2023-12-04 Thread Felix Huettner via dev
This exposes the old constants regarding min backoff, max backoff and probe interval using environment variables. In case previously users wanted to tune the probe interval for all connections this required setting this setting in multiple locations. E.g. to configure the probe interval from a rela

Re: [ovs-dev] [PATCH v3] reconnect: Set defaults from environment variables.

2023-12-04 Thread 0-day Robot
Bleep bloop. Greetings Felix Huettner, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: Failed to merge in the changes. hint: Use 'git am --show-current-patch=diff' to see the fa

Re: [ovs-dev] [PATCH v2] reconnect: Set defaults from environment variables.

2023-12-04 Thread Felix Huettner via dev
Hi Eelco, thanks for the feedback. I updated it and send a v3. On Fri, Dec 01, 2023 at 10:38:16AM +0100, Eelco Chaudron wrote: > > > On 8 Nov 2023, at 11:07, Felix Huettner via dev wrote: > > > this exposes the old constants regarding min backoff, max backoff and > > This > sorry, i missed that

[ovs-dev] [PATCH v3] reconnect: Set defaults from environment variables.

2023-12-04 Thread Felix Huettner via dev
this exposes the old constants regarding min backoff, max backoff and probe interval using environment variables. In case previously users wanted to tune the probe interval for all connections this required setting this setting in multiple locations. E.g. to configure the probe interval from a rela

Re: [ovs-dev] [PATCH v2] netdev-offload-tc: Fix offload of tunnel key tp_src.

2023-12-04 Thread Eelco Chaudron
On 2 Dec 2023, at 0:06, Ilya Maximets wrote: > There is no TCA_TUNNEL_KEY_ENC_SRC_PORT in the kernel, so the offload > should not be attempted if OVS_TUNNEL_KEY_ATTR_TP_SRC is requested > by OVS. Current code just ignores the attribute in the tunnel(set()) > action leading to a flow mismatch a

Re: [ovs-dev] [PATCH v10 1/4] token-bucket: Make token-bucket timestamp updated by caller.

2023-12-04 Thread Eelco Chaudron
On 3 Dec 2023, at 9:36, miter wrote: > Hi Eelco, > > Sorry for the late reply. > > A comments below. > > > On 9/19/2023 10:57 PM, Eelco Chaudron wrote: >> On 26 Aug 2023, at 8:01, mit...@outlook.com wrote: >> >>> From: Lin Huang >>> >>> Now, token-bucket 'last_fill' is updated by token_bucket_w

Re: [ovs-dev] [PATCH v10 3/4] netdev-dpdk: Add support for egress packet-per-second policing.

2023-12-04 Thread Eelco Chaudron
On 3 Dec 2023, at 15:19, miter wrote: > Hi Eelco, > > > Some comments below. > > > On 9/19/2023 10:58 PM, Eelco Chaudron wrote: >> On 26 Aug 2023, at 8:01, mit...@outlook.com wrote: >> >>> From: Lin Huang >>> >>> OvS has supported packet-per-second policer which can be set at ingress >>> and eg

Re: [ovs-dev] [RFC PATCH 00/10] Add flow visualization utility

2023-12-04 Thread Adrian Moreno
On 12/1/23 20:14, Adrian Moreno wrote: This series introduces a python utility called ovs-flowviz. The goal of this utility is to read both datapath and Openflow flows (using the flow library already available) and print them in different formats and styles to make it easier to understand them