[ovs-dev] [PATCH] ci: Add clang-analyze to GitHub actions.

This patch detects new static analyze issues, and report them. It does this by reporting on the delta for this branch, compared to the base branch. For example the error might look like this: error level: +0 -0 no changes warning level: +2 +0 New issue "deadcode.DeadStores Value stored to

[ovs-dev] [PATCH v3] ci: Add clang-analyze to GitHub actions.

This patch detects new static analyze issues, and report them. It does this by reporting on the delta for this branch, compared to the base branch. For example the error might look like this: error level: +0 -0 no changes warning level: +2 +0 New issue "deadcode.DeadStores Value stored to

Re: [ovs-dev] [PATCH] ci: Add clang-analyze to GitHub actions.

On 7 Dec 2023, at 10:31, Eelco Chaudron wrote: > This patch detects new static analyze issues, and report them. > It does this by reporting on the delta for this branch, compared > to the base branch. > > For example the error might look like this: > > error level: +0 -0 no changes > warnin

Re: [ovs-dev] [PATCH v2] reconnect: Set defaults from environment variables.

On 4 Dec 2023, at 11:38, Felix Huettner wrote: > Hi Eelco, > > thanks for the feedback. I updated it and send a v3. > > On Fri, Dec 01, 2023 at 10:38:16AM +0100, Eelco Chaudron wrote: >> >> >> On 8 Nov 2023, at 11:07, Felix Huettner via dev wrote: >> >>> this exposes the old constants regarding

Re: [ovs-dev] [PATCH v2] system-dpdk: Wait for MTU changes to be applied.

On 1 Dec 2023, at 15:29, David Marchand wrote: > Because a DPDK backed netdev configuration is done in an asynchronous way, > and a MTU change requires a reconfiguration, directly checking > ovs-vswitchd logs or querying ovsdb for the interface current MTU value > is racy. > > Add synchronisati

Re: [ovs-dev] [PATCH v5] system-dpdk: Test with mlx5 devices.

On 1 Dec 2023, at 15:37, David Marchand wrote: > On Tue, Nov 28, 2023 at 9:40 AM David Marchand > wrote: >> >> On Wed, Nov 22, 2023 at 5:34 PM David Marchand >> wrote: >>> >>> The DPDK unit test only runs if vfio or igb_uio kernel modules are loaded: >>> on systems with only mlx5, this test is

Re: [ovs-dev] [PATCH ovn] system-test: Fix tcpdump usage in LB template tests.

On 5 Dec 2023, at 0:09, Dumitru Ceara wrote: > Make sure the capture is up before continuing the test. > A similar fix was committed earlier via 6c4ffe5f111f > ("system-test: Use OVS_WAIT_UNTIL for tcpdump start instead > fo sleep") but other tests were added in the meantime. > > Suggested-by:

Re: [ovs-dev] [PATCH ovn] northd: Skip transient IDL records.

On 12/6/23 22:29, Numan Siddique wrote: > On Wed, Dec 6, 2023 at 9:03 AM Dumitru Ceara wrote: >> >> When multiple OVSDB updates have been received since the last northd run >> it's possible that the IDL tracks changes for database entities that >> were added _and also_ removed from the last time t

Re: [ovs-dev] [PATCH OVN 1/2] tests: Remove 'protoinfo' from the conntrack entries for SCTP tests.

On 12/1/23 15:28, Simon Horman wrote: > On Thu, Nov 30, 2023 at 03:18:03PM +0100, Eelco Chaudron wrote: >> The userspace lacks the supplementary protocol state machine for SCTP, >> resulting in the absence of 'protoinfo' fields. Nevertheless, this SCTP >> test doesn't need this feature, making the

Re: [ovs-dev] [PATCH OVN 2/2] tests: Move SCTP test from kernel only to general OVN system tests.

On 12/5/23 08:52, Eelco Chaudron wrote: > > > On 4 Dec 2023, at 19:57, Mark Michelson wrote: > >> Thanks for the updates, Eelco. What is the minimum OVS version required for >> the SCTP load balancer test to pass when using the userspace datapath? This >> will help me to backport this series t

Re: [ovs-dev] [PATCH ovn 23.06] controller: make garp_max_timeout configurable

On 12/6/23 17:34, Lorenzo Bianconi wrote: > When using VLAN backed networks and OVN routers leveraging the > 'ovn-chassis-mac-mappings' option for east-west traffic, the eth.src field is > replaced by the chassis mac address in order to not expose the router mac > address from different nodes and c

Re: [ovs-dev] [PATCH ovn] pinctrl: Fix up comments about sending RST packets for healthcheck.

On 11/23/23 15:36, Ales Musil wrote: > > > On Mon, Nov 20, 2023 at 8:45 PM Dumitru Ceara > wrote: > > We're sending TCP RST not RST-ACK as the comment suggests. > > Reported-at: > https://mail.openvswitch.org/pipermail/ovs-dev/2023-November/409288.html >

Re: [ovs-dev] [PATCH ovn] system-tests: Consolidate wait condition in CoPP test

On 11/21/23 10:52, Ales Musil wrote: > Add missing wait condition and at the same time > move the wait to the last ovn-nbctl command > of the chain, as there is no need to wait > if there are more command afterward. > > Signed-off-by: Ales Musil > --- Thanks for the cleanup, Ales! I applied thi

Re: [ovs-dev] [PATCH ovn 0/3] Improve in-tree ovn-northd perf testing.

On 11/24/23 16:20, Dumitru Ceara wrote: > It might not be very known but the OVN code base actually has its > own integrated performance self tests for ovn-northd. > > These allow benchmarking northd performance for a couple of common > scenarios. > > In order to run them one needs to use the 'ma

[ovs-dev] [PATCH ovn] ovn-macros: Make sure stopped daemons continue before the test ends.

In case there's a test failure while daemons are stopped ensure that we send a SIGCONT on exit so that they properly clean up. 30952c248d4f ("binding: fixed ovn-installed not properly removed (recomputes)") Fixes: 0794a6edf40b ("qos: fix potential double deletion of ovs idl row") Fixes: feb9184341

Re: [ovs-dev] [PATCH ovn] system-test: Fix tcpdump usage in LB template tests.

On 12/7/23 13:18, Eelco Chaudron wrote: > > > On 5 Dec 2023, at 0:09, Dumitru Ceara wrote: > >> Make sure the capture is up before continuing the test. >> A similar fix was committed earlier via 6c4ffe5f111f >> ("system-test: Use OVS_WAIT_UNTIL for tcpdump start instead >> fo sleep") but other t

Re: [ovs-dev] [PATCH ovn v3] northd: forward arp request to lrp snat on.

On 12/6/23 02:56, Daniel Ding wrote: > Hi Dumitru! > > On Tue, 5 Dec 2023 at 23:59, Dumitru Ceara wrote: > >> On 12/5/23 13:58, Daniel Ding wrote: >>> >>> >>> On Tue, 5 Dec 2023 at 18:58, Dumitru Ceara >> > wrote: >>> >>> Hi Daniel, >>> >>> Thanks for this new r

Re: [ovs-dev] [PATCH v2] system-dpdk: Wait for MTU changes to be applied.

On 01/12/2023 14:29, David Marchand wrote: Because a DPDK backed netdev configuration is done in an asynchronous way, and a MTU change requires a reconfiguration, directly checking ovs-vswitchd logs or querying ovsdb for the interface current MTU value is racy. Add synchronisation points on the

Re: [ovs-dev] [PATCH ovn v3 1/3] ci: Build container image before very job

On 11/23/23 13:38, Ales Musil wrote: > Build the image before every job to allow more > fine-grained dependency pinning. This is especially > useful for stable branches as they might need to stay > on specific distribution or Python version. > > This also allows us to switch to Ubuntu instead > of

Re: [ovs-dev] [PATCH ovn v3 2/3] ci: Cover more container posibilities

On 11/23/23 13:38, Ales Musil wrote: > Add more conditions to the image prepare process. > This allows us to test the prebuilt images for both > Fedora and Ubuntu. > > Run the weekly image on main branch with the > use of Fedora for the weekly runs. > > Reported-at: https://issues.redhat.com/brow

Re: [ovs-dev] [PATCH ovn v3 3/3] Documentation: Add note about pinning the container after release

On 11/23/23 13:38, Ales Musil wrote: > Add note that one the patches after branching should > pin the container to the current LTS version so the > CI on that branch remains stable as long as possible. > > Signed-off-by: Ales Musil > --- > Documentation/internals/release-process.rst | 4 >

Re: [ovs-dev] [PATCH ovn] ovn-macros: Make sure stopped daemons continue before the test ends.

Hi Dumitru Thanks for the patch. On Thu, Dec 7, 2023 at 2:12 PM Dumitru Ceara wrote: > In case there's a test failure while daemons are stopped ensure that we > send a SIGCONT on exit so that they properly clean up. > > 30952c248d4f ("binding: fixed ovn-installed not properly removed > (recompu

[ovs-dev] [ovsrobot] Announcing recheck feature

Greetings, The ovsrobot has learned a new trick - it can now rerun the tests for a specific patch (provided the patch is still in a state to be accepted). Simply reply to the patch with a single comment: Recheck-request: github-robot or for OVN based projects, you can also run: Recheck-request