Re: [ovs-dev] [PATCH ovn] northd: fix missing port up when deleting and adding back an lsp

Hi Numan Thanks for the review and the comments On Thu, Dec 7, 2023 at 12:48 AM Numan Siddique wrote: > On Mon, Nov 20, 2023 at 7:09 AM Ales Musil wrote: > > > > On Thu, Nov 2, 2023 at 3:58 PM Xavier Simonart > wrote: > > > > > When a logical switch port was deleted and added back quickly, it

Re: [ovs-dev] [PATCH ovn] ovn-macros: Make sure stopped daemons continue before the test ends.

On 12/7/23 14:40, Xavier Simonart wrote: > Hi Dumitru > > Thanks for the patch. > > On Thu, Dec 7, 2023 at 2:12 PM Dumitru Ceara wrote: > >> In case there's a test failure while daemons are stopped ensure that we >> send a SIGCONT on exit so that they properly clean up. >> >> 30952c248d4f ("bin

Re: [ovs-dev] [PATCH ovn v2] controller: fixed potential segfault when changing tunnel_key and deleting ls

Hi Dumitru Thanks for the review and sorry for the delay. On Fri, Nov 10, 2023 at 4:30 PM Dumitru Ceara wrote: > On 11/3/23 10:38, Ales Musil wrote: > > On Mon, Oct 30, 2023 at 9:46 AM Xavier Simonart > wrote: > > > >> When a tunnel_key for a datapath was changed, the local_datapaths hmap > wa

Re: [ovs-dev] [PATCH ovn v2 05/18] northd: Add a new engine 'lr-nat' to manage lr NAT data.

On 12/6/23 04:03, Numan Siddique wrote: > On Thu, Nov 23, 2023 at 9:04 AM Dumitru Ceara wrote: >> >> On 11/17/23 23:05, Numan Siddique wrote: >>> On Wed, Nov 15, 2023 at 1:27 AM Han Zhou wrote: On Thu, Oct 26, 2023 at 11:15 AM wrote: > > From: Numan Siddique > > This n

Re: [ovs-dev] [PATCH ovn v2 07/18] northd: Generate logical router's LB and NAT flows using lr_lbnat_data.

On 12/6/23 04:38, Numan Siddique wrote: > On Thu, Nov 23, 2023 at 4:15 PM Dumitru Ceara wrote: >> >> On 10/26/23 20:15, num...@ovn.org wrote: >>> From: Numan Siddique >>> >>> Previous commits added new engine nodes to store logical router's lb >>> and NAT data. Make use of the data stored by the

[ovs-dev] [PATCH ovn v3] controller: fixed potential segfault when changing tunnel_key and deleting ls

When a tunnel_key for a datapath was changed, the local_datapaths hmap was not properly updated as the old/initial entry was not removed. - If the datapath was not deleted at the same time, a new entry (for the same dp) was created in the local_datapaths as the previous entry was not found (wro

Re: [ovs-dev] [PATCH v4 1/2] mcast-snooping: Store IGMP/MLD protocol version.

On Mon, Nov 20, 2023 at 08:52:00PM +0200, Mohammad Heib wrote: > On Mon, Nov 20, 2023 at 6:09 PM Simon Horman wrote: > > > On Mon, Nov 20, 2023 at 04:22:44PM +0200, Mohammad Heib wrote: > > > Store the igmp/mld protocol version into the > > > mcast_group internally. > > > > > > This can be used b

Re: [ovs-dev] [PATCH ovn v3] northd: forward arp request to lrp snat on.

On Thu, 7 Dec 2023 at 21:26, Dumitru Ceara wrote: > On 12/6/23 02:56, Daniel Ding wrote: > > Hi Dumitru! > > > > On Tue, 5 Dec 2023 at 23:59, Dumitru Ceara wrote: > > > >> On 12/5/23 13:58, Daniel Ding wrote: > >>> > >>> > >>> On Tue, 5 Dec 2023 at 18:58, Dumitru Ceara >>>

Re: [ovs-dev] [PATCH ovn v3] northd: forward arp request to lrp snat on.

On 12/8/23 14:51, Daniel Ding wrote: > On Thu, 7 Dec 2023 at 21:26, Dumitru Ceara wrote: > >> On 12/6/23 02:56, Daniel Ding wrote: >>> Hi Dumitru! >>> >>> On Tue, 5 Dec 2023 at 23:59, Dumitru Ceara wrote: >>> On 12/5/23 13:58, Daniel Ding wrote: > > > On Tue, 5 Dec 2023 at 18:58

Re: [ovs-dev] [PATCH ovn v3 08/16] northd: Refactor lflow management into a separate module.

On 11/28/23 03:36, num...@ovn.org wrote: > From: Numan Siddique > > ovn_lflow_add() and other related functions/macros are now moved > into a separate module - lflow-mgr.c. This module maintains a > table 'struct lflow_table' for the logical flows. lflow table > maintains a hmap to store the lo

[ovs-dev] [PATCH ovn v4] northd: forward arp request to lrp snat on.

If the router has a snat rule and it's external ip isn't lrp address, when the arp request from other router for this external ip, will be drop, because of this external ip use same mac address as lrp, so can not forward to MC_FLOOD. Fixes: 32f5ebb06226 ("ovn-northd: Limit ARP/ND broadcast domain