[ovs-dev] [PATCH v1 2/2] ovsdb-idl: Add check for weak_ref deleting.

2023-12-11 Thread Mike Pattrick
From: Dumitru Ceara Add a check for inserting and then deleting rows referenced by weak references by the same idl client. Verify that insertion and deletion events are recorded. Reported-at: https://issues.redhat.com/browse/FDP-193 Signed-off-by: Dumitru Ceara Co-authored-by: Mike Pattrick Si

[ovs-dev] [PATCH v1 1/2] ovsdb-idl: Preserve change_seqno when deleting rows.

2023-12-11 Thread Mike Pattrick
In the case of a weak reference, clearing all change_seqno's can delete useful information. Instead of clearing all seqno's when removing track_node, only clear those values in cases including row insertion, and row deleting if no dst_arcs remain. Fixes: 95689f166818 ("ovsdb-idl: Preserve referenc

Re: [ovs-dev] [PATCH ovn] northd: fix missing port up when deleting and adding back an lsp

2023-12-11 Thread Numan Siddique
On Fri, Dec 8, 2023 at 5:21 AM Xavier Simonart wrote: > > Hi Numan > > Thanks for the review and the comments > > On Thu, Dec 7, 2023 at 12:48 AM Numan Siddique wrote: > > > On Mon, Nov 20, 2023 at 7:09 AM Ales Musil wrote: > > > > > > On Thu, Nov 2, 2023 at 3:58 PM Xavier Simonart > > wrote: >

Re: [ovs-dev] [External] : OVS+OVN Fall Conference 2023 - Day 2 information

2023-12-11 Thread Michael Santana
Hi Brendan, You can check out the ovscon site https://www.openvswitch.org/support/ovscon2023/ We have not yet made the videos available, but once we do they will be published on that site. So please check it regularly. We will also send out an email when we have pushed the videos Thanks! On Mon

[ovs-dev] [PATCH v2 2/2] netdev-dummy: Add support and test for tso.

2023-12-11 Thread Mike Pattrick
Test that netdev-dummy is able to send and recieve segment offloaded packets. Signed-off-by: Mike Pattrick --- v2: Fix clang build error: mutex needed to access netdev_dummy members Signed-off-by: Mike Pattrick --- lib/netdev-dummy.c | 32 +++- tests/dpif-netdev.at |

[ovs-dev] [PATCH v2 1/2] ofproto-dpif-upcall: Resolve checksums before controller upcall.

2023-12-11 Thread Mike Pattrick
Currently dp_netdev_upcall() resolves checksums on all packets, but this isn't strictly needed. The checksums will be resolved before transmission. However, we do have to resolve the checksums before sending a packet to the controller as offload flags aren't retained. Signed-off-by: Mike Pattrick

Re: [ovs-dev] [External] : OVS+OVN Fall Conference 2023 - Day 2 information

2023-12-11 Thread Brendan Doyle
Hi, I missed this, where can I access the recordings? On 06/12/2023 17:36, Aaron Conole wrote: Greetings, We had an open bridge today during the call that got flooded with spam bots for a few minutes, and we had to lock the meeting down. As such, we won't broadly publish the meeting link. I

[ovs-dev] [PATCH v1 2/2] netdev-dummy: Add support and test for tso.

2023-12-11 Thread Mike Pattrick
Test that netdev-dummy is able to send and recieve segment offloaded packets. Signed-off-by: Mike Pattrick --- lib/netdev-dummy.c | 28 - tests/dpif-netdev.at | 50 2 files changed, 77 insertions(+), 1 deletion(-) diff --git

[ovs-dev] [PATCH v1 1/2] ofproto-dpif-upcall: Resolve checksums before controller upcall.

2023-12-11 Thread Mike Pattrick
Currently dp_netdev_upcall() resolves checksums on all packets, but this isn't strictly needed. The checksums will be resolved before transmission. However, we do have to resolve the checksums before sending a packet to the controller as offload flags aren't retained. Signed-off-by: Mike Pattrick

Re: [ovs-dev] [PATCH v5 3/3] system-traffic.at: Test conntrack + FTP server running on a non-standard port.

2023-12-11 Thread 0-day Robot
Bleep bloop. Greetings Viacheslav Galaktionov, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: The subject, ': ', is over 70 characters, i.e., 78. Subject: system-traffic.

[ovs-dev] [PATCH v5 1/3] lib/conntrack: Only use given packet in protocol detection.

2023-12-11 Thread Viacheslav Galaktionov via dev
The current protocol detection logic relies on two pieces of metadata passed as arguments: tp_src and tp_dst, which represent the L4 source and destination port numbers from the flow that triggered the current flow rule first, and was responsible for creating the current DP flow. Since multiple ne

[ovs-dev] [PATCH v5 3/3] system-traffic.at: Test conntrack + FTP server running on a non-standard port.

2023-12-11 Thread Viacheslav Galaktionov via dev
All existing test iterations assume that the FTP server is running on a standard port, which may not always be the case. These tests helped find problems in conntrack alg processing with non-standard ports. Perform the necessary adjustments to ensure the test suite can start the L7 server on a use

[ovs-dev] [PATCH v5 2/3] conntrack: Use helpers from committed connections.

2023-12-11 Thread Viacheslav Galaktionov via dev
When a packet hits a flow rule without an explicitly specified helper, OvS has to rely on automatic application layer gateway detection to find related connections. This works as long as services are running on their standard ports, e.g. when FTP servers use TCP port 21. However, sometimes it's ne

Re: [ovs-dev] [PATCH v4 3/3] system-traffic.at: Test conntrack + FTP server running on a non-standard port.

2023-12-11 Thread 0-day Robot
Bleep bloop. Greetings Viacheslav Galaktionov, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. Patch skipped due to previous failure. Please check this out. If you feel there has been an err

Re: [ovs-dev] [PATCH v4 2/3] conntrack: Use helpers from committed connections.

2023-12-11 Thread 0-day Robot
Bleep bloop. Greetings Viacheslav Galaktionov, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: Failed to merge in the changes. hint: Use 'git am --show-current-patch=diff' to se

[ovs-dev] [PATCH v4 3/3] system-traffic.at: Test conntrack + FTP server running on a non-standard port.

2023-12-11 Thread Viacheslav Galaktionov via dev
All existing test iterations assume that the FTP server is running on a standard port, which may not always be the case. These tests helped find problems in conntrack alg processing with non-standard ports. Perform the necessary adjustments to ensure the test suite can start the L7 server on a use

[ovs-dev] [PATCH v4 1/3] lib/conntrack: Only use given packet in protocol detection.

2023-12-11 Thread Viacheslav Galaktionov via dev
The current protocol detection logic relies on two pieces of metadata passed as arguments: tp_src and tp_dst, which represent the L4 source and destination port numbers from the flow that triggered the current flow rule first, and was responsible for creating the current DP flow. Since multiple ne

[ovs-dev] [PATCH v4 2/3] conntrack: Use helpers from committed connections.

2023-12-11 Thread Viacheslav Galaktionov via dev
When a packet hits a flow rule without an explicitly specified helper, OvS has to rely on automatic application layer gateway detection to find related connections. This works as long as services are running on their standard ports, e.g. when FTP servers use TCP port 21. However, sometimes it's ne