Re: [ovs-dev] [PATCH 4/5] ovsdb: Preserve column diffs read from the storage.

2023-12-29 Thread Mike Pattrick
On Sun, Dec 17, 2023 at 9:03 PM Ilya Maximets wrote: > > Database file contains the column diff, but it is discarded once > the 'new' state of a row is constructed. Keep it in the transaction > row, as it can be used later by other parts of the code. > > Diffs do not live long, we keep them aroun

Re: [ovs-dev] [PATCH ovn v2] northd: Support CIDR-based MAC binding aging threshold.

2023-12-29 Thread Han Zhou
On Thu, Dec 21, 2023 at 11:30 AM Mark Michelson wrote: > > Thanks for the updates, Han, and apologies for the long time it took > before someone reviewed this. > > Acked-by: Mark Michelson > > I think there is potential for optimization here, specifically > incremental processing of mac binding a

Re: [ovs-dev] [PATCH 3/5] ovsdb: transaction: Don't try to diff unchanged columns.

2023-12-29 Thread Mike Pattrick
On Sun, Dec 17, 2023 at 9:03 PM Ilya Maximets wrote: > > While reassessing weak references the code attempts to collect added > and removed atoms, even if the column didn't change. In case the > column contains a large set, it may take significant amount of time > to process. > > Add a check for

Re: [ovs-dev] [PATCH 2/5] ovsdb: transaction: Avoid diffs for different type references.

2023-12-29 Thread Mike Pattrick
On Sun, Dec 17, 2023 at 9:03 PM Ilya Maximets wrote: > > While counting strong references current code first generates a > difference between old and new datums and only after it checks > the types of the atoms to be strong references. > > Similar thing happens while assessing weak references. Fi