Hello, Martin,
Thank you for working on this!
While the automatic conversion is nice when it works, it is a source
of problems when it does not, so I welcome this change.
An additional argument for this change is that the existing approach
executes asynchronously, so there is no way for the
On Mon, Jan 8, 2024 at 5:52 PM Frode Nordahl
wrote:
>
> Posting this as RFC as I'm not fully content with my test results.
>
> With this series there are still situations where we overrun the
> time threashold and subsequently get into the situation we are trying
> to fix with this series.
>
>
On Mon, Jan 8, 2024 at 3:52 PM Numan Siddique wrote:
>
> On Fri, Jan 5, 2024 at 11:36 AM Numan Siddique wrote:
> >
> > On Tue, Dec 19, 2023 at 2:37 AM Han Zhou wrote:
> > >
> > > On Mon, Nov 27, 2023 at 6:39 PM wrote:
> > > >
> > > > From: Numan Siddique
> > > >
> > > > Any changes to northd
On Fri, Jan 5, 2024 at 11:36 AM Numan Siddique wrote:
>
> On Tue, Dec 19, 2023 at 2:37 AM Han Zhou wrote:
> >
> > On Mon, Nov 27, 2023 at 6:39 PM wrote:
> > >
> > > From: Numan Siddique
> > >
> > > Any changes to northd engine node due to load balancers
> > > are now handled in 'sync_to_sb_lb'
Hi:
When setting extra args like ssl-cipers for ovn-controller, it results in
coredump on branch 23.09
compiled with --with-ovs-source and --with-ovs-build option, OVS
(branch-3.2)
dump:
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by
On 1/8/24 22:02, Ilya Maximets wrote:
> On 1/8/24 17:22, Eelco Chaudron wrote:
>>
>>
>> On 8 Jan 2024, at 17:07, Ilya Maximets wrote:
>>
>>> On 1/8/24 17:01, Eelco Chaudron wrote:
On 2 Jan 2024, at 12:19, Ilya Maximets wrote:
> On 12/19/23 13:41, Eelco Chaudron wrote:
On 1/8/24 16:40, Dumitru Ceara wrote:
> Specifically the following commit:
> 4102674b3e ovsdb-idl: Preserve change_seqno when deleting rows.
>
> Without it, in specific cases, the IDL might incorrectly report deletion
> of yet to be seen records.
>
> Signed-off-by: Dumitru Ceara
> ---
> NOTE:
On 1/8/24 17:22, Eelco Chaudron wrote:
>
>
> On 8 Jan 2024, at 17:07, Ilya Maximets wrote:
>
>> On 1/8/24 17:01, Eelco Chaudron wrote:
>>>
>>>
>>> On 2 Jan 2024, at 12:19, Ilya Maximets wrote:
>>>
On 12/19/23 13:41, Eelco Chaudron wrote:
> Updating this image is a requirement for the
man. 8. jan. 2024, 21:33 skrev Ilya Maximets :
> On 1/8/24 17:59, Frode Nordahl wrote:
> > Hello, Ilya and OVS developers,
> >
> > On Wed, Jan 3, 2024 at 12:59 AM Ilya Maximets
> wrote:
> >>
> >> Hi. As described in Documentation/internals/release-process.rst, we are
> >> in a "soft freeze"
On 1/8/24 17:59, Frode Nordahl wrote:
> Hello, Ilya and OVS developers,
>
> On Wed, Jan 3, 2024 at 12:59 AM Ilya Maximets wrote:
>>
>> Hi. As described in Documentation/internals/release-process.rst, we are
>> in a "soft freeze" state:
>>
>>During the freeze, we ask committers to refrain
On Wed, Dec 13, 2023 at 8:05 PM Ilya Maximets wrote:
>
> These functions will be needed when we'll need to load/save
> configuration of each OVSDB remote separately.
>
> The parsing function is written in a way that it updates the
> provided options and doesn't create a new structure. This
> is
Hello, Ilya and OVS developers,
On Wed, Jan 3, 2024 at 12:59 AM Ilya Maximets wrote:
>
> Hi. As described in Documentation/internals/release-process.rst, we are
> in a "soft freeze" state:
>
>During the freeze, we ask committers to refrain from applying patches that
>add new features
Posting this as RFC as I'm not fully content with my test results.
With this series there are still situations where we overrun the
time threashold and subsequently get into the situation we are trying
to fix with this series.
During testing I found a destroy call [0] to take around 500ms, but
One of the goals of Open vSwitch is to be as resource efficient as
possible. Core parts of the program has been implemented as
asynchronous state machines, and when absolutely necessary
additional threads are used.
Introduce cooperative multitasking module which allow us to
interleave important
Creating a serialized JSON object is a time consuming process.
Add a json_serialized_object_create_with_yield() function that
makes use of the cooperative multitasking module to yield during
processing, allowing time sensitive tasks in other parts of the
program to be completed during processing.
Initialize the cooperative multitasking module for the
ovsdb-server.
The server side schema conversion process used for storage engines
such as RAFT is time consuming, yield during processing.
After the schema conversion is done the processing of reconnecting
clients is time consuming, yield
The OVSDB server is mostly synchronous and single threaded. The
OVSDB RAFT storage engine operate under strict deadlines with
operational impact should the deadline overrun.
Register for cooperative multitasking so that long running
processing elsewhere in the program may yield to allow stable
At present the timeval timewarp functionality is tightly coupled
with the unixctl interface for external operation by test suite.
It is however desirable to make use of the timewarp functionality
directly in unit tests.
Split unixctl callback interface and the actual timewarp
functionality into
On 8 Jan 2024, at 17:07, Ilya Maximets wrote:
> On 1/8/24 17:01, Eelco Chaudron wrote:
>>
>>
>> On 2 Jan 2024, at 12:19, Ilya Maximets wrote:
>>
>>> On 12/19/23 13:41, Eelco Chaudron wrote:
Updating this image is a requirement for the kernel system-traffic
tests to pass on Ubuntu. In
On 1/8/24 17:01, Eelco Chaudron wrote:
>
>
> On 2 Jan 2024, at 12:19, Ilya Maximets wrote:
>
>> On 12/19/23 13:41, Eelco Chaudron wrote:
>>> Updating this image is a requirement for the kernel system-traffic
>>> tests to pass on Ubuntu. In addition, 20.04 might be replaced,
>>> as soon as 24.04
On 2 Jan 2024, at 12:19, Ilya Maximets wrote:
> On 12/19/23 13:41, Eelco Chaudron wrote:
>> Updating this image is a requirement for the kernel system-traffic
>> tests to pass on Ubuntu. In addition, 20.04 might be replaced,
>> as soon as 24.04 comes out. Or we need to do this when it becomes
Specifically the following commit:
4102674b3e ovsdb-idl: Preserve change_seqno when deleting rows.
Without it, in specific cases, the IDL might incorrectly report deletion
of yet to be seen records.
Signed-off-by: Dumitru Ceara
---
NOTE: when backporting this, please make sure the
(re-added the list)
Roberto Bartzen Acosta writes:
> Hi Aaron,
>
> I tried to send a new revision but I think that my Gmail web interface
> is putting some additional formatting even if I paste using
> .
> Do you recommend any tool or interface for sending correctly formatted
> patches?
> This
On 1/8/24 16:05, Ilya Maximets wrote:
> On 1/5/24 18:35, Terry Wilson wrote:
>> On Fri, Jan 5, 2024 at 9:56 AM Simon Horman wrote:
>>>
>>> On Mon, Dec 18, 2023 at 05:31:24PM -0600, Terry Wilson wrote:
Currently python-ovs claims to be "db change aware" but does not
parse the
On Fri, Jan 5, 2024 at 11:42 AM Frode Nordahl
wrote:
>
> The documentation for log_backtrace() states the backtrace is
> logged at DEBUG level, while in reality it is logged at ERROR
> level.
>
> Fixes: d0b99d38edab ("backtrace: Add log_backtrace()")
> Signed-off-by: Frode Nordahl
That looks
On 1/5/24 18:35, Terry Wilson wrote:
> On Fri, Jan 5, 2024 at 9:56 AM Simon Horman wrote:
>>
>> On Mon, Dec 18, 2023 at 05:31:24PM -0600, Terry Wilson wrote:
>>> Currently python-ovs claims to be "db change aware" but does not
>>> parse the "monitor_canceled" notification. Transactions can
Add new 'monitor' command to test-ovsdb utilities to make them just
run IDL loop infinitely. Other commands can still be placed before
the 'monitor', e.g. setting up conditions, tracking, running a few
transactions.
Having that, adding a couple test cases for IDL with online database
conversion.
References: <20240108131243.53816-1-priyankar.j...@nutanix.com>
Bleep bloop. Greetings Priyankar Jain, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 93
On 1/5/24 21:26, Terry Wilson wrote:
> On Wed, Dec 13, 2023 at 7:05 PM Ilya Maximets wrote:
>
>> -/* Clears and replaces 'remotes' and 'dbnames' by a configuration read from
>> - * 'config_file', which must have been previously written by save_config().
>> */
>> -static void
>> +/* Clears and
References: <20240108130004.51995-1-priyankar.j...@nutanix.com>
Bleep bloop. Greetings Priyankar Jain, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 81
Currently load balancer applied to a logical switch has the
following restriction:
- VIP of the load balancer cannot reside in the subnet prefix as the
clients as OVN does not install ARP responder flows for the LB VIP.
This change adds a new config option "lb_vip_mac" in the logical_switch
This commit adds a new optional svc_monitor_ipv4 config in the NB_Global
options column. This IP address can be used to send the packets to the
OVN controller bypassing most of the logical switches pipelines.
Usage: Currently Load balancer health check requires a source IP address
to be allocated
References: <20240108122446.48009-1-priyankar.j...@nutanix.com>
Bleep bloop. Greetings Priyankar Jain, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 81
This commit adds a new optional svc_monitor_ipv4 config in the NB_Global
options column. This IP address can be used to send the packets to the
OVN controller bypassing most of the logical switches pipelines.
Usage: Currently Load balancer health check requires a source IP address
to be allocated
On 12/6/23 16:08, Dumitru Ceara wrote:
> On 11/29/23 17:49, Mark Michelson wrote:
>> On 11/29/23 08:32, Frode Nordahl wrote:
>>> On Wed, Nov 29, 2023 at 2:21 PM Dumitru Ceara wrote:
On 11/28/23 15:58, Dumitru Ceara wrote:
> I went ahead and scheduled another instance (please let me
Bleep bloop. Greetings Roberto Bartzen Acosta, I am a robot and I have tried
out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
git-am:
error: patch failed: debian/rules:2
error: debian/rules: patch does not apply
error: Did
Current version of debian/rules simply uses the default lto GCC
optimization settings during the linkage process.
The main problem with this approach is that GCC on OS like Ubuntu
Jammy, for example, can enable the -flto=auto option during the
openvswitch building and linking process. In this
Introduce a dedicated test for garp-max-timeout knob
Signed-off-by: Lorenzo Bianconi
---
tests/ovn.at | 65
1 file changed, 65 insertions(+)
diff --git a/tests/ovn.at b/tests/ovn.at
index 5615ba1a9..6093e0ed9 100644
--- a/tests/ovn.at
+++
On 6 Jan 2024, at 10:23, Cheng Li wrote:
> vconn_sent counter is supposed to increase each time send() return
> 0, no matter if the vconn log debug is on or off.
>
> Signed-off-by: Cheng Li
Thanks for catching and fixing this! The change looks good to me.
Acked-by: Eelco Chaudron
> Hi Lorenzo,
Hi Mark,
thx for the review
>
> I have some comments below
>
> On 12/22/23 10:47, Lorenzo Bianconi wrote:
> > Introduce a dedicated test for garp-max-timeout knob
> >
> > Signed-off-by: Lorenzo Bianconi
> > ---
> > tests/ovn.at | 69
Bleep bloop. Greetings Martin Kalcok, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 99 characters long (recommended limit is 79)
#89 FILE:
ovn-ctl script currently automatically attempts to perform clustered
database schema upgrade when starting OVN SB or NB clustered
database. To provide more controll over this procees a
`--db-cluster-skip-upgrade` option is added that allows skipping
the upgrade.
Default value for this option is
42 matches
Mail list logo
