On Tue, Jan 9, 2024 at 2:54 PM Ilya Maximets wrote:
>
> In case the difference between 'old' and 'new' rows is readily
> available, it can be used to construct added/removed datums
> instead. Diffs are typically much smaller than the column
> itself. This change more than doubles the
On Tue, Jan 9, 2024, 9:46 PM aginwala wrote:
> So it seems it would be ok to use STREAM_SSL_OPTION_HANDLERS for multiple
> places not just ovn-controller which covers ssl-ciphers and ssl-protocols.
> Let me know and can amend in other patch or amend in same patch.
>
Thanks for root causing it.
So it seems it would be ok to use STREAM_SSL_OPTION_HANDLERS for multiple
places not just ovn-controller which covers ssl-ciphers and ssl-protocols.
Let me know and can amend in other patch or amend in same patch.
On Tue, Jan 9, 2024 at 4:15 PM aginwala wrote:
> Hi :
>
> Debugging further with
On Tue, Jan 9, 2024 at 10:32 AM Mark Michelson wrote:
>
> A static analyzer determined that if pb->n_mac was 0, then the c_addrs
> lport_addresses struct would never be initialized. We would then use
> and attempt to free uninitialized memory.
>
> In reality, pb->n_mac will always be 1. This is
Hi :
Debugging further with gdb, I was able to figure out it was was missed in
ovn-controller part of stream ssl option hanlder
git diff
diff --git a/controller/ovn-controller.c b/controller/ovn-controller.c
index 632a2cb15..66316e057 100644
--- a/controller/ovn-controller.c
+++
> On Tue, Jan 9, 2024 at 8:59 AM Lorenzo Bianconi
> wrote:
> >
> > > On Fri, Dec 22, 2023 at 11:27 AM Lorenzo Bianconi
> > > wrote:
> > > >
> > > > Introduce specif flows for E/W ICMPv{4,6} packets if tunnelled packets
> > > > do not fit path MTU. This patch enable PMTUD for East/West Geneve
>
Bleep bloop. Greetings Ilya Maximets, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line lacks whitespace around operator
#180 FILE: ovsdb/ovsdb-server.c:102:
Add more tests specific to --config-file.
Signed-off-by: Ilya Maximets
---
tests/ovsdb-server.at | 651 ++
1 file changed, 651 insertions(+)
diff --git a/tests/ovsdb-server.at b/tests/ovsdb-server.at
index 488dfc36f..036e4cc3b 100644
---
OVSDB server maintains a temporary file with the current database
configuration for the case it is restarted by a monitor process
after a crash. On startup the configuration from command line
arguments is stored there in a JSON format, also whenever user
changes the configuration with different
Basic relay and active-backup command execution tests extended
to run some copies of ovsdb-server processes with --config-file.
Signed-off-by: Ilya Maximets
---
tests/ovsdb-server.at | 123 +-
1 file changed, 97 insertions(+), 26 deletions(-)
diff --git
Allow setting all the JSON-RPC session options at once.
While at it, allow updating options the same way the source
can be updated while calling 'ovsdb_relay_add_db()' if the
relay is already configured.
Signed-off-by: Ilya Maximets
---
ovsdb/ovsdb-server.c | 2 +-
ovsdb/relay.c| 6
Allow setting all the options for the source connection, not only the
inactivity probe interval.
Signed-off-by: Ilya Maximets
---
lib/ovsdb-cs.c | 10 ++
lib/ovsdb-cs.h | 3 +++
2 files changed, 13 insertions(+)
diff --git a/lib/ovsdb-cs.c b/lib/ovsdb-cs.c
index c7c147cc0..b5eda88ad
Set all the options for the source connection, not only the
inactivity probe interval.
Signed-off-by: Ilya Maximets
---
ovsdb/ovsdb-server.c | 11 ---
ovsdb/replication.c | 6 +++---
ovsdb/replication.h | 3 ++-
3 files changed, 9 insertions(+), 11 deletions(-)
diff --git
Just introduced structure 'jsonrpc_session_options' is the same
as part of the 'ovsdb_jsonrpc_options'. In fact, these options
do really belong to a lower layer. So, replace a copy of these
fields with a structure, so it can be easily passed to jsonrpc's
'jsonrpc_session_set_options()'.
Not
It's useful to have a way to update all the JSON-RPC session
options all at once and not call 3 separate functions every
time. This may also allow the internals of these options
to be better abstracted, i.e. allow users to not know what
are these options exactly.
Signed-off-by: Ilya Maximets
Adding a --config-file option that will be used in the future to
allow users to provide the database server configuration via a
JSON file.
For now, it does nothing useful, but we define it as mutually
exclusive with all the command line options and UnixCtl commands
that configure values that will
When database is added to the replication, it should no longer
accept transactions that can modify it. When it's removed from
the replication, it should be writable again. Add this logic
to the replication module itself, so it can be removed from the
main ovsdb-server later.
Signed-off-by: Ilya
Refactoring of the replication code, so each database is handled
separately from each other. Supposed to work the same way as before
with the only difference that each backup database will have its own
connection to the source and will have its own state machine.
>From the user's perspective,
Add a new structure 'db_config' that holds the user-provided
configuration of the database. And attach this configuration
to each of the databases on the server.
Each database has a service model: standalone, clustered, relay
or active-backup. Relays and A-B databases have a source, each
source
It is currently not possible for the role to change in runtime
(unless a manual DB transaction is crafted), but it will be with
addition of a config file.
If the role changes, listening socket will be closed, and all
the connections to this remote will be terminated.
Signed-off-by: Ilya Maximets
Small refactoring so we can re-use this function in later commits.
Signed-off-by: Ilya Maximets
---
ovsdb/ovsdb-server.c | 45 +++-
1 file changed, 32 insertions(+), 13 deletions(-)
diff --git a/ovsdb/ovsdb-server.c b/ovsdb/ovsdb-server.c
index
Store JSON-RPC options for each remote separately, so it will be
possible to have different configurations per remote in the future.
These are also stored to and loaded from the temporary file that
OVSDB is using to restore runtime configuration of the server
restarted by the monitor process
These functions will be needed when we'll need to load/save
configuration of each OVSDB remote separately.
The parsing function is written in a way that it updates the
provided options and doesn't create a new structure. This
is done in order for different callers to have their own
default
Currently, the read-only option can be set on connections or JSON-RPC
server as a whole. However, there is no way to allow modifications in
one database, but not in the other.
Adding an internal read-only flag for a database itself. Will be used
later for running active and backup databases in
The original problem was summarized on the OVS+OVN Conf'22 last year:
https://www.openvswitch.org/support/ovscon2022/#t19
Slides:
https://www.openvswitch.org/support/ovscon2022/slides/ovsdb-a-database.pdf
In short, there are way to many ways to configure remotes and databases
but not a
On Tue, Jan 9, 2024 at 8:59 AM Lorenzo Bianconi
wrote:
>
> > On Fri, Dec 22, 2023 at 11:27 AM Lorenzo Bianconi
> > wrote:
> > >
> > > Introduce specif flows for E/W ICMPv{4,6} packets if tunnelled packets
> > > do not fit path MTU. This patch enable PMTUD for East/West Geneve traffic.
> > >
> >
On Fri, Dec 15, 2023 at 6:07 PM Lorenzo Bianconi
wrote:
>
> > On 12/14/23 18:42, Lorenzo Bianconi wrote:
> > > When using VLAN backed networks and OVN routers leveraging the
> > > 'ovn-chassis-mac-mappings' option for east-west traffic, the eth.src
> > > field is
> > > replaced by the chassis
On 1/8/24 10:37, Lorenzo Bianconi wrote:
> Introduce a dedicated test for garp-max-timeout knob
>
> Signed-off-by: Lorenzo Bianconi
> ---
> tests/ovn.at | 65
> 1 file changed, 65 insertions(+)
>
> diff --git a/tests/ovn.at b/tests/ovn.at
>
On 1/4/24 20:24, Mark Michelson wrote:
> Thanks, Ales.
>
> Acked-by: Mark Michelson
>
Thanks, Ales and Mark! I applied this to main and backported it to all
stable branches down to 22.03.
Regards,
Dumitru
___
dev mailing list
d...@openvswitch.org
In case the difference between 'old' and 'new' rows is readily
available, it can be used to construct added/removed datums
instead. Diffs are typically much smaller than the column
itself. This change more than doubles the performance of a
transaction replay.
For example, with this change
Database file contains the column diff, but it is discarded once
the 'new' state of a row is constructed. Keep it in the transaction
row, as it can be used later by other parts of the code.
Diffs do not live long, we keep them around only while transaction
is alive, so should not affect memory
Cover letter is not modified from v1, but the patch set no longer
contains the bug fixes, they were already applied.
Original cover letter:
This patch set contains a few bug fixes for transaction processing and
an optimization.
The first patch is just a bug fix. The 2nd and 3rd are also bug
A static analyzer determined that if pb->n_mac was 0, then the c_addrs
lport_addresses struct would never be initialized. We would then use
and attempt to free uninitialized memory.
In reality, pb->n_mac will always be 1. This is because the port binding is a
representation of a northbound
Greetings,
We've updated the links on the OVS+OVN Conference page to the YouTube
playlist that contains the OVS+OVN '23 Fall Conference. These
recordings include the Q sessions that were conducted after each
presentation is made for most of the sessions (some talks had conflicts
with speakers).
Roi Dayan writes:
> On 18/12/2023 9:45, Roi Dayan wrote:
>>
>>
>> On 14/12/2023 15:25, Aaron Conole wrote:
>>> Eelco Chaudron writes:
>>>
On 15 Nov 2023, at 3:33, Aaron Conole wrote:
> Eelco Chaudron writes:
>
>> On 14 Nov 2023, at 8:49, Roi Dayan wrote:
>>
>>>
> On Fri, Dec 22, 2023 at 11:27 AM Lorenzo Bianconi
> wrote:
> >
> > Introduce specif flows for E/W ICMPv{4,6} packets if tunnelled packets
> > do not fit path MTU. This patch enable PMTUD for East/West Geneve traffic.
> >
> > Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2241711
> >
Bleep bloop. Greetings Mohammad Heib, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
Until now, there has been no reliable for the CMS to detect when
changes made to the INB configuration have been passed through
to the ISB, This commit adds this feature to the system,
by adding sequence numbers to the INB and ISB and adding code
in ovn-ic-nbctl, ovn-ic to keep those sequence
add unit test that check validate that sync command
sync ISB properly
Signed-off-by: Mohammad Heib
---
tests/ovn-ic.at | 47 +++
1 file changed, 47 insertions(+)
diff --git a/tests/ovn-ic.at b/tests/ovn-ic.at
index d4c436f84..f55ffa6cd 100644
---
This patch implements a basic sequence number protocol
that can be used by CMS to determine if the changes
applied to INB are successfully propagated to ISB.
The implementation of this patch relies on OVN-ICs
instances to update the ISB by adding a per AZ a nb_ic_cfg
counter that will be updated
Add basic flow columns to interconnect northbound DB and
interconnect Southbound DB.
Those columns will be used by future patches to add basic
support for Information Flow in OVN interconnect.
Signed-off-by: Mohammad Heib
Acked-by: Mark Michelson
Acked-by: Ales Musil
---
NEWS
Currently, OVN-IC doesn't support a way to tell the end-user when their changes
to the IC-NB database have propagated successfully to the IC-SB Database.
This patch series adds basic support for the sequence number status protocol
that is implemented on the native OVN, with this patch series the
Considering following topology:
client - sw0 - lrp0 - lr - lrp1 - sw1 - server
sw0 in subnet 192.168.0.0/24
sw1 in subnet 172.168.0.0/24
SNAT configured for client
gateway_mtu=1400 configured for lrp0
If we send UDP traffic from client to server
and server responds with packet bigger than 1400
The ct_commit nat was hardcoded to use DNAT zone
in router pipeline. Extend it that it accepts
two new arguments (snat/dnat) which will determine
the zone for router pipeline. The switch pipeline
has only one, so it resolves to the same for both arguments.
In order to keep backward compatibility
The ICMP need frag could be generated after routing
stage when the unSNAT already happened. Add flows
that will ensure that we are keeping track of the CT
state and do appropriate CT nat action later on.
Because the ICMP traffic is related to already existing
one in this case we can use adjusted
On Mon, Jan 08, 2024 at 08:34:36AM -0300, Roberto Bartzen Acosta via dev wrote:
> Current version of debian/rules simply uses the default lto GCC
> optimization settings during the linkage process.
>
> The main problem with this approach is that GCC on OS like Ubuntu
> Jammy, for example, can
Hi everyone,
Thanks to everyone who could attend the meeting yesterday!
For those who couldn't attend here are the links to the recordings:
https://drive.google.com/file/d/1uB5mQapsqxMkG5BwtrGHmeUgN9K28XBI
https://drive.google.com/file/d/1mNb84ffQ2cGhUcaRUUUzfF9DSxgcURIL
and the meeting notes:
On 1/8/24 16:25, Mike Pattrick wrote:
> On Fri, Jan 5, 2024 at 11:42 AM Frode Nordahl
> wrote:
>>
>> The documentation for log_backtrace() states the backtrace is
>> logged at DEBUG level, while in reality it is logged at ERROR
>> level.
>>
>> Fixes: d0b99d38edab ("backtrace: Add
On 1/8/24 10:37, Eelco Chaudron wrote:
>
>
> On 6 Jan 2024, at 10:23, Cheng Li wrote:
>
>> vconn_sent counter is supposed to increase each time send() return
>> 0, no matter if the vconn log debug is on or off.
>>
>> Signed-off-by: Cheng Li
>
> Thanks for catching and fixing this! The change
On 1/8/24 22:34, Ilya Maximets wrote:
> On 1/8/24 16:40, Dumitru Ceara wrote:
>> Specifically the following commit:
>> 4102674b3e ovsdb-idl: Preserve change_seqno when deleting rows.
>>
>> Without it, in specific cases, the IDL might incorrectly report deletion
>> of yet to be seen records.
>>
On 1/2/24 16:54, Mike Pattrick wrote:
> On Wed, Dec 13, 2023 at 8:05 PM Ilya Maximets wrote:
>>
>> It's not a big problem, but it would be nice to ensure that
>> the backup database cannot be locally converted.
>>
>> Fixes: e51879e99b3e ("ovsdb: Make OVSDB backup sever read only")
>>
On 11/23/23 13:38, Ales Musil wrote:
> This series allows different branches to use different images.
> This is needed for stability reasons as it is hard to keep up
> with new Ubuntu/Fedora releases for all stable branches.
>
> We will still use the prebuilt images for main branch which
> is
On 1/5/24 16:09, Mike Pattrick wrote:
> On Fri, Jan 5, 2024 at 9:30 AM Ilya Maximets wrote:
>>
>> On 12/29/23 17:28, Mike Pattrick wrote:
>>> On Sun, Dec 17, 2023 at 9:03 PM Ilya Maximets wrote:
While reassessing weak references the code attempts to collect added
and removed
On 11/22/23 17:09, David Marchand wrote:
> The DPDK unit test only runs if vfio or igb_uio kernel modules are loaded:
> on systems with only mlx5, this test is always skipped.
>
> Besides, the test tries to grab the first device listed by dpdk-devbind.py,
> regardless of the PCI device status
On 12/6/23 11:19, Ales Musil wrote:
> Add feature flag for the updated ct_commit_nat action. In case there
> is an update of northd to newer version before all controllers are updated.
>
> Signed-off-by: Ales Musil
> ---
We don't use this new flag in this patch. I'd prefer if patches 2/3 and
Bleep bloop. Greetings Mohammad Heib, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
On 12/6/23 11:19, Ales Musil wrote:
> The ct_commit nat was hardcoded to use DNAT zone
> in router pipeline. Extend it that it accepts
> two new arguments (snat/dnat) which will determine
> the zone for router pipeline. The switch pipeline
> has only one so it resolves to the same for both
Hi Ales,
Thank you for your review :)
i addressed most of your comments in v3, i just have one small comment
please see below:
On Tue, Jan 2, 2024 at 10:13 AM Ales Musil wrote:
>
>
> On Wed, Dec 20, 2023 at 4:28 PM Mohammad Heib wrote:
>
>> Until now, there has been no reliable for the CMS
Until now, there has been no reliable for the CMS to detect when
changes made to the INB configuration have been passed through
to the ISB, This commit adds this feature to the system,
by adding sequence numbers to the INB and ISB and adding code
in ovn-ic-nbctl, ovn-ic to keep those sequence
Add basic flow columns to interconnect northbound DB and
interconnect Southbound DB.
Those columns will be used by future patches to add basic
support for Information Flow in OVN interconnect.
Signed-off-by: Mohammad Heib
Acked-by: Mark Michelson
Acked-by: Ales Musil
---
NEWS
This patch implements a basic sequence number protocol
that can be used by CMS to determine if the changes
applied to INB are successfully propagated to ISB.
The implementation of this patch relies on OVN-ICs
instances to update the ISB by adding a per AZ a nb_ic_cfg
counter that will be updated
add unit test that check validate that sync command
sync ISB properly
Signed-off-by: Mohammad Heib
---
tests/ovn-ic.at | 47 +++
1 file changed, 47 insertions(+)
diff --git a/tests/ovn-ic.at b/tests/ovn-ic.at
index d4c436f84..f55ffa6cd 100644
---
Currently, OVN-IC doesn't support a way to tell the end-user when their changes
to the IC-NB database have propagated successfully to the IC-SB Database.
This patch series adds basic support for the sequence number status protocol
that is implemented on the native OVN, with this patch series the
On 12/5/23 12:18, Ales Musil wrote:
> Add unixctl command called "ofctrl/flow-install-time"
> that returns the last time it took OvS to process
> and install all flows. The initial time is taken right
> before controller queues the updates to rconn.
> The end is marked when we receive barrier
On 2 Jan 2024, at 12:19, Ilya Maximets wrote:
> On 12/19/23 13:41, Eelco Chaudron wrote:
>> Updating this image is a requirement for the kernel system-traffic
>> tests to pass on Ubuntu. In addition, 20.04 might be replaced,
>> as soon as 24.04 comes out. Or we need to do this when it becomes
On 9 Jan 2024, at 10:22, Chris Mi wrote:
> Hi Roi and Eelco,
>
> Sorry for the late reply. We are still busy with other task. So maybe we'll
> have to postpone it.
Thanks for the update and I guess we are too late for the upcoming release
unless you can submit it this week.
//Eelco
FYI,
Hi Roi and Eelco,
Sorry for the late reply. We are still busy with other task. So maybe
we'll have to postpone it.
Regards,
Chris
On 1/9/2024 4:52 PM, Roi Dayan wrote:
On 02/11/2023 15:24, Eelco Chaudron wrote:
On 3 Oct 2023, at 17:03, Eelco Chaudron wrote:
On 19 Jun 2023, at 12:18,
On 02/11/2023 15:24, Eelco Chaudron wrote:
>
>
> On 3 Oct 2023, at 17:03, Eelco Chaudron wrote:
>
>> On 19 Jun 2023, at 12:18, Chris Mi wrote:
>>
>>> On 6/19/2023 6:04 PM, Eelco Chaudron wrote:
On 19 Jun 2023, at 7:05, Chris Mi wrote:
> Add three sFlow offload test cases:
On 18/12/2023 9:45, Roi Dayan wrote:
>
>
> On 14/12/2023 15:25, Aaron Conole wrote:
>> Eelco Chaudron writes:
>>
>>> On 15 Nov 2023, at 3:33, Aaron Conole wrote:
>>>
Eelco Chaudron writes:
> On 14 Nov 2023, at 8:49, Roi Dayan wrote:
>
>> On 13/11/2023 19:08, Aaron
69 matches
Mail list logo
