Re: [ovs-dev] [PATCH ovn] tests: Fix flaky test 'SB Port binding incremental processing'

2024-01-31 Thread 0-day Robot
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: The subject summary should end with a dot. Subject: tests: Fix flaky test 'SB Port

[ovs-dev] [PATCH ovn v2] tests: Fix flaky test 'SB Port binding incremental processing'.

2024-01-31 Thread numans
From: Numan Siddique Fixes: 121661678317 ("northd: Move router ports SB PB options sync to sync_to_sb_pb node.") Signed-off-by: Numan Siddique --- v1 -> v2 - * Fix the checkpatch errors. tests/ovn-northd.at | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/ovn-northd.at

[ovs-dev] [PATCH ovn] tests: Fix flaky test 'SB Port binding incremental processing'

2024-01-31 Thread numans
From: Numan Siddique Fixes: 121661678317 ("northd: Move router ports SB PB options sync to sync_to_sb_pb node.") Signed-off-by: Numan Siddique --- tests/ovn-northd.at | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/ovn-northd.at b/tests/ovn-northd.at index 67e81ddba3..fbd0d9ef18

Re: [ovs-dev] [PATCH ovn] northd: Added lb_vip_mac config option in Logical_Switch.

2024-01-31 Thread Numan Siddique
On Mon, Jan 8, 2024 at 8:13 AM Priyankar Jain wrote: > > Currently load balancer applied to a logical switch has the > following restriction: > - VIP of the load balancer cannot reside in the subnet prefix as the > clients as OVN does not install ARP responder flows for the LB VIP. > Hi

Re: [ovs-dev] [PATCH] github: Bump Fedora version to 39.

2024-01-31 Thread Ilya Maximets
On 1/30/24 10:55, Simon Horman wrote: > On Mon, Jan 29, 2024 at 11:33:56PM +0100, Ilya Maximets wrote: >> Fedora 37 reached EOL in November. Switch to the most recent version >> to avoid potential CI failures in the future. >> >> Signed-off-by: Ilya Maximets > > Acked-by: Simon Horman >

Re: [ovs-dev] [PATCH v8 1/2] revalidator: Add a USDT probe during flow deletion with purge reason.

2024-01-31 Thread Aaron Conole
Eelco Chaudron writes: > On 25 Jan 2024, at 21:55, Aaron Conole wrote: > >> From: Kevin Sprague >> >> During normal operations, it is useful to understand when a particular flow >> gets removed from the system. This can be useful when debugging performance >> issues tied to ofproto flow

Re: [ovs-dev] [PATCH ovn] github: Update versions of action dependencies (Node.js 20).

2024-01-31 Thread Ilya Maximets
On 1/31/24 14:27, Ilya Maximets wrote: > On 1/31/24 13:13, Ilya Maximets wrote: >> On 1/30/24 15:18, Ilya Maximets wrote: >>> On 1/30/24 13:07, Ilya Maximets wrote: checkout@v3, cache@v3, setup-python@v4 and setup-go@v3 are using outdated Node.js 16 which is now deprecated in GHA [1], so

Re: [ovs-dev] [PATCH net-next] selftests: openvswitch: Test ICMP related matches work with SNAT

2024-01-31 Thread Aaron Conole
Brad Cowie writes: > Add a test case for regression in openvswitch nat that was fixed by > commit e6345d2824a3 ("netfilter: nf_nat: fix action not being set for > all ct states"). > > Link: https://lore.kernel.org/netdev/20231221224311.130319-1-b...@faucet.nz/ > Link:

Re: [ovs-dev] [PATCH v2 3/4] dp-packet: Include inner offsets in adjustments and checks.

2024-01-31 Thread Mike Pattrick
On Wed, Jan 31, 2024 at 10:04 AM David Marchand wrote: > > On Tue, Jan 30, 2024 at 11:15 PM Mike Pattrick wrote: > > > > Include inner offsets in functions where l3 and l4 offsets are either > > modified or checked. > > > > Fixes: 084c8087292c ("userspace: Support VXLAN and GENEVE TSO.") > >

Re: [ovs-dev] [PATCH v8 1/2] revalidator: Add a USDT probe during flow deletion with purge reason.

2024-01-31 Thread Eelco Chaudron
On 25 Jan 2024, at 21:55, Aaron Conole wrote: > From: Kevin Sprague > > During normal operations, it is useful to understand when a particular flow > gets removed from the system. This can be useful when debugging performance > issues tied to ofproto flow changes, trying to determine deployed

Re: [ovs-dev] [PATCH v2 4/4] ofproto-dpif-monitor: Remove unneeded calls to clear packets.

2024-01-31 Thread David Marchand
On Tue, Jan 30, 2024 at 11:15 PM Mike Pattrick wrote: > > Currently the monitor will call dp_packet_clear() on the dp_packet that > is shared amongst BFD, LLDP, and CFM. However, all of these packets are > created with eth_compose(), which already calls dp_packet_clear(). > > Signed-off-by: Mike

Re: [ovs-dev] [PATCH v2 3/4] dp-packet: Include inner offsets in adjustments and checks.

2024-01-31 Thread David Marchand
On Tue, Jan 30, 2024 at 11:15 PM Mike Pattrick wrote: > > Include inner offsets in functions where l3 and l4 offsets are either > modified or checked. > > Fixes: 084c8087292c ("userspace: Support VXLAN and GENEVE TSO.") > Signed-off-by: Mike Pattrick > --- > v2: > > - Prints out new offsets in

Re: [ovs-dev] [PATCH v2 2/4] bfd: Set proper offsets and flags in BFD packets.

2024-01-31 Thread David Marchand
On Tue, Jan 30, 2024 at 11:15 PM Mike Pattrick wrote: > > Previously the BFD packet creation code did not appropriately set > offsets or flags. This contributed to issues involving encapsulation and > the TSO code. I noted that apart from fixing the offsets / flags used to checksum offloading,

Re: [ovs-dev] [PATCH v2 1/4] dp-packet: Validate correct offset for L4 inner size.

2024-01-31 Thread David Marchand
On Tue, Jan 30, 2024 at 11:15 PM Mike Pattrick wrote: > > This patch fixes the correctness of dp_packet_inner_l4_size() when > checking for the existence of an inner L4 header. Previously it checked > for the outer L4 header. > > This function is currently only used when a packet is already

Re: [ovs-dev] [PATCH ovn] github: Update versions of action dependencies (Node.js 20).

2024-01-31 Thread Ilya Maximets
On 1/31/24 13:13, Ilya Maximets wrote: > On 1/30/24 15:18, Ilya Maximets wrote: >> On 1/30/24 13:07, Ilya Maximets wrote: >>> checkout@v3, cache@v3, setup-python@v4 and setup-go@v3 are using >>> outdated Node.js 16 which is now deprecated in GHA [1], so these >>> actions may stop working soon. >>>

[ovs-dev] [PATCH ovn v2] OVN-SB: Exposes igmp group protocol version through IGMP table.

2024-01-31 Thread Mohammad Heib
Expose the igmp/mld group protocol version through the IGMP_GROUP table in SBDB. This patch can be used by ovn consumer for debuggability purposes, user now can match between the protocol version used in the OVN logical switches and the uplink ports. Rreported-at:

Re: [ovs-dev] [PATCH ovn] github: Update versions of action dependencies (Node.js 20).

2024-01-31 Thread Ilya Maximets
On 1/30/24 15:18, Ilya Maximets wrote: > On 1/30/24 13:07, Ilya Maximets wrote: >> checkout@v3, cache@v3, setup-python@v4 and setup-go@v3 are using >> outdated Node.js 16 which is now deprecated in GHA [1], so these >> actions may stop working soon. >> >> Updating to most recent major versions

Re: [ovs-dev] [PATCH ovs v2] Documentation: Adding note about using the jemalloc library.

2024-01-31 Thread Frode Nordahl
On Mon, Jan 29, 2024 at 12:33 PM Roberto Bartzen Acosta wrote: > > Updating the reference documentation with the inclusion of possible building > problems with libjemalloc and solution suggestions. nit: the above line is very long and does not look well in `git show` > Reported-at: >

Re: [ovs-dev] OVN 24.03 Soft Freeze 19 January

2024-01-31 Thread Dumitru Ceara
On 1/18/24 18:25, Han Zhou wrote: > On Tue, Jan 16, 2024 at 5:45 AM Mark Michelson wrote: >> >> Hi everyone, >> >> The soft freeze for OVN 24.03 is this Friday, 19 January, 2024. Please >> ensure that any patches that introduce new features are posted to the >> mailing list by that date if you

Re: [ovs-dev] [PATCH ovn] northd: Add qos packet marking.

2024-01-31 Thread Dumitru Ceara
Recheck-request: github-robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev