[ovs-dev] [PATCH v2] ovs-tcpdump: Fix cleanup mirror failed with twice fatal signals.

2024-02-22 Thread Daniel Ding
After running ovs-tcpdump and inputs multiple CTRL+C, the program will raise the following exception. Error in atexit._run_exitfuncs: Traceback (most recent call last): File "/usr/bin/ovs-tcpdump", line 421, in cleanup_mirror ovsdb = OVSDB(db_sock) File "/usr/bin/ovs-tcpdump", line 168,

Re: [ovs-dev] [PATCH v1] ovs-tcpdump: Cleanup mirror failed with twice fatal signals

2024-02-22 Thread Ilya Maximets
On 2/22/24 14:12, Daniel Ding wrote: > > > >> 2024年2月22日 下午7:20,Ilya Maximets > > 写道: >> >> On 2/22/24 11:53, Ilya Maximets wrote: >>> On 2/22/24 11:02, Daniel Ding wrote: > 2024年2月22日 上午1:55,Ilya Maximets

[ovs-dev] [RFC] ofproto-dpif-xlate: Recirculate on stack exhaustion.

2024-02-22 Thread Ilya Maximets
This change attempts to track the actual available stack and force recircuation if the flow translation logic is about to overflow it. Unlike the recursion depth counter, this approach allows to track the actual stack usage and bail early even if the recursion depth is not reached yet. This is

[ovs-dev] [PATCH v2] ovsdb: Don't iterate over rows on empty mutation.

2024-02-22 Thread Mike Pattrick
Previously when an empty mutation was used to count the number of rows in a table, OVSDB would iterate over all rows twice. First to perform an RBAC check, and then to perform the no-operation. This change adds a short circuit to mutate operations with no conditions and an empty mutation set,

Re: [ovs-dev] [PATCH] ofproto-dpif-trace: Fix infinite recirculation tracing.

2024-02-22 Thread Ilya Maximets
On 2/22/24 16:46, Jaime Caamaño Ruiz wrote: > We have the option to tweak the ct action ct_state output with `*--ct-next* > /flags/ ` trace > option. > Would it make sense to have the same capability for the ip_frag field given > that >

Re: [ovs-dev] [PATCH] ofproto-dpif-trace: Fix infinite recirculation tracing.

2024-02-22 Thread Jaime Caamaño Ruiz
We have the option to tweak the ct action ct_state output with `*--ct-next* *flags* ` trace option. Would it make sense to have the same capability for the ip_frag field given that the ct action might influence its value after re-injection?

[ovs-dev] [PATCH v3] bond: Reset stats when deleting post recirc rule.

2024-02-22 Thread Adrian Moreno
In order to properly balance bond traffic, ofproto/bond periodically reads usage statistics of the post-recirculation rules (which are added to a hidden internal table). To do that, each "struct bond_entry" (which represents a hash within a bond) stores the last seen statistics for its rule. When

[ovs-dev] [PATCH] ofproto-dpif-trace: Fix infinite recirculation tracing.

2024-02-22 Thread Ilya Maximets
Trace attempts to process all the recirculations. However, if there is a recirculation loop, i.e. if every recirculation generates another recirculation, this process will never stop. It will grind until the trace fills the system memory. A simple reproducer: make sandbox ovs-vsctl add-br

Re: [ovs-dev] [PATCH v2] bond: Reset stats when deleting post recirc rule.

2024-02-22 Thread Adrian Moreno
On 2/21/24 21:09, Ilya Maximets wrote: On 2/20/24 07:50, Adrian Moreno wrote: In order to properly balance bond traffic, ofproto/bond periodically reads usage statistics of the post-recirculation rules (which are added to a hidden internal table). To do that, each "struct bond_entry" (which

Re: [ovs-dev] [PATCH v1] ovs-tcpdump: Cleanup mirror failed with twice fatal signals

2024-02-22 Thread Daniel Ding
> 2024年2月22日 下午7:20,Ilya Maximets 写道: > > On 2/22/24 11:53, Ilya Maximets wrote: >> On 2/22/24 11:02, Daniel Ding wrote: >>> >>> 2024年2月22日 上午1:55,Ilya Maximets >>> > 写道: On 2/21/24 15:27, Aaron Conole wrote: > Daniel Ding

Re: [ovs-dev] [PATCH v1] ovs-tcpdump: Cleanup mirror failed with twice fatal signals

2024-02-22 Thread Ilya Maximets
On 2/22/24 11:53, Ilya Maximets wrote: > On 2/22/24 11:02, Daniel Ding wrote: >> >> >>> 2024年2月22日 上午1:55,Ilya Maximets >> > 写道: >>> >>> On 2/21/24 15:27, Aaron Conole wrote: Daniel Ding mailto:danieldin...@gmail.com>> writes: > After running

Re: [ovs-dev] [PATCH v1] ovs-tcpdump: Cleanup mirror failed with twice fatal signals

2024-02-22 Thread Ilya Maximets
On 2/22/24 11:02, Daniel Ding wrote: > > >> 2024年2月22日 上午1:55,Ilya Maximets > > 写道: >> >> On 2/21/24 15:27, Aaron Conole wrote: >>> Daniel Ding mailto:danieldin...@gmail.com>> writes: >>> After running ovs-tcpdump and inputs multiple CTRL+C, the program will

Re: [ovs-dev] [PATCH v1] ovs-tcpdump: Cleanup mirror failed with twice fatal signals

2024-02-22 Thread Daniel Ding
> 2024年2月22日 上午1:55,Ilya Maximets 写道: > > On 2/21/24 15:27, Aaron Conole wrote: >> Daniel Ding writes: >> >>> After running ovs-tcpdump and inputs multiple CTRL+C, the program will >>> raise the following exception. >>> >>> Error in atexit._run_exitfuncs: >>> Traceback (most recent call