Re: [ovs-dev] [PATCH net] net: openvswitch: fix overwriting ct original tuple for ICMPv6

Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Thu, 9 May 2024 11:38:05 +0200 you wrote: > OVS_PACKET_CMD_EXECUTE has 3 main attributes: > - OVS_PACKET_ATTR_KEY - Packet metadata in a netlink format. > - OVS_PACKET_ATTR_PACKET - Binary packet content. > -

Re: [ovs-dev] [PATCH v3 4/6] netdev-dpdk: Refactor TSO request code.

On 19/04/2024 15:06, David Marchand wrote: > Replace check on th == NULL with an assert() because dp_packet_l4(pkt) > is priorly used to compute (outer) L3 length. > > Besides, filling l4_len and tso_segsz only matters to TSO, so there is > no need to check for other L4 checksum offloading

Re: [ovs-dev] [PATCH v3 3/6] netdev-dpdk: Fix inner checksum when outer is not supported.

On 19/04/2024 15:06, David Marchand wrote: > If outer checksum is not supported and OVS already set L3/L4 outer > checksums in the packet, no outer mark should be left in ol_flags > (as it confuses some driver, like net/ixgbe). > > l2_len must be adjusted to account for the tunnel header. > >

Re: [ovs-dev] [PATCH v3 2/6] netdev-dpdk: Disable outer UDP checksum for net/iavf.

On 19/04/2024 15:06, David Marchand wrote: > Same as the commit 6f93d8e62f13 ("netdev-dpdk: Disable outer UDP checksum > offload for ice/i40e driver."), disable outer UDP checksum and related > offloads for net/iavf. > > Fixes: 084c8087292c ("userspace: Support VXLAN and GENEVE TSO.") >

Re: [ovs-dev] [PATCH v3 1/6] netdev-dpdk: Fallback to non tunnel checksum offloading.

On 19/04/2024 15:06, David Marchand wrote: > The outer checksum offloading API in DPDK is ambiguous and was > implemented by Intel folks in their drivers with the assumption that > any outer offloading always goes with an inner offloading request. > > With net/i40e and net/ice drivers, in the

Re: [ovs-dev] [PATCH ovn v4] controller: Track individual address set constants.

On Fri, May 10, 2024 at 12:39 PM Han Zhou wrote: > > On Fri, May 10, 2024 at 9:23 AM Numan Siddique wrote: > > > > On Fri, May 10, 2024 at 2:37 AM Han Zhou wrote: > > > > > > On Thu, May 9, 2024 at 10:32 AM Mark Michelson > wrote: > > > > > > > > On 5/7/24 02:12, Han Zhou wrote: > > > > > > >

Re: [ovs-dev] [PATCH ovn branch-23.06 2/2] Prepare for 23.06.5.

On Thu, May 9, 2024 at 3:12 PM Mark Michelson wrote: > > Signed-off-by: Mark Michelson Acked-by: Numan Siddique Numan > --- > NEWS | 3 +++ > configure.ac | 2 +- > debian/changelog | 6 ++ > 3 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/NEWS b/NEWS >

Re: [ovs-dev] [PATCH ovn branch-23.06 1/2] Set release date for 23.06.4.

On Thu, May 9, 2024 at 3:20 PM Mark Michelson wrote: > > Signed-off-by: Mark Michelson Acked-by: Numan Siddique Numan > --- > NEWS | 3 ++- > debian/changelog | 2 +- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/NEWS b/NEWS > index a87cfd7ec..e98c2102c

Re: [ovs-dev] [PATCH ovn branch-23.09 2/2] Prepare for 23.09.5.

On Thu, May 9, 2024 at 3:11 PM Mark Michelson wrote: > > Signed-off-by: Mark Michelson Acked-by: Numan Siddique Numan > --- > NEWS | 3 +++ > configure.ac | 2 +- > debian/changelog | 6 ++ > 3 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/NEWS b/NEWS

Re: [ovs-dev] [PATCH ovn branch-23.09 1/2] Set release date for 23.09.4.

On Thu, May 9, 2024 at 3:12 PM Mark Michelson wrote: > > Signed-off-by: Mark Michelson Acked-by: Numan Siddique Numan > --- > NEWS | 3 ++- > debian/changelog | 2 +- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/NEWS b/NEWS > index 97e1c41d5..5c80fa482

Re: [ovs-dev] [PATCH ovn branch-24.03 1/2] Set release date for 24.03.2.

On Thu, May 9, 2024 at 3:11 PM Mark Michelson wrote: > > Signed-off-by: Mark Michelson Acked-by: Numan Siddique Numan > --- > NEWS | 3 ++- > debian/changelog | 2 +- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/NEWS b/NEWS > index ca3562425..4d16d97ff

Re: [ovs-dev] [PATCH ovn v4] controller: Track individual address set constants.

On Fri, May 10, 2024 at 9:23 AM Numan Siddique wrote: > > On Fri, May 10, 2024 at 2:37 AM Han Zhou wrote: > > > > On Thu, May 9, 2024 at 10:32 AM Mark Michelson wrote: > > > > > > On 5/7/24 02:12, Han Zhou wrote: > > > > > > > > > > > > On Mon, May 6, 2024 at 10:37 PM Ales Musil > > >

Re: [ovs-dev] [PATCH ovn v2] controller: Fix an issue wrt cleanup of stale patch port.

On Fri, May 3, 2024 at 11:00 AM Numan Siddique wrote: > > On Mon, Apr 22, 2024 at 2:49 AM Priyankar Jain > wrote: > > > > Issue: > > Upon updating the network_name option of localnet port from one physical > > bridge to another, ovn-controller fails to cleanup the peer localnet > > patch port

Re: [ovs-dev] [PATCH ovn v4] controller: Track individual address set constants.

On Fri, May 10, 2024 at 2:37 AM Han Zhou wrote: > > On Thu, May 9, 2024 at 10:32 AM Mark Michelson wrote: > > > > On 5/7/24 02:12, Han Zhou wrote: > > > > > > > > > On Mon, May 6, 2024 at 10:37 PM Ales Musil > > > wrote: > > > > > > > > > > > > > > > > On Mon, May

[ovs-dev] [PATCH v2] conntrack: Fully initialize conn struct before insertion.

From: Mike Pattrick In case packets are concurrently received in both directions, there's a chance that the ones in the reverse direction get received right after the connection gets added to the connection tracker but before some of the connection's fields are fully initialized. This could

[ovs-dev] [PATCH] Subject: conntrack: Fully initialize conn struct before insertion.

From: Mike Pattrick In case packets are concurrently received in both directions, there's a chance that the ones in the reverse direction get received right after the connection gets added to the connection tracker but before some of the connection's fields are fully initialized. This could

Re: [ovs-dev] [RFC 04/11] vswitchd: Add psample to schema and configure it.

On 4/24/24 21:53, Adrian Moreno wrote: > Add a psample_group field to the Flow Sample Collector Set table and use > it to configure the psample ofproto layer. > > Signed-off-by: Adrian Moreno > --- > vswitchd/bridge.c | 54 ++ >

Re: [ovs-dev] [RFC 03/11] ofproto: Add ofproto-dpif-psample.

On 5/10/24 12:06, Eelco Chaudron wrote: > On 24 Apr 2024, at 21:53, Adrian Moreno wrote: > >> Add a new resource in ofproto-dpif and the corresponding API in >> ofproto_provider.h to represent and change psample configuration. > > See comments below. > > //Eelco > >> Signed-off-by: Adrian

Re: [ovs-dev] [RFC 01/11] odp-util: Add support to new psample uAPI.

On 5/10/24 14:01, Eelco Chaudron wrote: > > > On 10 May 2024, at 12:45, Adrian Moreno wrote: > >> On 5/10/24 12:06 PM, Eelco Chaudron wrote: >>> On 24 Apr 2024, at 21:53, Adrian Moreno wrote: >>> The new odp sample attributes allow userspace to specify a group_id and user-defined

Re: [ovs-dev] [RFC 01/11] odp-util: Add support to new psample uAPI.

On 10 May 2024, at 12:45, Adrian Moreno wrote: > On 5/10/24 12:06 PM, Eelco Chaudron wrote: >> On 24 Apr 2024, at 21:53, Adrian Moreno wrote: >> >>> The new odp sample attributes allow userspace to specify a group_id and >>> user-defined cookie to be passed down to psample. >>> >>> Add support

Re: [ovs-dev] [PATCH ovn v2] ovn-controller: Initialize bitmap to zero.

On 5/10/24 13:44, Ales Musil wrote: > > > On Fri, May 10, 2024 at 1:34 PM Ilya Maximets > wrote: > > On 5/10/24 12:57, Ales Musil wrote: > > The bitmap used in the update_ct_zones was uninitialized, and it could > > contain any value besides 0. Use the

Re: [ovs-dev] [RFC 02/11] ofproto_dpif: Check for psample support.

On 5/10/24 13:03, Adrian Moreno wrote: > > > On 5/10/24 12:06 PM, Eelco Chaudron wrote: >> On 24 Apr 2024, at 21:53, Adrian Moreno wrote: >> >>> Only kernel datapath supports psample so check that the datapath is not >>> userspace and that it accepts the new attributes. >>> >>> Signed-off-by:

Re: [ovs-dev] [PATCH] odp-execute: Fix AVX checksum calculation.

On 7 May 2024, at 17:24, Emma Finn wrote: > The AVX implementation for calcualting checksum was not > handling carry-over addition correctly in some cases. > This patch adds an additional shuffle to add 16-bit padding > to the final part of the calculation to handle such cases. > > Fixes:

Re: [ovs-dev] [PATCH ovn v2] ovn-controller: Initialize bitmap to zero.

On Fri, May 10, 2024 at 1:34 PM Ilya Maximets wrote: > On 5/10/24 12:57, Ales Musil wrote: > > The bitmap used in the update_ct_zones was uninitialized, and it could > > contain any value besides 0. Use the bitmap_allocate() function instead, > > to allocate the bitmap in heap rather than stack,

Re: [ovs-dev] [PATCH ovn v2] ovn-controller: Initialize bitmap to zero.

On 5/10/24 12:57, Ales Musil wrote: > The bitmap used in the update_ct_zones was uninitialized, and it could > contain any value besides 0. Use the bitmap_allocate() function instead, > to allocate the bitmap in heap rather than stack, the allocate makes sure > that the memory is properly zeroed.

Re: [ovs-dev] [Patch] ovsdb-client: Add missing arg to help for 'dump'.

Thanks for the merge and backports Simon. On Tue, 2024-05-07 at 17:26 +0100, Simon Horman wrote: > On Tue, May 07, 2024 at 03:16:25PM +0100, Simon Horman wrote: > > On Fri, May 03, 2024 at 02:22:27PM +0200, > > martin.kal...@canonical.com wrote: > > ... > > > Thanks, > > > > Sorry for the

Re: [ovs-dev] [RFC 05/11] ofproto_dpif_xlate: Use psample for OFP samples.

On 5/10/24 12:06 PM, Eelco Chaudron wrote: On 24 Apr 2024, at 21:53, Adrian Moreno wrote: When a OFP_SAMPLE action is xlated and a dpif_psample object has been configured (via Flow_Sample_Collector_Set table) with the same collector_set_id, add psample information to the odp sample action.

Re: [ovs-dev] [RFC 02/11] ofproto_dpif: Check for psample support.

On 5/10/24 12:06 PM, Eelco Chaudron wrote: On 24 Apr 2024, at 21:53, Adrian Moreno wrote: Only kernel datapath supports psample so check that the datapath is not userspace and that it accepts the new attributes. Signed-off-by: Adrian Moreno --- ofproto/ofproto-dpif.c | 59

[ovs-dev] [PATCH ovn v2] ovn-controller: Initialize bitmap to zero.

The bitmap used in the update_ct_zones was uninitialized, and it could contain any value besides 0. Use the bitmap_allocate() function instead, to allocate the bitmap in heap rather than stack, the allocate makes sure that the memory is properly zeroed. This was caught by valgrind: Conditional

Re: [ovs-dev] [RFC 01/11] odp-util: Add support to new psample uAPI.

On 5/10/24 12:06 PM, Eelco Chaudron wrote: On 24 Apr 2024, at 21:53, Adrian Moreno wrote: The new odp sample attributes allow userspace to specify a group_id and user-defined cookie to be passed down to psample. Add support for parsing and formatting such action. Signed-off-by: Adrian

Re: [ovs-dev] [PATCH v4 12/12] documentation: Document ovs-flowviz.

On 7 May 2024, at 16:30, Adrian Moreno wrote: > Add a man page for ovs-flowviz as well as a topic page with some more > detailed examples. > > Signed-off-by: Adrian Moreno Thanks for making the changes, they look good to me. Acked-by: Eelco Chaudron

Re: [ovs-dev] [PATCH ovn] ovn-controller: Initialize bitmap to zero.

On Fri, May 10, 2024 at 11:23 AM Ilya Maximets wrote: > On 5/10/24 10:44, Ales Musil wrote: > > The bitmap used in the update_ct_zones was uninitialized and it could > > contain any value besides 0, make sure we initialize it to 0 instead. > > This was caught by valgrind: > > > > Conditional

Re: [ovs-dev] [RFC 00/11] Add psample support to NXAST_SAMPLE action.

On 10 May 2024, at 10:23, Adrian Moreno wrote: > On 5/10/24 9:14 AM, Eelco Chaudron wrote: >> >> >> On 24 Apr 2024, at 21:53, Adrian Moreno wrote: >> >>> This is the userspace counterpart of the work being done in the kernel >>> [1]. Sending it as RFC to get some early feedback on the overall

Re: [ovs-dev] [RFC 10/11] ofproto-dpif-psample: Add command to show stats.

On 24 Apr 2024, at 21:53, Adrian Moreno wrote: Maybe add a small description to this patch. > Signed-off-by: Adrian Moreno > --- > ofproto/ofproto-dpif-psample.c | 59 ++ > ofproto/ofproto-dpif-psample.h | 1 + > ofproto/ofproto-dpif.c | 1 + > 3 files

Re: [ovs-dev] [RFC 07/11] netlink-offload-tc: Rename act_cookie->flow_cookie.

On 24 Apr 2024, at 21:53, Adrian Moreno wrote: > In preparation to allowing certain actions to have a cookie that does > not represent the entire flow, rename flower->act_cookie to > flower->flow_cookie. > > This patch does not introduce any behavioral change, it's just a > variable renaming.

Re: [ovs-dev] [RFC 04/11] vswitchd: Add psample to schema and configure it.

On 24 Apr 2024, at 21:53, Adrian Moreno wrote: > Add a psample_group field to the Flow Sample Collector Set table and use > it to configure the psample ofproto layer. See comments below, Eelco > Signed-off-by: Adrian Moreno > --- > vswitchd/bridge.c | 54

Re: [ovs-dev] [RFC 03/11] ofproto: Add ofproto-dpif-psample.

On 24 Apr 2024, at 21:53, Adrian Moreno wrote: > Add a new resource in ofproto-dpif and the corresponding API in > ofproto_provider.h to represent and change psample configuration. See comments below. //Eelco > Signed-off-by: Adrian Moreno > --- > ofproto/automake.mk| 2 + >

Re: [ovs-dev] [RFC 06/11] utilities: Add ovs-psample.

On 24 Apr 2024, at 21:53, Adrian Moreno wrote: > This simple program reads from psample and prints the packets to stdout. > It's useful for quickly collecting sampled packets. See some comments below, did not review the actual sample application in detail. //Eelco > Signed-off-by: Adrian

Re: [ovs-dev] [RFC 02/11] ofproto_dpif: Check for psample support.

On 24 Apr 2024, at 21:53, Adrian Moreno wrote: > Only kernel datapath supports psample so check that the datapath is not > userspace and that it accepts the new attributes. > > Signed-off-by: Adrian Moreno > --- > ofproto/ofproto-dpif.c | 59 ++ >

Re: [ovs-dev] [RFC 01/11] odp-util: Add support to new psample uAPI.

On 24 Apr 2024, at 21:53, Adrian Moreno wrote: > The new odp sample attributes allow userspace to specify a group_id and > user-defined cookie to be passed down to psample. > > Add support for parsing and formatting such action. > > Signed-off-by: Adrian Moreno Hi Adrian, See my comments below

Re: [ovs-dev] [RFC 05/11] ofproto_dpif_xlate: Use psample for OFP samples.

On 24 Apr 2024, at 21:53, Adrian Moreno wrote: > When a OFP_SAMPLE action is xlated and a dpif_psample object has been > configured (via Flow_Sample_Collector_Set table) with the same > collector_set_id, add psample information to the odp sample action. See comments below. //Eelco >

Re: [ovs-dev] [RFC 11/11] tests: Add test for sample offloading.

On 24 Apr 2024, at 21:53, Adrian Moreno wrote: > Signed-off-by: Adrian Moreno > --- > tests/system-common-macros.at| 4 +++ > tests/system-offloads-traffic.at | 53 > 2 files changed, 57 insertions(+) > > diff --git a/tests/system-common-macros.at

Re: [ovs-dev] [RFC 08/11] netdev-offload-tc: Add sample support.

On 24 Apr 2024, at 21:53, Adrian Moreno wrote: > Offload the sample action if it contains psample information by creating > a tc "sample" action with the user cookie inside the action's cookie. > > Avoid using the "sample" action's cookie to store the ufid. I have some concerns about the sample

Re: [ovs-dev] [RFC 09/11] ofproto-dpif-xlate-cache: Add psample to xcache.

On 24 Apr 2024, at 21:53, Adrian Moreno wrote: > Add a cache entry type for psample objects. > Store both the dpif_psample reference and the collector_set_id so we can > quickly find the particular exporter. > > Using that mechanism, account for packet and byte statistics. See comments inline.

Re: [ovs-dev] [PATCH ovn] ovn-controller: Initialize bitmap to zero.

On 5/10/24 10:44, Ales Musil wrote: > The bitmap used in the update_ct_zones was uninitialized and it could > contain any value besides 0, make sure we initialize it to 0 instead. > This was caught by valgrind: > > Conditional jump or move depends on uninitialised value(s) > at 0x44074B:

[ovs-dev] [PATCH ovn] ovn-controller: Initialize bitmap to zero.

The bitmap used in the update_ct_zones was uninitialized and it could contain any value besides 0, make sure we initialize it to 0 instead. This was caught by valgrind: Conditional jump or move depends on uninitialised value(s) at 0x44074B: update_ct_zones (ovn-controller.c:812) by 0x440DC9:

Re: [ovs-dev] [RFC 00/11] Add psample support to NXAST_SAMPLE action.

On 5/10/24 9:14 AM, Eelco Chaudron wrote: On 24 Apr 2024, at 21:53, Adrian Moreno wrote: This is the userspace counterpart of the work being done in the kernel [1]. Sending it as RFC to get some early feedback on the overall solution. ** Problem description ** Currently, OVS supports

Re: [ovs-dev] [RFC 00/11] Add psample support to NXAST_SAMPLE action.

On 24 Apr 2024, at 21:53, Adrian Moreno wrote: > This is the userspace counterpart of the work being done in the kernel > [1]. Sending it as RFC to get some early feedback on the overall > solution. > > ** Problem description ** > Currently, OVS supports several observability features, such as

Re: [ovs-dev] [PATCH v2] utilities: Correct deletion reason in flow_reval_monitor.py.

On 9 May 2024, at 15:25, Simon Horman wrote: > On Wed, May 08, 2024 at 11:19:56AM +0200, Eelco Chaudron wrote: >> The flow_reval_monitor.py script incorrectly reported the reasons for >> FDR_PURGE and FDR_TOO_EXPENSIVE, as their descriptions were swapped. >> This patch rectifies the order

Re: [ovs-dev] [PATCH ovn v4] controller: Track individual address set constants.

On Thu, May 9, 2024 at 10:32 AM Mark Michelson wrote: > > On 5/7/24 02:12, Han Zhou wrote: > > > > > > On Mon, May 6, 2024 at 10:37 PM Ales Musil > > wrote: > > > > > > > > > > > > On Mon, May 6, 2024 at 8:41 PM Han Zhou > > wrote: > > >> > >

Re: [ovs-dev] [PATCH net] net: openvswitch: fix overwriting ct original tuple for ICMPv6

On 9 May 2024, at 11:38, Ilya Maximets wrote: > OVS_PACKET_CMD_EXECUTE has 3 main attributes: > - OVS_PACKET_ATTR_KEY - Packet metadata in a netlink format. > - OVS_PACKET_ATTR_PACKET - Binary packet content. > - OVS_PACKET_ATTR_ACTIONS - Actions to execute on the packet. > >