[ovs-dev] [BUG][revalidator] ovs crash and could NOT fix again after set request_mtu

2024-05-30 Thread Simon Jones
Hi all, I'm using ovs-dpdk(ovs:2.17.1, dpdk:21.11.1). Now I found a BUG that ovs crash and could NOT fix again after set request_mtu. 1. How to reproduce and my Analysis: ``` # start ovs and add bridge and port and openflow [root@bogon ~]# ovs-vsctl show 0444869c-dc4d-462f-8caf-074ecbab1a55

Re: [ovs-dev] [PATCH v5] route-table: Add support for v4 via v6 route.

2024-05-30 Thread Ilya Maximets
On 5/30/24 20:17, Ilya Maximets wrote: > On 5/30/24 01:27, William Tu wrote: >> Add route-table support for ipv4 dst via ipv6. One use case is BGP >> unnumbered, a mechanism that establishes peering sessions without the >> need to explicitly configure IPv4 addresses on the interfaces involved >> in

Re: [ovs-dev] [PATCH v5] route-table: Add support for v4 via v6 route.

2024-05-30 Thread Ilya Maximets
On 5/30/24 01:27, William Tu wrote: > Add route-table support for ipv4 dst via ipv6. One use case is BGP > unnumbered, a mechanism that establishes peering sessions without the > need to explicitly configure IPv4 addresses on the interfaces involved > in the peering. Without using IPv4 address assi

Re: [ovs-dev] [PATCH v2 branch-2.17] dpdk: Use DPDK 21.11.7 release for OVS 2.17.

2024-05-30 Thread Kevin Traynor
On 30/05/2024 13:13, Eelco Chaudron wrote: > > > On 28 May 2024, at 11:25, Kevin Traynor wrote: > >> Update the CI and docs to use DPDK 21.11.7. >> >> Signed-off-by: Kevin Traynor > > Thanks Kevin, changes look good to me. > > Acked-by: Eelco Chaudron > Thanks Ilya and Eelco. Applied and p

Re: [ovs-dev] [v4] odp-execute: Fix AVX checksum calculation.

2024-05-30 Thread Eelco Chaudron
On 24 May 2024, at 11:20, Emma Finn wrote: > The AVX implementation for calcualting checksums was not > handling carry-over addition correctly in some cases. > This patch adds an additional shuffle to add 16-bit padding to > the final part of the calculation to handle such cases. This > commit

Re: [ovs-dev] [PATCH 1/1] ofproto-dpif-upcall: Avoid stale ukeys leaks.

2024-05-30 Thread Eelco Chaudron
On 23 May 2024, at 12:46, Roi Dayan via dev wrote: > It is observed in some environments that there are much more ukeys than > actual DP flows. For example: > > $ ovs-appctl upcall/show > system@ovs-system: > flows : (current 7) (avg 6) (max 117) (limit 2125) > offloaded flows : 525 > dump durat

Re: [ovs-dev] [PATCH v2 ovn] northd: Add bfd and bfd_consumer nodes to I-P engine.

2024-05-30 Thread Han Zhou
On Wed, May 29, 2024 at 5:26 AM Lorenzo Bianconi < lorenzo.bianc...@redhat.com> wrote: > > Introduce bfd and bfd_consumer nodes to northd I-P engine to track bfd > connections and northd static_route/policy_route changes. > > Reported-at: https://issues.redhat.com/browse/FDP-600 > Signed-off-by: Lo

Re: [ovs-dev] [PATCH ovn 5/5] controller: Handle postponed ports release.

2024-05-30 Thread Numan Siddique
On Tue, Apr 23, 2024 at 7:54 AM Xavier Simonart wrote: > > Reported-at: > https://mail.openvswitch.org/pipermail/ovs-dev/2023-May/405107.html > Suggested-by: Priyankar Jain > > Signed-off-by: Xavier Simonart > --- > controller/binding.c | 12 +- > tests/ovn.at | 57

Re: [ovs-dev] [PATCH ovn 4/5] controller: Handle postponed ports claims.

2024-05-30 Thread Numan Siddique
On Tue, Apr 23, 2024 at 7:54 AM Xavier Simonart wrote: > > When a port was claimed by two chassis, both chassis were fighting for the > port; > a claim was postponed if the port was claimed recently. > However, there were two issues: > - Not all the flows were properly removed when the remote cha

Re: [ovs-dev] [PATCH ovn 3/5] controller: Fix deletion of container parent port.

2024-05-30 Thread Numan Siddique
On Tue, Apr 23, 2024 at 7:54 AM Xavier Simonart wrote: > > Flows were not properly removed when parent port of a container port > was deleted. > > Signed-off-by: Xavier Simonart Acked-by: Numan Siddique Numan > --- > controller/binding.c | 1 + > controller/physical.c | 3 ++- > tests/ovn

Re: [ovs-dev] [PATCH ovn 2/5] controller: Nonvif related lports handling.

2024-05-30 Thread Numan Siddique
On Tue, Apr 23, 2024 at 7:54 AM Xavier Simonart wrote: > > This patches fixes flows not properly deleted in scenarios similar to: > foo1 (hv1) - foo - R1 - join - R2 (chassis = hv2) - alice - alice1 (hv2). > > When R2 is deleted, alice_R2 changed from l3gateway to patch, and, on hv1, > alice_R2 wa

Re: [ovs-dev] [PATCH ovn 1/5] controller: Fix iface-id-ver handling.

2024-05-30 Thread Numan Siddique
On Tue, Apr 23, 2024 at 7:53 AM Xavier Simonart wrote: > > If iface-id-ver was wrong and modified to a correct value, > the port was correctly claimed, but the flows were not installed > by I+P. > > Signed-off-by: Xavier Simonart Acked-by: Numan Siddique Numan > --- > controller/binding.c |

Re: [ovs-dev] [PATCH ovn] northd: Fix logical router load-balancer nat rules when using DGP.

2024-05-30 Thread Roberto Bartzen Acosta
Em qui., 2 de mai. de 2024 às 10:11, Numan Siddique escreveu: > On Fri, Mar 22, 2024 at 7:51 AM Roberto Bartzen Acosta > wrote: > > > > Hi Mark, > > > > Thanks for your feedback. > > > > Em seg., 18 de mar. de 2024 às 11:53, Mark Michelson < > mmich...@redhat.com> > > escreveu: > > > > > Hi Robe

Re: [ovs-dev] [v4] odp-execute: Fix AVX checksum calculation.

2024-05-30 Thread Eelco Chaudron
On 30 May 2024, at 15:28, Eelco Chaudron wrote: > On 30 May 2024, at 14:46, Finn, Emma wrote: > >>> -Original Message- >>> From: Eelco Chaudron >>> Sent: Wednesday, May 29, 2024 3:23 PM >>> To: Finn, Emma >>> Cc: Ilya Maximets ; ovs-dev@openvswitch.org; Van >>> Haaren, Harry >>> Subje

Re: [ovs-dev] [v4] odp-execute: Fix AVX checksum calculation.

2024-05-30 Thread Eelco Chaudron
On 30 May 2024, at 14:46, Finn, Emma wrote: >> -Original Message- >> From: Eelco Chaudron >> Sent: Wednesday, May 29, 2024 3:23 PM >> To: Finn, Emma >> Cc: Ilya Maximets ; ovs-dev@openvswitch.org; Van >> Haaren, Harry >> Subject: Re: [v4] odp-execute: Fix AVX checksum calculation. >>

[ovs-dev] [PATCH v4 6/6] netdev-dpdk: Refactor tunnel checksum offloading.

2024-05-30 Thread David Marchand
All informations required for checksum offloading can be deducted by already tracked dp_packet l3_ofs, l4_ofs, inner_l3_ofs and inner_l4_ofs fields. Remove DPDK specific l[2-4]_len from generic OVS code. netdev-dpdk code then fills mbuf specifics step by step: - outer_l2_len and outer_l3_len are n

[ovs-dev] [PATCH v4 5/6] netdev-dpdk: Use guest TSO segmentation size hint.

2024-05-30 Thread David Marchand
In a typical setup like: guest A <-virtio-> OVS A <-vxlan-> OVS B <-virtio-> guest B TSO packets from guest A are segmented against the OVS A physical port mtu adjusted by the vxlan tunnel header size, regardless of guest A interface mtu. As an example, let's say guest A and guest B mtu are set t

[ovs-dev] [PATCH v4 4/6] netdev-dpdk: Refactor TSO request code.

2024-05-30 Thread David Marchand
Every L3, L4 checksum offload or TSO requires a (outer) L3 length to be provided. This length is computed via dp_packet_l4(pkt) that is always set when such offloads are requested in OVS. Getting a th == NULL is a bug in OVS, so an assert() is more appropriate. Besides, filling l4_len and tso_segs

[ovs-dev] [PATCH v4 3/6] netdev-dpdk: Fix inner checksum when outer is not supported.

2024-05-30 Thread David Marchand
If outer checksum is not supported and OVS already set L3/L4 outer checksums in the packet, no outer mark should be left in ol_flags (as it confuses some driver, like net/ixgbe). l2_len must be adjusted to account for the tunnel header. Fixes: 084c8087292c ("userspace: Support VXLAN and GENEVE TS

[ovs-dev] [PATCH v4 2/6] netdev-dpdk: Disable outer UDP checksum for net/iavf.

2024-05-30 Thread David Marchand
Same as the commit 6f93d8e62f13 ("netdev-dpdk: Disable outer UDP checksum offload for ice/i40e driver."), disable outer UDP checksum and related offloads for net/iavf. Fixes: 084c8087292c ("userspace: Support VXLAN and GENEVE TSO.") Signed-off-by: David Marchand Acked-by: Kevin Traynor --- Note:

[ovs-dev] [PATCH v4 1/6] netdev-dpdk: Fallback to non tunnel checksum offloading.

2024-05-30 Thread David Marchand
The outer checksum offloading API in DPDK is ambiguous and was implemented by Intel folks in their drivers with the assumption that any outer offloading always goes with an inner offloading request. With net/i40e and net/ice drivers, in the case of encapsulating a ARP packet in a vxlan tunnel (whi

Re: [ovs-dev] [v4] odp-execute: Fix AVX checksum calculation.

2024-05-30 Thread Finn, Emma
> -Original Message- > From: Eelco Chaudron > Sent: Wednesday, May 29, 2024 3:23 PM > To: Finn, Emma > Cc: Ilya Maximets ; ovs-dev@openvswitch.org; Van > Haaren, Harry > Subject: Re: [v4] odp-execute: Fix AVX checksum calculation. > > > > On 29 May 2024, at 14:51, Ilya Maximets wrote:

Re: [ovs-dev] [PATCH v2] dpdk: Use DPDK 23.11.1 release.

2024-05-30 Thread Eelco Chaudron
On 28 May 2024, at 11:25, Kevin Traynor wrote: > Update the CI and docs to use DPDK 23.11.1. > > Signed-off-by: Kevin Traynor Thanks Kevin, changes look good to me. Acked-by: Eelco Chaudron ___ dev mailing list d...@openvswitch.org https://mail.o

Re: [ovs-dev] [PATCH v2 branch-3.3] dpdk: Use DPDK 23.11.1 release for OVS 3.3.

2024-05-30 Thread Eelco Chaudron
On 28 May 2024, at 11:25, Kevin Traynor wrote: > Update the CI and docs to use DPDK 23.11.1. > > Signed-off-by: Kevin Traynor Thanks Kevin, changes look good to me. Acked-by: Eelco Chaudron ___ dev mailing list d...@openvswitch.org https://mail.o

Re: [ovs-dev] [PATCH v2 branch-3.2] dpdk: Use DPDK 22.11.5 release for OVS 3.2.

2024-05-30 Thread Eelco Chaudron
On 28 May 2024, at 11:25, Kevin Traynor wrote: > Update the CI and docs to use DPDK 22.11.5. > > Signed-off-by: Kevin Traynor Thanks Kevin, changes look good to me. Acked-by: Eelco Chaudron ___ dev mailing list d...@openvswitch.org https://mail.o

Re: [ovs-dev] [PATCH v2 branch-3.1] dpdk: Use DPDK 22.11.5 release for OVS 3.1.

2024-05-30 Thread Eelco Chaudron
On 28 May 2024, at 11:25, Kevin Traynor wrote: > Update the CI and docs to use DPDK 22.11.5. > > Signed-off-by: Kevin Traynor Thanks Kevin, changes look good to me. Acked-by: Eelco Chaudron ___ dev mailing list d...@openvswitch.org https://mail.o

Re: [ovs-dev] [PATCH v2 branch-3.0] dpdk: Use DPDK 21.11.7 release for OVS 3.0.

2024-05-30 Thread Eelco Chaudron
On 28 May 2024, at 11:25, Kevin Traynor wrote: > Update the CI and docs to use DPDK 21.11.7. > > Signed-off-by: Kevin Traynor Thanks Kevin, changes look good to me. Acked-by: Eelco Chaudron ___ dev mailing list d...@openvswitch.org https://mail.o

Re: [ovs-dev] [PATCH v2 branch-2.17] dpdk: Use DPDK 21.11.7 release for OVS 2.17.

2024-05-30 Thread Eelco Chaudron
On 28 May 2024, at 11:25, Kevin Traynor wrote: > Update the CI and docs to use DPDK 21.11.7. > > Signed-off-by: Kevin Traynor Thanks Kevin, changes look good to me. Acked-by: Eelco Chaudron ___ dev mailing list d...@openvswitch.org https://mail.o

Re: [ovs-dev] [PATCH v3 4/8] sflow: Use uint32_t instead of time_t for tick handling in the poller.

2024-05-30 Thread Eelco Chaudron
On 29 May 2024, at 12:53, Eelco Chaudron wrote: > The sFlow library uses a uint32_t to configure timeout ticks, but > stores this value as a time_t. Although this doesn't cause functional > issues, it wastes space and confuses Coverity, potentially indicating > a Y2K38 problem when storing uint

Re: [ovs-dev] [PATCH v3 5/8] sflow: Fix check for disabled receive time.

2024-05-30 Thread Eelco Chaudron
On 29 May 2024, at 12:53, Eelco Chaudron wrote: > Changed sFlowRcvrTimeout to a uint32_t to avoid time_t warnings > reported by Coverity. A uint32_t is more than large enough as > this is a (seconds) tick counter and OVS is not even using this. > > Fixes: c72e245a0e2c ("Add InMon's sFlow Agent

Re: [ovs-dev] [PATCH v3 8/8] netdev-linux: Fix uninitialized gso_type case.

2024-05-30 Thread Eelco Chaudron
On 29 May 2024, at 12:53, Eelco Chaudron wrote: > This patch fixes an uninitialized gso_type case in > netdev_linux_prepend_vnet_hdr() by returning an error. > > Fixes: 3337e6d91c5b ("userspace: Enable L4 checksum offloading by default.") > Signed-off-by: Eelco Chaudron > --- > lib/netdev-lin