Re: [ovs-dev] [PATCH ovn v3] text respresntations for drop sampling.

2024-06-02 Thread Ales Musil
On Wed, May 29, 2024 at 2:25 AM Jacob Tanenbaum wrote: > created a new column in the southbound database to hardcode a human > readable > description for flows. This first use is describing why the flow is > dropping packets. > The new column is called flow_desc and will create southbound databas

[ovs-dev] [PATCH v2] ovsdb: Use table indexes if available for ovsdb_query().

2024-06-02 Thread Mike Pattrick
Currently all OVSDB database queries except for UUID lookups all result in linear lookups over the entire table, even if an index is present. This patch modifies ovsdb_query() to attempt an index lookup first, if possible. If no matching indexes are present then a linear index is still conducted.

Re: [ovs-dev] [PATCH] ovsdb: Use table indexes if available for ovsdb_query().

2024-06-02 Thread 0-day Robot
Bleep bloop. Greetings Mike Pattrick, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: Failed to merge in the changes. hint: Use 'git am --show-current-patch=diff' to see the fai

[ovs-dev] [PATCH] ovsdb: Use table indexes if available for ovsdb_query().

2024-06-02 Thread Mike Pattrick
Currently all OVSDB database queries except for UUID lookups all result in linear lookups over the entire table, even if an index is present. This patch modifies ovsdb_query() to attempt an index lookup first, if possible. If no matching indexes are present then a linear index is still conducted.

Re: [ovs-dev] [BUG][revalidator] ovs crash and could NOT fix again after set request_mtu

2024-06-02 Thread Simon Jones
In ovs code, bridge_reconfigure function should ONLY be called in ovs-vswitchd thread. But how about this case: - ovs-vswitchd is starting, the ovs-vswitch thread calls bridge_reconfigure function. - at the same time, ovs-vsctl set port xxx request_mtu=4800 comes to ovs-vswitchd thread. - the ovs-

Re: [ovs-dev] [PATCH v2 2/2] ipf: Handle common case of ipf defragmentation.

2024-06-02 Thread Paolo Valerio
Mike Pattrick writes: > When conntrack is reassembling packet fragments, the same reassembly > context can be shared across multiple threads handling different packets > simultaneously. Once a full packet is assembled, it is added to a packet > batch for processing, in the case where there are mu

Re: [ovs-dev] [PATCH v2 1/2] ipf: Only add fragments to batch of same dl_type.

2024-06-02 Thread Paolo Valerio
Mike Pattrick writes: > When conntrack is reassembling packet fragments, the same reassembly > context can be shared across multiple threads handling different packets > simultaneously. Once a full packet is assembled, it is added to a packet > batch for processing, this is most likely the batch