Re: [ovs-dev] [PATCH ovn v1] controller: Fix issue with ct_commit encode.

2024-06-10 Thread Dumitru Ceara
On 6/11/24 00:07, Dumitru Ceara wrote: > On 6/10/24 18:05, martin.kal...@canonical.com wrote: >> On Mon, 2024-06-10 at 12:54 +, Naveen Yerramneni wrote: >>> Action length is getting set incorrectly during ct_commit encode >>> due to which ct action is getting skipped  during phsycial flows >>>

Re: [ovs-dev] [PATCH] appveyor: Fix caching of OpenSSL installer.

2024-06-10 Thread Alin Serdean
Acked-by: Alin-Gabriel Serdean On Mon, Jun 10, 2024 at 11:18 PM Ilya Maximets wrote: > Apparently, if the cache dependency is specified, the cache folder > is not checked at the end of a build and so the cache is never > updated unless we change appveyor.yml. This makes the cache to not > actu

Re: [ovs-dev] [PATCH ovn v1] controller: Fix issue with ct_commit encode.

2024-06-10 Thread Dumitru Ceara
On 6/10/24 18:05, martin.kal...@canonical.com wrote: > On Mon, 2024-06-10 at 12:54 +, Naveen Yerramneni wrote: >> Action length is getting set incorrectly during ct_commit encode >> due to which ct action is getting skipped  during phsycial flows >> creation. This issue is noticed only if ct_co

[ovs-dev] [PATCH] appveyor: Fix caching of OpenSSL installer.

2024-06-10 Thread Ilya Maximets
Apparently, if the cache dependency is specified, the cache folder is not checked at the end of a build and so the cache is never updated unless we change appveyor.yml. This makes the cache to not actually work, because on each build we discover that the installer is outdated, download the new one

Re: [ovs-dev] [PATCH ovn v1] controller: Fix issue with ct_commit encode.

2024-06-10 Thread martin . kalcok
On Mon, 2024-06-10 at 12:54 +, Naveen Yerramneni wrote: > Action length is getting set incorrectly during ct_commit encode > due to which ct action is getting skipped  during phsycial flows > creation. This issue is noticed only if ct_commit is prefixed > with other actions. > > logical flow:

Re: [ovs-dev] [PATCH net-next v2 5/9] net: openvswitch: add emit_sample action

2024-06-10 Thread Aaron Conole
Adrian Moreno writes: > Add support for a new action: emit_sample. > > This action accepts a u32 group id and a variable-length cookie and uses > the psample multicast group to make the packet available for > observability. > > The maximum length of the user-defined cookie is set to 16, same as >

Re: [ovs-dev] [PATCH v2] checkpatch: Extend and move extra_keywords list to file.

2024-06-10 Thread Ilya Maximets
On 6/10/24 16:55, Aaron Conole wrote: > Eelco Chaudron writes: > >> On 7 Jun 2024, at 15:46, Mike Pattrick wrote: >> >>> On Fri, Jun 7, 2024 at 2:35 AM Eelco Chaudron wrote: On 6 Jun 2024, at 3:07, Mike Pattrick wrote: > This patch extends the extra_keywords list fro

Re: [ovs-dev] [PATCH v2] checkpatch: Don't warn on pointer to pointer.

2024-06-10 Thread Aaron Conole
Aaron Conole writes: > Adrian Moreno writes: > >> Current regexp used to check whitespaces around operators does not >> consider that there can be more than one "*" together to express pointer >> to pointer. >> >> As a result, false positive warnings are raised when the >> patch contains a simpl

Re: [ovs-dev] [PATCH v2] checkpatch: Extend and move extra_keywords list to file.

2024-06-10 Thread Aaron Conole
Eelco Chaudron writes: > On 7 Jun 2024, at 15:46, Mike Pattrick wrote: > >> On Fri, Jun 7, 2024 at 2:35 AM Eelco Chaudron wrote: >>> >>> >>> >>> On 6 Jun 2024, at 3:07, Mike Pattrick wrote: >>> This patch extends the extra_keywords list from 324 to 747 keywords and moves this list to a

Re: [ovs-dev] [PATCH v2] checkpatch: Don't warn on pointer to pointer.

2024-06-10 Thread Aaron Conole
Adrian Moreno writes: > Current regexp used to check whitespaces around operators does not > consider that there can be more than one "*" together to express pointer > to pointer. > > As a result, false positive warnings are raised when the > patch contains a simple list of pointers, e.g: "char *

[ovs-dev] [PATCH ovn v1] controller: Fix issue with ct_commit encode.

2024-06-10 Thread Naveen Yerramneni
Action length is getting set incorrectly during ct_commit encode due to which ct action is getting skipped during phsycial flows creation. This issue is noticed only if ct_commit is prefixed with other actions. logical flow: reg8[17] = 1; ct_commit { ct_mark.blocked = 1; }; without fix: encodes a

Re: [ovs-dev] [PATCH] dpif-netdev: Disable XPS (Transmit Packet Steering) for non-pmd ports.

2024-06-10 Thread Ilya Maximets
On 6/9/24 12:16, Roi Dayan via dev wrote: > From: Eli Britstein > > In the cited commit, XPS was introduced. It is NA for non-pmd ports. > Upon port creation it is indeed disabled, but at port reconfigure, the > condition of netdev_is_pmd() is missing. > As a result, XPS is configured, and such m

Re: [ovs-dev] [PATCH ovn] controller: Fix issue with ct_commit encode.

2024-06-10 Thread Ales Musil
On Mon, Jun 10, 2024 at 2:29 PM Naveen Yerramneni < naveen.yerramn...@nutanix.com> wrote: > > > > On 10 Jun 2024, at 5:02 PM, Ales Musil wrote: > > > > CAUTION: External Email > > > > > > On Mon, Jun 10, 2024 at 10:30 AM Naveen Yerramneni < > naveen.yerramn...@nutanix.com> wrote: > > Action lengt

Re: [ovs-dev] [PATCH ovn] controller: Fix issue with ct_commit encode.

2024-06-10 Thread Naveen Yerramneni
> On 10 Jun 2024, at 5:02 PM, Ales Musil wrote: > > CAUTION: External Email > > > On Mon, Jun 10, 2024 at 10:30 AM Naveen Yerramneni > wrote: > Action length is getting set incorrectly during ct_commit encode > due to which ct action is getting skipped during phsycial flows > creation. Thi

Re: [ovs-dev] [PATCH ovn] controller: Fix issue with ct_commit encode.

2024-06-10 Thread Ales Musil
On Mon, Jun 10, 2024 at 10:30 AM Naveen Yerramneni < naveen.yerramn...@nutanix.com> wrote: > Action length is getting set incorrectly during ct_commit encode > due to which ct action is getting skipped during phsycial flows > creation. This issue is noticed only if ct_commit is prefixed > with ot

Re: [ovs-dev] [PATCH net-next v2 9/9] selftests: openvswitch: add emit_sample test

2024-06-10 Thread Adrián Moreno
On Wed, Jun 05, 2024 at 08:43:14PM GMT, Simon Horman wrote: > On Mon, Jun 03, 2024 at 08:56:43PM +0200, Adrian Moreno wrote: > > Add a test to verify sampling packets via psample works. > > > > In order to do that, create a subcommand in ovs-dpctl.py to listen to > > on the psample multicast group

Re: [ovs-dev] [BUG][revalidator] ovs crash and could NOT fix again after set request_mtu

2024-06-10 Thread Adrián Moreno
On Mon, Jun 03, 2024 at 10:18:05AM GMT, Simon Jones wrote: > In ovs code, bridge_reconfigure function should ONLY be called in > ovs-vswitchd thread. > > But how about this case: > - ovs-vswitchd is starting, the ovs-vswitch thread calls bridge_reconfigure > function. > - at the same time, ovs-vsct

[ovs-dev] [PATCH ovn] controller: Fix issue with ct_commit encode.

2024-06-10 Thread Naveen Yerramneni
Action length is getting set incorrectly during ct_commit encode due to which ct action is getting skipped during phsycial flows creation. This issue is noticed only if ct_commit is prefixed with other actions. Logical Flows = uuid=0xb4afcd34, table=8 (ls_in_acl_eval ), priority=2

Re: [ovs-dev] [PATCH ovn 0/8] Flaky tests fixes and tests cleanup.

2024-06-10 Thread Ales Musil
On Tue, Jun 4, 2024 at 3:11 PM Xavier Simonart wrote: > Xavier Simonart (8): > tests: Cleanup on_exit commands. > tests: Fixed "lflow cache operations". > tests: Fixed flaky "Logical router IP for NAT". > tests: Fixed flaky "NB_Global and SB_Global I+P". > tests: Fixed multiple flaky te