[ovs-dev] [PATCH ovn v5 2/2] pinctrl: Handle arp/nd for other address families.

2024-06-11 Thread Felix Huettner via dev
Previously we could only generate ARP requests from IPv4 packets and NS requests from IPv6 packets. This was the case because we rely on information in the packet to generate the ARP/NS requests. However in case of ARP/NS requests originating from the Logical_Router pipeline for nexthop lookups we

[ovs-dev] [PATCH ovn v5 1/2] northd: Handle routing for other address families.

2024-06-11 Thread Felix Huettner via dev
In most cases IPv4 packets are routed only over other IPv4 networks and IPv6 packets are routed only over IPv6 networks. However there is no inherent reason for this limitation. Routing IPv4 packets over IPv6 networks just requires the router to contain a route for an IPv4 network with an IPv6 next

Re: [ovs-dev] [PATCH net-next v2 5/9] net: openvswitch: add emit_sample action

2024-06-11 Thread Adrián Moreno
On Tue, Jun 11, 2024 at 09:54:49AM GMT, Aaron Conole wrote: > Adrián Moreno writes: > > > On Mon, Jun 10, 2024 at 11:46:14AM GMT, Aaron Conole wrote: > >> Adrian Moreno writes: > >> > >> > Add support for a new action: emit_sample. > >> > > >> > This action accepts a u32 group id and a variable-l

Re: [ovs-dev] [PATCH ovn v4 1/2] northd: Handle routing for other address families.

2024-06-11 Thread 0-day Robot
Bleep bloop. Greetings Felix Huettner, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: Failed to merge in the changes. hint: Use 'git am --show-current-patch=diff' to see the fa

[ovs-dev] [PATCH ovn v4 2/2] pinctrl: Handle arp/nd for other address families.

2024-06-11 Thread Felix Huettner via dev
Previously we could only generate ARP requests from IPv4 packets and NS requests from IPv6 packets. This was the case because we rely on information in the packet to generate the ARP/NS requests. However in case of ARP/NS requests originating from the Logical_Router pipeline for nexthop lookups we

[ovs-dev] [PATCH ovn v4 1/2] northd: Handle routing for other address families.

2024-06-11 Thread Felix Huettner via dev
In most cases IPv4 packets are routed only over other IPv4 networks and IPv6 packets are routed only over IPv6 networks. However there is no inherent reason for this limitation. Routing IPv4 packets over IPv6 networks just requires the router to contain a route for an IPv4 network with an IPv6 next

Re: [ovs-dev] [PATCH net-next 2/2] selftests: openvswitch: set value to nla flags

2024-06-11 Thread Adrián Moreno
On Mon, Jun 03, 2024 at 03:02:46PM GMT, Aaron Conole wrote: > Adrian Moreno writes: > > > Netlink flags, although they don't have payload at the netlink level, > > are represented as having a "True" value in pyroute2. > > > > Without it, trying to add a flow with a flag-type action (e.g: pop_vlan)

Re: [ovs-dev] [PATCH net-next 1/2] selftests: openvswitch: fix action formatting

2024-06-11 Thread Aaron Conole
Adrián Moreno writes: > On Mon, Jun 03, 2024 at 03:00:03PM GMT, Aaron Conole wrote: >> Adrian Moreno writes: >> >> > In the action formatting function ("dpstr"), the iteration is made over >> > the nla_map, so if there are more than one attribute from the same type >> > we only print the first o

Re: [ovs-dev] [PATCH v2 2/2] ipf: Handle common case of ipf defragmentation.

2024-06-11 Thread Aaron Conole
Ilya Maximets writes: > On 6/5/24 16:54, Aaron Conole wrote: >> Mike Pattrick writes: >> >>> When conntrack is reassembling packet fragments, the same reassembly >>> context can be shared across multiple threads handling different packets >>> simultaneously. Once a full packet is assembled, it

Re: [ovs-dev] [PATCH net-next v2 5/9] net: openvswitch: add emit_sample action

2024-06-11 Thread Aaron Conole
Adrián Moreno writes: > On Mon, Jun 10, 2024 at 11:46:14AM GMT, Aaron Conole wrote: >> Adrian Moreno writes: >> >> > Add support for a new action: emit_sample. >> > >> > This action accepts a u32 group id and a variable-length cookie and uses >> > the psample multicast group to make the packet a

[ovs-dev] [BUG][meter] ovs crash when add meter openflow

2024-06-11 Thread Simon Jones
Hi all, I'm using ovs-dpdk with this patch: ``` commit 4c226944f7c55c9d6e7c85f7c33c5ce11c35ce54 Author: Jianbo Liu Date: Fri Jul 8 03:06:26 2022 + netdev-offload-tc: Implement meter offload API for tc ``` This patch is for offload flow meter by tc. Now I found a bug: ovs crash when ad

Re: [ovs-dev] [PATCH net-next v2 5/9] net: openvswitch: add emit_sample action

2024-06-11 Thread Adrián Moreno
On Mon, Jun 10, 2024 at 11:46:14AM GMT, Aaron Conole wrote: > Adrian Moreno writes: > > > Add support for a new action: emit_sample. > > > > This action accepts a u32 group id and a variable-length cookie and uses > > the psample multicast group to make the packet available for > > observability.

Re: [ovs-dev] [PATCH ovn v1] controller: Fix issue with ct_commit encode.

2024-06-11 Thread Martin Kalcok
> On 11 Jun 2024, at 00:07, Dumitru Ceara wrote: > > On 6/10/24 18:05, martin.kal...@canonical.com > wrote: >> On Mon, 2024-06-10 at 12:54 +, Naveen Yerramneni wrote: >>> Action length is getting set incorrectly during ct_commit encode >>> due to which