Re: [ovs-dev] [PATCH net-next 3/3] openvswitch: set IPS_CONFIRMED in tmpl status only when commit is set in conntrack

On 7/16/23 23:09, Xin Long wrote: > By not setting IPS_CONFIRMED in tmpl that allows the exp not to be removed > from the hashtable when lookup, we can simplify the exp processing code a > lot in openvswitch conntrack. > > Signed-off-by: Xin Long > --- > net/openvswitch/conntrack.c | 78

Re: [ovs-dev] [PATCH net-next 6/7] selftests: net: Use the provided dpctl rather than the vswitchd for tests.

On Mon, 17 Jun 2024 14:02:17 -0400 Aaron Conole wrote: > The current pmtu test infrastucture requires an installed copy of the > ovs-vswitchd userspace. This means that any automated or constrained > environments may not have the requisite tools to run the tests. However, > the pmtu tests

Re: [ovs-dev] [PATCH ovn] controller: Send RARP/GARP for VIF post link state is up.

Thanks Shibir, I merged this to main, branch-24.03, and branch-23.09. On 5/27/24 14:24, Shibir Basak wrote: Currently, GARP/RARP broadcast is sent for VIFs (part of logical switch with localnet port) after iface-id is set. This fix is to avoid packet loss during migration if iface-id is set

Re: [ovs-dev] [PATCH ovn v2 0/3] Arbitrary match for NAT

I pushed this series to main. I also added a fourth commit that adds a note to NEWS about conditional NAT. On 5/29/24 11:56, Ales Musil wrote: This series adds the ability to have extra match per NAT, this allows the CMS to have more fine-grained control over the NAT action. At the same time

[ovs-dev] [PATCH net-next 7/7] selftests: net: add config for openvswitch

The pmtu testing will require that the OVS module is installed, so do that. Reviewed-by: Simon Horman Tested-by: Simon Horman Signed-off-by: Aaron Conole --- tools/testing/selftests/net/config | 5 + 1 file changed, 5 insertions(+) diff --git a/tools/testing/selftests/net/config

[ovs-dev] [PATCH net-next 6/7] selftests: net: Use the provided dpctl rather than the vswitchd for tests.

The current pmtu test infrastucture requires an installed copy of the ovs-vswitchd userspace. This means that any automated or constrained environments may not have the requisite tools to run the tests. However, the pmtu tests don't require any special classifier processing. Indeed they are

[ovs-dev] [PATCH net-next 5/7] selftests: openvswitch: Support implicit ipv6 arguments.

The current iteration of IPv6 support requires explicit fields to be set in addition to not properly support the actual IPv6 addresses properly. With this change, make it so that the ipv6() bare option is usable to create wildcarded flows to match broad swaths of ipv6 traffic. Reviewed-by: Simon

[ovs-dev] [PATCH net-next 4/7] selftests: openvswitch: Add support for tunnel() key.

This will be used when setting details about the tunnel to use as transport. There is a difference between the ODP format between tunnel(): the 'key' flag is not actually a flag field, so we don't support it in the same way that the vswitchd userspace supports displaying it. Signed-off-by: Aaron

[ovs-dev] [PATCH net-next 3/7] selftests: openvswitch: Add set() and set_masked() support.

These will be used in upcoming commits to set specific attributes for interacting with tunnels. Since set() will use the key parsing routine, we also make sure to prepend it with an open paren, for the action parsing to properly understand it. Reviewed-by: Simon Horman Tested-by: Simon Horman

[ovs-dev] [PATCH net-next 1/7] selftests: openvswitch: Support explicit tunnel port creation.

The OVS module can operate in conjunction with various types of tunnel ports. These are created as either explicit tunnel vport types, OR by creating a tunnel interface which acts as an anchor for the lightweight tunnel support. This patch adds the ability to add tunnel ports to an OVS datapath

[ovs-dev] [PATCH net-next 2/7] selftests: openvswitch: Refactor actions parsing.

Until recently, the ovs-dpctl utility was used with a limited actions set and didn't need to have support for multiple similar actions. However, when adding support for tunnels, it will be important to support multiple set() actions in a single flow. When printing these actions, the existing

[ovs-dev] [PATCH net-next 0/7] selftests: net: Switch pmtu.sh to use the internal ovs script.

Currently, if a user wants to run pmtu.sh and cover all the provided test cases, they need to install the Open vSwitch userspace utilities. This dependency is difficult for users as well as CI environments, because the userspace build and setup may require lots of support and devel packages to be

Re: [ovs-dev] [RFC net-next 4/7] selftests: openvswitch: Add support for tunnel() key.

Simon Horman writes: > On Thu, Jun 13, 2024 at 02:13:30PM -0400, Aaron Conole wrote: >> This will be used when setting details about the tunnel to use as >> transport. There is a difference between the ODP format between tunnel(): >> the 'key' flag is not actually a flag field, so we don't

Re: [ovs-dev] [PATCH v2] ovsdb: Use table indexes if available for ovsdb_query().

On Mon, Jun 17, 2024 at 12:54 PM Mike Pattrick wrote: > > Currently all OVSDB database queries except for UUID lookups all result > in linear lookups over the entire table, even if an index is present. > > This patch modifies ovsdb_query() to attempt an index lookup first, if > possible. If no

Re: [ovs-dev] [PATCH v2] ovsdb: Use table indexes if available for ovsdb_query().

On Mon, Jun 3, 2024 at 2:01 PM Ilya Maximets wrote: > > On 6/3/24 06:20, Mike Pattrick wrote: > > Currently all OVSDB database queries except for UUID lookups all result > > in linear lookups over the entire table, even if an index is present. > > > > This patch modifies ovsdb_query() to attempt

Re: [ovs-dev] [RFC net-next 3/7] selftests: openvswitch: Add set() and set_masked() support.

Adrián Moreno writes: > On Thu, Jun 13, 2024 at 02:13:29PM GMT, Aaron Conole wrote: >> These will be used in upcoming commits to set specific attributes for >> interacting with tunnels. Since set() will use the key parsing routine, we >> also make sure to prepend it with an open paren, for the

Re: [ovs-dev] [RFC net-next 5/7] selftests: openvswitch: Support implicit ipv6 arguments.

Simon Horman writes: > On Thu, Jun 13, 2024 at 02:13:31PM -0400, Aaron Conole wrote: >> The current iteration of IPv6 support requires explicit fields to be set >> in addition to not properly support the actual IPv6 addresses properly. >> With this change, make it so that the ipv6() bare option

Re: [ovs-dev] [RFC net-next 1/7] selftests: openvswitch: Support explicit tunnel port creation.

Simon Horman writes: > On Thu, Jun 13, 2024 at 02:13:27PM -0400, Aaron Conole wrote: >> The OVS module can operate in conjunction with various types of >> tunnel ports. These are created as either explicit tunnel vport >> types, OR by creating a tunnel interface which acts as an anchor >> for

[ovs-dev] [PATCH v2] ovsdb: Use table indexes if available for ovsdb_query().

Currently all OVSDB database queries except for UUID lookups all result in linear lookups over the entire table, even if an index is present. This patch modifies ovsdb_query() to attempt an index lookup first, if possible. If no matching indexes are present then a linear index is still conducted.

Re: [ovs-dev] [PATCH] odp-execute: Set IPv6 traffic class in AVX implementation.

> -Original Message- > From: Mike Pattrick > Sent: Thursday, June 13, 2024 6:53 PM > To: Finn, Emma > Cc: ovs-dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH] odp-execute: Set IPv6 traffic class in AVX > implementation. > > On Wed, Jun 12, 2024 at 6:44 AM Emma Finn wrote: > > > >

[ovs-dev] [v2] odp-execute: Check IPv4 checksum offload flag in AVX.

The AVX implementation for IPv4 action did not check whether the IPv4 checksum offload flag has been set and was incorrectly calculating checksums in software. Adding a check to skip AVX checksum calculation when offload flags are set. Signed-off-by: Emma Finn Reported-by: Eelco Chaudron ---

Re: [ovs-dev] [PATCH net] selftests: openvswitch: Use bash as interpreter

On 6/17/24 10:28, Simon Horman wrote: openvswitch.sh makes use of substitutions of the form ${ns:0:1}, to obtain the first character of $ns. Empirically, this is works with bash but not dash. When run with dash these evaluate to an empty string and printing an error to stdout. # dash -c

Re: [ovs-dev] [RFC net-next 3/7] selftests: openvswitch: Add set() and set_masked() support.

On Thu, Jun 13, 2024 at 02:13:29PM GMT, Aaron Conole wrote: > These will be used in upcoming commits to set specific attributes for > interacting with tunnels. Since set() will use the key parsing routine, we > also make sure to prepend it with an open paren, for the action parsing to > properly

Re: [ovs-dev] [PATCH net-next v2 7/9] net: openvswitch: do not notify drops inside sample

On 6/17/24 13:55, Ilya Maximets wrote: > On 6/3/24 20:56, Adrian Moreno wrote: >> The OVS_ACTION_ATTR_SAMPLE action is, in essence, >> observability-oriented. >> >> Apart from some corner case in which it's used a replacement of clone() >> for old kernels, it's really only used for sFlow, IPFIX

Re: [ovs-dev] [PATCH net-next v2 7/9] net: openvswitch: do not notify drops inside sample

On 6/3/24 20:56, Adrian Moreno wrote: > The OVS_ACTION_ATTR_SAMPLE action is, in essence, > observability-oriented. > > Apart from some corner case in which it's used a replacement of clone() > for old kernels, it's really only used for sFlow, IPFIX and now, > local emit_sample. > > With this in

Re: [ovs-dev] [PATCH net-next v2 6/9] net: openvswitch: store sampling probability in cb.

On 6/17/24 09:08, Adrián Moreno wrote: > On Fri, Jun 14, 2024 at 12:55:59PM GMT, Aaron Conole wrote: >> Adrian Moreno writes: >> >>> The behavior of actions might not be the exact same if they are being >>> executed inside a nested sample action. Store the probability of the >>> parent sample

Re: [ovs-dev] [PATCH net-next v2 5/9] net: openvswitch: add emit_sample action

On 6/3/24 20:56, Adrian Moreno wrote: > Add support for a new action: emit_sample. > > This action accepts a u32 group id and a variable-length cookie and uses > the psample multicast group to make the packet available for > observability. > > The maximum length of the user-defined cookie is set

Re: [ovs-dev] [PATCH net] selftests: openvswitch: Use bash as interpreter

On Mon, Jun 17, 2024 at 12:05:11PM +0200, Przemek Kitszel wrote: > On 6/17/24 10:28, Simon Horman wrote: > > openvswitch.sh makes use of substitutions of the form ${ns:0:1}, to > > obtain the first character of $ns. Empirically, this is works with bash > > but not dash. When run with dash these

Re: [ovs-dev] [PATCH net-next v2 4/9] net: psample: allow using rate as probability

On Mon, Jun 17, 2024 at 06:32:14AM +, Adrián Moreno wrote: > On Fri, Jun 14, 2024 at 05:11:30PM GMT, Simon Horman wrote: > > On Mon, Jun 03, 2024 at 08:56:38PM +0200, Adrian Moreno wrote: > > > Although not explicitly documented in the psample module itself, the > > > definition of

Re: [ovs-dev] [BUG][meter] ovs crash when add meter openflow

It's PR: Bugfix of meter_set crash. by batmancn · Pull Request #425 · openvswitch/ovs (github.com) Simon Jones Simon Jones 于2024年6月17日周一 15:35写道： > This patch: > ``` > $ git diff > diff --git a/lib/netdev-offload-tc.c

Re: [ovs-dev] [PATCH net-next v2 2/9] net: sched: act_sample: add action cookie to sample

On 6/3/24 20:56, Adrian Moreno wrote: > If the action has a user_cookie, pass it along to the sample so it can > be easily identified. > > Signed-off-by: Adrian Moreno > --- > net/sched/act_sample.c | 12 > 1 file changed, 12 insertions(+) > > diff --git a/net/sched/act_sample.c

Re: [ovs-dev] [PATCH ovn] controller: Send RARP/GARP for VIF post link state is up.

Hi Mark, In case we are not waiting to batch any other patches, can we merge this? Thanks, Shibir From: Mark Michelson Date: Friday, 7 June 2024 at 1:54 AM To: Shibir Basak , d...@openvswitch.org Subject: Re: [ovs-dev] [PATCH ovn] controller: Send RARP/GARP for VIF post link state is up.

[ovs-dev] [PATCH net] selftests: openvswitch: Use bash as interpreter

openvswitch.sh makes use of substitutions of the form ${ns:0:1}, to obtain the first character of $ns. Empirically, this is works with bash but not dash. When run with dash these evaluate to an empty string and printing an error to stdout. # dash -c 'ns=client; echo "${ns:0:1}"' 2>error # cat

Re: [ovs-dev] [PATCH v3] netdev-dpdk: Use LSC interrupt mode.

On Mon, Jun 17, 2024 at 10:11 AM Ilya Maximets wrote: > > On 6/17/24 09:46, David Marchand wrote: > > On Fri, Jun 14, 2024 at 6:22 PM Ilya Maximets wrote: > >>> diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c > >>> index 0fa37d5145..a260bc8485 100644 > >>> --- a/lib/netdev-dpdk.c > >>> +++

Re: [ovs-dev] [PATCH v3] netdev-dpdk: Use LSC interrupt mode.

On 6/17/24 09:46, David Marchand wrote: > On Fri, Jun 14, 2024 at 6:22 PM Ilya Maximets wrote: >>> diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c >>> index 0fa37d5145..a260bc8485 100644 >>> --- a/lib/netdev-dpdk.c >>> +++ b/lib/netdev-dpdk.c >>> @@ -2397,7 +2397,18 @@

Re: [ovs-dev] [PATCH v3] netdev-dpdk: Use LSC interrupt mode.

On Fri, Jun 14, 2024 at 6:22 PM Ilya Maximets wrote: > > diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c > > index 0fa37d5145..a260bc8485 100644 > > --- a/lib/netdev-dpdk.c > > +++ b/lib/netdev-dpdk.c > > @@ -2397,7 +2397,18 @@ netdev_dpdk_set_config(struct netdev *netdev, const > > struct

Re: [ovs-dev] [BUG][meter] ovs crash when add meter openflow

This patch: ``` $ git diff diff --git a/lib/netdev-offload-tc.c b/lib/netdev-offload-tc.c index b000aeea8..74fd7c11b 100644 --- a/lib/netdev-offload-tc.c +++ b/lib/netdev-offload-tc.c @@ -86,6 +86,8 @@ static struct hmap meter_id_to_police_idx OVS_GUARDED_BY(meter_mutex) =

Re: [ovs-dev] [BUG][meter] ovs crash when add meter openflow

I use this patch to try to fix BUG, I test several times, it's OK ``` [root@bogon yusur_ovs]# git diff diff --git a/lib/netdev-offload-tc.c b/lib/netdev-offload-tc.c index b000aee..3330cb2 100644 --- a/lib/netdev-offload-tc.c +++ b/lib/netdev-offload-tc.c @@ -86,6 +86,8 @@ static struct hmap

Re: [ovs-dev] [PATCH ovn v3 4/4] controller, northd: Add support for CT zone limits.

Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 84 characters long (recommended limit is 79) #497 FILE: ovn-nb.xml:726:

Re: [ovs-dev] [PATCH ovn v3 1/4] controller: Move CT zone handling into separate module.

Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Comment with 'xxx' marker #190 FILE: controller/ct-zone.c:146: /* XXX Add

Re: [ovs-dev] [PATCH net-next v2 9/9] selftests: openvswitch: add emit_sample test

On Fri, Jun 14, 2024 at 01:07:33PM GMT, Aaron Conole wrote: > Adrian Moreno writes: > > > Add a test to verify sampling packets via psample works. > > > > In order to do that, create a subcommand in ovs-dpctl.py to listen to > > on the psample multicast group and print samples. > > > > In order

Re: [ovs-dev] [PATCH net-next v2 6/9] net: openvswitch: store sampling probability in cb.

On Fri, Jun 14, 2024 at 12:55:59PM GMT, Aaron Conole wrote: > Adrian Moreno writes: > > > The behavior of actions might not be the exact same if they are being > > executed inside a nested sample action. Store the probability of the > > parent sample action in the skb's cb area. > > What does

[ovs-dev] [PATCH ovn v3 4/4] controller, northd: Add support for CT zone limits.

Add support for limiting the CT zone usage per Ls, LR or LSP. When the limit is configured on logical switch it will also implicitly set limits for all ports in that logical switch. The port configuration can be overwritten individually and has priority over the whole logical switch configuration.

[ovs-dev] [PATCH ovn v3 3/4] controller: Prepare structure around CT zone limiting.

In order to be able to store CT limits for specified zone, store the zone inside separate struct instead of simap. This allows to add the addition of limit without changing the whole infrastructure again. This is a preparation step for the CT zone limits. Signed-off-by: Ales Musil --- v3:

[ovs-dev] [PATCH ovn v3 1/4] controller: Move CT zone handling into separate module.

Move the CT zone handling specific bits into its own module. This allows for easier changes done within the module and separates the logic that is unrelated from ovn-controller. Signed-off-by: Ales Musil --- v3: Rebase on top of latest main. --- controller/automake.mk | 4 +-

[ovs-dev] [PATCH ovn v3 2/4] controller: Further encapsulate the CT zone handling.

Move more code into the new ct-zone module and encapsulate functionality that is strictly related to CT zone handling. Signed-off-by: Ales Musil --- v3: Rebase on top of latest main. --- controller/ct-zone.c| 156 +--- controller/ct-zone.h| 8 +-

[ovs-dev] [PATCH ovn v3 0/4] Add ability to limit CT entries per LS/LR/LSP

Add ability that allows to set CT limits per logical switch, logical router or logical switch port. When the limit is applied to logical switch it will be implicitly set for all logical ports in the logical switch. This can be overwritten individually per port. To achieve this there is a small

Re: [ovs-dev] [PATCH net-next v2 4/9] net: psample: allow using rate as probability

On Fri, Jun 14, 2024 at 05:11:30PM GMT, Simon Horman wrote: > On Mon, Jun 03, 2024 at 08:56:38PM +0200, Adrian Moreno wrote: > > Although not explicitly documented in the psample module itself, the > > definition of PSAMPLE_ATTR_SAMPLE_RATE seems inherited from act_sample. > > > > Quoting