David Marchand writes:
> Querying link status may get delayed for an undeterministic (long) time
> with mlx5 ports. This is a consequence of the mlx5 driver calling ethtool
> kernel API and getting stuck on the kernel RTNL lock while some other
> operation is in progress under this lock.
>
> One
Xin Long writes:
> Ilya found a failure in running check-kernel tests with at_groups=144
> (144: conntrack - FTP SNAT orig tuple) in OVS repo. After his further
> investigation, the root cause is that the labels sent to userspace
> for related ct are incorrect.
>
> The labels for unconfirmed
Grigorii Nazarov writes:
> Signed-off-by: Grigorii Nazarov
> ---
There's only one user left in tree. Maybe it makes sense to remove
this? Or at least mark it deprecated or something? It is used quite a
bit in OVN project. It doesn't seem like it is worth the overhead of
the extra function
Grigorii Nazarov writes:
> Signed-off-by: Grigorii Nazarov
> ---
Why is this file existing? Maybe it would be better to generate the
compile_commands.json in automake? Or generate it via the makefile?
> .gitignore | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/.gitignore
On Mon, Jun 17, 2024 at 10:08 AM Emma Finn wrote:
>
> The AVX implementation for IPv4 action did not check whether
> the IPv4 checksum offload flag has been set and was incorrectly
> calculating checksums in software. Adding a check to skip AVX
> checksum calculation when offload flags are set.
>
On 6/20/24 00:08, Xin Long wrote:
> Ilya found a failure in running check-kernel tests with at_groups=144
> (144: conntrack - FTP SNAT orig tuple) in OVS repo. After his further
> investigation, the root cause is that the labels sent to userspace
> for related ct are incorrect.
>
> The labels for
The DPDK was built as extra step in the CI, however it is useful to
have it inside the container prepared. This also helps with
reproduction of failures with DPDK by having the exact version inside
the container already.
Also bump the Ubuntu version for container builds to 24.04 to get
Podman 4.
Move common preparation steps into script that can be invoked by both
container builds. This will ensure that any update will be reflected
in both containers, and it reduces the duplication between both
containers.
Signed-off-by: Ales Musil
---
utilities/automake.mk | 1 +
The pmtu testing will require that the OVS module is installed,
so do that.
Reviewed-by: Simon Horman
Tested-by: Simon Horman
Signed-off-by: Aaron Conole
---
tools/testing/selftests/net/config | 5 +
1 file changed, 5 insertions(+)
diff --git a/tools/testing/selftests/net/config
The current pmtu test infrastucture requires an installed copy of the
ovs-vswitchd userspace. This means that any automated or constrained
environments may not have the requisite tools to run the tests. However,
the pmtu tests don't require any special classifier processing. Indeed
they are
This will be used when setting details about the tunnel to use as
transport. There is a difference between the ODP format between tunnel():
the 'key' flag is not actually a flag field, so we don't support it in the
same way that the vswitchd userspace supports displaying it.
Signed-off-by: Aaron
The current iteration of IPv6 support requires explicit fields to be set
in addition to not properly support the actual IPv6 addresses properly.
With this change, make it so that the ipv6() bare option is usable to
create wildcarded flows to match broad swaths of ipv6 traffic.
Reviewed-by: Simon
These will be used in upcoming commits to set specific attributes for
interacting with tunnels. Since set() will use the key parsing routine, we
also make sure to prepend it with an open paren, for the action parsing to
properly understand it.
Reviewed-by: Simon Horman
Tested-by: Simon Horman
The OVS module can operate in conjunction with various types of
tunnel ports. These are created as either explicit tunnel vport
types, OR by creating a tunnel interface which acts as an anchor
for the lightweight tunnel support.
This patch adds the ability to add tunnel ports to an OVS
datapath
Until recently, the ovs-dpctl utility was used with a limited actions set
and didn't need to have support for multiple similar actions. However,
when adding support for tunnels, it will be important to support multiple
set() actions in a single flow. When printing these actions, the existing
Currently, if a user wants to run pmtu.sh and cover all the provided test
cases, they need to install the Open vSwitch userspace utilities. This
dependency is difficult for users as well as CI environments, because the
userspace build and setup may require lots of support and devel packages
to be
Bleep bloop. Greetings Grigorii Nazarov, I am a robot and I have tried out
your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: The subject summary should start with a capital.
WARNING: The subject summary
Bleep bloop. Greetings Grigorii Nazarov, I am a robot and I have tried out
your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: The subject summary should start with a capital.
WARNING: The subject summary
Bleep bloop. Greetings Grigorii Nazarov, I am a robot and I have tried out
your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: The subject summary should start with a capital.
WARNING: The subject summary
Bleep bloop. Greetings Grigorii Nazarov, I am a robot and I have tried out
your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: The subject summary should start with a capital.
WARNING: The subject summary
Currently serialization is performed by first converting
the internal data representation into JSON objects, followed by
serializing these objects by jsonrpc. This process results in lots of
allocations for these intermediate objects. Consequently, this
not only increases peak memory consumption,
Signed-off-by: Grigorii Nazarov
---
.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/.gitignore b/.gitignore
index 26ed8d3d0..3c7250159 100644
--- a/.gitignore
+++ b/.gitignore
@@ -79,3 +79,4 @@ testsuite.tmp.orig
/Documentation/_build
/.venv
/cxx-check
+/compile_flags.txt
--
Signed-off-by: Grigorii Nazarov
---
lib/json.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/lib/json.c b/lib/json.c
index 001f6e6ab..d40e93857 100644
--- a/lib/json.c
+++ b/lib/json.c
@@ -127,7 +127,9 @@ static void json_parser_input(struct json_parser *,
Signed-off-by: Grigorii Nazarov
---
lib/ovsdb-data.c | 8 +---
lib/uuid.h | 1 +
2 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/lib/ovsdb-data.c b/lib/ovsdb-data.c
index abb923ad8..defb048d7 100644
--- a/lib/ovsdb-data.c
+++ b/lib/ovsdb-data.c
@@ -2582,14 +2582,8 @@
On 5 Jun 2024, at 22:23, Adrian Moreno wrote:
> (Was: Add psample support to NXAST_SAMPLE action)
>
> This is the userspace counterpart of the work being done in the kernel
> [1] which is still not merged (hence the RFC state). There, a new
> datapath action is added, called "emit_sample".
On 20 Jun 2024, at 13:01, Finn, Emma wrote:
>> -Original Message-
>> From: Eelco Chaudron
>> Sent: Thursday, June 20, 2024 9:48 AM
>> To: Finn, Emma
>> Cc: ovs-dev@openvswitch.org; m...@redhat.com
>> Subject: Re: [v2] odp-execute: Check IPv4 checksum offload flag in AVX.
>>
>> On 17
> -Original Message-
> From: Eelco Chaudron
> Sent: Thursday, June 20, 2024 9:48 AM
> To: Finn, Emma
> Cc: ovs-dev@openvswitch.org; m...@redhat.com
> Subject: Re: [v2] odp-execute: Check IPv4 checksum offload flag in AVX.
>
> On 17 Jun 2024, at 16:08, Emma Finn wrote:
>
> > The AVX
> -Original Message-
> From: Eelco Chaudron
> Sent: Thursday, June 20, 2024 9:41 AM
> To: Finn, Emma
> Cc: ovs-dev@openvswitch.org
> Subject: Re: [PATCH] odp-execute: Set IPv6 traffic class in AVX
> implementation.
>
> On 12 Jun 2024, at 12:44, Emma Finn wrote:
>
> > The AVX
On 17 Jun 2024, at 16:08, Emma Finn wrote:
> The AVX implementation for IPv4 action did not check whether
> the IPv4 checksum offload flag has been set and was incorrectly
> calculating checksums in software. Adding a check to skip AVX
> checksum calculation when offload flags are set.
>
>
On 12 Jun 2024, at 12:44, Emma Finn wrote:
> The AVX implementation for the IPv6 action did not set
> traffic class field. Adding support for this field to
> the AVX implementation.
>
> Signed-off-by: Emma Finn
> Reported-by: Eelco Chaudron
This patch is missing a fixes tag.
Fixes:
Add the "set dscp action" parsing function,
so that the "set dscp action" can be offloaded.
Signed-off-by: Sunyang Wu
---
lib/netdev-offload-dpdk.c | 19 ++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c
index
On Wed, Jun 19, 2024 at 06:39:43PM GMT, Jakub Kicinski wrote:
> On Wed, 19 Jun 2024 23:00:06 +0200 Adrian Moreno wrote:
> > + OVS_EMIT_SAMPLE_ATTR_UNPSEC,
>
> Are you using this one? Looking closely I presume not, since it's
> misspelled ;) You can assign = 1 to GROUP, no need to name the value
32 matches
Mail list logo
