Add support for limiting the CT zone usage per Ls, LR or LSP.
When the limit is configured on logical switch it will also implicitly
set limits for all ports in that logical switch. The port configuration
can be overwritten individually and has priority over the whole logical
switch configuration.
In order to be able to store CT limits for specified zone, store the
zone inside separate struct instead of simap. This allows to add
the addition of limit without changing the whole infrastructure again.
This is a preparation step for the CT zone limits.
Signed-off-by: Ales Musil
---
v4:
Move more code into the new ct-zone module and encapsulate
functionality that is strictly related to CT zone handling.
Signed-off-by: Ales Musil
Acked-by: Lorenzo Bianconi
---
v4: Rebase on top of latest main.
Added ack from Lorenzo and fixed one nit.
v3: Rebase on top of latest main.
---
Move the CT zone handling specific bits into its own module. This
allows for easier changes done within the module and separates the
logic that is unrelated from ovn-controller.
Signed-off-by: Ales Musil
Acked-by: Lorenzo Bianconi
---
v4: Rebase on top of latest main.
Added ack from
Add ability that allows to set CT limits per logical switch, logical
router or logical switch port. When the limit is applied to logical
switch it will be implicitly set for all logical ports in the logical
switch. This can be overwritten individually per port.
To achieve this there is a small
On Tue, Jun 25, 2024 at 11:04:42PM GMT, Ilya Maximets wrote:
> On 6/25/24 22:53, Adrián Moreno wrote:
> > On Mon, Jun 24, 2024 at 07:43:32PM GMT, Adrián Moreno wrote:
> >> On Mon, Jun 24, 2024 at 04:05:36PM GMT, Ilya Maximets wrote:
> >>> On 6/24/24 15:19, Adrián Moreno wrote:
> On Mon, Jun
On 6/25/24 22:53, Adrián Moreno wrote:
> On Mon, Jun 24, 2024 at 07:43:32PM GMT, Adrián Moreno wrote:
>> On Mon, Jun 24, 2024 at 04:05:36PM GMT, Ilya Maximets wrote:
>>> On 6/24/24 15:19, Adrián Moreno wrote:
On Mon, Jun 24, 2024 at 01:37:44PM GMT, Ilya Maximets wrote:
> On 6/5/24 22:23,
The trunc action was supported decode-able but not parse-able. Add
support for parsing the action string.
Signed-off-by: Adrian Moreno
---
.../testing/selftests/net/openvswitch/ovs-dpctl.py | 13 +
1 file changed, 13 insertions(+)
diff --git
Add a test to verify sampling packets via psample works.
In order to do that, create a subcommand in ovs-dpctl.py to listen to
on the psample multicast group and print samples.
Signed-off-by: Adrian Moreno
---
.../selftests/net/openvswitch/openvswitch.sh | 114 +-
On Mon, Jun 24, 2024 at 07:43:32PM GMT, Adrián Moreno wrote:
> On Mon, Jun 24, 2024 at 04:05:36PM GMT, Ilya Maximets wrote:
> > On 6/24/24 15:19, Adrián Moreno wrote:
> > > On Mon, Jun 24, 2024 at 01:37:44PM GMT, Ilya Maximets wrote:
> > >> On 6/5/24 22:23, Adrian Moreno wrote:
> > >>> Use the
Add sample and emit_sample action support to ovs-dpctl.py.
Refactor common attribute parsing logic into an external function.
Signed-off-by: Adrian Moreno
---
.../selftests/net/openvswitch/ovs-dpctl.py| 162 +-
1 file changed, 161 insertions(+), 1 deletion(-)
diff --git
The userspace action lacks parsing support plus it contains a bug in the
name of one of its attributes.
This patch makes userspace action work.
Signed-off-by: Adrian Moreno
---
.../selftests/net/openvswitch/ovs-dpctl.py| 24 +--
1 file changed, 22 insertions(+), 2
When a packet sample is observed, the sampling rate that was used is
important to estimate the real frequency of such event.
Store the probability of the parent sample action in the skb's cb area
and use it in emit_sample to pass it down to psample.
Signed-off-by: Adrian Moreno
---
Add support for a new action: emit_sample.
This action accepts a u32 group id and a variable-length cookie and uses
the psample multicast group to make the packet available for
observability.
The maximum length of the user-defined cookie is set to 16, same as
tc_cookie, to discourage using
Although not explicitly documented in the psample module itself, the
definition of PSAMPLE_ATTR_SAMPLE_RATE seems inherited from act_sample.
Quoting tc-sample(8):
"RATE of 100 will lead to an average of one sampled packet out of every
100 observed."
With this semantics, the rates that we can
If nobody is listening on the multicast group, generating the sample,
which involves copying packet data, seems completely unnecessary.
Return fast in this case.
Reviewed-by: Simon Horman
Signed-off-by: Adrian Moreno
---
net/psample/psample.c | 4
1 file changed, 4 insertions(+)
diff
Add a user cookie to the sample metadata so that sample emitters can
provide more contextual information to samples.
If present, send the user cookie in a new attribute:
PSAMPLE_ATTR_USER_COOKIE.
Reviewed-by: Simon Horman
Signed-off-by: Adrian Moreno
---
include/net/psample.h| 2 ++
If the action has a user_cookie, pass it along to the sample so it can
be easily identified.
Signed-off-by: Adrian Moreno
---
net/sched/act_sample.c | 12
1 file changed, 12 insertions(+)
diff --git a/net/sched/act_sample.c b/net/sched/act_sample.c
index a69b53d54039..2ceb4d141b71
** Background **
Currently, OVS supports several packet sampling mechanisms (sFlow,
per-bridge IPFIX, per-flow IPFIX). These end up being translated into a
userspace action that needs to be handled by ovs-vswitchd's handler
threads only to be forwarded to some third party application that
will
On Tue, Jun 25, 2024 at 01:17:19PM GMT, Paolo Abeni wrote:
> On Fri, 2024-06-21 at 12:10 +0200, Adrian Moreno wrote:
> > diff --git a/include/uapi/linux/tc_act/tc_sample.h
> > b/include/uapi/linux/tc_act/tc_sample.h
> > index fee1bcc20793..7ee0735e7b38 100644
> > ---
The current pmtu test infrastucture requires an installed copy of the
ovs-vswitchd userspace. This means that any automated or constrained
environments may not have the requisite tools to run the tests. However,
the pmtu tests don't require any special classifier processing. Indeed
they are
The pmtu testing will require that the OVS module is installed,
so do that.
Reviewed-by: Simon Horman
Tested-by: Simon Horman
Signed-off-by: Aaron Conole
---
tools/testing/selftests/net/config | 5 +
1 file changed, 5 insertions(+)
diff --git a/tools/testing/selftests/net/config
The current iteration of IPv6 support requires explicit fields to be set
in addition to not properly support the actual IPv6 addresses properly.
With this change, make it so that the ipv6() bare option is usable to
create wildcarded flows to match broad swaths of ipv6 traffic.
Reviewed-by: Simon
This will be used when setting details about the tunnel to use as
transport. There is a difference between the ODP format between tunnel():
the 'key' flag is not actually a flag field, so we don't support it in the
same way that the vswitchd userspace supports displaying it.
Signed-off-by: Aaron
These will be used in upcoming commits to set specific attributes for
interacting with tunnels. Since set() will use the key parsing routine, we
also make sure to prepend it with an open paren, for the action parsing to
properly understand it.
Reviewed-by: Simon Horman
Tested-by: Simon Horman
Until recently, the ovs-dpctl utility was used with a limited actions set
and didn't need to have support for multiple similar actions. However,
when adding support for tunnels, it will be important to support multiple
set() actions in a single flow. When printing these actions, the existing
Currently, if a user wants to run pmtu.sh and cover all the provided test
cases, they need to install the Open vSwitch userspace utilities. This
dependency is difficult for users as well as CI environments, because the
userspace build and setup may require lots of support and devel packages
to be
The OVS module can operate in conjunction with various types of
tunnel ports. These are created as either explicit tunnel vport
types, OR by creating a tunnel interface which acts as an anchor
for the lightweight tunnel support.
This patch adds the ability to add tunnel ports to an OVS
datapath
Hello,
On Tue, Jun 25, 2024 at 6:04 PM Dumitru Ceara wrote:
>
> Hi,
>
> Thanks to everyone who attended the OVN meeting yesterday!
>
> The recording is available here:
> https://www.youtube.com/watch?v=bonLhUj2oGg
>
> Transcripts:
>
Hello,
We are increasingly seeing requests for integration between OVN
powered CMSs/workloads and the fabric.
As a side note, this is a very interesting topic to me personally, and
I think there are opportunities in the long term for this class of
software to potentially fill a void for more
On Tue, 25 Jun 2024 11:17:14 -0400 Aaron Conole wrote:
> > BTW I popped the v2 back into the queue, so the next run (in 20min)
> > will tell us if that's the only thing we were missing 爛️
>
> :) I'll wait to post the v3 then. So far, the only change I have is:
>
> ---
Hi,
Thanks to everyone who attended the OVN meeting yesterday!
The recording is available here:
https://www.youtube.com/watch?v=bonLhUj2oGg
Transcripts:
https://drive.google.com/file/d/1ioVXcHiuD-xr5RQTh5OSGbpmhUtIDiO_/view?usp=sharing
Notes:
On Tue, 25 Jun 2024 07:06:54 -0700
Jakub Kicinski wrote:
> On Tue, 25 Jun 2024 09:20:29 -0400 Aaron Conole wrote:
> > > I'm still wondering if the issue is Kconfig-related (plus possibly bad
> > > interaction with vng). I don't see the OVS knob enabled in the self-
> > > tests config. If it's
Jakub Kicinski writes:
> On Tue, 25 Jun 2024 10:14:24 -0400 Aaron Conole wrote:
>> > Sorry for not checking it earlier, looks like the runner was missing
>> > pyroute:
>> >
>> > # python3 ./tools/testing/selftests/net/openvswitch/ovs-dpctl.py
>> > Need to install the python pyroute2 package >=
On Tue, 25 Jun 2024 10:14:24 -0400 Aaron Conole wrote:
> > Sorry for not checking it earlier, looks like the runner was missing
> > pyroute:
> >
> > # python3 ./tools/testing/selftests/net/openvswitch/ovs-dpctl.py
> > Need to install the python pyroute2 package >= 0.6.
> >
> > I guess run_cmd
Jakub Kicinski writes:
> On Tue, 25 Jun 2024 09:20:29 -0400 Aaron Conole wrote:
>> > I'm still wondering if the issue is Kconfig-related (plus possibly bad
>> > interaction with vng). I don't see the OVS knob enabled in the self-
>> > tests config. If it's implied by some other knob, and ends-up
On Tue, 25 Jun 2024 09:20:29 -0400 Aaron Conole wrote:
> > I'm still wondering if the issue is Kconfig-related (plus possibly bad
> > interaction with vng). I don't see the OVS knob enabled in the self-
> > tests config. If it's implied by some other knob, and ends-up being
> > selected as a
On 6/25/24 15:27, Mike Pattrick wrote:
> On Tue, Jun 25, 2024 at 4:30 AM echken wrote:
>>
>> The OVS internal port does not support UDP fragmentation offloading,
>> resulting in large packets sent through the OVS internal port to OVS
>> being prematurely fragmented. This increases the total
On Tue, Jun 25, 2024 at 4:30 AM echken wrote:
>
> The OVS internal port does not support UDP fragmentation offloading,
> resulting in large packets sent through the OVS internal port to OVS
> being prematurely fragmented. This increases the total number of packets
> processed in the path from the
Paolo Abeni writes:
> On Mon, 2024-06-24 at 12:53 -0400, Aaron Conole wrote:
>> Aaron Conole writes:
>>
>> > Jakub Kicinski writes:
>> >
>> > > On Thu, 20 Jun 2024 08:55:54 -0400 Aaron Conole wrote:
>> > > > This series enhances the ovs-dpctl utility to provide support for set()
>> > > > and
Jakub Kicinski writes:
> On Mon, 24 Jun 2024 12:53:45 -0400 Aaron Conole wrote:
>> Additionally, the "Cannot find device ..." text comes from an iproute2
>> utility output. The only place we actually interact with that is via
>> the call at pmtu.sh:973:
>>
>> run_cmd ip link set ovs_br0
> -Original Message-
> From: Eelco Chaudron
> Sent: Tuesday, June 25, 2024 11:37 AM
> To: Phelan, Michael
> Cc: Finn, Emma ; Ilya Maximets
> ; ovs-dev@openvswitch.org; Van Haaren, Harry
>
> Subject: Re: [v4] odp-execute: Fix AVX checksum calculation.
>
>
>
> On 14 Jun 2024, at 10:17,
On 6/25/24 13:17, Paolo Abeni wrote:
> On Fri, 2024-06-21 at 12:10 +0200, Adrian Moreno wrote:
>> diff --git a/include/uapi/linux/tc_act/tc_sample.h
>> b/include/uapi/linux/tc_act/tc_sample.h
>> index fee1bcc20793..7ee0735e7b38 100644
>> --- a/include/uapi/linux/tc_act/tc_sample.h
>> +++
On Fri, 2024-06-21 at 12:10 +0200, Adrian Moreno wrote:
> diff --git a/include/uapi/linux/tc_act/tc_sample.h
> b/include/uapi/linux/tc_act/tc_sample.h
> index fee1bcc20793..7ee0735e7b38 100644
> --- a/include/uapi/linux/tc_act/tc_sample.h
> +++ b/include/uapi/linux/tc_act/tc_sample.h
> @@ -18,6
On 6/24/24 16:33, Ales Musil wrote:
> The DPDK was built as extra step in the CI, however it is useful to
> have it inside the container prepared. This also helps with
> reproduction of failures with DPDK by having the exact version inside
> the container already.
>
> Also bump the Ubuntu version
On 6/24/24 16:33, Ales Musil wrote:
> Move common preparation steps into script that can be invoked by both
> container builds. This will ensure that any update will be reflected
> in both containers, and it reduces the duplication between both
> containers. At the same time use the --user
On 14 Jun 2024, at 10:17, Eelco Chaudron wrote:
>> Op 14 jun 2024 om 10:13 heeft Phelan, Michael het
>> volgende geschreven:
>>
>>
>>>
>>> -Original Message-
>>> From: Eelco Chaudron
>>> Sent: Thursday, June 13, 2024 12:45 PM
>>> To: Finn, Emma ; Phelan, Michael
>>>
>>> Cc: Ilya
On 17 Jun 2024, at 16:08, Emma Finn wrote:
> The AVX implementation for IPv4 action did not check whether
> the IPv4 checksum offload flag has been set and was incorrectly
> calculating checksums in software. Adding a check to skip AVX
> checksum calculation when offload flags are set.
>
>
On 12 Jun 2024, at 12:44, Emma Finn wrote:
> The AVX implementation for the IPv6 action did not set
> traffic class field. Adding support for this field to
> the AVX implementation.
>
> Signed-off-by: Emma Finn
> Reported-by: Eelco Chaudron
Thanks for the patch Emma, it has been applied to
On Mon, 24 Jun 2024 15:30:23 -0700
Jakub Kicinski wrote:
> On Mon, 24 Jun 2024 12:53:45 -0400 Aaron Conole wrote:
> > Additionally, the "Cannot find device ..." text comes from an iproute2
> > utility output. The only place we actually interact with that is via
> > the call at pmtu.sh:973:
> >
The OVS internal port does not support UDP fragmentation offloading,
resulting in large packets sent through the OVS internal port to OVS
being prematurely fragmented. This increases the total number of packets
processed in the path from the vport to the OVS bridge output port,
affecting
Currently serialization is performed by first converting
the internal data representation into JSON objects, followed by
serializing these objects by jsonrpc. This process results in lots of
allocations for these intermediate objects. Consequently, this
not only increases peak memory consumption,
On Thursday, June 20, 2024 9:52:07 PM GMT+3 Aaron Conole wrote:
> Why is this file existing? Maybe it would be better to generate the
> compile_commands.json in automake? Or generate it via the makefile?
I'm not checking in the file. It's local configuration file, used by clangd,
which is
Bleep bloop. Greetings Grigorii Nazarov, I am a robot and I have tried out
your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Inappropriate bracing around statement
#332 FILE: ovsdb/monitor.c:1010:
On Thursday, June 20, 2024 9:58:41 PM GMT+3 Aaron Conole wrote:
> There's only one user left in tree. Maybe it makes sense to remove
> this? Or at least mark it deprecated or something? It is used quite a
> bit in OVN project. It doesn't seem like it is worth the overhead of
> the extra
On Mon, 2024-06-24 at 12:53 -0400, Aaron Conole wrote:
> Aaron Conole writes:
>
> > Jakub Kicinski writes:
> >
> > > On Thu, 20 Jun 2024 08:55:54 -0400 Aaron Conole wrote:
> > > > This series enhances the ovs-dpctl utility to provide support for set()
> > > > and tunnel() flow specifiers,
Currently serialization is performed by first converting
the internal data representation into JSON objects, followed by
serializing these objects by jsonrpc. This process results in lots of
allocations for these intermediate objects. Consequently, this
not only increases peak memory consumption,
Signed-off-by: Grigorii Nazarov
---
lib/ovsdb-data.c | 8 +---
lib/uuid.h | 1 +
2 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/lib/ovsdb-data.c b/lib/ovsdb-data.c
index abb923ad8..defb048d7 100644
--- a/lib/ovsdb-data.c
+++ b/lib/ovsdb-data.c
@@ -2582,14 +2582,8 @@
Signed-off-by: Grigorii Nazarov
---
lib/json.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/lib/json.c b/lib/json.c
index 001f6e6ab..d40e93857 100644
--- a/lib/json.c
+++ b/lib/json.c
@@ -127,7 +127,9 @@ static void json_parser_input(struct json_parser *,
Signed-off-by: Grigorii Nazarov
---
.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/.gitignore b/.gitignore
index 26ed8d3d0..3c7250159 100644
--- a/.gitignore
+++ b/.gitignore
@@ -79,3 +79,4 @@ testsuite.tmp.orig
/Documentation/_build
/.venv
/cxx-check
+/compile_flags.txt
--
> On Thu, Jun 6, 2024 at 8:35 PM Lorenzo Bianconi
> wrote:
>
> > Introduce the nexthop identifier in the ct_label.label field for
> > ecmp-symmetric replies connections. This field will be used by
> > ovn-controller to track ct entries and to flush them if requested by the
> > CMS (e.g. removing
On Jun 24, Ales Musil wrote:
> On Thu, Jun 6, 2024 at 8:35 PM Lorenzo Bianconi
> wrote:
>
> > Introduce ecmp_nexthop_monitor in ovn-controller in order to track and
> > flush ecmp-symmetric reply ct entires when requested by the CMS (e.g
> > removing the related static routes).
> >
> >
On Mon, Jun 24, 2024 at 08:26:44PM GMT, Ilya Maximets wrote:
> On 6/24/24 20:00, Adrián Moreno wrote:
> > On Mon, Jun 24, 2024 at 02:03:00PM GMT, Ilya Maximets wrote:
> > [...]
> >>
> >> Why are we adding IPFIX? This should work without IPFIX.
> >>
> >> Having both together can be a separate
On Mon, Jun 24, 2024 at 07:57:28PM GMT, Ilya Maximets wrote:
> On 6/24/24 19:38, Adrián Moreno wrote:
> > On Mon, Jun 24, 2024 at 04:15:50PM GMT, Ilya Maximets wrote:
> >> On 6/24/24 15:14, Adrián Moreno wrote:
> >>> On Mon, Jun 24, 2024 at 02:03:00PM GMT, Ilya Maximets wrote:
> On 6/5/24
64 matches
Mail list logo
