Test cases have been added.
发件人: Ales Musil
发送时间: 2024年7月10日 15:02
收件人: Qiang Qiang45 Zhang
抄送: d...@openvswitch.org
主题: [External] Re: [ovs-dev] [PATCH ovn] northd: Fix issues for Forwarding_Group
On Mon, Jul 8, 2024 at 5:01 PM Qiang Qiang45 Zhang via dev
mailto:ovs-dev@openvswitch.org>> w
On 7/10/24 23:38, Adrián Moreno wrote:
> On Wed, Jul 10, 2024 at 11:00:43PM GMT, Ilya Maximets wrote:
>> On 7/7/24 22:09, Adrian Moreno wrote:
>>> When sample action gets used as a way of sampling traffic with
>>> controller-generated metadata (i.e: obs_domain_id and obs_point_id),
>>> the controll
On Wed, Jul 10, 2024 at 11:31:42PM GMT, Ilya Maximets wrote:
> On 7/7/24 22:09, Adrian Moreno wrote:
> > When an action set ends in a an OFP_SAMPLE action, it means the packet
> > will be dropped and sampled. Make the drop explicit in this case so that
> > drop statistics remain accurate.
> >
> > T
On Wed, Jul 10, 2024 at 11:00:43PM GMT, Ilya Maximets wrote:
> On 7/7/24 22:09, Adrian Moreno wrote:
> > When sample action gets used as a way of sampling traffic with
> > controller-generated metadata (i.e: obs_domain_id and obs_point_id),
> > the controller will have to increase the number of flo
On 7/7/24 22:09, Adrian Moreno wrote:
> When an action set ends in a an OFP_SAMPLE action, it means the packet
> will be dropped and sampled. Make the drop explicit in this case so that
> drop statistics remain accurate.
>
> This could be done outside of the sample action, i.e: "sample(...),drop"
On 7/7/24 22:09, Adrian Moreno wrote:
> When sample action gets used as a way of sampling traffic with
> controller-generated metadata (i.e: obs_domain_id and obs_point_id),
> the controller will have to increase the number of flows to ensure each
> part of the pipeline contains the right metadata.
On Wed, Jul 10, 2024 at 10:26:23PM GMT, Ilya Maximets wrote:
> On 7/9/24 16:25, Eelco Chaudron wrote:
> >
> >
> > On 9 Jul 2024, at 16:17, Adrián Moreno wrote:
> >
> >> On Tue, Jul 09, 2024 at 11:46:12AM GMT, Eelco Chaudron wrote:
> >>> On 7 Jul 2024, at 22:09, Adrian Moreno wrote:
> >>>
> Whe
On 7/9/24 16:25, Eelco Chaudron wrote:
>
>
> On 9 Jul 2024, at 16:17, Adrián Moreno wrote:
>
>> On Tue, Jul 09, 2024 at 11:46:12AM GMT, Eelco Chaudron wrote:
>>> On 7 Jul 2024, at 22:09, Adrian Moreno wrote:
>>>
When sample action gets used as a way of sampling traffic with
controller-
On 7/10/24 19:17, Adrián Moreno wrote:
> On Wed, Jul 10, 2024 at 06:52:30PM GMT, Ilya Maximets wrote:
>> On 7/10/24 15:25, Adrián Moreno wrote:
>>> On Wed, Jul 10, 2024 at 02:56:44PM GMT, Ilya Maximets wrote:
On 7/7/24 22:08, Adrian Moreno wrote:
> Use the newly added psample action to imp
Introduce bfd, static_routes and route_policies nodes to northd I-P
engine to track bfd connections and northd static_route/policy_route
changes.
Acked-by: Numan Siddique
Reported-at: https://issues.redhat.com/browse/FDP-600
Signed-off-by: Lorenzo Bianconi
---
Changes since v5:
- remove bfd_mute
Bleep bloop. Greetings Adrian Moreno, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 81 characters long (recommended limit is 79)
#550 FILE: Documentation/ref/ovs
On Wed, Jul 10, 2024 at 06:52:30PM GMT, Ilya Maximets wrote:
> On 7/10/24 15:25, Adrián Moreno wrote:
> > On Wed, Jul 10, 2024 at 02:56:44PM GMT, Ilya Maximets wrote:
> >> On 7/7/24 22:08, Adrian Moreno wrote:
> >>> Use the newly added psample action to implement OpenFlow sample() actions
> >>> wit
Add a man page for ovs-flowviz as well as a topic page with some more
detailed examples.
Signed-off-by: Adrian Moreno
---
Documentation/automake.mk | 4 +-
Documentation/conf.py | 2 +
Documentation/ref/index.rst | 1 +
Documentation/
Graph view leverages the TreeFlow hierarchy and uses graphviz library to
build a visual graph of the datapath tree.
Conntrack zones are shown in random colors to help visualize connection
tracking interdependencies.
An html flag builds an HTML page with both the html flows and the graph
(in svg)
Datapath flows can be arranged into a "tree"-like structure based on
recirculation ids and input ports.
A recirculation group is composed of flows sharing the same "recirc_id"
and "in_port" match. Within that group, flows are arranged in blocks of
flows that have the same action list. Finally, if
Add a HTML Formatter and use it to print OpenFlow flows in an HTML list
with table links.
Examples
$ ovs-flowviz -i offlows.txt --highlight "drop" openflow html >
/tmp/flows.html
$ ovs-flowviz -i offlows.txt --filter "n_packets > 0" openflow html >
/tmp/flows.html
Both light and dark styles are s
This view is interesting for debugging the logical pipeline. It arranges
the flows in "logical" groups (not to be confused with OVN's
Logical_Flows). A logical group of flows is a set of flows that:
- Have the same table number and priority
- Match on the same fields (regardless of the value they m
Add a flow formatting framework and one implementation for console
printing using rich.
The flow formatting framework is a simple set of classes that can be
used to write different flow formatting implementations. It supports
styles to be described by any class, highlighting and config-file based
process.py contains a useful base class that processes files. Datapath
flow processing is pmd-thread-aware.
odp.py and ofp.py: contain datapath and openflow subcommand definitions
as well as the first formatting option: json.
Also, this patch adds basic filtering support.
Examples:
$ ovs-ofctl d
Using the existing FlowTree and HTMLFormatter, create an HTML tree
visualization that also supports collapsing and expanding entire flow
subtrees.
Examples:
$ ovs-appcl dpctl/dump-flows | ovs-flowviz --highlight drop datapath
html > /tmp/flows.html
$ ovs-appcl dpctl/dump-flows | ovs-flowviz -f "ou
When anaylizing OVN issues, it might be useful to see what OpenFlow
flows were generated from each logical flow. In order to make it simpler
to visualize this, add a cookie format that simply sorts the flows first
by cookie, then by table.
Example:
$ export OVN_NB_DB=...
$ export OVN_SB_DB=...
$ o
It has two basic styles defined: "dark" and "light" intended for
dark and light terminals.
Examples:
$ ovs-flowviz -i /tmp/dpflows --style=dark datapath console
$ ovs-flowviz -i /tmp/ofpflows --style=light openflow console
Acked-by: Eelco Chaudron
Signed-off-by: Adrian Moreno
---
python/automa
Add a new python package (just the scheleton for now) to hold a flow
visualization tool based on the flow parsing library.
flowviz dependencies are installed via "extras_require", so a user must
run:
$ pip install .[flowviz]
or
$ pip install ovs[flowviz]
Acked-by: Eelco Chaudron
Signed-off-by:
DPDK flows can have this extra section that, for now, only has one
possible key (miniflow_bits). Add it to the ODPFlow flow.
Signed-off-by: Adrian Moreno
---
python/ovs/flow/odp.py | 23 ++-
1 file changed, 22 insertions(+), 1 deletion(-)
diff --git a/python/ovs/flow/odp.py
The goal of this utility is to read both datapath and Openflow flows
(using the flow library already available) and print them in different
formats and styles to make it easier to understand them and troubleshoot
issues.
The formats are quite opinionated and so are the colors chosen so I'm
eager t
Add "offloaded" key in the info section of datapath flow.
Signed-off-by: Adrian Moreno
---
python/ovs/flow/odp.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/python/ovs/flow/odp.py b/python/ovs/flow/odp.py
index d5faff03e..f51154513 100644
--- a/python/ovs/flow/odp.py
+++ b/python/ovs/fl
On 7/10/24 15:25, Adrián Moreno wrote:
> On Wed, Jul 10, 2024 at 02:56:44PM GMT, Ilya Maximets wrote:
>> On 7/7/24 22:08, Adrian Moreno wrote:
>>> Use the newly added psample action to implement OpenFlow sample() actions
>>> with local sampling configuration if possible.
>>>
>>> A bit of refactorin
On 7/10/24 18:30, Adrián Moreno wrote:
> On Wed, Jul 10, 2024 at 04:28:55PM GMT, Eelco Chaudron wrote:
>>
>>
>> On 10 Jul 2024, at 15:06, Ilya Maximets wrote:
>>
>>> On 7/7/24 22:09, Adrian Moreno wrote:
Add a command to dump statistics per exporter.
Signed-off-by: Adrian Moreno
>>>
On Wed, Jul 10, 2024 at 04:28:55PM GMT, Eelco Chaudron wrote:
>
>
> On 10 Jul 2024, at 15:06, Ilya Maximets wrote:
>
> > On 7/7/24 22:09, Adrian Moreno wrote:
> >> Add a command to dump statistics per exporter.
> >>
> >> Signed-off-by: Adrian Moreno
> >> ---
> >> NEWS |
On 7/10/24 17:41, Phelan, Michael wrote:
>
>> -Original Message-
>> From: Ilya Maximets
>> Sent: Monday, July 8, 2024 4:41 PM
>> To: Phelan, Michael
>> Cc: i.maxim...@ovn.org; ovs-dev ; Aaron Conole
>> ; Chaudron, Eelco
>> Subject: Re: Intel CI not running?
>>
>> On 7/8/24 11:02, Phelan
On Fri, Jul 5, 2024 at 1:31 PM Lorenzo Bianconi
wrote:
>
> Introduce bfd, static_routes, route_policies and bfd_nb_sync nodes to northd
> I-P
> engine to track bfd connections and northd static_route/policy_route
> changes.
>
> Reported-at: https://issues.redhat.com/browse/FDP-600
> Signed-off-by
> -Original Message-
> From: Ilya Maximets
> Sent: Monday, July 8, 2024 4:41 PM
> To: Phelan, Michael
> Cc: i.maxim...@ovn.org; ovs-dev ; Aaron Conole
> ; Chaudron, Eelco
> Subject: Re: Intel CI not running?
>
> On 7/8/24 11:02, Phelan, Michael wrote:
> >> -Original Message-
>
On 9 Jul 2024, at 23:38, Ilya Maximets wrote:
> On 7/3/24 12:28, Roi Dayan via dev wrote:
>>
>>
>> On 03/07/2024 13:16, Eelco Chaudron wrote:
>>>
>>>
>>> On 3 Jul 2024, at 9:33, Roi Dayan wrote:
>>>
It is observed in some environments that there are much more ukeys than
actual DP flows
Introduce the capability to specify boundaries (max and min values) for
the ct_zones dynamically selected by ovn-controller.
Reported-at: https://issues.redhat.com/browse/FDP-383
Signed-off-by: Lorenzo Bianconi
---
Changes since v1:
- rely on get_chassis_external_id_value() to get ct_zone_range
-
On 10 Jul 2024, at 15:06, Ilya Maximets wrote:
> On 7/7/24 22:09, Adrian Moreno wrote:
>> Add a command to dump statistics per exporter.
>>
>> Signed-off-by: Adrian Moreno
>> ---
>> NEWS | 2 +
>> ofproto/ofproto-dpif-lsample.c | 111
On Jul 10, Ales Musil wrote:
> On Tue, Jul 9, 2024 at 6:37 PM Lorenzo Bianconi
> wrote:
>
> > Introduce the capability to specify boundaries (max and min values) for
> > the ct_zones dynamically selected by ovn-controller.
> >
> > Reported-at: https://issues.redhat.com/browse/FDP-383
> > Signed-o
On Wed, Jul 10, 2024 at 02:56:44PM GMT, Ilya Maximets wrote:
> On 7/7/24 22:08, Adrian Moreno wrote:
> > Use the newly added psample action to implement OpenFlow sample() actions
> > with local sampling configuration if possible.
> >
> > A bit of refactoring in compose_sample_actions arguments help
On 7/7/24 22:09, Adrian Moreno wrote:
> Add a command to dump statistics per exporter.
>
> Signed-off-by: Adrian Moreno
> ---
> NEWS | 2 +
> ofproto/ofproto-dpif-lsample.c | 111 +
> ofproto/ofproto-dpif-lsample.h | 1 +
> ofproto/of
On 7/7/24 22:08, Adrian Moreno wrote:
> Use the newly added psample action to implement OpenFlow sample() actions
> with local sampling configuration if possible.
>
> A bit of refactoring in compose_sample_actions arguments helps make it a
> bit more readable.
>
> Signed-off-by: Adrian Moreno
>
On Wed, Jul 10, 2024 at 02:18:35PM GMT, Ilya Maximets wrote:
> On 7/9/24 16:03, Eelco Chaudron wrote:
> >
> >
> > On 9 Jul 2024, at 15:52, Adrián Moreno wrote:
> >
> >> On Tue, Jul 09, 2024 at 11:45:51AM GMT, Eelco Chaudron wrote:
> >>> On 7 Jul 2024, at 22:08, Adrian Moreno wrote:
> >>>
> Use
On 7/9/24 16:03, Eelco Chaudron wrote:
>
>
> On 9 Jul 2024, at 15:52, Adrián Moreno wrote:
>
>> On Tue, Jul 09, 2024 at 11:45:51AM GMT, Eelco Chaudron wrote:
>>> On 7 Jul 2024, at 22:08, Adrian Moreno wrote:
>>>
Use the newly added psample action to implement OpenFlow sample() actions
On 7/7/24 22:08, Adrian Moreno wrote:
> Add as new column in the Flow_Sample_Collector_Set table named
> "local_group_id" which enables this feature.
>
> Signed-off-by: Adrian Moreno
> ---
> NEWS | 4 ++
> vswitchd/bridge.c | 78 +++
On 7/9/24 15:32, Adrián Moreno wrote:
> On Tue, Jul 09, 2024 at 11:45:19AM GMT, Eelco Chaudron wrote:
>> On 7 Jul 2024, at 22:08, Adrian Moreno wrote:
>>
>>> Add a new resource in ofproto-dpif and the corresponding API in
>>> ofproto_provider.h to represent and local sampling configuration.
>>>
>>>
On 7/7/24 22:08, Adrian Moreno wrote:
> Add a new resource in ofproto-dpif and the corresponding API in
> ofproto_provider.h to represent and local sampling configuration.
>
> Signed-off-by: Adrian Moreno
> ---
> ofproto/automake.mk| 2 +
> ofproto/ofproto-dpif-lsample.c | 187
On Wed, Jul 10, 2024 at 01:28:29PM GMT, Ilya Maximets wrote:
> On 7/7/24 22:08, Adrian Moreno wrote:
> > Only kernel datapath supports this action so add a function in dpif.c
> > that checks for that.
> >
> > Signed-off-by: Adrian Moreno
> > ---
> > lib/dpif.c | 7 +++
> > lib/dp
On 7/7/24 22:08, Adrian Moreno wrote:
> Only kernel datapath supports this action so add a function in dpif.c
> that checks for that.
>
> Signed-off-by: Adrian Moreno
> ---
> lib/dpif.c | 7 +++
> lib/dpif.h | 1 +
> ofproto/ofproto-dpif.c | 43 +
On 7/10/24 13:18, Adrián Moreno wrote:
> On Wed, Jul 10, 2024 at 12:56:57PM GMT, Ilya Maximets wrote:
>> On 7/7/24 22:08, Adrian Moreno wrote:
>>> Add support for parsing and formatting the new action.
>>>
>>> Also, flag OVS_ACTION_ATTR_SAMPLE as requiring datapath assistance if it
>>> contains a n
On Wed, Jul 10, 2024 at 12:56:57PM GMT, Ilya Maximets wrote:
> On 7/7/24 22:08, Adrian Moreno wrote:
> > Add support for parsing and formatting the new action.
> >
> > Also, flag OVS_ACTION_ATTR_SAMPLE as requiring datapath assistance if it
> > contains a nested OVS_ACTION_ATTR_PSAMPLE. The reason
On 7/9/24 13:27, Adrián Moreno wrote:
> On Mon, Jul 08, 2024 at 01:24:14PM GMT, Dumitru Ceara wrote:
>> From: Adrian Moreno
>>
>> Introduce a new table called Sample where per-flow IPFIX configuration
>> can be specified.
>> Also, reference rows from such table from the ACL table to enable the
>>
Hi,
Yes, that’s right.
Let’s say, the VM is getting copied to the destination AZ or say it is not yet
ready to process any traffic, yet.
In such cases we may want OVN to avoid sending RARP/GARP early and lead to
traffic outage.
Thanks,
Shibir
From: Ales Musil
Date: Wednesday, 10 July 2024 at
Since on CentOS/RHEL the builds are based on stable branches and not on
tags for debugging purpose it's better to have the downstream version as
version so it's easier to know which commits are included in a build.
This commit adds --with-version-suffix as ./configure option in
order to set an OVS
On 7/7/24 22:08, Adrian Moreno wrote:
> Add support for parsing and formatting the new action.
>
> Also, flag OVS_ACTION_ATTR_SAMPLE as requiring datapath assistance if it
> contains a nested OVS_ACTION_ATTR_PSAMPLE. The reason is that the
> sampling rate form the parent "sample" is made available
On Wed, Jul 10, 2024 at 12:26 PM Shibir Basak
wrote:
> Hi Ales,
>
>
>
> The use case we are trying to address is not limited to migration within a
> local AZ.
>
> Here, the VM can also be migrated across AZs and it is supposed to retain
> the same MAC & IP addresses.
>
> Hence, requested-chassis
Hi Ales,
The use case we are trying to address is not limited to migration within a
local AZ.
Here, the VM can also be migrated across AZs and it is supposed to retain the
same MAC & IP addresses.
Hence, requested-chassis along with LSP option "activation-strategy" is not
applicable for such a
On Wed, Jul 10, 2024 at 01:01:03AM GMT, Ilya Maximets wrote:
> On 7/9/24 21:07, Adrián Moreno wrote:
> > On Tue, Jul 09, 2024 at 04:15:12PM GMT, Eelco Chaudron wrote:
> >>
> >>
> >> On 9 Jul 2024, at 15:30, Adrián Moreno wrote:
> >>
> >>> On Tue, Jul 09, 2024 at 11:45:15AM GMT, Eelco Chaudron wrote
On 9 Jul 2024, at 21:31, Adrián Moreno wrote:
> On Tue, Jul 09, 2024 at 11:46:09AM GMT, Eelco Chaudron wrote:
>> On 7 Jul 2024, at 22:09, Adrian Moreno wrote:
>>
>>> The decision to add or not the explicit drop action is currently based
>>> on whether the resulting dp action list is empty or not
There are a couple of places where the test script "sleep"s to wait for
some external condition to be met.
This is error prone, specially in slow systems (identified in CI by
"KSFT_MACHINE_SLOW=yes").
To fix this, add a "ovs_wait" function that tries to execute a command
a few times until it succ
On Tue, Jul 09, 2024 at 09:18:17PM +0800, Sunyang Wu wrote:
> Add the "set dscp action" parsing function,
> so that the "set dscp action" can be offloaded.
>
> Signed-off-by: Sunyang Wu
> ---
> Documentation/howto/dpdk.rst | 5 +++--
> lib/netdev-offload-dpdk.c| 27 +
On Tue, Jul 9, 2024 at 6:37 PM Lorenzo Bianconi
wrote:
> Introduce the capability to specify boundaries (max and min values) for
> the ct_zones dynamically selected by ovn-controller.
>
> Reported-at: https://issues.redhat.com/browse/FDP-383
> Signed-off-by: Lorenzo Bianconi
> ---
>
Hi Lorenzo,
On Tue, Jul 9, 2024 at 7:57 AM Shibir Basak
wrote:
> If the lsp option 'disable_garp_rarp' is set to true,
> GARP and RARP announcements are not sent by ovn when a
> VIF port is created on a bridged logical switch.
>
> Usecase
>
> This option is useful during VM migration to let the
> hy
On Mon, Jul 8, 2024 at 5:01 PM Qiang Qiang45 Zhang via dev <
ovs-dev@openvswitch.org> wrote:
> When a logical switch has 2 FWGs and each FWG has 3 ports,
> Logical-Flow only has one fwg_group() action.
> Submitted-at: northd: Fix issues for Forwarding_Group by ZhangQiang3 *
> Pull Request #250 * o
61 matches
Mail list logo
