Re: [ovs-dev] [PATCH v1] netdev-dpdk: Added xstat statistics interface.

2024-09-17 Thread Jun Wang
>On Mon, Sep 16, 2024 at 9:46 AM Eelco Chaudron wrote: > > On 14 Sep 2024, at 7:26, Jun Wang wrote: > > > > > For many network cards, xstat statistics cannot be queried in the > > > ovs interface. A new interface is added to retrieve all xstat > > > information of the network card. > > Hi Jun, > >

Re: [ovs-dev] [PATCH ovn] northd: Respect --ecmp-symmetric-reply for single routes.

2024-09-17 Thread Rosemarie O'Riorden
Recheck-request: github-robot-_ovn-kubernetes On 9/17/24 1:00 PM, Rosemarie O'Riorden wrote: > When preparing to build ECMP and static route flows, routes are sorted > into unique routes (meaning they are not part of a group) or they are > added to EMCP groups. Then, ECMP route flows are built out

[ovs-dev] [PATCH branch-3.3 v1] ofproto-dpif-mirror: Always revalidate on mirror update.

2024-09-17 Thread Mike Pattrick
Previously updating mirror settings would not trigger a revalidation, this could result in impactful changes to mirrors taking a long time to take effect. This change sets need_revalidate whenever a setting is successfully set on a mirror. Fixes: ec7ceaed4f3e ("ofproto-dpif: Modularize mirror cod

Re: [ovs-dev] [PATCH ovn] northd: Don't monitor most of northbound external IDs.

2024-09-17 Thread Ilya Maximets
On 9/17/24 17:53, Ilya Maximets wrote: > ovn-northd copies external IDs from Logical Switch, Router and their > Port records to corresponding Southbound Datapath and Port Binding > records. IDs in other tables are not used by northd in any way, so > there is no point in monitoring them. > > CMSes

[ovs-dev] [PATCH ovn] northd: Respect --ecmp-symmetric-reply for single routes.

2024-09-17 Thread Rosemarie O'Riorden
When preparing to build ECMP and static route flows, routes are sorted into unique routes (meaning they are not part of a group) or they are added to EMCP groups. Then, ECMP route flows are built out of the groups, and static route flows are built out of the unique routes. However, 'unique routes'

[ovs-dev] [PATCH ovn] northd: Don't monitor most of northbound external IDs.

2024-09-17 Thread Ilya Maximets
ovn-northd copies external IDs from Logical Switch, Router and their Port records to corresponding Southbound Datapath and Port Binding records. IDs in other tables are not used by northd in any way, so there is no point in monitoring them. CMSes tend to create a huge amount of external IDs for e

Re: [ovs-dev] [PATCH v5 3/3] ovsdb: Optimize monitor update by directly serializing data into ds.

2024-09-17 Thread Eelco Chaudron
On 16 Sep 2024, at 18:33, Grigorii Nazarov wrote: > `Hi Eelco, > > See my comments below. > > I'm new to this process, so I guess I'm to address all the issues together > when we agree on currently mentioned? You are right Grigorii. After we wrap up the discussion on all patches in the series

[ovs-dev] [PATCH ovn] ipam: Do not report error for static assigned IPs.

2024-09-17 Thread Lorenzo Bianconi
Do not report error in ipam_insert_ip routine for addresses staticatically assigned to ovn logical {swith,router} ports since they have precedence on addressed dynamically assigned by ipam. Reported-at: https://issues.redhat.com/browse/FDP-752 Signed-off-by: Lorenzo Bianconi --- northd/ipam.c

Re: [ovs-dev] [PATCH branch-2.17] ofproto-dpif-upcall: Avoid stale ukeys leaks.

2024-09-17 Thread Simon Horman
On Thu, Sep 12, 2024 at 05:13:56PM -0400, Aaron Conole wrote: > Eelco Chaudron writes: > > > It is observed in some environments that there are much more ukeys than > > actual DP flows. For example: > > > > $ ovs-appctl upcall/show > > system@ovs-system: > > flows : (current 7) (avg 6) (max 117)

Re: [ovs-dev] OVN technical community meeting - Sep 16th

2024-09-17 Thread Dumitru Ceara
On 9/13/24 12:18, Dumitru Ceara wrote: > Hi everyone, > > Just a quick reminder for anyone interested in joining the next OVN > technical meeting. It's scheduled to happen Monday, September 16th, at > 3PM UTC. > Thanks to everyone who could join. For those who want to watch the recording it's

Re: [ovs-dev] [PATCH v1] netdev-dpdk: Disable outer udp checksum offload for txgbe driver.

2024-09-17 Thread Simon Horman
On Sat, Sep 14, 2024 at 10:52:38AM +0800, Jun Wang wrote: > Fixing the issue of incorrect outer UDP checksum in packets sent by > the wangxun network card (driver is txgbe), we disabled > RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM. > > Fixes: 084c8087292c ("userspace: Support VXLAN and GENEVE TSO.") > Rep

Re: [ovs-dev] [PATCH] ci: Run oss-fuzz build stage during CI.

2024-09-17 Thread Simon Horman
On Mon, Sep 16, 2024 at 12:32:44PM +0200, Eelco Chaudron wrote: > The oss-fuzz project builds specific OVS fuzzing code located in the > tests/oss-fuzz/ directory of our repository. However, this code is > not currently built as part of our CI pipeline, creating a potential > risk that changes in t

Re: [ovs-dev] RFC OVN: fabric integration

2024-09-17 Thread Vladislav Odintsov
On 16.09.2024 17:41, Dumitru Ceara wrote: On 9/12/24 19:45, Roberto Bartzen Acosta wrote: >          - The result of this synchronization is basically: >          - SB->NB: creating/deleting/updating Logical_Router_Static_Route >          entries for learned routes in the Ro