Thanks for the reviews Shashank!
I applied the series on master.
From: Shashank Ram [mailto:shashan...@gmail.com]
Sent: Tuesday, November 7, 2017 3:04 AM
To: Alin Gabriel Serdean
Cc: d...@openvswitch.org
Subject: Re: [ovs-dev] [PATCH v2 1/7] datapath-windows: Use only non executable
patch uses the full form of the IPv6 address instead of its shorter
notation.
Signed-off-by: Alin Gabriel Serdean
---
tests/ovn.at | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/ovn.at b/tests/ovn.at
index f051d86..b6a83cc 100644
--- a/tests/ovn.at
+++ b/tests/ovn.at
> -Original Message-
> From: Ben Pfaff [mailto:b...@ovn.org]
> Sent: Tuesday, November 7, 2017 12:16 AM
> To: Alin Gabriel Serdean
> Cc: d...@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH v2 1/6] build-windows: Suppress output from
> MSBuild
>
> On Mon, Nov 0
When trying to compile with WDK 10 the files under
datapath-windows/ovsext/Netlink
can't see the headers from datapath-windows/ovsext.
Add the project directory under the include files.
Signed-off-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/ovsext.vcxproj | 6 +++---
1 file ch
Found while compiling with VS2017.
Signed-off-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/IpHelper.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/datapath-windows/ovsext/IpHelper.h
b/datapath-windows/ovsext/IpHelper.h
index 6bda1b1..0556965 100644
--- a/datapath
Visual Studio 2017 uses `.vs` directory for temporary files.
Add the directory to gitignore.
Signed-off-by: Alin Gabriel Serdean
---
datapath-windows/.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/datapath-windows/.gitignore b/datapath-windows/.gitignore
index 5d84960..8e8f0c7
This series includes fixes that were found while compiling using
WDK 1709 and Visual Studio 2017.
Alin Gabriel Serdean (3):
datapath-windows: Add directory to .gitignore
datapath-windows: Change include type in Iphelper.h
datapath-windows: Add include directory to ovsext project
datapath
From: Alin Serdean
If we can't allocate the NBL just go to the cleanup sequence.
Found using WDK 10 static code analysis.
Signed-off-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/IpFragment.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/datapath-windows/ovsext/IpFragment
From: Alin Serdean
Check for return value when trying to initialize ovsInstanceListLock.
Also return the status back to caller of `OvsInitIpHelper`.
Signed-off-by: Alin Gabriel Serdean
---
v2: Removed an extra return. Suggested by: Shashank Ram r...@vmware.com
---
datapath-windows/ovsext
From: Alin Serdean
This fixes the static code analysis over the function
'OvsGetTcpPayloadLength'.
Signed-off-by: Alin Gabriel Serdean
---
v2: No change.
---
datapath-windows/ovsext/Conntrack.h | 17 +++--
1 file changed, 7 insertions(+), 10 deletions(-)
diff --git
From: Alin Serdean
`ethHdr` cannot be NULL because we did a partial copy before it.
Add an assert to keep the static analysis happy.
Signed-off-by: Alin Gabriel Serdean
---
v2: switch from if to assert
---
datapath-windows/ovsext/Actions.c | 1 +
1 file changed, 1 insertion(+)
diff --git a
From: Alin Serdean
The result of `RtlStringCbLengthW` is not currently checked and triggers
a warning using the WDK 8.1 static analysis.
This patch treats the result of `RtlStringCbLengthW`.
Signed-off-by: Alin Gabriel Serdean
---
v2: s/Fail/Failed. Suggested by: Shashank Ram r...@vmware.com
From: Alin Serdean
Found by inspection.
Signed-off-by: Alin Gabriel Serdean
---
v2: s/Fail/Failed. Suggested by: Shashank Ram r...@vmware.com
---
datapath-windows/ovsext/IpHelper.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/datapath-windows/ovsext/IpHelper.c
b
From: Alin Serdean
Use only non-executable memory when using MmGetSystemAddressForMdlSafe.
Introduce a new function called OvsGetMdlWithLowPriority for readability.
Found using WDK 10 static code analysis.
Signed-off-by: Alin Gabriel Serdean
---
v2: Change OvsGetMdlWithLowPrio to
Add a new variable to know on which platform we are compiling.
Make the msbuild command to be aware of the platform we want to build.
Shorter the msbuild parameters from `property:`->`p:`. Change slashes
to double slashes so msys does not get confused.
Signed-off-by: Alin Gabriel Serdean
Ac
Add variables to know for which platform we are building.
They are needed for the installer to know if it should install
in `Program Files (x86)` or `Program Files` and which registry
it needs to update.
Signed-off-by: Alin Gabriel Serdean
Acked-by: Alin Balutoiu
---
v2: Change comment
run as an individual process when the
platform is not x86.
Signed-off-by: Alin Gabriel Serdean
Acked-by: Alin Balutoiu
---
v2: Add acked
---
windows/ovs-windows-installer/ovs-windows-installer.wixproj | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/windows/ovs-windows
Until now the x64 build of the installer solution was pointing to the
x86 build of the WIX project.
This patch changes for them to match.
Signed-off-by: Alin Gabriel Serdean
Acked-by: Alin Balutoiu
---
v2: Add acked
---
windows/ovs-windows-installer.sln | 4 ++--
1 file changed, 2 insertions
Add `nologo` parameter to MSBuild to suppress the banner.
This will make tidier log messages.
Signed-off-by: Alin Gabriel Serdean
Acked-by: Alin Balutoiu
---
v2: Add acked
---
Makefile.am | 8
datapath-windows/automake.mk | 4 ++--
windows/automake.mk | 2
Remove duplicate and obsolete entries from the installer WIX project.
Found by inspection.
Signed-off-by: Alin Gabriel Serdean
Acked-by: Alin Balutoiu
---
v2: Add acked
---
.../ovs-windows-installer.wixproj | 36 --
1 file changed, 36 deletions(-)
diff
e. :
https://developercommunity.visualstudio.com/content/problem/22196/static-assert-cannot-compile-constexprs-method-tha.html
), but we don't have a fix yet.
This patch adds an explicit compare, although we could redefine the macro
for the same effect.
Signed-off-by: Alin Gabriel Serdean
---
incl
Gabriel Serdean
---
lib/ovs-atomic-msvc.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/lib/ovs-atomic-msvc.h b/lib/ovs-atomic-msvc.h
index 0b041c6..81f7682 100644
--- a/lib/ovs-atomic-msvc.h
+++ b/lib/ovs-atomic-msvc.h
@@ -41,6 +41,13 @@ typedef enum {
memory_order_seq_cst
This series adds support for userspace compiling on VS 2015/2017.
I would mark "ofp-actions: Add compare to offsetof need for MSVC 2015/17"
as RFC since it is not the cleanest solution.
Alin Gabriel Serdean (4):
windows: _set_output_format is no longer required from VS2015
wi
Starting from WDK 10 the structure `timespec` is defined in .
This patch adds a check for the structure to make aware of it, so
it doesn't try to redefine the structure.
Signed-off-by: Alin Gabriel Serdean
---
m4/openvswitch.m4 | 1 +
1 file changed, 1 insertion(+)
diff --git
_set_output_format is deprecated ang no longer required
starting from MSC_VER 1900 (VS 2015):
https://msdn.microsoft.com/en-us/library/bb531344(v=vs.140).aspx .
Signed-off-by: Alin Gabriel Serdean
---
lib/util.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/util.c b/lib/util.c
Add `nologo` parameter to MSBuild to suppress the banner.
This will make tidier log messages.
Signed-off-by: Alin Gabriel Serdean
---
Makefile.am | 8
datapath-windows/automake.mk | 4 ++--
windows/automake.mk | 2 +-
3 files changed, 7 insertions(+), 7
Add a new variable to know on which platform we are compiling.
Make the msbuild command to be aware of the platform we want to build.
Shorter the msbuild parameters from `property:`->`p:`. Change slashes
to double slashes so msys does not get confused.
Signed-off-by: Alin Gabriel Serd
Add variables to know for which platform we are building.
They are needed for the installer to know if it should install
in `Program Files (x86)` or `Program Files` and which registry
it needs to update.
Signed-off-by: Alin Gabriel Serdean
---
windows/ovs-windows-installer/Product.wxs | 12
run as an individual process when the
platform is not x86.
Signed-off-by: Alin Gabriel Serdean
---
windows/ovs-windows-installer/ovs-windows-installer.wixproj | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/windows/ovs-windows-installer/ovs-windows-installer.wixproj
b
Until now the x64 build of the installer solution was pointing to the
x86 build of the WIX project.
This patch changes for them to match.
Signed-off-by: Alin Gabriel Serdean
---
windows/ovs-windows-installer.sln | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/windows
Remove duplicate and obsolete entries from the installer WIX project.
Found by inspection.
Signed-off-by: Alin Gabriel Serdean
---
.../ovs-windows-installer.wixproj | 36 --
1 file changed, 36 deletions(-)
diff --git a/windows/ovs-windows-installer/ovs
Installer fixes to allow the MSI build using msbuild(64bit variant).
Alin Gabriel Serdean (6):
build-windows: Suppress output from MSBuild
installer-windows: Remove unused entries from WIX project
installer-windows: Resolve WIX solution build type
installer-windows: Call WIX binaries
Commit d5c70d4bcc344ae10a644b83f1790a0235871efc fixed the MSVC issue
however, introduced a sparse error:
"tests/test-ovn.c:205:43: warning: Using plain integer as NULL pointer"
Use 'NULL' instead of '0'.
Signed-off-by: Alin Gabriel Serdean
---
tests/test-o
MSVC doesn't like an empty initializer for a flexible array.
Add a zero initializer to keep the compiler happy.
Fixes current build on Windows.
Signed-off-by: Alin Gabriel Serdean
---
tests/test-ovn.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/test-ovn.c b/
Test: "testing ovn -- ensure one gw controller restart in HA doesn't
bounce the master" uses the command `truncate`.
Skip the test if the command is not found.
Signed-off-by: Alin Gabriel Serdean
---
tests/ovn.at | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/ovn.at
broken.
Signed-off-by: Alin Gabriel Serdean
Suggested-by: Ben Pfaff
---
v2: Change commit message.
---
lib/ovs-atomic-msvc.h | 12
lib/ovs-atomic.h | 2 +-
2 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/lib/ovs-atomic-msvc.h b/lib/ovs-atomic-msvc.h
index c6a7db3
more performance.
As a side effect fix tests on x64 because usage of `ovs-atomic-pthreads.h`
is currently broken.
Signed-off-by: Alin Gabriel Serdean
Suggested-by: Ben Pfaff
---
lib/ovs-atomic-msvc.h | 12
lib/ovs-atomic.h | 2 +-
2 files changed, 13 insertions(+), 1 deletion
names (default behavior),
we shall try to define an alias to overcome dashes if the shell allows it.
Signed-off-by: Alin Gabriel Serdean
Suggested-by: Ben Pfaff
---
tests/ovs-macros.at | 37 +
1 file changed, 37 insertions(+)
diff --git a/tests/ovs-macros.at b/
Just a small nit to see current build status of appveyor.
Also add a link so one could easily reach the history of the builds.
Signed-off-by: Alin Gabriel Serdean
---
README.rst | 2 ++
1 file changed, 2 insertions(+)
diff --git a/README.rst b/README.rst
index 28f8590..251e2bb 100644
--- a
Alin Gabriel Serdean
Requested-by: Anand Kumar
---
lib/daemon-windows.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/lib/daemon-windows.c b/lib/daemon-windows.c
index 1ba714d..2ba62d2 100644
--- a/lib/daemon-windows.c
+++ b/lib/daemon-windows.c
@@ -138,6 +138,12 @@ service_start(int *
201 - 240 of 240 matches
Mail list logo
