Re: [ovs-dev] [PATCH] ofproto: Fix crash on PACKET_OUT due to recursive locking after upcall.

2019-11-21 Thread Anil Kumar Koli via dev
Hi Ben, I was not able to reproduce this issue in ovs sandbox, but able to test this patch on local testbed which had this issue and the patch works. Thanks & Regards, Anil Kumar. -Original Message- From: Ilya Maximets Sent: Friday, 22 November, 2019 12:02 AM To: Ilya Maximets ;

Re: [ovs-dev] [PATCH v1] ofproto: Fix OVS crash when packets hit Openflow rules with certain combinations of nested actions

2019-11-06 Thread Anil Kumar Koli via dev
Hi Ben/Ilya, I was not able to reproduce the issue under OVS sandbox. I have tested the below patch in my local testbed and didn't observe the crash. https://patchwork.ozlabs.org/patch/1188193/ Please find attached the commands to reproduce the issue on a physical host/VM. 1. Start the

Re: [ovs-dev] [PATCH v1] ofproto: Fix OVS crash when packets hit Openflow rules with certain combinations of nested actions

2019-11-03 Thread Anil Kumar Koli via dev
Hi Ben, I have not tried it under OVS sandbox. I can test the patch on both OVS sandbox and my local testbed and update with the results. Thanks & Regards, Anil Kumar -Original Message- From: Ben Pfaff Sent: Friday, 1 November, 2019 11:12 PM To: Ilya Maximets Cc: Ilya Maximets ; Anil

Re: [ovs-dev] [PATCH v1] ofproto: Fix OVS crash when packets hit Openflow rules with certain combinations of nested actions

2019-09-24 Thread Anil Kumar Koli via dev
Hi Ben & Ilya, The provided changes were internally tested and works fine. Can we consider these changes for now and can be later enhanced as suggested by Ilya. Best Regards, Anil Kumar. -Original Message- From: Anil Kumar Koli Sent: Friday, 13 September, 2019 08:20 AM To: 'Ben Pfaff'

Re: [ovs-dev] [PATCH v1] ofproto: Fix OVS crash when packets hit Openflow rules with certain combinations of nested actions

2019-09-12 Thread Anil Kumar Koli via dev
Hi Ben, Please consider this as a gentle remainder and provide your inputs on the below issue. Thanks & Regards, Anil Kumar -Original Message- From: Anil Kumar Koli Sent: Thursday, 5 September, 2019 11:12 PM To: 'Ben Pfaff' Cc: 'Ilya Maximets' ; 'ovs-dev@openvswitch.org' Subject:

Re: [ovs-dev] [PATCH v1] ofproto: Fix OVS crash when packets hit Openflow rules with certain combinations of nested actions

2019-09-05 Thread Anil Kumar Koli via dev
Hi Ben, Please consider this as a gentle remainder and provide your inputs on the below issue. This issue has been discussed earlier in the following thread. https://mail.openvswitch.org/pipermail/ovs-discuss/2019-April/048494.html Best Regards, Anil Kumar. -Original Message- From: Anil

Re: [ovs-dev] [PATCH v1] ofproto: Fix OVS crash when packets hit Openflow rules with certain combinations of nested actions

2019-09-03 Thread Anil Kumar Koli via dev
Hi Ilya, Sorry for late reply and thanks for the review comments. Yes, the issue happens only in the userspace datapath and not in kernel datapath. I have tested it on kernel datapath and could not see this issue for the same build. Regarding the suggested solution, I still feel like going

Re: [ovs-dev] [PATCH v1] ofproto: Fix OVS crash when packets hit Openflow rules with certain combinations of nested actions

2019-08-29 Thread Anil Kumar Koli via dev
Hi Ilya, Thanks for the review. Please find below the stack trace of the crash (gdb) bt #0 0x7f0a3da46c37 in __GI_raise (sig=sig@entry=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56 #1 0x7f0a3da4a028 in __GI_abort () at abort.c:89 #2 0x0094262e in ovs_abort_valist

Re: [ovs-dev] [ovs-discuss] ovs 2.8.2 crash

2019-04-02 Thread Anil Kumar Koli via dev
Hello OVS team, This issue is observed in ovs-master with dpdk-18.11. Please find the steps to reproduce. root@ubuntu16:/home/sdn# ovs-vswitchd --version ovs-vswitchd (Open vSwitch) 2.11.90 DPDK 18.11.0 root@ubuntu16:/home/sdn# apport-retrace -g

[ovs-dev] [ovs-discuss] ovs 2.8.2 crash

2019-03-29 Thread Anil Kumar Koli via dev
Hello OVS team, I have a ovs-vswitched crash of ovs version 2.8.2. I don't have the flow which has lead to this crash, but from the backtrace I could see that the crash is because of double locking. The ofproto_mutex lock is acquired in handle_packet_out() and the same lock is being tried to