[ovs-dev] [PATCH v4 0/2] ALLOW Stateless NAT operations

2019-10-31 Thread Ankur Sharma
ons, which will replace source and destination ips, while recalculating the checksums. This option is applicable only for the NAT rules which can be 1:1 mapped between inner and external ips, i.e dnat_and_snat rule. Signed-off-by: Ankur Sharma Ankur Sharma (2): OVN: ADD nbctl cli to mark a dnat_and

[ovs-dev] [PATCH v4 1/2 ovn] OVN: ADD nbctl cli to mark a dnat_and_snat rule as stateless

2019-10-31 Thread Ankur Sharma
Adding ovn-nbctl to mark a dnat_and_snat rule as stateless. This configuration will added to "options" column of NAT table. Signed-off-by: Ankur Sharma --- ovn-nb.ovsschema | 6 -- ovn-nb.xml| 5 + tests/ovn-nbctl.at

Re: [ovs-dev] [PATCH v2 2/2 ovn] OVN: Use ipv4.src and ipv4.dst actions for NAT rules

2019-10-30 Thread Ankur Sharma
Hi Numan, Submitted a v3 yesterday, addressing all the review comments. Please take a look. Regards, Ankur -Original Message- From: Numan Siddique Sent: Monday, October 28, 2019 6:40 AM To: Ankur Sharma Cc: ovs-dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH v2 2/2 ovn] OVN: Use

[ovs-dev] [PATCH v3 2/2 ovn] OVN: Use ip4.src and ip4.dst actions for NAT rules

2019-10-29 Thread Ankur Sharma
For dnat_and_snat rules which are meant to be stateless instead of using ct_snat/dnat OVN actions, we will use ip4.src/ip4.dst. This actions will do 1:1 mapping to inner ip to external ip, while recalculating the checksums. Signed-off-by: Ankur Sharma --- northd/ovn-northd.8.xml | 34

[ovs-dev] [PATCH v3 1/2 ovn] OVN: ADD nbctl cli to mark a dnat_and_snat rule as stateless

2019-10-29 Thread Ankur Sharma
Adding ovn-nbctl to mark a dnat_and_snat rule as stateless. This configuration will added to "options" column of NAT table. Signed-off-by: Ankur Sharma --- ovn-nb.ovsschema | 6 -- ovn-nb.xml| 5 + tests/ovn-nbctl.at

[ovs-dev] [PATCH v3 0/2] ALLOW Stateless NAT operations

2019-10-29 Thread Ankur Sharma
ons, which will replace source and destination ips, while recalculating the checksums. This option is applicable only for the NAT rules which can be 1:1 mapped between inner and external ips, i.e dnat_and_snat rule. Signed-off-by: Ankur Sharma Ankur Sharma (2): OVN: ADD nbctl cli to mark a dnat_and

Re: [ovs-dev] [PATCH v2 1/2 ovn] OVN: ADD nbctl cli to mark a dnat_and_snat rule as stateless

2019-10-17 Thread Ankur Sharma
Hi, Gentle reminder for reviewing this series. Regards, Ankur From: Ankur Sharma Sent: Friday, October 4, 2019 1:13 PM To: ovs-dev@openvswitch.org Cc: Ankur Sharma Subject: [PATCH v2 1/2 ovn] OVN: ADD nbctl cli to mark a dnat_and_snat rule as stateless

[ovs-dev] [PATCH v3] OVN: Send RARP for vif ports for which OVN does not know the IP.

2019-10-11 Thread Ankur Sharma
will not work, since TOR will direct the packets destined to this VIF to old chassis. This patch addresses the same by advertising reverse ARP (RARP) for non ip assigned bridged logical switch connected VIF ports. Signed-off-by: Ankur Sharma --- controller/pinctrl.c | 225

[ovs-dev] [PATCH v2] OVN: Send RARP for vif ports for which OVN does not know the IP.

2019-10-11 Thread Ankur Sharma
will not work, since TOR will direct the packets destined to this VIF to old chassis. This patch addresses the same by advertising reverse ARP (RARP) for non ip assigned bridged logical switch connected VIF ports. Signed-off-by: Ankur Sharma --- controller/pinctrl.c | 225

Re: [ovs-dev] [PATCH v1 1/3 ovn] OVN: ADD new ovn actions to replace source and destination ip

2019-10-04 Thread Ankur Sharma
Hi Ben, Submitted a v2 without new OVN actions. Ease of interpretation was the reasoning for having these actions, but you are right they were redundant. Regards, Ankur -Original Message- From: Ben Pfaff Sent: Friday, October 4, 2019 10:37 AM To: Ankur Sharma Cc: ovs-dev

[ovs-dev] [PATCH v2 2/2 ovn] OVN: Use ipv4.src and ipv4.dst actions for NAT rules

2019-10-04 Thread Ankur Sharma
For dnat_and_snat rules which are meant to be stateless instead of using ct_snat/dnat OVN actions, we will use ipv4.src/ipv4.dst. This actions will do 1:1 mapping to inner ip to external ip, while recalculating the checksums. Signed-off-by: Ankur Sharma --- northd/ovn-northd.8.xml | 34

[ovs-dev] [PATCH v2 0/2] ALLOW Stateless NAT operations

2019-10-04 Thread Ankur Sharma
ons, which will replace source and destination ips, while recalculating the checksums. This option is applicable only for the NAT rules which can be 1:1 mapped between inner and external ips, i.e dnat_and_snat rule. Signed-off-by: Ankur Sharma Ankur Sharma (2): OVN: ADD nbctl cli to mark a dna

[ovs-dev] [PATCH v2 1/2 ovn] OVN: ADD nbctl cli to mark a dnat_and_snat rule as stateless

2019-10-04 Thread Ankur Sharma
Adding ovn-nbctl to mark a dnat_and_snat rule as stateless. This configuration will added to "options" column of NAT table. Signed-off-by: Ankur Sharma --- ovn-nb.ovsschema | 6 -- ovn-nb.xml| 5 + tests/ovn-nbctl.at

[ovs-dev] [PATCH v1 2/3 ovn] OVN: ADD nbctl cli to mark a dnat_and_snat rule as stateless

2019-10-03 Thread Ankur Sharma
Adding ovn-nbctl to mark a dnat_and_snat rule as stateless. This configuration will added to "options" column of NAT table. Signed-off-by: Ankur Sharma --- ovn-nb.ovsschema | 6 -- ovn-nb.xml| 5 + tests/ovn-nbctl.at

[ovs-dev] [PATCH v1 3/3 ovn] OVN: Use replace_src_ip and replace_dst_ip for NAT rules

2019-10-03 Thread Ankur Sharma
For dnat_and_snat rules which are meant to be stateless instead of using ct_snat/dnat OVN actions, we will use replace_src/dst_ip actions. This actions will do 1:1 mapping to inner ip to dest ip, while recalculating the checksums. Signed-off-by: Ankur Sharma --- northd/ovn-northd.8.xml | 34

[ovs-dev] [PATCH v1 1/3 ovn] OVN: ADD new ovn actions to replace source and destination ip

2019-10-03 Thread Ankur Sharma
This patch adds 2 new ovn actions, "replace_src_ip" and "replace_dst_ip" These actions map to mod_nw_src and mod_nw_dst OVS actions respectively. These actions simply replace the source and destination IPs of the packets, while changing the L3 and L4 checksums. Signed-

[ovs-dev] [PATCH v1 0/3] ALLOW Stateless NAT operations

2019-10-03 Thread Ankur Sharma
ace source and destination ips, while recalculating the checksums. This option is applicable only for the NAT rules which can be 1:1 mapped between inner and external ips, i.e dnat_and_snat rule. Signed-off-by: Ankur Sharma Ankur Sharma (3): OVN: ADD new ovn actions to replace source and destination ip

Re: [ovs-dev] [PATCH v4 ovn] Replace chassis mac with router port mac on destination chassis

2019-09-10 Thread Ankur Sharma
Hi Numan, Thanks for calling out the failure. Fixed the same in v5. Did not realize that we have removed OVS tests from repo, hence based on test number, I ruled it out as an unrelated tests. Regards, Ankur From: Numan Siddique Sent: Tuesday, September 10, 2019 12:51 AM To: Ankur Sharma Cc

[ovs-dev] [PATCH v5 ovn] Replace chassis mac with router port mac on destination chassis

2019-09-10 Thread Ankur Sharma
, whereas with conjunction that number comes down to 1000 (500 + 500). Signed-off-by: Ankur Sharma --- controller/chassis.c| 2 +- controller/chassis.h| 3 + controller/ovn-controller.c | 5 + controller/physical.c | 222

Re: [ovs-dev] [PATCH v3 ovn] Replace chassis mac with router port mac on destination chassis

2019-09-08 Thread Ankur Sharma
Hi Numan, Thanks a lot for the feedback. Submitted a V4, please take a look. Regards, Ankur From: Numan Siddique Sent: Thursday, September 5, 2019 11:12 PM To: Ankur Sharma Cc: ovs-dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH v3 ovn] Replace chassis mac with router port mac

[ovs-dev] [PATCH v4 ovn] Replace chassis mac with router port mac on destination chassis

2019-09-08 Thread Ankur Sharma
, whereas with conjunction that number comes down to 1000 (500 + 500). Signed-off-by: Ankur Sharma --- controller/chassis.c| 2 +- controller/chassis.h| 3 + controller/ovn-controller.c | 5 + controller/physical.c | 222

Re: [ovs-dev] [PATCH v1 ovn] OVN: Send RARP for vif ports for which OVN does not know the IP.

2019-09-03 Thread Ankur Sharma
, September 3, 2019 3:47 AM To: Ankur Sharma Cc: ovs-dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH v1 ovn] OVN: Send RARP for vif ports for which OVN does not know the IP. On Fri, Aug 2, 2019 at 3:12 AM Ankur Sharma mailto:ankur.sha...@nutanix.com>> wrote: ISSUE: For a VIF port (on a b

Re: [ovs-dev] [PATCH v2 ovn] Replace chassis mac with router port mac on destination chassis

2019-09-03 Thread Ankur Sharma
Hi Numan, Thanks a lot for trying the patch. Just submitted the v3. Regards, Ankur From: Numan Siddique Sent: Tuesday, September 3, 2019 3:42 AM To: Ankur Sharma Cc: ovs-dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH v2 ovn] Replace chassis mac with router port mac on destination chassis

[ovs-dev] [PATCH v3 ovn] Replace chassis mac with router port mac on destination chassis

2019-09-03 Thread Ankur Sharma
, whereas with conjunction that number comes down to 1000 (500 + 500). Signed-off-by: Ankur Sharma --- controller/chassis.c| 2 +- controller/chassis.h| 3 + controller/ovn-controller.c | 5 + controller/physical.c | 222

Re: [ovs-dev] [PATCH v6 3/4 ovn] OVN: Vlan backed DVR N-S, avoid get_arp on non redirect chassis.

2019-08-27 Thread Ankur Sharma
there itself. Let me know your thoughts on this. I will be happy to discuss further and make additional changes, if needed. Appreciate your feedback. Regards, Ankur From: Numan Siddique Sent: Saturday, August 24, 2019 11:59 AM To: Ankur Sharma Cc: ovs-dev@openvswitch.org; Lorenzo Bianconi Subject

Re: [ovs-dev] [PATCH v7 1/3 ovn] OVN: Vlan backed DVR N-S, redirect-type option

2019-08-27 Thread Ankur Sharma
Gosh, bad miss, just now sent out a V8. Regards, Ankur From: Numan Siddique Sent: Tuesday, August 27, 2019 6:39 PM To: Ankur Sharma Cc: ovs-dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH v7 1/3 ovn] OVN: Vlan backed DVR N-S, redirect-type option On Wed, Aug 28, 2019, 6:34 AM Ankur Sharma

[ovs-dev] [PATCH v8 2/3 ovn] OVN: Vlan backed DVR N-S, avoid get_arp on non redirect chassis.

2019-08-27 Thread Ankur Sharma
port mac will be going through continous mac moves in physical network. Worst, it would affect the redirection, since it uses router port mac as destination mac. Signed-off-by: Ankur Sharma --- northd/ovn-northd.8.xml | 12 northd/ovn-northd.c | 32

[ovs-dev] [PATCH v8 3/3 ovn] OVN: Vlan backed DVR N-S, redirect packet via localnet port

2019-08-27 Thread Ankur Sharma
decremented twice, since the packets are going through logical router ingress pipeline twice (once on sender chassis and again on gateway chassis). No changes needed for the reverse path. Signed-off-by: Ankur Sharma --- controller/physical.c | 255 +++-- lib/o

[ovs-dev] [PATCH v8 1/3 ovn] OVN: Vlan backed DVR N-S, redirect-type option

2019-08-27 Thread Ankur Sharma
release/why it was removed. I do not see a harm in adding it back. Signed-off-by: Ankur Sharma --- northd/ovn-northd.c | 6 + ovn-nb.xml| 43 ++ tests/ovn-nbctl.at| 25 tests/ovn-northd.at | 31

[ovs-dev] [PATCH v8 0/3 ovn] OVN: Vlan backed DVR, enable N-S packet flow

2019-08-27 Thread Ankur Sharma
> v4 -- * Handle review comments. * Rebased to TOT. v2 -> v3 -- * Fix merge conflicts. v1 -> v2 -- * Added ovn in the comment description prefix. Ankur Sharma (3): OVN: Vlan backed DVR N-S, redirect-type option OVN: Vlan backed DVR N-S, avoid get_arp on non redir

Re: [ovs-dev] [PATCH v6 2/4 ovn] OVN: Vlan backed DVR N-S, redirect-type option

2019-08-27 Thread Ankur Sharma
Hi Numan, Thanks a lot for the feedback. Just sent out V7 with following changes. a. Replace “vlan” with “bridged”. b. Remove dependency of datum_to_smap. Appreciate your inputs. Regards, Ankur From: Numan Siddique Sent: Saturday, August 24, 2019 11:53 AM To: Ankur Sharma Cc: ovs-dev

[ovs-dev] [PATCH v7 3/3 ovn] OVN: Vlan backed DVR N-S, redirect packet via localnet port

2019-08-27 Thread Ankur Sharma
decremented twice, since the packets are going through logical router ingress pipeline twice (once on sender chassis and again on gateway chassis). No changes needed for the reverse path. Signed-off-by: Ankur Sharma --- controller/physical.c | 255 +++-- lib/o

[ovs-dev] [PATCH v7 2/3 ovn] OVN: Vlan backed DVR N-S, avoid get_arp on non redirect chassis.

2019-08-27 Thread Ankur Sharma
port mac will be going through continous mac moves in physical network. Worst, it would affect the redirection, since it uses router port mac as destination mac. Signed-off-by: Ankur Sharma --- northd/ovn-northd.8.xml | 12 northd/ovn-northd.c | 32

[ovs-dev] [PATCH v7 1/3 ovn] OVN: Vlan backed DVR N-S, redirect-type option

2019-08-27 Thread Ankur Sharma
release/why it was removed. I do not see a harm in adding it back. Signed-off-by: Ankur Sharma --- northd/ovn-northd.c | 6 + ovn-nb.xml| 43 ++ ovs/lib/ovsdb-data.c | 11 + ovs/lib/ovsdb-data.h | 2 ++ tests/ovn-nbctl.at| 25 +

[ovs-dev] [PATCH v7 0/3 ovn] OVN: Vlan backed DVR, enable N-S packet flow

2019-08-27 Thread Ankur Sharma
v2 -> v3 -- * Fix merge conflicts. v1 -> v2 -- * Added ovn in the comment description prefix. Ankur Sharma (3): OVN: Vlan backed DVR N-S, redirect-type option OVN: Vlan backed DVR N-S, avoid get_arp on non redirect chassis. OVN: Vlan backed DVR N-S, redirect

[ovs-dev] [PATCH v2 ovn] Replace chassis mac with router port mac on destination chassis

2019-08-26 Thread Ankur Sharma
, whereas with conjunction that number comes down to 1000 (500 + 500). Signed-off-by: Ankur Sharma --- controller/chassis.c| 2 +- controller/chassis.h| 3 + controller/ovn-controller.c | 5 + controller/physical.c | 222

Re: [ovs-dev] [PATCH v1 ovn] OVN: Replace chassis mac with router port mac on destination chassis

2019-08-26 Thread Ankur Sharma
Sent: Monday, August 26, 2019 5:02 AM To: Ankur Sharma Cc: ovs-dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH v1 ovn] OVN: Replace chassis mac with router port mac on destination chassis Hi Ankur, This patch doesn't apply now. Can you please re base. Few comments below Thanks Numan On Thu

Re: [ovs-dev] [PATCH v5 1/4 ovn] OVN: Do not replace router port mac on gateway chassis.

2019-08-22 Thread Ankur Sharma
Hi Numan, Submitted a v6 last week. Awaiting your feedback on it, please feel free to let me know if additional changes are needed. Thanks Regards, Ankur From: Ankur Sharma Sent: Friday, August 16, 2019 5:37 PM To: Numan Siddique Cc: ovs-dev@openvswitch.org Subject: RE: [ovs-dev] [PATCH v5 1/4

[ovs-dev] [PATCH v1 ovn] OVN: Replace chassis mac with router port mac on destination chassis

2019-08-21 Thread Ankur Sharma
, whereas with conjunction that number comes down to 1000 (500 + 500). Signed-off-by: Ankur Sharma --- controller/chassis.c| 2 +- controller/chassis.h| 3 + controller/ovn-controller.c | 5 + controller/physical.c | 222

[ovs-dev] [PATCH v6 1/4 ovn] OVN: Do not replace router port mac on gateway chassis.

2019-08-16 Thread Ankur Sharma
the same. Signed-off-by: Ankur Sharma --- controller/lport.c| 20 controller/lport.h| 6 + controller/physical.c | 18 ++- controller/pinctrl.c | 20 +--- tests/ovn.at | 321 ++ 5 files changed, 364 insertions(+), 21

[ovs-dev] [PATCH v6 4/4 ovn] OVN: Vlan backed DVR N-S, redirect packet via localnet port

2019-08-16 Thread Ankur Sharma
decremented twice, since the packets are going through logical router ingress pipeline twice (once on sender chassis and again on gateway chassis). No changes needed for the reverse path. Signed-off-by: Ankur Sharma --- controller/physical.c | 255 +++-- lib/o

Re: [ovs-dev] [PATCH v5 1/4 ovn] OVN: Do not replace router port mac on gateway chassis.

2019-08-16 Thread Ankur Sharma
Hi Numan, My bad, I missed the sleep related comments. Fixed the same in v6, please take a look. Appreciate your help. Regards, Ankur From: Numan Siddique Sent: Friday, August 16, 2019 5:46 AM To: Ankur Sharma Cc: ovs-dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH v5 1/4 ovn] OVN: Do

[ovs-dev] [PATCH v6 3/4 ovn] OVN: Vlan backed DVR N-S, avoid get_arp on non redirect chassis.

2019-08-16 Thread Ankur Sharma
port mac will be going through continous mac moves in physical network. Worst, it would affect the redirection, since it uses router port mac as destination mac. Signed-off-by: Ankur Sharma --- northd/ovn-northd.c | 32 1 file changed, 32 insertions(+

[ovs-dev] [PATCH v6 0/4 ovn] OVN: Vlan backed DVR, enable N-S packet flow

2019-08-16 Thread Ankur Sharma
ed to the logical router pipeline. v5 -> v6 -- * Removed sleep from unit tests v4 -> v5 -- * Fixed a compilation warning in lport.h v3 -> v4 -- * Handle review comments. * Rebased to TOT. v2 -> v3 -- * Fix merge conflicts. v1 -> v2 ------ * Added o

[ovs-dev] [PATCH v6 2/4 ovn] OVN: Vlan backed DVR N-S, redirect-type option

2019-08-16 Thread Ankur Sharma
/why it was removed. I do not see a harm in adding it back. Signed-off-by: Ankur Sharma --- northd/ovn-northd.c | 6 + ovn-nb.xml| 43 ovs/lib/ovsdb-data.c | 11 + ovs/lib/ovsdb-data.h | 2 ++ tests/ovn-nbctl.at| 25 +++

[ovs-dev] [PATCH v5 4/4 ovn] OVN: Vlan backed DVR N-S, redirect packet via localnet port

2019-08-15 Thread Ankur Sharma
decremented twice, since the packets are going through logical router ingress pipeline twice (once on sender chassis and again on gateway chassis). No changes needed for the reverse path. Signed-off-by: Ankur Sharma --- controller/physical.c | 255 +++- lib/o

[ovs-dev] [PATCH v5 2/4 ovn] OVN: Vlan backed DVR N-S, redirect-type option

2019-08-15 Thread Ankur Sharma
/why it was removed. I do not see a harm in adding it back. Signed-off-by: Ankur Sharma --- northd/ovn-northd.c | 6 + ovn-nb.xml| 43 ovs/lib/ovsdb-data.c | 11 + ovs/lib/ovsdb-data.h | 2 ++ tests/ovn-nbctl.at| 25 +++

[ovs-dev] [PATCH v5 3/4 ovn] OVN: Vlan backed DVR N-S, avoid get_arp on non redirect chassis.

2019-08-15 Thread Ankur Sharma
port mac will be going through continous mac moves in physical network. Worst, it would affect the redirection, since it uses router port mac as destination mac. Signed-off-by: Ankur Sharma --- northd/ovn-northd.c | 32 1 file changed, 32 insertions(+

[ovs-dev] [PATCH v5 0/4 ovn] OVN: Vlan backed DVR, enable N-S packet flow

2019-08-15 Thread Ankur Sharma
ed to the logical router pipeline. v4 -> v5 -- * Fixed a compilation warning in lport.h v3 -> v4 -- * Handle review comments. * Rebased to TOT. v2 -> v3 -- * Fix merge conflicts. v1 -> v2 -- * Added ovn in the comment description prefix. Ankur Sharma

[ovs-dev] [PATCH v5 1/4 ovn] OVN: Do not replace router port mac on gateway chassis.

2019-08-15 Thread Ankur Sharma
the same. Signed-off-by: Ankur Sharma --- controller/lport.c| 20 controller/lport.h| 6 + controller/physical.c | 18 ++- controller/pinctrl.c | 20 +--- tests/ovn.at | 313 ++ 5 files changed, 356 insertions(+), 21

[ovs-dev] [PATCH v4 4/4 ovn] OVN: Vlan backed DVR N-S, redirect packet via localnet port

2019-08-13 Thread Ankur Sharma
decremented twice, since the packets are going through logical router ingress pipeline twice (once on sender chassis and again on gateway chassis). No changes needed for the reverse path. Signed-off-by: Ankur Sharma --- controller/physical.c | 255 +++- lib/o

[ovs-dev] [PATCH v4 1/4 ovn] OVN: Do not replace router port mac on gateway chassis.

2019-08-13 Thread Ankur Sharma
the same. Signed-off-by: Ankur Sharma --- controller/lport.c| 20 controller/lport.h| 5 + controller/physical.c | 18 ++- controller/pinctrl.c | 20 +--- tests/ovn.at | 313 ++ 5 files changed, 355 insertions(+), 21

[ovs-dev] [PATCH v4 0/4 ovn] OVN: Vlan backed DVR, enable N-S packet flow

2019-08-13 Thread Ankur Sharma
ed to the logical router pipeline. v3 -> v4 -- * Handle review comments. * Rebased to TOT. v2 -> v3 -- * Fix merge conflicts. v1 -> v2 -- * Added ovn in the comment description prefix. Ankur Sharma (4): OVN: Do not replace router port mac on gateway chassis. O

[ovs-dev] [PATCH v4 2/4 ovn] OVN: Vlan backed DVR N-S, redirect-type option

2019-08-13 Thread Ankur Sharma
/why it was removed. I do not see a harm in adding it back. Signed-off-by: Ankur Sharma --- northd/ovn-northd.c | 6 + ovn-nb.xml| 43 ovs/lib/ovsdb-data.c | 11 + ovs/lib/ovsdb-data.h | 2 ++ tests/ovn-nbctl.at| 25 +++

[ovs-dev] [PATCH v4 3/4 ovn] OVN: Vlan backed DVR N-S, avoid get_arp on non redirect chassis.

2019-08-13 Thread Ankur Sharma
port mac will be going through continous mac moves in physical network. Worst, it would affect the redirection, since it uses router port mac as destination mac. Signed-off-by: Ankur Sharma --- northd/ovn-northd.c | 32 1 file changed, 32 insertions(+

Re: [ovs-dev] OVN: Guest VLAN Tagging proposal

2019-08-12 Thread Ankur Sharma
Hi, Gentle reminder. Regards, Ankur From: Ankur Sharma Sent: Tuesday, August 6, 2019 3:33 PM To: ovs-dev@openvswitch.org Subject: OVN: Guest VLAN Tagging proposal Hi, PROBLEM STATEMENT: === OVN does not provide support for guest vlan tagging

Re: [ovs-dev] [PATCH v3 3/4 ovn] OVN: Vlan backed DVR N-S, avoid get_arp on non redirect chassis.

2019-08-08 Thread Ankur Sharma
Hi Numan, Thanks a lot for the review. Please find my comments inline. V4 will accommodate changes for review comments. Regards, Ankur From: Numan Siddique Sent: Thursday, August 8, 2019 12:13 AM To: Ankur Sharma Cc: ovs-dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH v3 3/4 ovn] OVN: Vlan

[ovs-dev] OVN: Guest VLAN Tagging proposal

2019-08-06 Thread Ankur Sharma
Hi, PROBLEM STATEMENT: === OVN does not provide support for guest vlan tagging, i.e where a VIF can vlan tag the packets. a. This feature can also be addressed as Trunking support as well (from logical switch port perspective). b. Main use case would be

Re: [ovs-dev] [PATCH v3 2/4 ovn] OVN: Vlan backed DVR N-S, redirect-type option

2019-08-05 Thread Ankur Sharma
, will submit v4 with addressed comments on all of them. Thanks Regards, Ankur From: Numan Siddique Sent: Monday, August 5, 2019 9:24 AM To: Ankur Sharma Cc: ovs-dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH v3 2/4 ovn] OVN: Vlan backed DVR N-S, redirect

Re: [ovs-dev] [PATCH v3 1/4 ovn] OVN: Do not replace router port mac on gateway chassis.

2019-08-05 Thread Ankur Sharma
Hi Numan, Sure, i will address the comments in V4. Regards, Ankur From: Numan Siddique Sent: Monday, August 5, 2019 9:03 AM To: Ankur Sharma Cc: ovs-dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH v3 1/4 ovn] OVN: Do not replace router port mac on gateway

[ovs-dev] [PATCH v3 4/4 ovn] OVN: Vlan backed DVR N-S, redirect packet via localnet port

2019-08-01 Thread Ankur Sharma
decremented twice, since the packets are going through logical router ingress pipeline twice (once on sender chassis and again on gateway chassis). No changes needed for the reverse path. Signed-off-by: Ankur Sharma --- controller/physical.c | 255 +++- lib/o

[ovs-dev] [PATCH v3 3/4 ovn] OVN: Vlan backed DVR N-S, avoid get_arp on non redirect chassis.

2019-08-01 Thread Ankur Sharma
port mac will be going through continous mac moves in physical network. Worst, it would affect the redirection, since it uses router port mac as destination mac. Signed-off-by: Ankur Sharma --- northd/ovn-northd.c | 22 ++ 1 file changed, 22 insertions(+) diff --git

[ovs-dev] [PATCH v3 2/4 ovn] OVN: Vlan backed DVR N-S, redirect-type option

2019-08-01 Thread Ankur Sharma
uration has to be done at the router port level. Signed-off-by: Ankur Sharma --- northd/ovn-northd.c | 6 ++ ovn-nb.xml| 43 ++ tests/ovn-nbctl.at| 25 ++ tests/ovn-northd.at | 31 +++

[ovs-dev] [PATCH v3 1/4 ovn] OVN: Do not replace router port mac on gateway chassis.

2019-08-01 Thread Ankur Sharma
the same. Signed-off-by: Ankur Sharma --- controller/physical.c | 19 ++- controller/pinctrl.c | 37 +++--- controller/pinctrl.h | 5 + tests/ovn.at | 313 ++ 4 files changed, 354 insertions(+), 20 deletions(-) diff --git a/controller

[ovs-dev] [PATCH v3 0/4 ovn] OVN: Vlan backed DVR, enable N-S packet flow

2019-08-01 Thread Ankur Sharma
ed to the logical router pipeline. v2 -> v3 -- * Fix merge conflicts. v1 -> v2 -- * Added ovn in the comment description prefix. Ankur Sharma (4): OVN: Do not replace router port mac on gateway chassis. OVN: Vlan backed DVR N-S, redirect-type option OVN: Vlan backed DVR N

[ovs-dev] [PATCH v1 ovn] OVN: Send RARP for vif ports for which OVN does not know the IP.

2019-08-01 Thread Ankur Sharma
will not work, since TOR will direct the packets destined to this VIF to old chassis. This patch addresses the same by advertising reverse ARP (RARP) for non ip assigned bridged logical switch connected VIF ports. Signed-off-by: Ankur Sharma --- controller/pinctrl.c | 238

Re: [ovs-dev] [PATCH v1 1/4] OVN: Do not replace router port mac on gateway chassis.

2019-08-01 Thread Ankur Sharma
Hi Numan, Sure, sent a v2 just now. Regards, Ankur From: Numan Siddique Sent: Thursday, August 1, 2019 9:08 AM To: Ankur Sharma Cc: ovs-dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH v1 1/4] OVN: Do not replace router port mac on gateway chassis. Hi Ankur, Can you please resend

[ovs-dev] [PATCH v2 4/4 ovn] OVN: Vlan backed DVR N-S, redirect packet via localnet port

2019-08-01 Thread Ankur Sharma
decremented twice, since the packets are going through logical router ingress pipeline twice (once on sender chassis and again on gateway chassis). No changes needed for the reverse path. Signed-off-by: Ankur Sharma --- controller/physical.c | 255 +++- lib/o

[ovs-dev] [PATCH v2 2/4 ovn] OVN: Vlan backed DVR N-S, redirect-type option

2019-08-01 Thread Ankur Sharma
uration has to be done at the router port level. Signed-off-by: Ankur Sharma --- northd/ovn-northd.c | 6 ++ ovn-nb.xml| 43 ++ tests/ovn-nbctl.at| 25 ++ tests/ovn-northd.at | 31 +++

[ovs-dev] [PATCH v2 3/4 ovn] OVN: Vlan backed DVR N-S, avoid get_arp on non redirect chassis.

2019-08-01 Thread Ankur Sharma
port mac will be going through continous mac moves in physical network. Worst, it would affect the redirection, since it uses router port mac as destination mac. Signed-off-by: Ankur Sharma --- northd/ovn-northd.c | 22 ++ 1 file changed, 22 insertions(+) diff --git

[ovs-dev] [PATCH v2 1/4 ovn] OVN: Do not replace router port mac on gateway chassis.

2019-08-01 Thread Ankur Sharma
the same. Signed-off-by: Ankur Sharma --- controller/physical.c | 19 ++- controller/pinctrl.c | 37 +++--- controller/pinctrl.h | 5 + tests/ovn.at | 313 ++ 4 files changed, 354 insertions(+), 20 deletions(-) diff --git a/controller

[ovs-dev] [PATCH v2 0/4 ovn] OVN: Vlan backed DVR, enable N-S packet flow

2019-08-01 Thread Ankur Sharma
ed to the logical router pipeline. v1 -> v2 -- * Added ovn in the comment description prefix. Ankur Sharma (4): OVN: Do not replace router port mac on gateway chassis. OVN: Vlan backed DVR N-S, redirect-type option OVN: Vlan backed DVR N-S, avoid get_arp on non redirect chassis.

Re: [ovs-dev] [PATCH v1 0/4] OVN: Vlan backed DVR, enable N-S packet flow

2019-07-31 Thread Ankur Sharma
Hi, Sent out the same series (with same version) on OVN repo. Thanks Regards, Ankur -Original Message- From: Ankur Sharma Sent: Tuesday, July 30, 2019 7:23 PM To: ovs-dev@openvswitch.org Subject: RE: [PATCH v1 0/4] OVN: Vlan backed DVR, enable N-S packet flow Hi, I will be sending

Re: [ovs-dev] OVS/OVN split complete in ovn-org/ovn repository

2019-07-31 Thread Ankur Sharma
Thanks a lot for reply Numan. Regards, Ankur From: Numan Siddique Sent: Tuesday, July 30, 2019 10:49 PM To: Ankur Sharma Cc: ovs-dev@openvswitch.org; ovs-discuss Subject: Re: [ovs-dev] OVS/OVN split complete in ovn-org/ovn repository On Wed, Jul 31, 2019 at 7:13 AM Ankur Sharma

[ovs-dev] [PATCH v1 4/4] OVN: Vlan backed DVR N-S, redirect packet via localnet port

2019-07-31 Thread Ankur Sharma
decremented twice, since the packets are going through logical router ingress pipeline twice (once on sender chassis and again on gateway chassis). No changes needed for the reverse path. Signed-off-by: Ankur Sharma --- controller/physical.c | 255 +++- lib/o

[ovs-dev] [PATCH v1 3/4] OVN: Vlan backed DVR N-S, avoid get_arp on non redirect chassis.

2019-07-31 Thread Ankur Sharma
port mac will be going through continous mac moves in physical network. Worst, it would affect the redirection, since it uses router port mac as destination mac. Signed-off-by: Ankur Sharma --- northd/ovn-northd.c | 22 ++ 1 file changed, 22 insertions(+) diff --git

[ovs-dev] [PATCH v1 2/4] OVN: Vlan backed DVR N-S, redirect-type option

2019-07-31 Thread Ankur Sharma
uration has to be done at the router port level. Signed-off-by: Ankur Sharma --- northd/ovn-northd.c | 6 ++ ovn-nb.xml| 43 ++ tests/ovn-nbctl.at| 25 ++ tests/ovn-northd.at | 31 +++

[ovs-dev] [PATCH v1 1/4] OVN: Do not replace router port mac on gateway chassis.

2019-07-31 Thread Ankur Sharma
the same. Signed-off-by: Ankur Sharma --- controller/physical.c | 19 ++- controller/pinctrl.c | 37 +++--- controller/pinctrl.h | 5 + tests/ovn.at | 313 ++ 4 files changed, 354 insertions(+), 20 deletions(-) diff --git a/controller

[ovs-dev] [PATCH v1 0/4] OVN: Vlan backed DVR, enable N-S packet flow

2019-07-31 Thread Ankur Sharma
redirected packets from compute chassis to gateway chassis. d. Because of c. above, existing patch needs changes on receiving side as well. This is because since packet's vlan id is not of the correct logical switch, hence on receiving node (gateway chassis), packet has to be forced forwaded

Re: [ovs-dev] [PATCH v1 0/4] OVN: Vlan backed DVR, enable N-S packet flow

2019-07-30 Thread Ankur Sharma
Hi, I will be sending the same series in OVN repo. Thanks Regards, Ankur -Original Message- From: Ankur Sharma Sent: Tuesday, July 30, 2019 3:20 PM To: ovs-dev@openvswitch.org Cc: Ankur Sharma Subject: [PATCH v1 0/4] OVN: Vlan backed DVR, enable N-S packet flow Problem Description

Re: [ovs-dev] OVS/OVN split complete in ovn-org/ovn repository

2019-07-30 Thread Ankur Sharma
Hi Numan, I have some basic queries: a. Will OVN has its own versioning and release now? b. Will OVS RPM continue to provide OVN binaries? Sorry, I know these things have been discussed already. I thought I will check on mailing list, rather than digging through the emails . Regards, Ankur

[ovs-dev] [PATCH v1 4/4] OVN: Vlan backed DVR N-S, redirect packet via localnet port

2019-07-30 Thread Ankur Sharma
decremented twice, since the packets are going through logical router ingress pipeline twice (once on sender chassis and again on gateway chassis). No changes needed for the reverse path. Signed-off-by: Ankur Sharma --- ovn/controller/physical.c | 255 + ovn/l

[ovs-dev] [PATCH v1 2/4] OVN: Vlan backed DVR N-S, redirect-type option

2019-07-30 Thread Ankur Sharma
uration has to be done at the router port level. Signed-off-by: Ankur Sharma --- ovn/northd/ovn-northd.c | 6 + ovn/ovn-nb.xml| 43 +++ ovn/utilities/ovn-nbctl.c | 58 +++ tests/ovn-nbctl.at

[ovs-dev] [PATCH v1 3/4] OVN: Vlan backed DVR N-S, avoid get_arp on non redirect chassis.

2019-07-30 Thread Ankur Sharma
port mac will be going through continous mac moves in physical network. Worst, it would affect the redirection, since it uses router port mac as destination mac. Signed-off-by: Ankur Sharma --- ovn/northd/ovn-northd.c | 22 ++ 1 file changed, 22 insertions(+) diff

[ovs-dev] [PATCH v1 1/4] OVN: Do not replace router port mac on gateway chassis.

2019-07-30 Thread Ankur Sharma
the same. Signed-off-by: Ankur Sharma --- ovn/controller/physical.c | 19 ++- ovn/controller/pinctrl.c | 37 +++--- ovn/controller/pinctrl.h | 5 + tests/ovn.at | 313 ++ 4 files changed, 354 insertions(+), 20 deletions(-) diff --git

[ovs-dev] [PATCH v1 0/4] OVN: Vlan backed DVR, enable N-S packet flow

2019-07-30 Thread Ankur Sharma
redirected packets from compute chassis to gateway chassis. d. Because of c. above, existing patch needs changes on receiving side as well. This is because since packet's vlan id is not of the correct logical switch, hence on receiving node (gateway chassis), packet has to be forced forwaded

Re: [ovs-dev] [PATCH v12] OVN: Enable E-W Traffic, Vlan backed DVR

2019-06-28 Thread Ankur Sharma
Hi Ben, Gentle reminder. This patch has been acked. Please let me know, if it can be applied to master. I will be happy to address, if there are more review comments. Thanks Regards, Ankur From: Ankur Sharma Sent: Wednesday, June 19, 2019 6:36 PM To: ovs-dev

Re: [ovs-dev] [PATCH v11] OVN: Enable E-W Traffic, Vlan backed DVR

2019-06-19 Thread Ankur Sharma
Siddique Sent: Tuesday, June 18, 2019 10:44 PM To: Ankur Sharma Cc: ovs-dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH v11] OVN: Enable E-W Traffic, Vlan backed DVR On Tue, Jun 18, 2019 at 2:10 AM Ankur Sharma mailto:ankur.sha...@nutanix.com>> wrote: Background: [1]

[ovs-dev] [PATCH v11] OVN: Enable E-W Traffic, Vlan backed DVR

2019-06-17 Thread Ankur Sharma
and aa:bb:cc:dd:ee:ff is chassis mac. Signed-off-by: Ankur Sharma Acked-by: Numan Siddique --- ovn/controller/binding.c| 12 +-- ovn/controller/chassis.c| 64 +++- ovn/controller/chassis.h| 4 + ovn/controller/ovn-controller.8.xml | 10 ++ ovn/controller/ovn

Re: [ovs-dev] [PATCH v10] OVN: Enable E-W Traffic, Vlan backed DVR

2019-06-17 Thread Ankur Sharma
Hi Numan, Thank for the Ack. Sent out v11, addressing your comment. Thanks again. Regards, Ankur From: Numan Siddique Sent: Monday, June 17, 2019 3:53 AM To: Ankur Sharma Cc: ovs-dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH v10] OVN: Enable E-W Traffic, Vlan backed DVR On Wed, Jun 12

Re: [ovs-dev] [PATCH] ovn: Send GARP for the router ports connected to localnet switches

2019-06-12 Thread Ankur Sharma
Hi, Just adding a minor clarification inline. Regards, Ankur From: Numan Siddique Sent: Wednesday, June 12, 2019 12:29 AM To: Han Zhou Cc: ovs dev ; Ankur Sharma Subject: Re: [ovs-dev] [PATCH] ovn: Send GARP for the router ports connected to localnet switches On Tue, Jun 11, 2019 at 9:37

Re: [ovs-dev] [PATCH v9 2/2] OVN: Enable N-S Traffic, Vlan backed DVR

2019-06-11 Thread Ankur Sharma
garp advertisement patch to go in first, hence I could not accommodate those changes in this patch. Please take a look and looking forward toy our feedback. Thanks Regards, Ankur From: Numan Siddique Sent: Monday, June 10, 2019 10:18 AM To: Ankur Sharma Cc: ovs-dev@openvswitch.org Subject: Re

[ovs-dev] [PATCH v10] OVN: Enable E-W Traffic, Vlan backed DVR

2019-06-11 Thread Ankur Sharma
and aa:bb:cc:dd:ee:ff is chassis mac. Signed-off-by: Ankur Sharma --- ovn/controller/binding.c| 12 +-- ovn/controller/chassis.c| 64 +++- ovn/controller/chassis.h| 4 + ovn/controller/ovn-controller.8.xml | 10 ++ ovn/controller/ovn-controller.c | 4

Re: [ovs-dev] [PATCH] ovn: Send GARP for the router ports connected to localnet switches

2019-06-10 Thread Ankur Sharma
; Ankur Sharma Subject: Re: [ovs-dev] [PATCH] ovn: Send GARP for the router ports connected to localnet switches On Fri, Jun 7, 2019 at 5:18 AM Han Zhou mailto:zhou...@gmail.com>> wrote: On Wed, May 1, 2019 at 9:04 AM mailto:nusid...@redhat.com>> wrote: > > From: Numan Sid

Re: [ovs-dev] [PATCH v9 2/2] OVN: Enable N-S Traffic, Vlan backed DVR

2019-06-06 Thread Ankur Sharma
bug fixes soon after as well. For rest of the comments, please find my replies inline. Appreciate your feedback. Regards, Ankur From: Numan Siddique Sent: Monday, June 3, 2019 3:06 AM To: Ankur Sharma Cc: ovs-dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH v9 2/2] OVN: Enable N-S Traffic,

Re: [ovs-dev] [PATCH v7 2/2] OVN: Enable N-S Traffic, Vlan backed DVR

2019-05-29 Thread Ankur Sharma
4:31 AM To: Ankur Sharma Cc: ovs-dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH v7 2/2] OVN: Enable N-S Traffic, Vlan backed DVR On Mon, May 20, 2019 at 4:32 PM Numan Siddique mailto:nusid...@redhat.com>> wrote: Hi Ankur Please see below for my comments. On Sat, May 11, 2019 at 6

[ovs-dev] [PATCH v9 2/2] OVN: Enable N-S Traffic, Vlan backed DVR

2019-05-29 Thread Ankur Sharma
, and hence in the absence of NATing configuration we need redirect the packet to gateway chassis. Signed-off-by: Ankur Sharma --- ovn/controller/physical.c | 24 +- ovn/controller/pinctrl.c | 205 +++-- ovn/controller/pinctrl.h | 6 + ovn/lib/ovn-util.c | 31 ++ ovn/lib

[ovs-dev] [PATCH v9 1/2] OVN: Enable E-W Traffic, Vlan backed DVR

2019-05-29 Thread Ankur Sharma
ther avoid redirection totally (if there is no NAT) or do redirection based on router port mac, rather than encap over a tunnel. Signed-off-by: Ankur Sharma --- ovn/controller/binding.c| 12 +-- ovn/controller/chassis.c| 64 +++- ovn/controller/chassis.h| 4 + ovn/c

[ovs-dev] [PATCH v9 0/2] OVN: Distributed Virtual Router for Vlan Backed Networks

2019-05-29 Thread Ankur Sharma
-- * Rebased with TOT. v1 -> v2 -- * Fixed unit tests and review comments. Ankur Sharma (2): OVN: Enable E-W Traffic, Vlan backed DVR OVN: Enable N-S Traffic, Vlan backed DVR ovn/controller/binding.c| 12 +- ovn/controller/chassis.c| 64 ++- ovn/contr

Re: [ovs-dev] [PATCH v1] OVN: Fix the ovn-controller 100% usage issue with put_mac_bindings

2019-05-16 Thread Ankur Sharma
Hi Numan, Excellent find. I missed the POP while iterating the hmap. Submitted a V2, added relevant tags as well. Please take a look. Regards, Ankur From: Numan Siddique Sent: Thursday, May 16, 2019 11:31 AM To: Ankur Sharma Cc: Han Zhou ; ovs-dev@openvswitch.org Subject: Re: [ovs-dev

<    1   2   3   >