24-January/410476.html
Suggested-by: Aaron Conole
Signed-off-by: Brad Cowie
---
.../selftests/net/openvswitch/openvswitch.sh | 62 +++
1 file changed, 62 insertions(+)
diff --git a/tools/testing/selftests/net/openvswitch/openvswitch.sh
b/tools/testing/selftests/net/o
On Fri, 5 Jan 2024 at 03:03, Ilya Maximets wrote:
> On 1/4/24 11:57, Simon Horman wrote:
>> One question from my side is, given that this is currently broken in many
>> kernels in use today, how we should integrate this. For one thing,
>> applying this patch causes the CI to fail.
>>
>>
versions lower than v6.7.
Link: https://lore.kernel.org/netdev/20231221224311.130319-1-b...@faucet.nz/
Suggested-by: Aaron Conole
Signed-off-by: Brad Cowie
---
tests/ofproto-macros.at | 5 +++
tests/system-traffic.at | 89 +
2 files changed, 94 inser
On Wed, 3 Jan 2024 at 04:10, Aaron Conole wrote:
> LGTM. I guess we should try to codify the specific flows that were used
> to flag this into the ovs selftest - we clearly have a missing case
> after NAT lookup.
Thanks for the review Aaron, and the sensible suggestion to add a
test to ovs to
will pass on earlier kernel versions where the issue
wasn't present, or on later kernel versions that have the fix applied.
Link: https://lore.kernel.org/netdev/20231221224311.130319-1-b...@faucet.nz/
Suggested-by: Aaron Conole
Signed-off-by: Brad Cowie
---
tests/sy
On Sun, 24 Dec 2023 at 10:13, Simon Horman wrote:
> Thanks Brad,
>
> I agree with your analysis and that the problem appears to
> have been introduced by the cited commit.
Thanks for the review Simon.
> I am curious to know what use case triggers this /
> why it when unnoticed for a year.
We
being matched for that packet.
Move the goto label above where the action bit field is being set so
that it is updated in all cases where the packet is accepted.
Fixes: ebddb1404900 ("net: move the nat function to nf_nat_ovs for ovs and tc")
Signed-off-by: Brad Cowie
---
net
Hi Eelco,
On Thu, 28 Sept 2023 at 23:22, Eelco Chaudron wrote:
>
> Thanks for sending a v2, see some styling issues below.
>
Apologies for messing up the styling again, I just pushed a v3 patch which
should hopefully address all the issues raised.
Thanks,
Brad
s is populated.
This commit also removes the hardcoded default values for
inactivity_probe (5s) and max_backoff (8s) on initial creation
of the ofservice, as these config values are available from the
ofproto_controller struct c.
Signed-off-by: Brad Cowie
Acked-by: Simon Horman
---
ofproto/connmgr.c
On Sat, 23 Sept 2023 at 08:32, Eelco Chaudron wrote:
>
> Hi Brad,
>
> See one style comment below, the rest of the changes seem fine.
> However, would it be possible to add a unit test for this fix?
>
Hi Eelco,
Thanks for the review and feedback.
I have sent a V2 patch which addresses the
s is populated.
This commit also removes the hardcoded default values for
inactivity_probe (5s) and max_backoff (8s) on initial creation
of the ofservice, as these config values are available from the
ofproto_controller struct c.
Signed-off-by: Brad Cowie
Acked-by: Simon Horman
---
ofproto/connmgr.c
s is populated.
This commit also removes the hardcoded default values for
inactivity_probe (5s) and max_backoff (8s) on initial creation
of the ofservice, as these config values are available from the
ofproto_controller struct c.
Signed-off-by: Brad Cowie
---
ofproto/connmgr.c | 12 +---
1 f
Hi Ilya,
Sorry for the late reply, this email got lost in my inbox.
Yes this patch is still good to go and happy for it to be merged.
Thanks,
Brad
On 10/09/20 12:39 am, Ilya Maximets wrote:
On 9/12/18 1:53 AM, Brad Cowie wrote:
Newer versions of Faucet use a dynamic OpenFlow pipeline based
On 18/09/18 4:50 PM, Ben Pfaff wrote:
On Wed, Sep 12, 2018 at 11:53:28AM +1200, Brad Cowie wrote:
Reported-by: Matthias Ableidinger
Reported-at:
https://mail.openvswitch.org/pipermail/ovs-discuss/2018-August/047180.html
Signed-off-by: Brad Cowie
This is really nice. Thank you
-by: Brad Cowie
---
Documentation/tutorials/faucet.rst | 596 +++--
1 file changed, 304 insertions(+), 292 deletions(-)
diff --git a/Documentation/tutorials/faucet.rst
b/Documentation/tutorials/faucet.rst
index 9696dfd..82e5efa 100644
--- a/Documentation/tutorials
* Update output from commands/log files to reflect changes in the
Faucet pipeline and to use OpenFlow 1.3 format.
Signed-off-by: Brad Cowie <b...@wand.net.nz>
---
Documentation/tutorials/faucet.rst | 163 +++--
1 file changed, 82 insertions(+), 81 del
Updates Faucet tutorial to work with newer versions than 1.6.7.
Tutorial now shows how to check out latest tag from Faucet's git.
Tutorial now sets minimum_ip_size_check flag to False so that the
payloadless packets generated by ofproto/trace aren't dropped by Faucet.
Signed-off-by: Brad Cowie
17 matches
Mail list logo
