Re: [ovs-dev] [PATCH] socket: Increase listen backlog to 128 everywhere.

Maximets. On Tue, Jun 4, 2024 at 11:05 AM Simon Horman wrote: + Ihar On Fri, May 31, 2024 at 03:40:08PM -0400, Brian Haley wrote: An earlier patch [1] increased the size of the listen backlog to 64. While that was a huge improvement over 10, further testing in large deployments showed 128

[ovs-dev] [PATCH] socket: Increase listen backlog to 128 everywhere.

/ovs/commit/2b7efee031c3a2205ad2ee999275893edd083c1c [2] https://github.com/openvswitch/ovs/commit/2b7efee031c3a2205ad2ee999275893edd083c1c Signed-off-by: Brian Haley --- lib/socket-util.c| 2 +- python/ovs/stream.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib

Re: [ovs-dev] [PATCH] Rename primary development branch as main.

Hi, On 3/21/24 6:09 AM, Simon Horman wrote: Recently OVS adopted a policy of using the inclusive naming word list v1 [1, 2]. In keeping with this policy rename the primary development branch from 'master' to 'main'. This patch does not actually make that change, but rather updates references

Re: [ovs-dev] [PATCH ovn] pinctrl: Reply with correct destination for ICMPv6 RA packets

Hi Ales, On 9/15/23 8:15 AM, Ales Musil wrote: When client sends RS we reply with RA to the source address, however the client is allowed to send RS with unspecified source address ("::"). In that case we would send the RA to that empty address which is not correct. According to RFC 2461 [0]

Re: [ovs-dev] [PATCH 2/2] conntrack: Release nat_conn in case both keys have the same hash.

On 6/8/23 3:52 PM, Paolo Valerio wrote: Brian Haley writes: Hi Paolo, On 4/19/23 2:40 PM, Paolo Valerio wrote: During the creation of a new connection, there's a chance both key and rev_key end up having the same hash. This is more common in the case of all-zero snat with no collisions

Re: [ovs-dev] [PATCH 2/2] conntrack: Release nat_conn in case both keys have the same hash.

Hi Paolo, On 4/19/23 2:40 PM, Paolo Valerio wrote: During the creation of a new connection, there's a chance both key and rev_key end up having the same hash. This is more common in the case of all-zero snat with no collisions. In that case, once the connection is expired, but not cleaned up,

[ovs-dev] [PATCH ovn v4] controller: Ignore DNS queries with RRs

/issues/192 Reported-by: Nicolas Bock Signed-off-by: Brian Haley --- Changes since v3: - Updated commit message to include reporter info --- Changes since v2: - Updated commit message to be more clear --- Changes since v1: - Added issue #192 to commit message --- controller/pinctrl.c | 7 +++ 1

Re: [ovs-dev] [PATCH ovn v3] controller: Ignore DNS queries with RRs

: On Thu, May 25, 2023 at 8:29 PM Brian Haley <mailto:haleyb@gmail.com>> wrote: DNS queries with optional records (RRs), for example, with cookies for EDNS, are not supported by the OVN resolver. Trying to reply will result in mangled responses that clients do not u

[ovs-dev] [PATCH ovn v3] controller: Ignore DNS queries with RRs

, which will trigger a negative response and cause clients to go to the upstream forwarder, hopefully resulting in a successful query. In our testing, the resolver only retries if the response is correctly formatted, which now happens with this change. Closes issue #192 Signed-off-by: Brian Haley

Re: [ovs-dev] [PATCH ovn v2] controller: Ignore DNS queries with RRs

. Thanks, -Brian [0] https://patchwork.ozlabs.org/project/ovn/patch/2023052223.363328-1-haleyb@gmail.com/ On 5/22/23 4:13 PM, Brian Haley wrote: DNS queries with optional records (RRs), for example, with cookies for EDNS, are not supported by the OVN resolver. Trying to reply

[ovs-dev] [PATCH ovn v2] controller: Ignore DNS queries with RRs

and cause clients to go to the upstream forwarder, hopefully resulting in a successful query. Closes issue #192 Signed-off-by: Brian Haley --- Changes since v1: - Added issue #192 to commit message --- controller/pinctrl.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/controller/pinctrl.c

[ovs-dev] [PATCH ovn] controller: Ignore DNS queries with RRs

and cause clients to go to the upstream forwarder, hopefully resulting in a successful query. Signed-off-by: Brian Haley --- controller/pinctrl.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/controller/pinctrl.c b/controller/pinctrl.c index b5df8b1eb..b45b4c747 100644 --- a/controller

Re: [ovs-dev] [PATCH] tc: fix crash on EAGAIN return from recvmsg on netlink socket.

Hi Frode, Thanks for fixing this, just had one nit below since you're pushing out a new PS. On 5/10/23 11:12 AM, Frode Nordahl wrote: The tc module combines the use of the `tc_transact` helper function for communication with the in-kernel tc infrastructure with assertions on the reply data

Re: [ovs-dev] [PATCH v6] python: Send notifications after the transaction ends

Acked-by: Brian Haley -Brian On 3/9/21 9:34 AM, Terry Wilson wrote: The Python IDL notification mechanism was sending a notification for each processed update in a transaction as it was processed. This causes issues with multi-row changes that contain references to each other. For example

Re: [ovs-dev] [PATCH v5] python: Send notifications after the transaction ends

Acked-by: Brian Haley Thanks for fixing this Terry. -Brian On 3/4/21 11:18 AM, Terry Wilson wrote: The Python IDL notification mechanism was sending a notification for each processed update in a transaction as it was processed. This causes issues with multi-row changes that contain

Re: [ovs-dev] [PATCH v2] python: Send notifications after the transaction ends

On 3/3/21 3:18 PM, Terry Wilson wrote: On Wed, Mar 3, 2021 at 1:47 PM Brian Haley wrote: Hi Terry, Thanks for the patch, comments below. On 3/3/21 9:24 AM, Terry Wilson wrote: The Python IDL notification mechanism was sending a notification for each processed update in a transaction

Re: [ovs-dev] [PATCH v2] python: Send notifications after the transaction ends

Hi Terry, Thanks for the patch, comments below. On 3/3/21 9:24 AM, Terry Wilson wrote: The Python IDL notification mechanism was sending a notification for each processed update in a transaction as it was processed. This causes isseues with multi-row change that contain references to each

Re: [ovs-dev] OVN-OVS build compatibility, take 2

On 10/23/20 2:56 PM, Mark Michelson wrote: On 10/23/20 8:42 AM, Brian Haley wrote: On 10/22/20 3:31 PM, Mark Michelson wrote: Hi, In today's OVN meeting [1], Numan brought up that he had proposed an OVN patch [2] that deals with a compilation error that occurred after updating to the latest

Re: [ovs-dev] OVN-OVS build compatibility, take 2

On 10/22/20 3:31 PM, Mark Michelson wrote: Hi, In today's OVN meeting [1], Numan brought up that he had proposed an OVN patch [2] that deals with a compilation error that occurred after updating to the latest OVS master. This sparked a discussion about the process behind OVN/OVS build

[ovs-dev] [PATCH ovn] Remove python six library

Since OVN is python3-only, there is no need for six. Signed-off-by: Brian Haley --- Documentation/intro/install/general.rst | 6 -- Documentation/intro/install/rhel.rst| 2 +- Vagrantfile | 9 - Vagrantfile-FreeBSD | 2 +- debian

[ovs-dev] [PATCH ovn] Fix LISTEN_ON_IP typo

Fix LISTEN_ON_IP typo Found by inspection in utilities/ovndb-servers.ocf Signed-off-by: Brian Haley --- utilities/ovndb-servers.ocf | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/utilities/ovndb-servers.ocf b/utilities/ovndb-servers.ocf index 4678a1dc9..42e0412ad

Re: [ovs-dev] [PATCH] OVN: Fix failures after OVS/OVN split

On 4/25/19 4:26 PM, Ben Pfaff wrote: On Thu, Apr 25, 2019 at 04:08:15PM -0400, Brian Haley wrote: Added TODO_SPLIT.rst to Makefile.am to avoid an error during build. Removed a section from config-h-check section of Makefile.am that was no longer relevant. Signed-off-by: Brian Haley

[ovs-dev] [PATCH] OVN: Fix failures after OVS/OVN split

Added TODO_SPLIT.rst to Makefile.am to avoid an error during build. Removed a section from config-h-check section of Makefile.am that was no longer relevant. Signed-off-by: Brian Haley --- Makefile.am | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/Makefile.am b

[ovs-dev] [PATCH] ovn: Make DHCP log messages unique

From: Brian Haley Two messags were using the same string, add info to one to make it unique. Also cleaned-up some of the others to make them consistent throughout. Signed-off-by: Brian Haley --- ovn/controller/pinctrl.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions

Re: [ovs-dev] OVN: IPv6 Periodic Router Advertisement Plan

Sorry for the slow review, was on PTO. Comments below. On 08/22/2017 05:43 PM, Mark Michelson wrote: Hi folks, For a while now, in a "learn the OVN project from scratch" project, I've been investigating what it would take in order to allow for OVN to send periodic router advertisements (RAs)

Re: [ovs-dev] [PATCH v1 4/6] ovn util: Refactor dhcp_opts_map to make it generic

On 06/15/2017 04:39 AM, nusid...@redhat.com wrote: From: Numan Siddique Renamed 'struct dhcp_opts_map' to 'struct gen_opts_map' and renamed ovn-dhcp.h to ovn-l7.h. An upcoming commit to support IPv6 Router Advertisement, will make use of the refactored code to store the