Re: [ovs-dev] [PATCH 1/7 v3] datapath: Handle removal of nf_conntrack_l3proto.h

2019-05-10 Thread Darrell Ball via dev
Looks a little odd: 'HAVE_NF_CONNTRACK_L3PROATO_H' You may want a follow up patch: s/HAVE_NF_CONNTRACK_L3PROATO_H/HAVE_NF_CONNTRACK_L3PROTO_H On 5/10/19, 12:31 PM, "ovs-dev-boun...@openvswitch.org on behalf of Yifeng Sun" wrote: Upstream kernel commit a0ae2562 ("netfilter: conntrack:

Re: [ovs-dev] SNAT on OVN logical_router in userspace works for ICMP but not TCP or UDP

2019-02-08 Thread Darrell Ball via dev
If TCP packets do not go thru conntrack, then that would explain why the TCP traffic is not natted (since you don't have any other rules that could do that) You need to find out where the TCP packets are going. Try making the rules L4 protocol specific (i.e. look for TCP and also do something

Re: [ovs-dev] SNAT on OVN logical_router in userspace works for ICMP but not TCP or UDP

2019-02-08 Thread Darrell Ball via dev
I thought the problem was with TCP/UDP traffic ? Did you send TCP traffic for this test ?; if not, can you run the test with TCP ? On 2/8/19, 12:53 PM, "Rostyslav Fridman" wrote: # ovs-appctl dpif/dump-flows br-int

Re: [ovs-dev] SNAT on OVN logical_router in userspace works for ICMP but not TCP or UDP

2019-02-08 Thread Darrell Ball via dev
Could you dump the datapath flows and conntrack entries while your test is running (i.e. sending packets) ? == # ovs-appctl dpif/dump-flows br-int == # ovs-appctl dpctl/dump-conntrack Also besides arp, could you limit

Re: [ovs-dev] SNAT on OVN logical_router in userspace works for ICMP but not TCP or UDP

2019-02-08 Thread Darrell Ball via dev
We have advanced system tests for userspace datapath to test OVN, including tcp packets. system-ovn 124: ovn -- 2 LRs connected via LS, gateway router, SNAT and DNAT ok 125: ovn -- 2 LRs connected via LS, gateway router, easy SNAT ok 126: ovn -- multiple gateway routers, SNAT and DNAT ok 127:

Re: [ovs-dev] [patch v3 2/2] conntrack: Exclude l2 padding in 'conn_key_extract()'.

2019-02-04 Thread Darrell Ball via dev
Thanks Vishal Yes, it needs to go back to 2.6; I will be doing some backport patches soon. Darrell On 2/1/19, 8:57 PM, "ovs-dev-boun...@openvswitch.org on behalf of Vishal Deep Ajmera" wrote: > > 'conn_key_extract()' in userspace conntrack is including L2 > (Ethernet) pad bytes

Re: [ovs-dev] [patch v3] conntrack: Fix possibly uninitialized memory.

2019-02-04 Thread Darrell Ball via dev
On 2/4/19, 12:24 PM, "Ben Pfaff" wrote: On Mon, Feb 04, 2019 at 07:52:18PM +, Darrell Ball wrote: > > > On 2/4/19, 11:15 AM, "ovs-dev-boun...@openvswitch.org on behalf of Ben Pfaff" wrote: > > On Sun, Feb 03, 2019 at 02:15:27PM -0800, Darrell Ball wrote:

Re: [ovs-dev] [patch v3 1/2] dp-packet: Add 'dp_packet_l3_size()'.

2019-02-04 Thread Darrell Ball via dev
On 2/4/19, 11:23 AM, "ovs-dev-boun...@openvswitch.org on behalf of Ben Pfaff" wrote: On Mon, Jan 28, 2019 at 10:49:03AM -0800, Darrell Ball wrote: > The new api will be used in a subsequent patch. > > Signed-off-by: Darrell Ball I think that this could use some

Re: [ovs-dev] [patch v3] conntrack: Fix possibly uninitialized memory.

2019-02-04 Thread Darrell Ball via dev
On 2/4/19, 11:15 AM, "ovs-dev-boun...@openvswitch.org on behalf of Ben Pfaff" wrote: On Sun, Feb 03, 2019 at 02:15:27PM -0800, Darrell Ball wrote: > There are a few cases where padding may be undefined according to > the C standard. Practically, it seems implementations don't

Re: [ovs-dev] [patch v2] conntrack: Fix possible uninitialized memory.

2019-02-04 Thread Darrell Ball via dev
On 2/4/19, 8:53 AM, "ovs-dev-boun...@openvswitch.org on behalf of Aaron Conole" wrote: Darrell Ball writes: > There are a few cases where padding may be undefined according to > the C standard. Practically, it seems implementations don't have issue, > but it is better

Re: [ovs-dev] [patch v4 1/2] conntrack: fix ftp ipv4 address substitution.

2019-01-22 Thread Darrell Ball via dev
I would like to wait for David to return, so please hold off for now. On 1/22/19, 3:58 PM, "ovs-dev-boun...@openvswitch.org on behalf of Ben Pfaff" wrote: It looks like you have some changes to both patches, will you post a v5? Is this series otherwise ready to go (do you have

Re: [ovs-dev] [PATCH v3 1/2] conntrack: fix tcp seq adjustments when mangling commands

2019-01-14 Thread Darrell Ball via dev
On 1/14/19, 4:49 AM, "ovs-dev-boun...@openvswitch.org on behalf of David Marchand" wrote: On Mon, Jan 14, 2019 at 7:32 AM Darrell Ball wrote: > Thanks for the patch > > On Wed, Jan 9, 2019 at 7:33 AM David Marchand > wrote: > > The ftp alg deals with