On Tue, Sep 29, 2020 at 04:53:22PM +0200, Ilya Maximets wrote:
> On 9/15/20 9:20 PM, Flavio Leitner wrote:
> > The datapath flow limit is calculated by revalidators so
> > log the value as well.
> >
> > Signed-off-by: Flavio Leitner
> > ---
> > ofproto/of
The datapath flow limit is calculated by revalidators so
log the value as well.
Signed-off-by: Flavio Leitner
---
ofproto/ofproto-dpif-upcall.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
v2: Updated the log message.
diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto
When the number of flows in the datapath reaches twice the
maximum, revalidators will delete all flows as an emergency
action to recover. In that case, log a message with values
and increase a coverage counter.
Signed-off-by: Flavio Leitner
---
ofproto/ofproto-dpif-upcall.c | 21
On Tue, Sep 29, 2020 at 05:27:31PM +0200, Ilya Maximets wrote:
> On 9/15/20 9:21 PM, Flavio Leitner wrote:
> > When the number of flows in the datapath reaches twice the
> > maximum, revalidators will delete all flows as an emergency
> > action to recover. In that case, log
n
the meantime I think the patch should include the Fixes: tag to
the commit pointed by Aaron. It would be great if it includes a
new test.
Thanks,
fbl
On Thu, Sep 24, 2020 at 09:19:53AM +, 范开喜 wrote:
> Hi Aaron conole and Flavio Leitner, I am just trying to fix the bug. When I
> am trying to
Hi XiaoXiong,
Thanks again for the patch.
Could you please follow the guidelines to post patches?
https://github.com/openvswitch/ovs/blob/master/Documentation/internals/contributing/submitting-patches.rst
The Subject for instance is a bit confusing as I think
you don't want reports forwarded t
On Tue, Sep 22, 2020 at 06:46:40PM +0100, Kevin Traynor wrote:
> On 19/09/2020 14:07, Flavio Leitner wrote:
> > The EMC is not large enough for current production cases
> > and they are scaling up, so this change switches over from
> > EMC to SMC by default, which pr
On Tue, Sep 22, 2020 at 12:45:03PM +0200, Ilya Maximets wrote:
> On 9/17/20 9:59 PM, Greg Rose wrote:
> > The skb now uses l4_hash and it is easier to check for it. Also
> > fixes a compile error for RHEL 7.7.
> >
> > Signed-off-by: Greg Rose
> > ---
> > acinclude.m4
On Wed, Sep 23, 2020 at 10:51:51AM -0400, Aaron Conole wrote:
> fankaixi...@bytedance.com writes:
>
> > From: "fankaixi.li"
> >
> > In order to support openflow rule which setting nd_ext fields in openflow
> > tables,
> > we should remove setting nd_ext fields when constructing rule. The ofproto
Hi Ilya,
On Tue, Sep 22, 2020 at 01:22:58PM +0200, Ilya Maximets wrote:
> On 9/19/20 3:07 PM, Flavio Leitner wrote:
> > The EMC is not large enough for current production cases
> > and they are scaling up, so this change switches over from
> > EMC to SMC by default,
Hi,
Thanks for the patch.
On Sat, Sep 19, 2020 at 10:46:01AM +0800, XiaoXiong Ding wrote:
> When mld report come(same as mld done), will do funciton
function
> xlate_normal_mcast_send_rports, and because of no return,
> will do forwarding to group base ports logic, and if
> other_config:mcast
turn the same name).
This patch adds new ioctl() cmd for obtaining net ns of a device.
Reported-by: Harald Albrecht
Signed-off-by: Kirill Tkhai
Signed-off-by: David S. Miller
HTH,
fbl
>
>
> -邮件原件-
> 发件人: Flavio Leitner [mailto:f...@sysc
ly added. This will mean
> that OVS finished processing of a netlink event and will use up to
> date list of ip addresses on desired interface.
>
> Fixes: 526cf4e1d6a8 ("tests: Added unit tests in packet-type-aware.at")
> Signed-off-by: Ilya Maximets
> ---
Acke
The EMC is not large enough for current production cases
and they are scaling up, so this change switches over from
EMC to SMC by default, which provides better results.
The EMC is still available and could be used when only a
few number of flows is used.
Signed-off-by: Flavio Leitner
al
> >>> ip netns exec left arping -I left0 -c 1 172.31.110.11
> >>>
> >>> # in the perf terminal after exiting
> >>> perf script
> >>>
> >>> Look for the number of 'handler' threads which were made active.
> &
On Fri, Sep 18, 2020 at 05:32:41PM +0100, Mark Gray wrote:
> On 18/09/2020 15:33, Mark Gray wrote:
> > On 17/09/2020 20:23, Flavio Leitner wrote:
> >> On Thu, Sep 17, 2020 at 08:43:38PM +0200, Ilya Maximets wrote:
> >>> On 9/9/20 7:08 PM, Mark Gray wrote:
> >>
On Thu, Sep 10, 2020 at 03:38:04PM +0200, Timothy Redaelli wrote:
> conf.db is by default at /etc/openvswitch, but it should be at
> /var/lib/openvswitch like on Debian or like ovnnb_db.db and ovnsb_db.db.
>
> If conf.db already exists in /etc/openvswitch then it's moved to
> /var/lib/openvswitch.
I missed this one, but the comments to the previous patch
remains the same here.
fbl
On Thu, Sep 10, 2020 at 03:49:00PM +0800, XiaoXiong Ding wrote:
> when mld report come(same as mld done), will do funciton
> xlate_normal_mcast_send_rports, and because of no return,
> will doforwarding to grou
On Thu, Sep 10, 2020 at 03:51:34AM +, dingxiaoxiong wrote:
> when mld report come(same as mld done), will do funciton
Please start with Capital.
> xlate_normal_mcast_send_rports, and because of no return,
> will doforwarding to group base ports logic,and if
two spaces needed
> other_config:
0 -c 1 172.31.110.11
> >
> > # in the perf terminal after exiting
> > perf script
> >
> > Look for the number of 'handler' threads which were made active.
> >
> > Suggested-by: Ben Pfaff
> > Co-authored-by: Mark Gray
> >
can
> be extracted it's treated as generic L3. The change below mimics the
> behavior of the kernel.
>
> Signed-off-by: Eelco Chaudron
> ---
LGTM
Acked-by: Flavio Leitner
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Thu, Sep 17, 2020 at 01:05:22AM +, Yi Yang (杨燚)-云服务集团 wrote:
> Aaron, any caller thread just binds it to netns on calling enter_netns, once
> it has entered netns, it won't disappear, so exit_netns caller thread must be
> current thread, once it exits netns, it returns back to original roo
On Wed, Sep 16, 2020 at 01:09:29PM +0200, Ilya Maximets wrote:
> On 9/7/20 6:27 PM, Flavio Leitner wrote:
> > On Thu, Sep 03, 2020 at 04:20:53PM +0200, Ilya Maximets wrote:
> >> On 8/28/20 3:55 PM, Flavio Leitner wrote:
> >>> On Tue, Aug 25, 2020 at 02:24:1
When the number of flows in the datapath reaches twice the
maximum, revalidators will delete all flows as an emergency
action to recover. In that case, log a message with values
and increase a coverage counter.
Signed-off-by: Flavio Leitner
---
ofproto/ofproto-dpif-upcall.c | 15
The datapath flow limit is calculated by revalidators so
log the value as well.
Signed-off-by: Flavio Leitner
---
ofproto/ofproto-dpif-upcall.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c
index 72a5b4d73
On Wed, Sep 09, 2020 at 07:17:44PM +0200, Ilya Maximets wrote:
> On 4/30/19 7:10 PM, Jaime Caamaño Ruiz wrote:
> > Otherwise logrotate will fail to generate the rotated log files.
> >
> > Signed-off-by: Jaime Caamaño Ruiz
> > ---
>
> Hi. I'm looking through old patches after the patchwork clean
On Tue, Apr 30, 2019 at 07:10:19PM +0200, Jaime Caamaño Ruiz wrote:
> Otherwise logrotate will fail to generate the rotated log files.
>
> Signed-off-by: Jaime Caamaño Ruiz
> ---
LGTM
Acked-by: Flavio Leitner
___
dev ma
ff
> Co-authored-by: Mark Gray
> Reported-by: David Ahern
> Reported-at:
> https://mail.openvswitch.org/pipermail/ovs-dev/2019-December/365857.html
> Cc: Matteo Croce
> Cc: Flavio Leitner
> Fixes: 69c51582f ("dpif-netlink: don&#x
t; Look for the number of 'handler' threads which were made active.
>
> Suggested-by: Ben Pfaff
> Co-authored-by: Mark Gray
> Reported-by: David Ahern
> Reported-at:
> https://mail.openvswitch.org/pipermail/ovs-dev/2019-December/365857.html
> Cc: Matteo Croce
&g
172.31.110.11
>
> # in the perf terminal after exiting
> perf script
>
> Look for the number of 'handler' threads which were made active.
>
> Suggested-by: Ben Pfaff
> Co-authored-by: Mark Gray
> Reported-by: David Ahern
> Reported-at:
> https:
On Thu, Sep 03, 2020 at 04:20:53PM +0200, Ilya Maximets wrote:
> On 8/28/20 3:55 PM, Flavio Leitner wrote:
> > On Tue, Aug 25, 2020 at 02:24:11PM +0200, Ilya Maximets wrote:
> >> While only 2 branches are formally maintained (LTS and latest release),
> >> OVS team usual
On Mon, Sep 07, 2020 at 01:53:11PM +0200, Ilya Maximets wrote:
> On 9/4/20 9:25 PM, Flavio Leitner wrote:
> > On Fri, Sep 04, 2020 at 08:07:41PM +0200, Ilya Maximets wrote:
> >> On 9/4/20 5:09 PM, Flavio Leitner wrote:
> >>> On Fri, Sep 04, 2020 at 12:54:39AM +0200,
onitor Database table to manage lifecycle of IDL
client.")
Co-authored-by:: Ilya Maximets
Signed-off-by: Flavio Leitner
---
tests/ovsdb-idl.at | 52 +++---
1 file changed, 31 insertions(+), 21 deletions(-)
- v2
Convert to M4 macro.
diff --git a/
On Fri, Sep 04, 2020 at 08:07:41PM +0200, Ilya Maximets wrote:
> On 9/4/20 5:09 PM, Flavio Leitner wrote:
> > On Fri, Sep 04, 2020 at 12:54:39AM +0200, Ilya Maximets wrote:
> >> On 9/4/20 12:05 AM, Flavio Leitner wrote:
> >>> On Thu, Sep 03, 2020 at 11:20:56PM +0200,
On Fri, Sep 04, 2020 at 12:54:39AM +0200, Ilya Maximets wrote:
> On 9/4/20 12:05 AM, Flavio Leitner wrote:
> > On Thu, Sep 03, 2020 at 11:20:56PM +0200, Ilya Maximets wrote:
> >> On 6/11/20 1:45 AM, Flavio Leitner wrote:
> >>> The test 'Check Python IDL reconnect
On Fri, Sep 04, 2020 at 08:42:25AM +0100, Mark Gray wrote:
> On 01/09/2020 16:10, Flavio Leitner wrote:
> >
> > Hi Mark,
> >
> > Sort of nitpicking but looks like making id_pool_find()
> > public would be better because I don't know what is
> > bein
On Thu, Sep 03, 2020 at 11:20:56PM +0200, Ilya Maximets wrote:
> On 6/11/20 1:45 AM, Flavio Leitner wrote:
> > The test 'Check Python IDL reconnects to leader - Python3
> > (leader only)' fails sometimes when the first ovsdb-server
> > gets killed before th
On Thu, Sep 03, 2020 at 02:12:54PM -0300, Flavio Leitner wrote:
> On Thu, Sep 03, 2020 at 04:55:43PM +0200, Timothy Redaelli wrote:
> > manpages.mk is generated at build-time using sodepends.py and so there is no
> > need to keep it in git.
> >
> > Signed-off-by: Timot
srcdir and add it to
> CLEANFILES to make "make distcleancheck" happy.
> Thank you Ilya and travis for reporting.
> ---
^^^ This extra '---' breaks git am, otherwise
Acked-by: Flavio Leitner
> .gitignore
Hi,
Thanks for the patch. I just did a quick look and found couple
things to discuss.
On Mon, Aug 24, 2020 at 10:44:08AM +0800, xiangxia.m@gmail.com wrote:
> From: Tonghao Zhang
>
> "ovs-appctl dpctl/dump-flows" added the option
> "pmd" which allow user to dump pmd specified.
>
> That op
On Tue, Sep 01, 2020 at 04:46:56PM +0200, Ilya Maximets wrote:
> For a last couple of weeks I worked on a script to update statuses of all the
> patches in openvswitch patchwork instance [1], i.e. to mark all the patches
> that
> already applied or superseded.
[...]
> But anyway, OVS patchwork s
邮件原件-
> 发件人: Flavio Leitner [mailto:f...@sysclose.org]
> 发送时间: 2020年8月27日 21:28
> 收件人: Yi Yang (杨燚)-云服务集团
> 抄送: acon...@redhat.com; yang_y...@163.com; ovs-dev@openvswitch.org;
> i.maxim...@ovn.org
> 主题: Re: [ovs-dev] 答复: [PATCH] userspace: fix bad UDP performance issue of?veth
&
On Tue, Sep 01, 2020 at 08:00:09PM +0200, Timothy Redaelli wrote:
> On Wed, 12 Aug 2020 16:12:03 -0300
> Flavio Leitner wrote:
>
> > On Wed, Aug 05, 2020 at 01:38:47PM +0200, Timothy Redaelli wrote:
> > > manpages.mk is generated at build-time using sodepends.py a
On Fri, Aug 28, 2020 at 06:03:05PM +0100, Mark Gray wrote:
> Signed-off-by: Mark Gray
> ---
:-)
Acked-by: Flavio Leitner
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
andler' threads which were made active.
>
> Suggested-by: Ben Pfaff
> Co-authored-by: Mark Gray
> Reported-by: David Ahern
> Reported-at:
> https://mail.openvswitch.org/pipermail/ovs-dev/2019-December/365857.html
> Cc: Matteo Croce
> Cc: Flavio Leitner
> F
Hi Mark,
Sort of nitpicking but looks like making id_pool_find()
public would be better because I don't know what is
being checked in the new function.
The new function is a simple wrapper around _find()
and to me either _find() or _lookup() names translate
better to what is being done.
What
On Fri, Aug 28, 2020 at 03:21:16PM -0300, Flavio Leitner wrote:
>
> Mark,
>
> This patch is v4 and 2/3. Before it was only one patch, so I wonder
> if v4 is only one patch, or if this has multiple patches (2/3).
Scratch that, I got the other emails now.
Thanks,
fbl
>
>
s exec left arping -I left0 -c 1 172.31.110.11
>
> # in the perf terminal after exiting
> perf script
>
> Look for the number of 'handler' threads which were made active.
>
> Suggested-by: Ben Pfaff
> Co-authored-by: Mark Gray
> Reported-by: David Ahern
>
On Tue, Aug 25, 2020 at 02:24:11PM +0200, Ilya Maximets wrote:
> While only 2 branches are formally maintained (LTS and latest release),
> OVS team usually provides stable releases for other branches too, at
> least for branches between LTS and latest.
>
> While LTS change happens, according to re
; Suggested-by: Ben Pfaff
> Signed-off-by: Ilya Maximets
> ---
Sounds like a good idea to me.
Acked-by: Flavio Leitner
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Hi,
On Wed, Aug 26, 2020 at 12:47:43AM +, Yi Yang (杨燚)-云服务集团 wrote:
> Aaron, thank for your comments, actually final value depends on
> /proc/sys/net/core/rmem_max and /proc/sys/net/core/wmem_max, so it is still
> configurable. setsockopt(...) will set it to minimum one among of
> 1073741
On Fri, Aug 21, 2020 at 08:50:49AM -0700, Gregory Rose wrote:
>
>
> On 8/21/2020 4:32 AM, Ilya Maximets wrote:
> > On 8/20/20 5:56 PM, Gregory Rose wrote:
> > >
> > >
> > > On 8/18/2020 9:41 PM, Flavio Leitner wrote:
> > > >
> > >
On Tue, Aug 18, 2020 at 08:44:45PM -0700, Gregory Rose wrote:
>
> On 8/18/2020 7:21 PM, Flavio Leitner wrote:
> > On Tue, Aug 18, 2020 at 01:29:33PM -0700, Gregory Rose wrote:
> > > On 8/18/2020 1:10 PM, Ilya Maximets wrote:
> > > > On 8/18/20 9:17 PM, Gregory Ro
On Tue, Aug 18, 2020 at 01:29:33PM -0700, Gregory Rose wrote:
> On 8/18/2020 1:10 PM, Ilya Maximets wrote:
> > On 8/18/20 9:17 PM, Gregory Rose wrote:
> > >
> > > On 8/18/2020 11:31 AM, Ilya Maximets wrote:
> > > > On 8/18/20 6:45 PM, Greg Rose wrote:
> > > > > Builds on RHEL 8.2 systems are faili
a4fe ("connmgr: Make treatment of active and passive
> connections more uniform")
> Cc: Numan Siddique
> Cc: Flavio Leitner
> Suggested-by: Ben Pfaff
> Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1782834
> Signed-off-by: Aaron Conole
> ---
Acked-b
t; > >
> > > [1] 715070ea10e6 ("vhost: prevent zero-copy with incompatible client
> > > mode")
> > > [2] http://mails.dpdk.org/archives/dev/2020-August/177236.html
> > >
> > > Signed-off-by: Ian Stokes
> > > ---
>
On Wed, Aug 05, 2020 at 01:38:47PM +0200, Timothy Redaelli wrote:
> manpages.mk is generated at build-time using sodepends.py and so there is no
> need to keep it in git.
>
> Signed-off-by: Timothy Redaelli
> ---
> .gitignore | 1 +
> Makefile.am | 2 +-
> manpages.mk | 266
020-August/177236.html
>
> Signed-off-by: Ian Stokes
> ---
Acked-by: Flavio Leitner
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Tue, Aug 11, 2020 at 03:58:44PM -0400, Aaron Conole wrote:
> Flavio Leitner writes:
>
> > Hi Aaron,
> >
> > Thanks for the patch, see my comments below.
> >
> > On Fri, Aug 07, 2020 at 05:32:03PM -0400, Aaron Conole wrote:
> >> When commit a0baa7d
Hi Aaron,
Thanks for the patch, see my comments below.
On Fri, Aug 07, 2020 at 05:32:03PM -0400, Aaron Conole wrote:
> When commit a0baa7dfa4fe ("connmgr: Make treatment of active and passive
> connections more uniform") was applied, it did not take into account
> that a reconfiguration of the
On Mon, Aug 10, 2020 at 09:27:32AM +0800, yuelongguang wrote:
> Hi, all.
>
> two nodes: ovs 2.12.0, kernel 3.10.0-1062, centos 7.7, dpdk 18.11.8, x722
> for 10gbe sfp+, each of which has one running vm.
>
>
> the flows of br-int and br-tun are NORMAL, local_ip and remote_ip are
> reach
On Tue, Aug 11, 2020 at 06:21:44PM +0100, Ian Stokes wrote:
> Add an entry for OVS 2.14 to map to the validated DPDK release.
>
> Signed-off-by: Ian Stokes
> ---
Acked-by: Flavio Leitner
___
dev mailing list
d...@openvswit
Hi,
This fix the testsuite which breaks 50% of times inside a VM.
It would be great to have it included in master, 2.14 and older
branches.
fbl
On Wed, Jun 10, 2020 at 08:45:38PM -0300, Flavio Leitner wrote:
> The test 'Check Python IDL reconnects to leader - Python3
> (leader o
l-top" since it expects that every
> element has a value.
>
> This commit skips the parsing of the empty "eth()" element.
>
> Fixes: efde188622ae ("odp-util: Print eth() for Ethernet flows if packet_type
> is absent.")
> Cc: b...@ovn.org
> Sig
On Fri, Jun 19, 2020 at 03:53:51PM +0200, Timothy Redaelli wrote:
> On Python3 buffering can only be disabled on files opened in binary mode.
>
> Signed-off-by: Timothy Redaelli
> ---
> v2:
> - Added missing Signed-off-by
>
> utilities/ovs-dpctl-top.in | 2 +-
> 1 file changed, 1 insertion(+),
2.31.110.11
>
> # in the perf terminal after exiting
> perf script
>
> Look for the number of 'handler' threads which were made active.
>
> Suggested-by: Ben Pfaff
> Reported-by: David Ahern
> Reported-at:
> https://mail.openvswitch.org/piperma
On Mon, Jul 13, 2020 at 02:49:50PM -0700, William Tu wrote:
> On Fri, Jul 10, 2020 at 12:12:57PM -0300, Flavio Leitner wrote:
> > On Fri, Jul 10, 2020 at 12:53:13PM +0100, Ross Lagerwall wrote:
> > > mlockall locks thread stack pages into memory, even pages which have not
>
On Tue, Jul 14, 2020 at 10:24:41AM +0300, Roi Dayan wrote:
> This arg can be used internally by groups using gerrit for code reviews.
>
> Signed-off-by: Roi Dayan
> Signed-off-by: Ben Pfaff
> ---
Acked-by: Flavio Leitner
___
dev
Hi Yi,
This is not a full review, but netdev-dpdk.c is used by Window
and BSD as well, and there is a 'linux' function which seems
to be a copy of another existing one. Perhaps we can use just one?
This patch resets ol_flags from vhostuser ignoring what has
been set by rte_vhost_dequeue_burst()
Hi Yi,
Thanks for putting this patch-set together.
On Wed, Jul 01, 2020 at 05:15:29PM +0800, yang_y...@163.com wrote:
> From: Yi Yang
>
> For multi-seg mbuf, pkt_len isn't equal to data_len,
> data_len is data_len of the first seg, pkt_len is
> sum of data_len of all the segs, so for such pac
n try to reduce the default stack size as done
by this commit:
commit b82a90e266e1246fe2973db97c95df22558174ea
Author: Flavio Leitner
Date: Thu Feb 28 13:13:57 2019 -0300
rhel: limit stack size to 2M.
Thanks,
fbl
>
> Signed-off-by: Ross Lagerwall
> ---
> vswitc
the "primary" concept, make a few small
> improvements to the non-primary AB bonding test.
>
> Signed-off-by: Jeff Squyres
> Reviewed-by: Aaron Conole
> Tested-by: Greg Rose
> Acked-by: Greg Rose
> ---
Acked-by: Flavio Leitner
Thanks!
fbl
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Thu, Jul 09, 2020 at 10:18:18PM +0530, Gowrishankar Muthukrishnan wrote:
> Moved commands to set hugepages in every numa node into a macro
> for tests to reuse.
>
> Signed-off-by: Gowrishankar Muthukrishnan
> ---
LGTM
Acked-by:
> Signed-off-by: Gowrishankar Muthukrishnan
> ---
LGTM
Acked-by: Flavio Leitner
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
y: Gowrishankar Muthukrishnan
> ---
LGTM
Acked-by: Flavio Leitner
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Thu, Jul 09, 2020 at 10:18:19PM +0530, Gowrishankar Muthukrishnan wrote:
> This patch adds minimal check for userspace-tso in system-dpdk
> tests, starting with verification on virtio negotiation.
>
> Signed-off-by: Gowrishankar Muthukrishnan
> ---
LGTM
Acked-by:
On Sun, Jun 14, 2020 at 07:03:03PM +0300, Roi Dayan wrote:
> This arg can be used internally by groups using gerrit for code reviews.
The patch looks good, but there is the condition line
that goes up to column 85. It's the only line beyond
column 79 in that file.
Sorry the nitpicking, but could
to have TSO negotiation checks, so it's part
of the patch. On another hand, those new filtering messages are
unrelated.
A patch should make one logical change.
fbl
>
> Thanks,
> Gowrishankar
>
> On Thu, Jul 9, 2020 at 6:26 PM Flavio Leitner wrote:
>
> >
> > Hi G
Hi Gowrishankar,
On Thu, Jul 09, 2020 at 11:34:33AM +0530, Gowrishankar Muthukrishnan wrote:
> This patch adds minimal check for userspace-tso in system-dpdk
> tests, starting with verification on virtio negotiation.
>
> Signed-off-by: Gowrishankar Muthukrishnan
> ---
> v7:
> - fixed ovs stop
Hi Jeff,
Thanks for following up with this patch.
I think there is still an issue with this version where one could
change the bond-primary after adding a bond port. See the sequence
below:
# ovs-vsctl add-bond br0 bond0 p1 p2 \
bond_mode=active-backup \
other_config:bond-pri
Hi Gowrishankar,
Thanks again for following up.
This patch still fails to me because of those ovs-vswitchd NUMA
messages I told in my previous e-mail. I think we need to address
that (and the VHOST_CONFIG error as well) because other tests
already do that.
Then we have test #8 failing due to tes
Hi Jeff,
On Tue, Jul 07, 2020 at 09:41:00PM +, Jeff Squyres (jsquyres) wrote:
> On Jul 2, 2020, at 4:17 PM, Flavio Leitner wrote:
> > On Thu, Jun 25, 2020 at 02:03:34PM -0700, Jeff Squyres via dev wrote:
[...]
> >> diff --git a/tests/ofproto-dpif.at b/tests/ofproto-
Hi Gowrishankar,
Thanks for following up with this patch.
However, I think we need to reconsider the tests. It doesn't seem
useful to have negotiation tests that will always fail because of
a code that is marked as deprecated (vhost-user).
I see few options here:
1) Fix vhost-user to support
Moreno
> ---
LGTM
Acked-by: Flavio Leitner
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Fri, Jul 03, 2020 at 06:57:11PM +0200, Adrian Moreno wrote:
> Document recently added ovs-appctl command
>
> Fixes: 9df65060cf4c (userspace: Avoid dp_hash recirculation for balance-tcp
> bond mode.)
> Cc: Vishal Deep Ajmera
> Signed-off-by: Adrian Moreno
> ---
The fixes tag is missing the d
Hi Gowrishankar,
Thanks for working on this patch, it's a good idea to test the
TSO negotiation.
Which dpdk version are you testing? Because I am getting the same
results on 19.11.3 or master. See the details below.
Sometimes it fails with this in testpmd-dpdkvhostuser0.log:
EAL: Detected 4 l
On Fri, Jun 26, 2020 at 03:56:31PM +0200, Adrian Moreno wrote:
> Document recently added ovs-appctl command
Could you add a Fixes tag to indicate the commit?
Thanks
fbl
>
> Cc: Vishal Deep Ajmera
> Signed-off-by: Adrian Moreno
> ---
> lib/dpif-netdev-unixctl.man | 9 +
> 1 file change
Another thing, consider a small note in NEWS.
On Thu, Jul 02, 2020 at 05:17:59PM -0300, Flavio Leitner wrote:
>
> Hi Jeff,
>
> Thanks for following up.
> I have a couple comments inline.
>
>
> On Thu, Jun 25, 2020 at 02:03:34PM -0700, Jeff Squyres via dev wrote:
&
tected.
>
> CC: Numan Siddique
> Fixes: 5b34f8fc3b38 ("Add a new OVS action check_pkt_larger")
> Reported-by: Miroslav Kubiczek
> Reported-at:
> https://mail.openvswitch.org/pipermail/ovs-discuss/2020-May/050157.html
> Signed-off-by:
Hi Jeff,
Thanks for following up.
I have a couple comments inline.
On Thu, Jun 25, 2020 at 02:03:34PM -0700, Jeff Squyres via dev wrote:
> In AB bonding, if the current active slave becomes disabled, a
> replacement slave is arbitrarily picked from the remaining set of
> enabled slaves. This
1000 is not set
> CONFIG_HZ=250
>
>
>
> On Tue, Jun 30, 2020 at 12:50 PM Flavio Leitner wrote:
>
> >
> > Right, you might want to review Documentation/timers/no_hz.rst from
> > the kernel sources and look for RCU implications section where
> > it expl
stance, instead of indexing the array with
port_idx, use handler->port_idx as an identifier?
More inline
> Reported-by: David Ahern
> Reported-at:
> https://mail.openvswitch.org/pipermail/ovs-dev/2019-December/365857.html
> Cc: Matteo Croce
> Cc: Flavio Leitner
> Signed-off-
cking_user_enter
>
> %4.86 (14181) arm_stb_user_lo user_enter #206
> |
> --- *user_enter*
> context_tracking_user_enter
>
> %2.95 (14181) arm_stb_user_lo gic_handle_irq #125
> |
> --
On Sat, Jun 27, 2020 at 05:11:15PM -0700, William Tu wrote:
> On Wed, Jun 10, 2020 at 04:49:45PM -0300, Flavio Leitner wrote:
> > The annotation OVS_NO_THREAD_SAFETY_ANALYSIS and OVS_LOCKABLE are
> > not part of the list, so ctags can't find functions using them.
> >
>
- 93320.000.000.000.00
> 0.00 7 |__pmd10
> 02:16:230 - 93330.000.000.000.00
> 0.00 5 |__pmd16
> 02:16:230 - 9334 100.000.000.000.00
> 100.00 2 |__pmd15
> 02:16:230 - 9335 100.000.000.000.00
> 100.00 4 |__pmd14
> -
Hi,
It would be nice to have this applied to branch-2.13 as well.
fbl
On Wed, Jun 10, 2020 at 08:45:38PM -0300, Flavio Leitner wrote:
> The test 'Check Python IDL reconnects to leader - Python3
> (leader only)' fails sometimes when the first ovsdb-server
> gets killed be
Hi,
It would be nice to have this applied to branch-2.13 as well.
fbl
On Wed, Jun 10, 2020 at 04:49:45PM -0300, Flavio Leitner wrote:
> The annotation OVS_NO_THREAD_SAFETY_ANALYSIS and OVS_LOCKABLE are
> not part of the list, so ctags can't find functions using them.
>
> Th
ned-off-by: Flavio Leitner
---
tests/ovsdb-idl.at | 11 +++
1 file changed, 11 insertions(+)
diff --git a/tests/ovsdb-idl.at b/tests/ovsdb-idl.at
index b5cbee7d9..c045e9264 100644
--- a/tests/ovsdb-idl.at
+++ b/tests/ovsdb-idl.at
@@ -29,6 +29,17 @@ ovsdb_cluster_start_idltest () {
ov
Hi,
First of all thanks for the patch.
I found some issues that I would like to discuss while I continue
reviewing the patch. I haven't tested yet.
See my comment in line.
Thanks!
fbl
On Tue, May 19, 2020 at 05:19:12PM +0530, Sivaprasad Tummala wrote:
> The vHost PMD brings vHost User port t
t supposed to change much and there
is no standard names.
Also add a comment to remind to keep the list up-to-date.
Signed-off-by: Flavio Leitner
---
Makefile.am| 2 +-
acinclude.m4 | 6 +++---
include/openvswitch/compiler.h | 2 ++
3 files changed, 6 insert
301 - 400 of 1046 matches
Mail list logo
