On Tue, May 19, 2020 at 12:23:40AM +0530, Gowrishankar Muthukrishnan wrote:
> >
> > > dnl Find number of sockets
> > > AT_CHECK([lscpu], [], [stdout])
> > > -AT_CHECK([cat stdout | grep "NUMA node(s)" | awk '{c=1; while
> > (c++<$(3)) {printf "512,"}; print "512"}' > NUMA_NODE])
> > >
año Ruiz
> ---
LGTM, thanks!
Acked-by: Flavio Leitner
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Thu, May 14, 2020 at 10:36:12AM -0700, Ben Pfaff wrote:
> This is based on acinclude.m4 in branch-2.13, which rejects anything
> newer than 5.0.
>
> Reported-by: Han Zhou
> Signed-off-by: Ben Pfaff
> ---
Acked-by: Flavio Leitner
_
On Sat, May 16, 2020 at 11:23:52AM +0530, Gowrishankar Muthukrishnan wrote:
> Today we need 1GB from hugepages for running dpdk tests (i.e
> 512MB for ovs-vswitchd including phy ports and 512MB for testpmd
> app). This patch optimize the usage as:
> - 1GB for dpdk tests including phy ports, vhu
On Sat, May 16, 2020 at 11:23:51AM +0530, Gowrishankar Muthukrishnan wrote:
> After dpdk tests completes, cleaning up hugepage map files
> created by tests is helpful to release used memory into
> hugepage memory allocator.
>
> Signed-off-by: Gowrishankar Muthukrishnan
> ---
>
On Mon, May 18, 2020 at 10:19:06AM -0700, Ravi Kerur wrote:
> To answer your question why I need to change mac address, we recently moved
> from kernel/bond to ovs-dpdk/bond with 2 members. With kernel/bond, all 3
> interfaces (bond + 2 members) had same mac address and if one member goes
> down
On Thu, May 14, 2020 at 03:38:44PM +0200, Jaime Caamaño Ruiz wrote:
> Since DPDK 19.11 [1], it is not allowed to set any RX mq mode for virtio
> driver.
>
> [1]
> https://github.com/DPDK/dpdk/commit/13b3137f3b7c8f866947a9b34e06a8aec0d084f7
>
> Signed-off-by: Jaime Caamaño Ruiz
> ---
>
On Mon, May 04, 2020 at 11:43:59AM -0700, Jeff Squyres via dev wrote:
> In AB bonding, if the current active slave becomes disabled, a
> replacement slave is arbitrarily picked from the remaining set of
> enabled slaves. This commit adds the concept of a "primary" slave: an
> interface that will
On Wed, Mar 25, 2020 at 11:34:57PM +0530, Numan Siddique wrote:
> On Wed, Mar 25, 2020 at 9:04 PM William Tu wrote:
> >
> > On Wed, Mar 25, 2020 at 08:21:38AM -0700, William Tu wrote:
> > > On Wed, Mar 25, 2020 at 10:08:14AM -0400, Tim Rozet wrote:
> > > > Hi All,
> > > > I've run into this
nd 6Gbps, similar to TSO with DPDK-enabled.
>
> Signed-off-by: William Tu
> ---
To the set
Acked-by: Flavio Leitner
Thanks William
fbl
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Tue, Mar 17, 2020 at 01:27:13PM -0700, William Tu wrote:
> So far we only use travis to do run 'make check' per commit.
> This enables per-commit check for 'make check-system-userspace' test.
> We can think about what others to add using github actions.
>
> Example run:
>
Hi William,
Nice that the amount of specific DPDK and non-DPDK reduced a lot!
I haven't tried to build or test yet.
It may be nitpicking because you didn't introduce some of the
names in this patch so I understand it is not the goal of your
patch. However, I think it can take the opportunity
On Thu, Mar 12, 2020 at 12:21:56PM -0700, William Tu wrote:
> This patch enables TSO support for non-DPDK use cases, and
> also add check-system-tso testsuite. Before TSO, we have to
> disable checksum offload, allowing the kernel to calculate the
> TCP/UDP packet checsum. With TSO, we can skip
On Thu, Mar 12, 2020 at 10:04:30AM -0700, William Tu wrote:
[...]
> static inline bool
> -dp_packet_ip_checksum_valid(const struct dp_packet *p)
> -{
> -return (p->mbuf.ol_flags & PKT_RX_IP_CKSUM_MASK) ==
> -PKT_RX_IP_CKSUM_GOOD;
The indentation here is correct
> -}
> -
>
Hi William,
Thanks for the patch, this one passes my tests with DPDK and
TSO enabled or disabled.
I made few comments inline
On Wed, Mar 11, 2020 at 04:46:56PM -0700, William Tu wrote:
> This patch enables TSO support for non-DPDK use cases, and
> also add check-system-tso testsuite. Before
On Wed, Mar 11, 2020 at 02:13:07PM +0100, Ilya Maximets wrote:
> On 3/11/20 1:37 PM, Flavio Leitner wrote:
> > On Wed, Mar 11, 2020 at 01:30:32PM +0100, Ilya Maximets wrote:
> >> On 3/11/20 1:13 PM, Flavio Leitner wrote:
> >>> On Wed, Mar 11, 2020 at 11:47:2
On Wed, Mar 11, 2020 at 01:30:32PM +0100, Ilya Maximets wrote:
> On 3/11/20 1:13 PM, Flavio Leitner wrote:
> > On Wed, Mar 11, 2020 at 11:47:22AM +0100, Ilya Maximets wrote:
> >> On 3/10/20 10:01 PM, Flavio Leitner wrote:
> >>>
> >>> Hi William,
> >
On Wed, Mar 11, 2020 at 11:47:22AM +0100, Ilya Maximets wrote:
> On 3/10/20 10:01 PM, Flavio Leitner wrote:
> >
> > Hi William,
> >
> > Any chance to get the function comments copied to the non-dpdk
> > versions as well?
> >
> > I won
Hi William,
Any chance to get the function comments copied to the non-dpdk
versions as well?
I wonder if we could define DP_PACKET_OL.* defines as it is
proposed in this patch if DPDK is not enabled, or define them
as DPDK defines. For example:
#ifdef DPDK
DP_PACKET_OL_TX_TCP_SEG =
On Fri, Mar 06, 2020 at 04:50:38PM +0100, Ilya Maximets wrote:
> On 3/2/20 8:51 PM, Flavio Leitner wrote:
> > On Mon, Mar 02, 2020 at 01:11:35PM +0100, Ilya Maximets wrote:
> >> On 2/28/20 11:58 PM, Flavio Leitner wrote:
> >>> The kernel needs to be at least
: Yi Yang (杨燚)-云服务集团
Signed-off-by: Flavio Leitner
---
Documentation/topics/userspace-tso.rst | 6 ++
1 file changed, 6 insertions(+)
v2
- Change wording to be more clear with regards to kernel
versions and possible backports.
diff --git a/Documentation/topics/userspace-tso.rst
b/Documentat
s point.
fbl
>
> Thanks
> Timo
>
>
>
> ------
>
>
>
>
> On Fri, Feb 28, 2020 at 9:56 AM Flavio Leitner wrote:
> >
> >
> > Hi Yi Yang,
> >
> > This is the bug fix required to make
On Mon, Mar 02, 2020 at 01:11:35PM +0100, Ilya Maximets wrote:
> On 2/28/20 11:58 PM, Flavio Leitner wrote:
> > The kernel needs to be at least 4.19-rc7 to include the commit
> > 9d2f67e43b73 ("net/packet: fix packet drop as of virtio gso")
> > otherwise the TSO pac
Hi William,
I've posted this one instead few days ago:
https://mail.openvswitch.org/pipermail/ovs-dev/2020-February/368255.html
Please have a look.
Thanks,
fbl
On Mon, Mar 02, 2020 at 11:06:21AM -0800, William Tu wrote:
> For enabling TSO on devices using AF_PACKET, minimum supported
> kernel
orted-at: https://bugzilla.redhat.com/show_bug.cgi?id=1809184
Tested-by: Flavio Leitner
Acked-by: Flavio Leitner
Please apply to branch-2.13 as well.
Thanks,
fbl
> ---
>
>
> diff --git a/utilities/ovs-dpctl-top.in b/utilities/ovs-dpctl-top.in
> index f2cc3f7f2a..011cc64b74 1007
Use ioctl TUNSETOFFLOAD if kernel supports to enable TSO
offloading in the tap device.
Fixes: 29cf9c1b3b9c ("userspace: Add TCP Segmentation Offload support")
Reported-by: "Yi Yang (杨�D)-云服务集团"
Tested-by: William Tu
Signed-off-by: Flavio Leitner
---
lib
: Yi Yang (杨燚)-云服务集团
Signed-off-by: Flavio Leitner
---
Documentation/topics/userspace-tso.rst | 4
1 file changed, 4 insertions(+)
This applies to branch-2.13 as well.
diff --git a/Documentation/topics/userspace-tso.rst
b/Documentation/topics/userspace-tso.rst
index 0fbac93a5..da370e64f 100644
DPDK
> 重要性: 高
>
> Hi, Flavio
>
> After I ran it repeatedly in different servers, I'm very sure it can't work
> on Ubuntu 16.04 kernel 4.15.0-55-generic and Upstream kernel 4.15.9, so can
> you tell me your kernel version when you ran run-iperf3.sh I provided ? I
.9, so can
> you tell me your kernel version when you ran run-iperf3.sh I provided ? I
> doubt this TSO patch for veth needs higher kernel version.
>
> -邮件原件-
> 发件人: Flavio Leitner [mailto:f...@sysclose.org]
> 发送时间: 2020年2月20日 21:41
> 收件人: Yi Yang (杨燚)-云服务集团
> 抄送:
On Thu, Feb 20, 2020 at 11:39:21AM -0800, William Tu wrote:
> On Tue, Feb 4, 2020 at 9:12 AM Flavio Leitner wrote:
> >
> > On Tue, Feb 04, 2020 at 12:00:19PM -0300, Flavio Leitner wrote:
> > > On Tue, Feb 04, 2020 at 12:51:24AM +, Yi Yang (杨�D)-云服务集团 wrote:
> &g
wasn't requested.
>
> Fixes: 29cf9c1b3b9c ("userspace: Add TCP Segmentation Offload support")
> Reported-by: David Marchand
> Acked-by: David Marchand
> Acked-by: Flavio Leitner
> Acked-by: Kevin Traynor
> Signed-off-by: Ilya Maximets
>
&
ny
> ---
Does this apply to 2.13 as well?
LGTM
Acked-by: Flavio Leitner
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Fri, Feb 14, 2020 at 12:39:50PM -0800, Ben Pfaff wrote:
> On Fri, Feb 14, 2020 at 12:20:44PM -0800, Ben Pfaff wrote:
> > On Fri, Feb 14, 2020 at 04:31:55PM -0300, Flavio Leitner wrote:
> > > On Fri, Feb 14, 2020 at 09:45:40AM -0800, Ben Pfaff wrote:
> > > >
On Fri, Feb 14, 2020 at 12:20:44PM -0800, Ben Pfaff wrote:
> On Fri, Feb 14, 2020 at 04:31:55PM -0300, Flavio Leitner wrote:
> > On Fri, Feb 14, 2020 at 09:45:40AM -0800, Ben Pfaff wrote:
> > > Hi Justin, I released 2.13.0, or at least I pushed it to the repo. Do
> >
On Fri, Feb 14, 2020 at 09:45:40AM -0800, Ben Pfaff wrote:
> Hi Justin, I released 2.13.0, or at least I pushed it to the repo. Do
> you have a checklist of other things to do for a release? I know I need
> to tag it, but I think you did other things too.
Hi Ben and Justin,
Not sure if they
;
> Thanks,
> Yifeng
>
> On Thu, Feb 13, 2020 at 12:05 PM Flavio Leitner wrote:
> >
> >
> > Hi Yifeng,
> >
> > Sorry the late response.
> >
> > On Wed, Jan 29, 2020 at 09:04:39AM -0800, Yifeng Sun wrote:
> > > Hi Flavio,
> >
it fixes netdev layer to handle each L4 checksum
independently.
Flavio Leitner (3):
netdev-dpdk: vhost: disable unsupported offload features.
userspace TSO: Include UDP checksum offload.
userspace TSO: SCTP checksum offload optional.
Documentation/topics/userspace-tso.rst | 7 +++
lib/netdev
pport")
Signed-off-by: Flavio Leitner
---
lib/netdev-dpdk.c | 18 --
lib/netdev-linux.c| 1 +
lib/netdev-provider.h | 3 ++-
lib/netdev.c | 24
4 files changed, 35 insertions(+), 11 deletions(-)
diff --git a/lib/netdev-dpdk.c b/
will be dropped on
NICs without support.
Fixes: 29cf9c1b3b9c ("userspace: Add TCP Segmentation Offload support")
Signed-off-by: Flavio Leitner
---
Documentation/topics/userspace-tso.rst | 7 +++
lib/netdev-dpdk.c | 21 +++--
lib/netdev-linux.c
Disable ECN and UFO since this is not supported yet. Also, disable
all other features when userspace_tso is not enabled.
Fixes: 29cf9c1b3b9c ("userspace: Add TCP Segmentation Offload support")
Signed-off-by: Flavio Leitner
---
lib/netdev-dpdk.c | 24 +++-
1 file c
On Thu, Feb 13, 2020 at 04:31:31PM -0800, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
> ---
testsuite is passing over here, pushed through some kernel
and dpdk traffic basic tests and all passed as well.
Acked-by: Flavio Leitner
___
dev mailin
gt; ---
I don't see any issues with this patch.
Acked-by: Flavio Leitner
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
ther host without issues.
Any chance for you to try with the same upstream kernel version?
Thanks,
fbl
>
> Thanks,
> Yifeng
>
> On Wed, Jan 29, 2020 at 3:25 AM Flavio Leitner wrote:
> >
> > On Tue, Jan 28, 2020 at 03:23:02PM -0800, Yifeng Sun wrote:
> > >
On Thu, Feb 13, 2020 at 04:18:35PM +0100, Ilya Maximets wrote:
> On 2/12/20 8:31 PM, Flavio Leitner wrote:
> > On Wed, Feb 12, 2020 at 04:26:46PM +0100, Ilya Maximets wrote:
> >> On 2/10/20 8:18 PM, Flavio Leitner wrote:
> >>> Disable ECN and UFO since this is no
test packet, but another unrelated
traffic in the network.
HTH,
fbl
>
> >
> > -----邮件原件-
> > 发件人: Ilya Maximets [mailto:i.maxim...@ovn.org]
> > 发送时间: 2020年2月13日 21:23
> > 收件人: Flavio Leitner ; Yi Yang (杨燚)-云服务集团
> >
> > 抄送: ovs-disc...@openvswitc
On Thu, Feb 13, 2020 at 01:42:32PM +0100, Ilya Maximets wrote:
> On 2/13/20 12:30 PM, Flavio Leitner wrote:
> > On Thu, Feb 13, 2020 at 11:10:15AM +0100, Ilya Maximets wrote:
> >> On 2/13/20 12:44 AM, Flavio Leitner wrote:
> >>> On Wed, Feb 12, 2020 at 04:31:09
On Thu, Feb 13, 2020 at 09:18:38AM +, Yi Yang (杨燚)-云服务集团 wrote:
> Hi, all
>
> We find ovs has serious performance issue, we only launch one VM in one
> compute, and do iperf small udp pps performance test between these two VMs,
> we can see about 18 pps (packets per second, -l 16), but
On Wed, Feb 12, 2020 at 11:46:47AM -0800, Yi-Hung Wei wrote:
> Signed-off-by: Yi-Hung Wei
> ---
Thanks the patch, looks much better with it.
Acked-by: Flavio Leitner
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/m
On Thu, Feb 13, 2020 at 11:10:15AM +0100, Ilya Maximets wrote:
> On 2/13/20 12:44 AM, Flavio Leitner wrote:
> > On Wed, Feb 12, 2020 at 04:31:09PM -0300, Flavio Leitner wrote:
> >> On Wed, Feb 12, 2020 at 04:26:46PM +0100, Ilya Maximets wrote:
> >>> On 2/10/20
On Wed, Feb 12, 2020 at 04:31:09PM -0300, Flavio Leitner wrote:
> On Wed, Feb 12, 2020 at 04:26:46PM +0100, Ilya Maximets wrote:
> > On 2/10/20 8:18 PM, Flavio Leitner wrote:
> > > Disable ECN and UFO since this is not supported yet. Also, disable
> > > all other
On Wed, Feb 12, 2020 at 04:10:28PM +0100, Ilya Maximets wrote:
> On 2/12/20 3:54 PM, Tomasz Konieczny wrote:
> > Signed-off-by: Tomasz Konieczny
> > ---
> > Documentation/howto/dpdk.rst | 19 +++
> > Documentation/intro/install/dpdk.rst | 4
> > 2 files changed, 19
On Wed, Feb 12, 2020 at 04:26:46PM +0100, Ilya Maximets wrote:
> On 2/10/20 8:18 PM, Flavio Leitner wrote:
> > Disable ECN and UFO since this is not supported yet. Also, disable
> > all other features when userspace_tso is not enabled.
>
> Disabling UFO saves us fr
On Wed, Feb 12, 2020 at 02:22:14PM +0100, Tomasz Konieczny wrote:
> There is an issue with flow control configuration on i40e devices
> and it has a work around. We add this to documentation as known issue
> until a permanent solution is developed.
>
Can you add pointers to how to set that to
On Wed, Feb 12, 2020 at 02:15:56PM +0100, Tomasz Konieczny wrote:
> Signed-off-by: Tomasz Konieczny
> ---
LGTM
Acked-by: Flavio Leitner
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Wed, Feb 12, 2020 at 02:10:11PM +0100, Tomasz Konieczny wrote:
> Modify travis linux build script to use the latest DPDK stable release
> 18.11.6. Update docs for latest DPDK stable releases.
>
> Signed-off-by: Tomasz Konieczny
> ---
Acked-by:
On Wed, Feb 12, 2020 at 02:06:53PM +0100, Tomasz Konieczny wrote:
> Modify travis linux build script to use the latest DPDK stable release
> 18.11.6. Update docs for latest DPDK stable releases.
>
> Signed-off-by: Tomasz Konieczny
> ---
Acked-by:
Disable ECN and UFO since this is not supported yet. Also, disable
all other features when userspace_tso is not enabled.
Fixes: 29cf9c1b3b9c ("userspace: Add TCP Segmentation Offload support")
Signed-off-by: Flavio Leitner
---
lib/netdev-dpdk.c | 25 -
1 file c
There is a cache miss when accessing mbuf->data_off while cloning
a batch and using prefetch improved the throughput by ~2.3%.
Before: 13709416.30 pps
After: 14031475.80 pps
Fixes: d48771848560 ("dp-packet: preserve headroom when cloning a pkt batch")
Signed-off-by: Flavio Leitner
On Thu, Feb 06, 2020 at 12:27:53PM -0800, Ben Pfaff wrote:
> On Thu, Feb 06, 2020 at 04:54:25PM -0300, Flavio Leitner wrote:
> > On Thu, Feb 06, 2020 at 11:37:06AM -0800, Ben Pfaff wrote:
> > > On Thu, Feb 06, 2020 at 11:31:37AM -0800, Ben Pfaff wrote:
> > > > On M
On Thu, Feb 06, 2020 at 12:26:38PM -0800, Ben Pfaff wrote:
> On Mon, Feb 03, 2020 at 06:45:50PM -0300, Flavio Leitner wrote:
> > Usually TSO packets are close to 50k, 60k bytes long, so to
> > to copy less bytes when receiving a packet from the kernel
> > change the approach.
On Thu, Feb 06, 2020 at 11:37:06AM -0800, Ben Pfaff wrote:
> On Thu, Feb 06, 2020 at 11:31:37AM -0800, Ben Pfaff wrote:
> > On Mon, Feb 03, 2020 at 11:22:22AM -0300, Flavio Leitner wrote:
> > > The dp_packet length is limited to 16 bits, so document that
> > > and fix t
s: 29cf9c1b3b9c ("userspace: Add TCP Segmentation Offload support")
> Signed-off-by: Ilya Maximets
> ---
Acked-by: Flavio Leitner
Thanks Ilya!
fbl
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
vice.
netdev-linux: Prepend the std packet in the TSO packet
netdev-linux-private: fix max length to be 16 bits
On top of: Prepare for 2.13.0.
You can always add a git remote and fetch only the changes you need.
fbl
>
> -----邮件原件-
> 发件人: Flavio Leitner [mailto:f...@sysclose.org
g vethbr2 0 up
>
>
> ovs-vsctl add-port br-int vethbr1
> ovs-vsctl add-port br-int vethbr2
>
> ip netns exec ns01 ping 10.15.1.3 -c 3
> ip netns exec ns02 ping 10.15.1.2 -c 3
>
> ip netns exec ns02 iperf3 -s -i 10 -D
> ip netns exec ns01 iperf3 -t 60 -i 10 -c 10.15
On Thu, Feb 06, 2020 at 11:48:58AM +0100, Ilya Maximets wrote:
> On 2/5/20 7:01 PM, David Marchand wrote:
> > On Wed, Feb 5, 2020 at 12:42 PM Flavio Leitner wrote:
> >>
> >> On Tue, Feb 04, 2020 at 10:28:26PM +0100, David Marchand wrote:
> >>> The ch
On Wed, Feb 05, 2020 at 12:05:23AM +, Yi Yang (杨燚)-云服务集团 wrote:
> Thanks Flavio, which kernel version can support TSO for tap device?
That ioctl was introduced in 2.6.27.
fbl
>
> -邮件原件-
> 发件人: Flavio Leitner [mailto:f...@sysclose.org]
> 发送时间: 2020年2月5日 1:12
> 收件人:
|00084|dpdk|ERR|Ethdev port_id=0 requested Tx
> offloads 0x2a doesn't match Tx offloads capabilities 0xe in
> rte_eth_dev_configure()*
>
> Fixes: 29cf9c1b3b9c ("userspace: Add TCP Segmentation Offload support")
>
> Reported-by: Ravi Kerur
> Signed-off-by: David Marchand
On Tue, Feb 04, 2020 at 08:41:37PM +0100, David Marchand wrote:
> On Tue, Feb 4, 2020 at 7:07 PM Ravi Kerur wrote:
> > *2020-02-04T17:42:52.976Z|00084|dpdk|ERR|Ethdev port_id=0 requested Tx
> > offloads 0x2a doesn't match Tx offloads capabilities 0xe in
> > rte_eth_dev_configure()*
>
> I'd say
On Tue, Feb 04, 2020 at 12:00:19PM -0300, Flavio Leitner wrote:
> On Tue, Feb 04, 2020 at 12:51:24AM +, Yi Yang (杨�D)-云服务集团 wrote:
> > Hi, Flavio
> >
> > With this one patch and previous several merged TSO-related patches, can
> > veth work with "ethtool -K vet
Gbits/sec 2.19 Gbits/sec
fbl
> -邮件原件-
> 发件人: Flavio Leitner [mailto:f...@sysclose.org]
> 发送时间: 2020年2月4日 5:46
> 收件人: d...@openvswitch.org
> 抄送: Stokes Ian ; Loftus Ciara
> ; Ilya Maximets ; Yi Yang (杨
> ?D)-云服务集团 ; txfh2007 ; Ben
> Pfaff ; Flavio Leitner
&
to prepend the std packet data.
Fixes: 29cf9c1b3b9c ("userspace: Add TCP Segmentation Offload support")
Suggested-by: Ben Pfaff
Signed-off-by: Flavio Leitner
---
lib/dp-packet.c| 8 +--
lib/dp-packet.h| 2 +
lib/netdev-linux-private.h | 3 +-
lib/netd
The dp_packet length is limited to 16 bits, so document that
and fix the length value accordingly.
Fixes: 29cf9c1b3b9c ("userspace: Add TCP Segmentation Offload support")
Signed-off-by: Flavio Leitner
---
lib/netdev-linux-private.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletio
Hi Ben,
On Fri, Jan 31, 2020 at 08:54:23AM -0800, Ben Pfaff wrote:
> On Wed, Jan 29, 2020 at 08:15:11PM -0300, Flavio Leitner wrote:
> > Usually TSO packets are close to 50k, 60k bytes long, so to
> > to copy less bytes when receiving a packet from the kernel
> > change
to prepend the std packet data.
Suggested-by: Ben Pfaff
Signed-off-by: Flavio Leitner
---
lib/dp-packet.c| 8 +--
lib/dp-packet.h| 2 +
lib/netdev-linux-private.h | 3 +-
lib/netdev-linux.c | 117 ++---
4 files changed, 78 insertions
then we pass the start and offset.
HTH,
fbl
>
>
> Any comments will be appreciated!
>
> Thanks a lot,
> Yifeng
>
> On Wed, Jan 29, 2020 at 1:21 PM Flavio Leitner wrote:
> >
> > On Wed, Jan 29, 2020 at 11:19:47AM -0800, William Tu wrote:
> >
On Wed, Jan 29, 2020 at 11:19:47AM -0800, William Tu wrote:
> On Wed, Jan 29, 2020 at 3:25 AM Flavio Leitner wrote:
> >
> > On Tue, Jan 28, 2020 at 03:23:02PM -0800, Yifeng Sun wrote:
> > > Sure.
> > >
> > > Firstly, make sure userspace-tso-enable
; static inline bool tcp_checksum_complete(struct sk_buff *skb)
> {
> return 0;
> }
That's odd. Which kernel is that? Maybe I can try the same version.
I am using 5.2.14-200.fc30.x86_64.
Looks like somehow the packet lost its offloading flags, then kernel
has to check the cs
alidation
> to get it working properly. I got 30.0Gbps for 'iperf' between 2 VMs.
Could you provide more details on how you did that? What's running
inside the VM?
I don't change anything inside of the VMs (Linux) in my testbed.
fbl
>
> Best,
> Yifeng
>
>
> On Tue, Jan 28
imental.
HTH,
fbl
>
> Thanks
> Timo
>
>
> ----------
> Flavio Leitner
> William Tu
> Ben Pfaff ; d...@openvswitch.org ; Ilya
> Maximets ; txfh2007
> Re: [ovs-dev] [PATCH v5] userspace: Add TCP Segmentation
On Fri, Jan 24, 2020 at 03:06:47PM -0800, William Tu wrote:
> On Fri, Jan 24, 2020 at 1:38 PM Flavio Leitner wrote:
> >
> > On Fri, Jan 24, 2020 at 10:17:10AM -0800, William Tu wrote:
> > > On Fri, Jan 24, 2020 at 6:40 AM Flavio Leitner wrote:
> > > >
> &
On Mon, Jan 27, 2020 at 05:17:01PM -0800, Yifeng Sun wrote:
> Hi Ilya,
>
> Thanks for your reply.
>
> The thing is, if checksum offloading is enabled in both VMs, then
> sender VM will send
> a packet with invalid TCP checksum, and later OVS will send this
> packet to receiver
> VM directly
On Fri, Jan 24, 2020 at 10:17:10AM -0800, William Tu wrote:
> On Fri, Jan 24, 2020 at 6:40 AM Flavio Leitner wrote:
> >
> > On Wed, Jan 22, 2020 at 10:33:59AM -0800, William Tu wrote:
> > > On Wed, Jan 22, 2020 at 12:54 AM Flavio Leitner wrote:
> &
On Wed, Jan 22, 2020 at 09:32:31AM -0800, William Tu wrote:
[...]
> Hi Flavio,
[...]
> Do you know that for af_packet (netdev-linux.c), if we switch to use
> packet mmap[1]
> instead of recvmmsg, will it improve performance?
>
> [1]
On Wed, Jan 22, 2020 at 10:33:59AM -0800, William Tu wrote:
> On Wed, Jan 22, 2020 at 12:54 AM Flavio Leitner wrote:
> >
> >
> > Hi Ben,
> >
> > Thanks for reviewing it!
> >
> > On Tue, Jan 21, 2020 at 01:35:39PM -0800, Ben Pfaff wrote:
> &g
Hi Ben,
Thanks for reviewing it!
On Tue, Jan 21, 2020 at 01:35:39PM -0800, Ben Pfaff wrote:
> On Sat, Jan 18, 2020 at 12:08:06AM +0100, Ilya Maximets wrote:
> > On 18.01.2020 00:03, Stokes, Ian wrote:
> > > Thanks all for review/testing, pushed to master.
> >
> > OK, thanks Ian.
> >
> >
On Tue, Jan 21, 2020 at 10:39:14AM -0800, William Tu wrote:
> On Thu, Jan 16, 2020 at 9:01 AM Flavio Leitner wrote:
> >
> > Abbreviated as TSO, TCP Segmentation Offload is a feature which enables
> > the network stack to delegate the TCP segmentation to the NIC reducing
&
tation until a DPDK release with the fix
> included is supported by OVS.
>
> Also, document best known methods for performance tuning when
> testing TSO with the tool iperf.
>
> Fixes: 29cf9c1b3b9c ("userspace: Add TCP Segmentation Offload support")
> Signed-off-b
until a DPDK release with the fix
> included is supported by OVS.
>
> Also, document best known methods for performance tuning when
> testing TSO with the tool iperf.
>
> Signed-off-by: Ciara Loftus
> Acked-by: Flavio Leitner
> ---
> v2:
> - rebased to master
> - change
On Fri, Jan 17, 2020 at 06:58:56PM +0100, Ilya Maximets wrote:
> On 16.01.2020 18:00, Flavio Leitner wrote:
[...]
> > Signed-off-by: Flavio Leitner
>
>
> I still didn't check computation of offsets and device configuration.
> Few comments inline.
>
> In general
by default. For additional information please
check the tso.rst document.
Signed-off-by: Flavio Leitner
---
Documentation/automake.mk | 1 +
Documentation/topics/index.rst | 1 +
Documentation/topics/userspace-tso.rst | 98 +++
NEWS | 1
On Fri, Jan 17, 2020 at 12:37:56PM -0800, William Tu wrote:
> On Fri, Jan 17, 2020 at 04:58:57PM -0300, Flavio Leitner wrote:
> > On Fri, Jan 17, 2020 at 06:58:56PM +0100, Ilya Maximets wrote:
> > > On 16.01.2020 18:00, Flavio Leitner wrote:
> [...]
> > > > diff
On Fri, Jan 17, 2020 at 06:58:56PM +0100, Ilya Maximets wrote:
> On 16.01.2020 18:00, Flavio Leitner wrote:
> > Abbreviated as TSO, TCP Segmentation Offload is a feature which enables
> > the network stack to delegate the TCP segmentation to the NIC reducing
> > the pe
by default. For additional information please
check the tso.rst document.
Signed-off-by: Flavio Leitner
---
Documentation/automake.mk | 1 +
Documentation/topics/index.rst | 1 +
Documentation/topics/userspace-tso.rst | 98 +++
NEWS | 1
The headroom is useful if the packet needs to insert additional
header, so preserve the original headroom when cloning the batch.
Signed-off-by: Flavio Leitner
---
lib/dp-packet.h | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/lib/dp-packet.h b/lib/dp-packet.h
index
There is no support for multi-segmented buffers, so flag
that to vhost library.
Signed-off-by: Flavio Leitner
---
lib/netdev-dpdk.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
index 72b67af1a..d1469f6f2 100644
--- a/lib/netdev-dpdk.c
+++ b/lib
no change with the exception for tunneled packets (not
supported).
Travis, AppVeyor, and Cirrus-ci passed.
Flavio Leitner (3):
dp-packet: preserve headroom when cloning a pkt batch
vhost: Disable multi-segmented buffers
netdev-dpdk: Add TCP Segmentation Offload support
Documentation
ne" is used by default when a file is open
> in text mode.
>
> Reported-at: https://bugzilla.redhat.com/1791681
> Reported-by: Miro Hrončok
> Signed-off-by: Timothy Redaelli
> ---
LGTM
Acked-by: Flavio Leitner
___
dev mailing list
On Tue, Jan 14, 2020 at 06:48:14PM +0100, Ilya Maximets wrote:
> On 09.01.2020 15:44, Flavio Leitner wrote:
> > Abbreviated as TSO, TCP Segmentation Offload is a feature which enables
> > the network stack to delegate the TCP segmentation to the NIC reducing
> > the pe
On Tue, Jan 14, 2020 at 03:41:57PM +, Stokes, Ian wrote:
>
>
> On 1/9/2020 2:44 PM, Flavio Leitner wrote:
> > Abbreviated as TSO, TCP Segmentation Offload is a feature which enables
> > the network stack to delegate the TCP segmentation to the NIC reducing
> >
gt; Document this as a limitation until a DPDK release with the fix
> included is supported by OVS.
>
> Also, document best known methods for performance tuning when
> testing TSO with the tool iperf.
>
> Signed-off-by: Ciara Loftus
> ---
Thank
401 - 500 of 1013 matches
Mail list logo
