Re: [ovs-dev] [PATCH] rhel: fix log directory permissions

2017-09-26 Thread Flavio Leitner
On Mon, 25 Sep 2017 14:42:48 -0400 Aaron Conole <acon...@redhat.com> wrote: > Flavio Leitner <f...@sysclose.org> writes: > > > On Fri, 22 Sep 2017 09:44:18 -0400 > > Aaron Conole <acon...@redhat.com> wrote: > > > >> When the logrotate scr

Re: [ovs-dev] [PATCH] ovs-save: Use --bundle to restore flows (on OpenFlow 1.4+)

2017-09-22 Thread Flavio Leitner
On Fri, 8 Sep 2017 13:03:48 +0200 Timothy Redaelli wrote: > If possible, use OpenFlow 1.4 atomic bundle transaction to restore flows. > The patch uses also the enabled OpenFlow version to do the queries. > > With the actual implementation if you have the default openflow

Re: [ovs-dev] [PATCH v4 0/2] Add system service to delete transient ports on boot.

2017-09-22 Thread Flavio Leitner
utilities/ovs-ctl.8| 6 ++ > utilities/ovs-ctl.in | 24 > +- > 6 files changed, 34 insertions(+), 11 deletions(-) > create mode 100644 > rhel/usr_lib_systemd_system_ovs-delete-transient-ports.service >

Re: [ovs-dev] [PATCH] rhel: fix log directory permissions

2017-09-22 Thread Flavio Leitner
ssion denied ovs-appctl: ovs-vswitchd: server returned an error Acked-by: Flavio Leitner <f...@sysclose.org> > > Signed-off-by: Aaron Conole <acon...@redhat.com> > Tested-by: Jean Hsiao <jhs...@redhat.com> > --- > rhel/openvswitch-fedora.spec.in | 2 +- &

Re: [ovs-dev] [RFC v2] [OVS/NOVA] Vhost-user backends cross-version migration support

2017-09-06 Thread Flavio Leitner
On Tue, 18 Jul 2017 15:42:08 +0200 Maxime Coquelin wrote: > This is an revival from a thread I initiated earlier this year [0], that > I had to postpone due to other priorities. > > First, I'd like to thanks reviewers of my first proposal, this new > version tries to

Re: [ovs-dev] [PATCH] Set release date for 2.8.0.

2017-09-05 Thread Flavio Leitner
On Fri, 1 Sep 2017 11:47:19 -0700 Justin Pettit wrote: > > On Aug 31, 2017, at 1:18 PM, Justin Pettit wrote: > > > >> > >> On Aug 31, 2017, at 1:14 PM, Ben Pfaff wrote: > >> > >> Since you are getting that last revert in for Flavio, and you

Re: [ovs-dev] [branch-2.8 2/2] NEWS: Mention ct() API change that will arrive in the next major release.

2017-08-31 Thread Flavio Leitner
On Thu, 31 Aug 2017 13:04:11 -0700 Justin Pettit wrote: > Signed-off-by: Justin Pettit > --- > NEWS | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/NEWS b/NEWS > index ecb32c4df80c..0eaa64a8dfdc 100644 > --- a/NEWS > +++ b/NEWS > @@ -90,6 +90,11

Re: [ovs-dev] [branch-2.8 1/2] Revert "ofproto-dpif: Mark packets as "untracked" after call to ct()."

2017-08-31 Thread Flavio Leitner
the change > until the next major release. > > Signed-off-by: Justin Pettit <jpet...@ovn.org> > Requested-by: Flavio Leitner <f...@sysclose.org> > --- LGTM, thanks! fbl > NEWS | 4 > lib/ofp-actions.c| 27 +

Re: [ovs-dev] [PATCHv2] ofproto-dpif: Mark packets as "untracked" after call to ct().

2017-08-31 Thread Flavio Leitner
On Thu, 31 Aug 2017 13:17:28 -0700 Justin Pettit <jpet...@ovn.org> wrote: > > > On Aug 29, 2017, at 9:13 PM, Flavio Leitner <f...@sysclose.org> wrote: > > > > On Mon, 21 Aug 2017 12:56:33 -0700 > > Justin Pettit <jpet...@ovn.org> wrote: > >

Re: [ovs-dev] [PATCH] Set release date for 2.8.0.

2017-08-31 Thread Flavio Leitner
On Thu, 31 Aug 2017 09:33:25 -0700 Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- > This will be applied to both master and branch-2.8, to effectively release > Open vSwitch 2.8.0. Hi Ben, I don't want to delay 2.8 even more but there was a conntrack change[1]

Re: [ovs-dev] [PATCH] redhat: fix upgrades where group doesn't exist

2017-08-30 Thread Flavio Leitner
: allow dpdk to also run as non-root user') > Signed-off-by: Aaron Conole <acon...@redhat.com> > Reported-by: Jean-Tsung Hsiao <jhs...@redhat.com> > Tested-by: Jean-Tsung Hsiao <jhs...@redhat.com> > --- Acked-by: Flavio Leitner <f...@sysclose.org> _

Re: [ovs-dev] [PATCHv2] ofproto-dpif: Mark packets as "untracked" after call to ct().

2017-08-29 Thread Flavio Leitner
On Mon, 21 Aug 2017 12:56:33 -0700 Justin Pettit wrote: > > On Aug 21, 2017, at 12:38 PM, Joe Stringer wrote: > > > > Overall I think that this is an improvement to consistency of what > > connection tracking metadata is accessible from different points in > >

Re: [ovs-dev] [PATCH] NEWS: Mark NSH support as experimental in 2.8.

2017-08-29 Thread Flavio Leitner
On Tue, 29 Aug 2017 10:50:11 -0700 Ben Pfaff <b...@ovn.org> wrote: > This feature landed late in 2.8 and the NSH wire protocol itself is not > completely stable. > > CC: Jiri Benc <jb...@redhat.com> > CC: Flavio Leitner <f...@sysclose.org> > Signed-off-by: Be

Re: [ovs-dev] [PATCH 0/3] updated selinux policy for Open vSwitch

2017-08-17 Thread Flavio Leitner
) > delete mode 100644 selinux/openvswitch-custom.te > create mode 100644 selinux/openvswitch-custom.te.in > Looks good to me. Acked-by: Flavio Leitner <f...@sysclose.org> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCHv2 2/2] tests: Comment which netcat version the opts are for.

2017-08-15 Thread Flavio Leitner
d-only -w 5" > else > + # BSD netcat > NC_EOF_OPT="-q 1 -w 5" > fi > Acked-by: Flavio Leitner <f...@sysclose.org> -- Flavio ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCHv2 1/2] tests: Put maximum timeout on netcat calls.

2017-08-15 Thread Flavio Leitner
- ## ## Test results. ## ## - ## 1 test was successful. in parallel: ps auwx | grep nc | grep 'send-' root 2379 0.0 0.0 9680 2508 pts/25 S+ 20:42 0:00 bash -c echo a | nc --send-only -w 5 -u 10.1.1.2 1 Acked-by: Flavio Leitner <f...@sysclose.org> Thanks J

Re: [ovs-dev] [PATCH] tests: Put maximum timeout on netcat calls.

2017-08-15 Thread Flavio Leitner
On Tue, 15 Aug 2017 15:03:25 -0700 Joe Stringer wrote: > This was causing test script execution to hang forever on Ubuntu Zesty. > Make sure it times out within 5 seconds, so at least it will fail out > properly. > > Signed-off-by: Joe Stringer > --- >

Re: [ovs-dev] [PATCH V2] tc: Add SCTP support

2017-08-15 Thread Flavio Leitner
On Thu, 27 Jul 2017 10:17:23 +0200 Simon Horman wrote: > On Wed, Jul 26, 2017 at 02:35:51PM -0700, Joe Stringer wrote: > > On 25 July 2017 at 04:39, Roi Dayan wrote: > > > From: Vlad Buslov > > > > > > Implement SCTP source

Re: [ovs-dev] [branch-2.7 1/2] Set release date for 2.7.1.

2017-07-03 Thread Flavio Leitner
On Sat, Jul 01, 2017 at 04:34:34PM -0700, Justin Pettit wrote: > > > On Jun 28, 2017, at 11:43 AM, Flavio Leitner <f...@redhat.com> wrote: > > > > On Wed, Jun 28, 2017 at 09:47:19AM -0700, Justin Pettit wrote: > >> Signed-off-by: Justin Pettit <jpet...@ovn.

Re: [ovs-dev] [branch-2.5 2/2] Prepare for 2.5.4.

2017-06-28 Thread Flavio Leitner
On Wed, Jun 28, 2017 at 09:52:58AM -0700, Justin Pettit wrote: > Signed-off-by: Justin Pettit <jpet...@ovn.org> > --- Acked-by: Flavio Leitner <f...@sysclose.org> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.or

Re: [ovs-dev] [branch-2.5 1/2] Set release date for 2.5.3.

2017-06-28 Thread Flavio Leitner
On Wed, Jun 28, 2017 at 09:52:57AM -0700, Justin Pettit wrote: > Signed-off-by: Justin Pettit <jpet...@ovn.org> > --- Acked-by: Flavio Leitner <f...@sysclose.org> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.or

Re: [ovs-dev] [branch-2.7 2/2] Prepare for 2.7.2.

2017-06-28 Thread Flavio Leitner
On Wed, Jun 28, 2017 at 09:47:20AM -0700, Justin Pettit wrote: > Signed-off-by: Justin Pettit <jpet...@ovn.org> > --- Acked-by: Flavio Leitner <f...@sysclose.org> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.or

Re: [ovs-dev] [branch-2.7 1/2] Set release date for 2.7.1.

2017-06-28 Thread Flavio Leitner
On Wed, Jun 28, 2017 at 09:47:19AM -0700, Justin Pettit wrote: > Signed-off-by: Justin Pettit <jpet...@ovn.org> > --- Acked-by: Flavio Leitner <f...@sysclose.org> Thanks, fbl ___ dev mailing list d...@openvswitch.org https://ma

[ovs-dev] [PATCH] ctags: include symbols with locking annotations.

2017-06-26 Thread Flavio Leitner
OVS uses extensively clang annotations for thread safety checks. The ctags tool can't parse them, so they are not included in the tag file. This patch improves the configure script to generate a list of identifiers from the header compiler.h to be ignored by ctags. Signed-off-by: Flavio Leitner

Re: [ovs-dev] Fail to netdev_open internal iface with error "File exists"

2017-06-22 Thread Flavio Leitner
On Thu, Jun 22, 2017 at 01:04:59AM +0800, Huanle Han wrote: > Hi,all > > I get this problem with latest(dbd8112) branch-2.7 code on my Ubuntu. > root@ubuntu:/var/log/# ovs-vsctl show > adf2ea99-0c53-4180-914f-7dadaa71302b > Bridge test > Port test > Interface test >

Re: [ovs-dev] [PATCH 2/3] netdev-linux: make tap devices persistent.

2017-06-20 Thread Flavio Leitner
ally, so could you try reverting that patch and see if the issue goes away? > > Regards, > Vishal > > -----Original Message- > From: Flavio Leitner [mailto:f...@sysclose.org] > Sent: Tuesday, June 20, 2017 12:32 AM > To: Vishal Deep Ajmera <vishal.deep.aj

Re: [ovs-dev] [PATCH 2/3] netdev-linux: make tap devices persistent.

2017-06-19 Thread Flavio Leitner
Hi Vishal, On Thu, Jun 08, 2017 at 02:22:38PM -0300, Flavio Leitner wrote: > On Thu, Jun 08, 2017 at 11:24:58AM +, Vishal Deep Ajmera wrote: > > Hi Flavio, > > > > I am facing some issue with ovs-master on Ubuntu 14.04 system. Here are the > > steps I followed

Re: [ovs-dev] [PATCH] docs: Document that hw-offload is experimental.

2017-06-19 Thread Flavio Leitner
ental. Over time, we expect that the functionality and usefulness > of this feature will grow and we should be in a better shape to revisit > the status of this functionality after it has had some time to mature. > > Signed-off-by: Joe Stringer <j...@ovn.org> > --- Thanks for followin

Re: [ovs-dev] [PATCH V11 08/33] other-config: Add tc-policy switch to control tc flower flag

2017-06-14 Thread Flavio Leitner
the kernel to provide a define for policy NONE because then I think we don't need tc_offload_policy enum. It also has that known limitation of forcing the user to set the policy before enabling HW offloading. Both are not a blocker to me. Acked-by: Flavio Leitner <f...@sysclose.org> > --- &

Re: [ovs-dev] [PATCH V10 05/33] tc: Add tc flower functions

2017-06-13 Thread Flavio Leitner
On Mon, Jun 12, 2017 at 05:57:37PM +0300, Roi Dayan wrote: > > > On 09/06/2017 21:37, Flavio Leitner wrote: > > On Thu, Jun 08, 2017 at 02:46:22PM +0300, Roi Dayan wrote: > > > Add tc helper functions to query and manipulate the flower classifier. > > > >

Re: [ovs-dev] [PATCH V10 28/33] dpctl: Indicate if flow is offloaded when dumping flows of all types

2017-06-10 Thread Flavio Leitner
an <r...@mellanox.com> > --- I'd suggest to either say offloaded: yes or no, and not to just add the field if offloaded. It makes harder to parse on a script. I can propose an improvement if this gets merged, so it's not a problem for me. A

Re: [ovs-dev] [PATCH V10 33/33] NEWS: add a note about hw offloading

2017-06-10 Thread Flavio Leitner
On Thu, Jun 08, 2017 at 02:46:50PM +0300, Roi Dayan wrote: > Signed-off-by: Roi Dayan <r...@mellanox.com> > --- Acked-by: Flavio Leitner <f...@sysclose.org> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/ma

Re: [ovs-dev] [PATCH V10 32/33] dpif-netlink: Use dpif logging functions

2017-06-10 Thread Flavio Leitner
On Thu, Jun 08, 2017 at 02:46:49PM +0300, Roi Dayan wrote: > Remove redundant logging functions and reuse > the exposed dpif logging functions. > > Signed-off-by: Roi Dayan <r...@mellanox.com> > Reviewed-by: Paul Blakey <pa...@mellanox.com> > --- Acked-by: Fla

Re: [ovs-dev] [PATCH V10 31/33] dpif: Refactor flow logging functions to be used by other modules

2017-06-10 Thread Flavio Leitner
On Thu, Jun 08, 2017 at 02:46:48PM +0300, Roi Dayan wrote: > To be reused by other modules. > > Signed-off-by: Roi Dayan <r...@mellanox.com> > Reviewed-by: Paul Blakey <pa...@mellanox.com> > --- Acked-by: Flavio Leitner <f...@sysclose.org> __

Re: [ovs-dev] [PATCH V10 26/33] dpctl: Add filter arg to dump-flows command info

2017-06-10 Thread Flavio Leitner
On Thu, Jun 08, 2017 at 02:46:43PM +0300, Roi Dayan wrote: > This is for it to appear in bash completion. > > Signed-off-by: Roi Dayan <r...@mellanox.com> > --- Acked-by: Flavio Leitner <f...@sysclose.org> ___ dev mailing l

Re: [ovs-dev] [PATCH V10 25/33] netdev-tc-offloads: Add ingress on netdev flow api init

2017-06-10 Thread Flavio Leitner
On Thu, Jun 08, 2017 at 02:46:42PM +0300, Roi Dayan wrote: > From: Paul Blakey <pa...@mellanox.com> > > Signed-off-by: Paul Blakey <pa...@mellanox.com> > Reviewed-by: Roi Dayan <r...@mellanox.com> > Reviewed-by: Simon Horman <simon.hor...@netronome.com

Re: [ovs-dev] [PATCH V10 24/33] netdev-vport: Use common offloads interface

2017-06-09 Thread Flavio Leitner
ned-off-by: Paul Blakey <pa...@mellanox.com> > Reviewed-by: Roi Dayan <r...@mellanox.com> > Reviewed-by: Simon Horman <simon.hor...@netronome.com> > --- Acked-by: Flavio Leitner <f...@sysclose.org> ___ dev mailing li

Re: [ovs-dev] [PATCH V10 23/33] netdev-linux: Disallow setting policing when configured with hw offload

2017-06-09 Thread Flavio Leitner
t; > Reviewed-by: Roi Dayan <r...@mellanox.com> > Reviewed-by: Simon Horman <simon.hor...@netronome.com> > --- Acked-by: Flavio Leitner <f...@sysclose.org> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH V10 22/33] netdev-tc-offloads: Implement flow get using tc interface

2017-06-09 Thread Flavio Leitner
t; > Reviewed-by: Roi Dayan <r...@mellanox.com> > Reviewed-by: Simon Horman <simon.hor...@netronome.com> > --- Acked-by: Flavio Leitner <f...@sysclose.org> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH V10 21/33] dpif-netlink: Use netdev flow get api to query a flow

2017-06-09 Thread Flavio Leitner
t; > Reviewed-by: Roi Dayan <r...@mellanox.com> > Reviewed-by: Simon Horman <simon.hor...@netronome.com> > --- Acked-by: Flavio Leitner <f...@sysclose.org> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH V10 20/33] netdev-tc-offloads: Implement netdev flow del using tc interface

2017-06-09 Thread Flavio Leitner
On Thu, Jun 08, 2017 at 02:46:37PM +0300, Roi Dayan wrote: > From: Paul Blakey <pa...@mellanox.com> > > Signed-off-by: Paul Blakey <pa...@mellanox.com> > Reviewed-by: Roi Dayan <r...@mellanox.com> > Reviewed-by: Simon Horman <simon.hor...@netronome.com

Re: [ovs-dev] [PATCH V10 19/33] dpif-netlink: Use netdev flow del api to delete a flow

2017-06-09 Thread Flavio Leitner
.@mellanox.com> > Reviewed-by: Simon Horman <simon.hor...@netronome.com> > --- Acked-by: Flavio Leitner <f...@sysclose.org> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH V10 18/33] netdev-tc-offloads: Implement netdev flow put using tc interface

2017-06-09 Thread Flavio Leitner
t; Reviewed-by: Simon Horman <simon.hor...@netronome.com> > --- Happy that there was no reason to hardcode dst_mask. No SCTP and one function argument per line. Acked-by: Flavio Leitner <f...@sysclose.org> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH V10 17/33] netdev-tc-offloads: Add flower mask to priority map

2017-06-09 Thread Flavio Leitner
Blakey <pa...@mellanox.com> > Reviewed-by: Roi Dayan <r...@mellanox.com> > Reviewed-by: Simon Horman <simon.hor...@netronome.com> > --- Thanks for fixing the types and for adding a comment about the overflow. Acked-by: Flavio Leitner <f...@sysclose.org> __

Re: [ovs-dev] [PATCH V10 16/33] dpif-netlink: Use netdev flow put api to insert a flow

2017-06-09 Thread Flavio Leitner
ches. > > Signed-off-by: Paul Blakey <pa...@mellanox.com> > Reviewed-by: Roi Dayan <r...@mellanox.com> > Reviewed-by: Simon Horman <simon.hor...@netronome.com> > --- Acked-by: Flavio Leitner <f...@sysclose.org> ___

Re: [ovs-dev] [PATCH V10 15/33] netdev-tc-offloads: Implement netdev flow dump api using tc interface

2017-06-09 Thread Flavio Leitner
On Thu, Jun 08, 2017 at 02:46:32PM +0300, Roi Dayan wrote: > From: Paul Blakey <pa...@mellanox.com> > > Signed-off-by: Paul Blakey <pa...@mellanox.com> > Reviewed-by: Roi Dayan <r...@mellanox.com> > Reviewed-by: Simon Horman <simon.hor...@netronome.com

Re: [ovs-dev] [PATCH V10 13/33] netdev-tc-offloads: Add ufid to tc/netdev map

2017-06-09 Thread Flavio Leitner
; retrieval and deleting of offloaded flows. > > Signed-off-by: Paul Blakey <pa...@mellanox.com> > Reviewed-by: Roi Dayan <r...@mellanox.com> > Reviewed-by: Simon Horman <simon.hor...@netronome.com> > --- Acked-by: Flavio Leitner <f...@sysclose.org> ___

Re: [ovs-dev] [PATCH V10 12/33] dpif-netlink: Dump netdevs flows on flow dump

2017-06-09 Thread Flavio Leitner
t; > Reviewed-by: Roi Dayan <r...@mellanox.com> > Reviewed-by: Simon Horman <simon.hor...@netronome.com> > --- Acked-by: Flavio Leitner <f...@sysclose.org> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH V10 06/33] netdev: Adding a new netdev API to be used for offloading flows

2017-06-09 Thread Flavio Leitner
ox.com> > Reviewed-by: Roi Dayan <r...@mellanox.com> > Reviewed-by: Simon Horman <simon.hor...@netronome.com> > --- Acked-by: Flavio Leitner <f...@sysclose.org> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH V10 05/33] tc: Add tc flower functions

2017-06-09 Thread Flavio Leitner
On Thu, Jun 08, 2017 at 02:46:22PM +0300, Roi Dayan wrote: > Add tc helper functions to query and manipulate the flower classifier. > > Signed-off-by: Paul Blakey <pa...@mellanox.com> > Co-authored-by: Roi Dayan <r...@mellanox.com> > Signed-off-by: Roi Dayan <r...@m

Re: [ovs-dev] [PATCH V10 04/33] tc: Move functions the create/parse handle to be static inline

2017-06-09 Thread Flavio Leitner
TC_H_ROOT, but that's ok. Acked-by: Flavio Leitner <f...@sysclose.org> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH V10 03/33] tc: Refactor tcm handle assignment when creating filter qdisc

2017-06-09 Thread Flavio Leitner
On Thu, Jun 08, 2017 at 02:46:20PM +0300, Roi Dayan wrote: > Use the available TC macros instead of 0x. > > Signed-off-by: Roi Dayan <r...@mellanox.com> > --- Acked-by: Flavio Leitner <f...@sysclose.org> ___ dev mailing l

[ovs-dev] [PATCH v2] testsuite: exit gracefully if it fails.

2017-06-09 Thread Flavio Leitner
The daemon is killed leaving resources behind when a test fails. This fixes to first signal the daemon to exit gracefully. Fixes: 0f28164be02ac ("netdev-linux: make tap devices persistent") Suggested-by: Joe Stringer <j...@ovn.org> Co-authored-by: Ben Pfaff <b...@ovn.org>

Re: [ovs-dev] [PATCH 5/6] redhat: dynamically allocate and reference ovs user

2017-06-08 Thread Flavio Leitner
On Thu, Jun 08, 2017 at 04:39:07PM -0400, Aaron Conole wrote: > >> half-dozen-of-the-other thing. Whichever we choose, the requirements, > >> in my mind, are simple: > >> > >> 1. Don't break existing users who are upgrading. > >> 2. Provide new installs with non-root users, because it's a good >

Re: [ovs-dev] [PATCH 5/6] redhat: dynamically allocate and reference ovs user

2017-06-08 Thread Flavio Leitner
On Thu, Jun 08, 2017 at 03:46:24PM -0400, Aaron Conole wrote: > Flavio Leitner <f...@sysclose.org> writes: > > > On Sat, Jun 03, 2017 at 11:10:00AM -0400, Aaron Conole wrote: > >> After this commit, the fedora RPM will create the openvswitch user, from > >&g

Re: [ovs-dev] [PATCH] dpdk: announce deprecation of vhost-user server ports

2017-06-08 Thread Flavio Leitner
On Thu, Jun 08, 2017 at 06:54:24PM +, Darrell Ball wrote: > > > On 6/8/17, 11:22 AM, "Darrell Ball" <db...@vmware.com> wrote: > > > > On 6/8/17, 11:13 AM, "Flavio Leitner" <f...@sysclose.org> wrote: > > O

Re: [ovs-dev] [PATCH] testsuite: exit gracefully if it fails.

2017-06-08 Thread Flavio Leitner
On Thu, Jun 08, 2017 at 10:53:05AM -0700, Ben Pfaff wrote: > On Thu, Jun 08, 2017 at 02:30:48PM -0300, Flavio Leitner wrote: > > The daemon is killed leaving resources behind when a test fails. > > This fixes to first signal the daemon to exit gracefully. > > > > Su

Re: [ovs-dev] [PATCH] dpdk: announce deprecation of vhost-user server ports

2017-06-08 Thread Flavio Leitner
On Thu, Jun 08, 2017 at 09:40:52AM -0400, Aaron Conole wrote: > Hi Darrell, > > Thanks so much for the review! Comments below. > > Darrell Ball writes: > > > On 6/7/17, 3:46 PM, "Aaron Conole" wrote: > > > > Since vhost-user server mode ports are the

Re: [ovs-dev] [PATCH] testsuite: release resources when vswitch exits.

2017-06-08 Thread Flavio Leitner
On Thu, Jun 08, 2017 at 10:16:11AM -0700, Ben Pfaff wrote: > On Wed, Jun 07, 2017 at 05:56:36PM -0700, Joe Stringer wrote: > > On 7 June 2017 at 17:36, Joe Stringer <j...@ovn.org> wrote: > > > On 7 June 2017 at 13:58, Flavio Leitner <f...@redhat.com> wrote: > >

[ovs-dev] [PATCH] testsuite: exit gracefully if it fails.

2017-06-08 Thread Flavio Leitner
The daemon is killed leaving resources behind when a test fails. This fixes to first signal the daemon to exit gracefully. Suggested-by: Joe Stringer <j...@ovn.org> Fixes: 0f28164be02ac ("netdev-linux: make tap devices persistent") Signed-off-by: Flavio Leitner <f...@red

Re: [ovs-dev] [PATCH 2/3] netdev-linux: make tap devices persistent.

2017-06-08 Thread Flavio Leitner
"2.7.90" The same thing Eric reported to me when a test unit had failed. Oddly I can't reproduce (yet), but reviewing the code seems that a rtnetlink to add a route can open the device but not add to the DP, then when it tries to that error would be reported. I will look more into it an

Re: [ovs-dev] [PATCH 2/6] redhat: replace python3 with python package macro

2017-06-07 Thread Flavio Leitner
On Wed, Jun 07, 2017 at 05:39:28PM -0300, Flavio Leitner wrote: > On Sat, Jun 03, 2017 at 11:09:57AM -0400, Aaron Conole wrote: > > diff --git a/rhel/openvswitch-fedora.spec.in > > b/rhel/openvswitch-fedora.spec.in > > index 9fc5f27..95533aa 100644 > > --- a/rhel

Re: [ovs-dev] [PATCH 2/3] netdev-linux: make tap devices persistent.

2017-06-07 Thread Flavio Leitner
ereas data-path is > not present ? The link goes down and packets are dropped. fbl > > Regards, > Vishal > > -Original Message- > From: ovs-dev-boun...@openvswitch.org > [mailto:ovs-dev-boun...@openvswitch.org] On Behalf Of Flavio Leitner > Sent: Tuesday, May 30, 20

Re: [ovs-dev] [PATCH 1/3] ovs-router: fix refcnt leak when program terminates.

2017-06-07 Thread Flavio Leitner
On Tue, Jun 06, 2017 at 05:10:10PM -0700, Ben Pfaff wrote: > On Mon, May 29, 2017 at 04:40:21PM -0300, Flavio Leitner wrote: > > Install a handler to flush routes and release devices when > > the program is terminating. > > > > Signed-off-by: Flavio Leitner <f...@

Re: [ovs-dev] [PATCH V9 09/31] dpif-netlink: Flush added ports using netdev flow api

2017-06-02 Thread Flavio Leitner
an <r...@mellanox.com> > Reviewed-by: Simon Horman <simon.hor...@netronome.com> > Acked-by: Flavio Leitner <f...@sysclose.org> > --- > lib/dpif-netlink.c | 5 + > lib/netdev.c | 12 > lib/netdev.h | 1 + > 3 files changed, 18

Re: [ovs-dev] [PATCH V9 08/31] dpif: Save added ports in a port map for netdev flow api use

2017-06-02 Thread Flavio Leitner
translate dpif ports to netdevs. > > Signed-off-by: Paul Blakey <pa...@mellanox.com> > Reviewed-by: Roi Dayan <r...@mellanox.com> > Reviewed-by: Simon Horman <simon.hor...@netronome.com> > Acked-by: Flavio Leitner <f...@sysclose.org> > --- > lib/dpif.c

Re: [ovs-dev] [PATCH V9 06/31] other-config: Add hw-offload switch to control netdev flow offloading

2017-05-31 Thread Flavio Leitner
f the kernel datapath. > This configuration option defaults to false - disabled. > > Signed-off-by: Paul Blakey <pa...@mellanox.com> > Reviewed-by: Roi Dayan <r...@mellanox.com> > Reviewed-by: Simon Horman <simon.hor...@netronome.com&

Re: [ovs-dev] [PATCH V9 02/31] tc: Introduce tc module

2017-05-31 Thread Flavio Leitner
anox.com> > Signed-off-by: Roi Dayan <r...@mellanox.com> > --- Nice change and my comments are dup of others. Anyway, I am happy as it is today. Acked-by: Flavio Leitner <f...@sysclose.org> ___ dev mailing list d...@openvswitch.o

Re: [ovs-dev] [PATCH V9 01/31] netdev-linux: Refactor two tc functions

2017-05-31 Thread Flavio Leitner
y functionality. > > Signed-off-by: Paul Blakey <pa...@mellanox.com> > Signed-off-by: Roi Dayan <r...@mellanox.com> > --- Acked-by: Flavio Leitner <f...@sysclose.org> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH 1/3] ovs-router: fix refcnt leak when program terminates.

2017-05-29 Thread Flavio Leitner
Install a handler to flush routes and release devices when the program is terminating. Signed-off-by: Flavio Leitner <f...@redhat.com> --- lib/ovs-router.c | 34 ++ 1 file changed, 26 insertions(+), 8 deletions(-) diff --git a/lib/ovs-router.c b/lib/ovs-ro

[ovs-dev] [PATCH 0/3] Allow restart to keep network configuration

2017-05-29 Thread Flavio Leitner
This patchset changes OVS to allow restarts to preserve bridge's network configuration when using netdev datapath. Flavio Leitner (3): ovs-router: fix refcnt leak when program terminates. netdev-linux: make tap devices persistent. netdev-linux: maintain original device's state lib/netdev

Re: [ovs-dev] [PATCH v8] netdev-dpdk: Increase pmd thread priority

2017-05-26 Thread Flavio Leitner
On Tue, Jan 03, 2017 at 03:08:11PM -0500, Aaron Conole wrote: > Bhanuprakash Bodireddy writes: > > > Increase the DPDK pmd thread scheduling priority by lowering the nice > > value. This will advise the kernel scheduler to prioritize pmd thread > > over other

Re: [ovs-dev] [PATCH RFC] Drop support for RHEL 5 and 6

2017-05-25 Thread Flavio Leitner
On Thu, May 25, 2017 at 08:21:11AM -0700, Guru Shetty wrote: > On 24 May 2017 at 16:51, Flavio Leitner <f...@sysclose.org> wrote: > > > On Tue, May 16, 2017 at 11:05:24AM -0700, Guru Shetty wrote: > > > On 15 May 2017 at 16:49, Joe Stringer <j...@ovn.org> wrote: &

Re: [ovs-dev] [PATCH RFC] Drop support for RHEL 5 and 6

2017-05-24 Thread Flavio Leitner
On Tue, May 16, 2017 at 11:05:24AM -0700, Guru Shetty wrote: > On 15 May 2017 at 16:49, Joe Stringer wrote: > > > On 12 May 2017 at 07:45, Timothy Redaelli wrote: > > > RHEL 6 is not supported anymore since it uses Python 2.6 and GCC 4.4.x, > > > but Open

Re: [ovs-dev] [PATCH ovs V8 02/26] netdev: Adding a new netdev api to be used for offloading flows

2017-05-16 Thread Flavio Leitner
On Mon, May 15, 2017 at 09:34:35AM +0300, Roi Dayan wrote: > > > On 09/05/2017 21:12, Flavio Leitner wrote: > > On Wed, May 03, 2017 at 06:07:53PM +0300, Roi Dayan wrote: > > > From: Paul Blakey <pa...@mellanox.com> > > > > > > Signed-off-by:

Re: [ovs-dev] [PATCH ovs V8 00/26] Introducing HW offload support for openvswitch

2017-05-10 Thread Flavio Leitner
On Wed, May 10, 2017 at 10:44:46AM +0300, Roi Dayan wrote: > > > On 09/05/2017 22:05, Flavio Leitner wrote: > > On Sun, May 07, 2017 at 10:55:32AM +0300, Roi Dayan wrote: > > > > > > > > > On 03/05/2017 18:58, Federico Iezzi wrote: > >

Re: [ovs-dev] [PATCH ovs V8 12/26] netdev-tc-offloads: Add flower mask to priority map

2017-05-09 Thread Flavio Leitner
On Tue, May 09, 2017 at 03:23:12PM -0300, Flavio Leitner wrote: > On Wed, May 03, 2017 at 06:08:03PM +0300, Roi Dayan wrote: > > From: Paul Blakey <pa...@mellanox.com> > > > > Flower classifer requires a different priority per mask, > > so we hash the mask and gen

Re: [ovs-dev] [PATCH ovs V8 00/26] Introducing HW offload support for openvswitch

2017-05-09 Thread Flavio Leitner
On Sun, May 07, 2017 at 10:55:32AM +0300, Roi Dayan wrote: > > > On 03/05/2017 18:58, Federico Iezzi wrote: > > On Wed, May 3, 2017 at 5:07 PM, Roi Dayan wrote: > > > This patch series introduces rule offload functionality to dpif-netlink > > > via netdev ports new flow

Re: [ovs-dev] [PATCH ovs V8 12/26] netdev-tc-offloads: Add flower mask to priority map

2017-05-09 Thread Flavio Leitner
On Wed, May 03, 2017 at 06:08:03PM +0300, Roi Dayan wrote: > From: Paul Blakey > > Flower classifer requires a different priority per mask, > so we hash the mask and generate a new priority for > each new mask used. > > Signed-off-by: Paul Blakey >

Re: [ovs-dev] [PATCH ovs V8 13/26] netdev-tc-offloads: Implement netdev flow put using tc interface

2017-05-09 Thread Flavio Leitner
On Wed, May 03, 2017 at 06:08:04PM +0300, Roi Dayan wrote: > From: Paul Blakey > > Currently only tunnel offload is supported. > > Signed-off-by: Paul Blakey > Reviewed-by: Roi Dayan > Reviewed-by: Simon Horman

Re: [ovs-dev] [PATCH ovs V8 02/26] netdev: Adding a new netdev api to be used for offloading flows

2017-05-09 Thread Flavio Leitner
On Wed, May 03, 2017 at 06:07:53PM +0300, Roi Dayan wrote: > From: Paul Blakey > > Signed-off-by: Paul Blakey > Reviewed-by: Roi Dayan > Reviewed-by: Simon Horman > --- > lib/automake.mk | 2 + >

Re: [ovs-dev] [PATCH] build: Don't run tests in rpm makefile targets.

2017-04-27 Thread Flavio Leitner
On Thu, Apr 27, 2017 at 03:04:43PM -0400, Russell Bryant wrote: > On Fri, Apr 21, 2017 at 7:01 PM, Ben Pfaff wrote: > > On Fri, Mar 31, 2017 at 11:27:23AM -0400, Russell Bryant wrote: > >> The RPM build makefile targets are helpful during development and testing, > >> but I

Re: [ovs-dev] [PATCH ovs V7 00/24] Introducing HW offload support for openvswitch

2017-04-12 Thread Flavio Leitner
On Wed, Apr 12, 2017 at 02:53:13PM -0300, Marcelo Ricardo Leitner wrote: > Hi, > > On Wed, Apr 12, 2017 at 01:13:36PM -0300, Flavio Leitner wrote: > > > > Hi Marcelo, > > > > Could you please confirm if this patch series fixes the aggregation > > issue

Re: [ovs-dev] Minutes: OvS Offload Discussion at Netdev 2.1

2017-04-12 Thread Flavio Leitner
On Sat, Apr 08, 2017 at 04:47:57PM -0400, Simon Horman wrote: > At Netdev 2.1 a meeting was held to discuss OvS offload. Minutes of the > discussion follow. I apologise in advance for any errors or omissions; > doubly for any errors in the attendee list. > > Topic: OVS Hardware Offload Using TC

Re: [ovs-dev] [PATCH ovs V7 21/24] dpctl: Add an option to dump only certain kinds of flows

2017-04-12 Thread Flavio Leitner
On Wed, Apr 12, 2017 at 10:04:50AM -0700, Joe Stringer wrote: > On 12 April 2017 at 08:22, Flavio Leitner <f...@sysclose.org> wrote: > > On Fri, Apr 07, 2017 at 04:13:08PM +0300, Roi Dayan wrote: > >> From: Paul Blakey <pa...@mellanox.com> > >> > >&

Re: [ovs-dev] [PATCH ovs V7 13/24] netdev-tc-offloads: Implement netdev flow put using tc interface

2017-04-12 Thread Flavio Leitner
On Fri, Apr 07, 2017 at 04:13:00PM +0300, Roi Dayan wrote: > From: Paul Blakey > > Currently only tunnel offload is supported. > > Signed-off-by: Paul Blakey > Reviewed-by: Roi Dayan > Reviewed-by: Simon Horman

Re: [ovs-dev] [PATCH ovs V7 00/24] Introducing HW offload support for openvswitch

2017-04-12 Thread Flavio Leitner
Hi Marcelo, Could you please confirm if this patch series fixes the aggregation issue in your environment? Thanks, fbl On Fri, Apr 07, 2017 at 04:12:47PM +0300, Roi Dayan wrote: > This patch series introduces rule offload functionality to dpif-netlink > via netdev ports new flow offloading

Re: [ovs-dev] [PATCH ovs V7 21/24] dpctl: Add an option to dump only certain kinds of flows

2017-04-12 Thread Flavio Leitner
On Fri, Apr 07, 2017 at 04:13:08PM +0300, Roi Dayan wrote: > From: Paul Blakey > > Usage: > # to dump all datapath flows (default): > ovs-dpctl dump-flows > > # to dump only flows that in kernel datapath: > ovs-dpctl dump-flows type=ovs > > # to dump

Re: [ovs-dev] [PATCH ovs V7 07/24] netdev-tc-offloads: Implement netdev flow flush using tc interface

2017-04-12 Thread Flavio Leitner
On Fri, Apr 07, 2017 at 04:12:54PM +0300, Roi Dayan wrote: > From: Paul Blakey > > Signed-off-by: Paul Blakey > Reviewed-by: Roi Dayan > Reviewed-by: Simon Horman > --- > lib/netdev-tc-offloads.c | 14

Re: [ovs-dev] [PATCH ovs V7 06/24] dpif-netlink: Flush added ports using netdev flow api

2017-04-12 Thread Flavio Leitner
an <r...@mellanox.com> > Reviewed-by: Simon Horman <simon.hor...@netronome.com> > --- Acked-by: Flavio Leitner <f...@sysclose.org> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH ovs V7 05/24] dpif: Save added ports in a port map for netdev flow api use

2017-04-12 Thread Flavio Leitner
translate dpif ports to netdevs. > > Signed-off-by: Paul Blakey <pa...@mellanox.com> > Reviewed-by: Roi Dayan <r...@mellanox.com> > Reviewed-by: Simon Horman <simon.hor...@netronome.com> > --- Acked-by: Flavio Leitner <f...@sysclose.org> __

Re: [ovs-dev] [PATCH ovs V7 04/24] other-config: Add tc-policy switch to control tc flower flag

2017-04-12 Thread Flavio Leitner
On Fri, Apr 07, 2017 at 04:12:51PM +0300, Roi Dayan wrote: > From: Paul Blakey > > Add a new configuration tc-policy option that controls tc > flower flag. Possible options are none, skip_sw, skip_hw. > The default is none which is to insert the rule both to sw and hw. > This

Re: [ovs-dev] [PATCH ovs V7 03/24] other-config: Add hw-offload switch to control netdev flow offloading

2017-04-12 Thread Flavio Leitner
On Fri, Apr 07, 2017 at 04:12:50PM +0300, Roi Dayan wrote: > From: Paul Blakey > > Add a new configuration option - hw-offload that enables netdev > flow api. Enabling this option will allow offloading flows > using netdev implementation instead of the kernel datapath. > This

Re: [ovs-dev] [PATCH ovs V7 01/24] tc: Add tc flower interface

2017-04-07 Thread Flavio Leitner
On Fri, Apr 07, 2017 at 05:56:40PM -0300, Flavio Leitner wrote: > On Fri, Apr 07, 2017 at 04:12:48PM +0300, Roi Dayan wrote: > > From: Paul Blakey <pa...@mellanox.com> [...] > > > > +static const struct nl_policy act_policy[] = { > > +[TCA_ACT_KIND] = { .type

Re: [ovs-dev] [PATCH ovs V7 01/24] tc: Add tc flower interface

2017-04-07 Thread Flavio Leitner
On Fri, Apr 07, 2017 at 04:12:48PM +0300, Roi Dayan wrote: > From: Paul Blakey > > Add tc flower interface that will be used to offload flows via tc > flower classifier. Depending on the flag used (skip_sw/hw) flower > will pass those to HW or handle them itself. > Move some

Re: [ovs-dev] [RFC] lib/automake.mk: remove runtime directories

2017-03-23 Thread Flavio Leitner
On Wed, Mar 22, 2017 at 12:43:29PM -0400, Eric Garver wrote: > On Tue, Mar 21, 2017 at 02:20:30PM -0400, Aaron Conole wrote: > > Aaron Conole writes: > > > > > The Open vSwitch run, log, and DB directories are installed as part of the > > > normal `make install` process.

Re: [ovs-dev] [PATCH] fedora: Add python3-openvswitch split package

2017-03-03 Thread Flavio Leitner
On Thu, Mar 02, 2017 at 04:13:17PM -0500, Leif Madsen wrote: > On Thu, Mar 2, 2017 at 3:44 PM, Russell Bryant wrote: > > > > > On Thu, Mar 2, 2017 at 3:42 PM, Leif Madsen wrote: > > > >> Just an FYI that this patch breaks CentOS 7 builds because of the > >>

Re: [ovs-dev] [patch_v6 4/8] dpdk: Userspace Datapath: Introduce NAT Support.

2017-02-22 Thread Flavio Leitner
On Wed, Feb 22, 2017 at 04:29:09AM +, Darrell Ball wrote: > > > On 2/21/17, 1:12 PM, "ovs-dev-boun...@openvswitch.org on behalf of Flavio > Leitner" <ovs-dev-boun...@openvswitch.org on behalf of f...@sysclose.org> > wrote: > > On Thu, Feb 16, 2

Re: [ovs-dev] [PATCH] docs: fix typo in testing.rst

2017-02-21 Thread Flavio Leitner
On Mon, Feb 20, 2017 at 01:12:30PM -0500, Lance Richardson wrote: > Coverage section refers to "check-lcoc" target, should be > "check-lcov". > > Signed-off-by: Lance Richardson <lrich...@redhat.com> > --- Thanks for pointing me to that doc :-) Ac

Re: [ovs-dev] [patch_v6 2/8] dpdk: Parse NAT netlink for userspace datapath.

2017-02-21 Thread Flavio Leitner
On Thu, Feb 16, 2017 at 12:47:33AM -0800, Darrell Ball wrote: > Signed-off-by: Darrell Ball <dlu...@gmail.com> > --- Looks good to me. Acked-by: Flavio Leitner <f...@sysclose.org> ___ dev mailing list d...@openvswitch.org https://ma

<    5   6   7   8   9   10   11   >