aves != NULL));
-bundle = bundle_lookup(ofproto, aux);
if (!bundle) {
bundle = xmalloc(sizeof *bundle);
Makes sense...
Reviewed-by: Greg Rose
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Linux kernel 4.13 has been released. Update the kernel build list to
the current list of kernels from kernel.org.
Signed-off-by: Greg Rose
---
.travis.yml | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/.travis.yml b/.travis.yml
index 9d0fd44..f217840 100644
Document Open vSwitch Linux kernel support for the 4.13 kernel
release.
Signed-off-by: Greg Rose
---
Documentation/faq/releases.rst | 2 +-
NEWS | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/faq/releases.rst b/Documentation/faq
Add configuration support for the just released 4.13 Linux kernel.
Signed-off-by: Greg Rose
---
acinclude.m4 | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/acinclude.m4 b/acinclude.m4
index 46efa69..cb5f3ae 100644
--- a/acinclude.m4
+++ b/acinclude.m4
@@ -143,10 +143,10
ned-off-by: Greg Rose
---
datapath/vport-vxlan.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/datapath/vport-vxlan.c b/datapath/vport-vxlan.c
index 2910694..c7139ab 100644
--- a/datapath/vport-vxlan.c
+++ b/datapath/vport-vxlan.c
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2
The list member of nf_hook_ops has been removed in Linux kernel
release 4.13. Check for the definition of it in pre-4.13 kernels.
Signed-off-by: Greg Rose
---
datapath/linux/compat/stt.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/datapath/linux/compat/stt.c b/datapath/linux/compat
The "list" member of the nf_hook_ops structure is removed in Linux
kernel release 4.13.
Signed-off-by: Greg Rose
---
acinclude.m4 | 3 +++
1 file changed, 3 insertions(+)
diff --git a/acinclude.m4 b/acinclude.m4
index 577437f..46efa69 100644
--- a/acinclude.m4
+++ b/acinclude.m4
are no longer supported since 2.5.x.
Signed-off-by: Greg Rose
---
datapath/linux/compat/lisp.c | 21 ++---
datapath/linux/compat/stt.c | 11 +++
2 files changed, 21 insertions(+), 11 deletions(-)
diff --git a/datapath/linux/compat/lisp.c b/datapath/linux/compat/lisp.c
in
RTNL ops validate and newlink now include the extended netlink
ack feature. Check for it and set HAVE_EXT_ACK_IN_RTNL_LINKOPS
if found.
Signed-off-by: Greg Rose
---
acinclude.m4 | 3 +++
1 file changed, 3 insertions(+)
diff --git a/acinclude.m4 b/acinclude.m4
index 772ff03..577437f 100644
DST_NOCACHE was removed from the Linux 4.13 kernel. Check if
HAVE_DST_NOCACHE is defined for older kernels.
Signed-off-by: Greg Rose
---
datapath/linux/compat/include/net/ip6_fib.h | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/datapath/linux/compat/include/net
DST_NOCACHE is removed in the 4.13 Linux kernel - add check for it
and if found set HAVE_DST_NOCACHE.
Signed-off-by: Greg Rose
---
acinclude.m4 | 2 ++
1 file changed, 2 insertions(+)
diff --git a/acinclude.m4 b/acinclude.m4
index 0e98ade..772ff03 100644
--- a/acinclude.m4
+++ b/acinclude.m4
ixes: ccea74457bbd ("openvswitch: include datapath actions with sampled-pac
Cc: Neil McKee
Signed-off-by: Liping Zhang
Acked-by: Pravin B Shelar
Signed-off-by: David S. Miller
Fixes: 0e469d3b380c ("datapath: Include datapath actions with sampled-packet
upcall to user
.
Signed-off-by: Joe Perches
Acked-by: Joe Stringer
Signed-off-by: David S. Miller
Signed-off-by: Greg Rose
---
datapath/conntrack.c| 14 +-
datapath/flow_netlink.c | 2 +-
2 files changed, 6 insertions(+), 10 deletions(-)
diff --git a/datapath/conntrack.c b/datapath
getting,
cleaning, and updating the flow_stats. Adding the cpu_used_mask to
sw_flow struct does’t increase the cacheline number.
Signed-off-by: Tonghao Zhang
Acked-by: Pravin B Shelar
Signed-off-by: David S. Miller
Signed-off-by: Greg Rose
---
datapath/flow.c | 7
is not a
common case, it is unnecessary to call the numa_node_id()
everytime. This patch is not a bugfix, but there maybe
a small increase.
Signed-off-by: Tonghao Zhang
Signed-off-by: David S. Miller
Signed-off-by: Greg Rose
---
datapath/flow.c | 3 +--
1 file changed, 1
upstream kernel. Use HAVE_SKB_GSO_UDP
define from acinclude to detect if SKB_GSO_UDP exists and if so apply
openvswitch section of this upstream patch.
Signed-off-by: Greg Rose
---
datapath/flow.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/datapath/flow.c b/datapath/flow.c
index
Removed in kernel 4.13
Signed-off-by: Greg Rose
---
acinclude.m4 | 3 +++
1 file changed, 3 insertions(+)
diff --git a/acinclude.m4 b/acinclude.m4
index aeb594a..0e98ade 100644
--- a/acinclude.m4
+++ b/acinclude.m4
@@ -767,6 +767,9 @@ AC_DEFUN([OVS_CHECK_LINUX_COMPAT
On 09/11/2017 10:56 AM, Greg Rose wrote:
RTNL ops validate and newlink now include the extended netlink
ack feature. Check for it and set HAVE_EXT_ACK_IN_RTNL_LINKOPS
if found.
Signed-off-by: Greg Rose
---
acinclude.m4 | 6 ++
1 file changed, 6 insertions(+)
diff --git a/acinclude.m4
Linux kernel 4.13 has been released. Update the kernel build list to
the current list of kernels from kernel.org.
Signed-off-by: Greg Rose
---
.travis.yml | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/.travis.yml b/.travis.yml
index 9d0fd44..f217840 100644
Document Open vSwitch Linux kernel support for the 4.13 kernel
release.
Signed-off-by: Greg Rose
---
Documentation/faq/releases.rst | 2 +-
NEWS | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/faq/releases.rst b/Documentation/faq
Add configuration support for the just released 4.13 Linux kernel.
Signed-off-by: Greg Rose
---
acinclude.m4 | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/acinclude.m4 b/acinclude.m4
index 46efa69..cb5f3ae 100644
--- a/acinclude.m4
+++ b/acinclude.m4
@@ -143,10 +143,10
ned-off-by: Greg Rose
---
datapath/vport-vxlan.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/datapath/vport-vxlan.c b/datapath/vport-vxlan.c
index 2910694..c7139ab 100644
--- a/datapath/vport-vxlan.c
+++ b/datapath/vport-vxlan.c
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2
The list member of nf_hook_ops has been removed in Linux kernel
release 4.13. Check for the definition of it in pre-4.13 kernels.
Signed-off-by: Greg Rose
---
datapath/linux/compat/stt.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/datapath/linux/compat/stt.c b/datapath/linux/compat
are no longer supported since 2.5.x.
Signed-off-by: Greg Rose
---
datapath/linux/compat/lisp.c | 21 ++---
datapath/linux/compat/stt.c | 11 +++
2 files changed, 21 insertions(+), 11 deletions(-)
diff --git a/datapath/linux/compat/lisp.c b/datapath/linux/compat/lisp.c
in
RTNL ops validate and newlink now include the extended netlink
ack feature. Check for it and set HAVE_EXT_ACK_IN_RTNL_LINKOPS
if found.
Signed-off-by: Greg Rose
---
acinclude.m4 | 6 ++
1 file changed, 6 insertions(+)
diff --git a/acinclude.m4 b/acinclude.m4
index 772ff03..46efa69 100644
DST_NOCACHE was removed from the Linux 4.13 kernel. Check if
HAVE_DST_NOCACHE is defined for older kernels.
Signed-off-by: Greg Rose
---
datapath/linux/compat/include/net/ip6_fib.h | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/datapath/linux/compat/include/net
DST_NOCACHE is removed in the 4.13 Linux kernel - add check for it
and if found set HAVE_DST_NOCACHE.
Signed-off-by: Greg Rose
---
acinclude.m4 | 2 ++
1 file changed, 2 insertions(+)
diff --git a/acinclude.m4 b/acinclude.m4
index 0e98ade..772ff03 100644
--- a/acinclude.m4
+++ b/acinclude.m4
ixes: ccea74457bbd ("openvswitch: include datapath actions with sampled-pac
Cc: Neil McKee
Signed-off-by: Liping Zhang
Acked-by: Pravin B Shelar
Signed-off-by: David S. Miller
Fixes: 0e469d3b380c ("datapath: Include datapath actions with sampled-packet
upcall to user
.
Signed-off-by: Joe Perches
Acked-by: Joe Stringer
Signed-off-by: David S. Miller
Signed-off-by: Greg Rose
---
datapath/conntrack.c| 14 +-
datapath/flow_netlink.c | 2 +-
2 files changed, 6 insertions(+), 10 deletions(-)
diff --git a/datapath/conntrack.c b/datapath
getting,
cleaning, and updating the flow_stats. Adding the cpu_used_mask to
sw_flow struct does’t increase the cacheline number.
Signed-off-by: Tonghao Zhang
Acked-by: Pravin B Shelar
Signed-off-by: David S. Miller
Signed-off-by: Greg Rose
---
datapath/flow.c | 7
is not a
common case, it is unnecessary to call the numa_node_id()
everytime. This patch is not a bugfix, but there maybe
a small increase.
Signed-off-by: Tonghao Zhang
Signed-off-by: David S. Miller
Signed-off-by: Greg Rose
---
datapath/flow.c | 3 +--
1 file changed, 1
upstream kernel. Use HAVE_SKB_GSO_UDP
define from acinclude to detect if SKB_GSO_UDP exists and if so apply
openvswitch section of this upstream patch.
Signed-off-by: Greg Rose
---
datapath/flow.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/datapath/flow.c b/datapath/flow.c
index
Removed in kernel 4.13
Signed-off-by: Greg Rose
---
acinclude.m4 | 3 +++
1 file changed, 3 insertions(+)
diff --git a/acinclude.m4 b/acinclude.m4
index aeb594a..0e98ade 100644
--- a/acinclude.m4
+++ b/acinclude.m4
@@ -767,6 +767,9 @@ AC_DEFUN([OVS_CHECK_LINUX_COMPAT
On 09/08/2017 06:35 AM, Weglicki, MichalX wrote:
Greg,
Patch is rebased and sent to mailing list as V3 (Last patch was supposed to be
V2 - Przemek by accident sent it again as V1).
Br,
Michal.
Thanks, I'll have a look at it!
- Greg
> -Original Message-
> From
On 09/07/2017 03:49 PM, Justin Pettit wrote:
On Sep 7, 2017, at 3:48 PM, Greg Rose wrote:
On 09/07/2017 03:47 PM, Justin Pettit wrote:
On Sep 7, 2017, at 3:45 PM, Greg Rose wrote:
On 09/07/2017 03:44 PM, Justin Pettit wrote:
On Sep 7, 2017, at 3:42 PM, Greg Rose wrote:
On 09/07/2017 01
On 09/07/2017 03:47 PM, Justin Pettit wrote:
On Sep 7, 2017, at 3:45 PM, Greg Rose wrote:
On 09/07/2017 03:44 PM, Justin Pettit wrote:
On Sep 7, 2017, at 3:42 PM, Greg Rose wrote:
On 09/07/2017 01:09 PM, Justin Pettit wrote:
On Sep 7, 2017, at 10:14 AM, Ben Pfaff wrote:
On Tue, Sep 05
On 09/07/2017 03:44 PM, Justin Pettit wrote:
On Sep 7, 2017, at 3:42 PM, Greg Rose wrote:
On 09/07/2017 01:09 PM, Justin Pettit wrote:
On Sep 7, 2017, at 10:14 AM, Ben Pfaff wrote:
On Tue, Sep 05, 2017 at 10:22:47AM -0700, Justin Pettit wrote:
Signed-off-by: Justin Pettit
Acked-by
On 09/07/2017 01:09 PM, Justin Pettit wrote:
On Sep 7, 2017, at 10:14 AM, Ben Pfaff wrote:
On Tue, Sep 05, 2017 at 10:22:47AM -0700, Justin Pettit wrote:
Signed-off-by: Justin Pettit
Acked-by: Ben Pfaff
Thanks. I pushed this to master and branch-2.8.
There are patches posted to this
On 08/24/2017 08:10 AM, Greg Rose wrote:
Removed in kernel 4.13
Signed-off-by: Greg Rose
---
acinclude.m4 | 3 +++
1 file changed, 3 insertions(+)
diff --git a/acinclude.m4 b/acinclude.m4
index 74cc046..9bd1c49 100644
--- a/acinclude.m4
+++ b/acinclude.m4
@@ -763,6 +763,9 @@ AC_DEFUN
On 09/03/2017 10:19 PM, Roi Dayan wrote:
On 29/08/2017 07:30, Roi Dayan wrote:
Hi,
The first commit is a fix for parsing set masked action
and the second commit is adding a test.
Before the fix the addtion of the tests fails with the following:
# make check TESTSUITEFLAGS=436
# ./tests/ovste
ards.
I'll just need to debug the connection issue to the
collector.
Thanks,
- Greg
-Original Message-
From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-boun...@openvswitch.org]
On Behalf Of Greg Rose
Sent: Saturday, August 19, 2017 12:51 AM
To: Szczerbik, PrzemyslawX
Cc
ssage-
From: Greg Rose [mailto:gvrose8...@gmail.com]
Sent: Tuesday, August 29, 2017 5:15 PM
To: Weglicki, MichalX
Cc: d...@openvswitch.org; Szczerbik, PrzemyslawX
Subject: Re: [ovs-dev] [PATCH 2/2] ofproto-dpif-ipfix: add interface
Information Elements to flow key
On 08/29/2017 04:48 AM, Weg
On 08/25/2017 03:51 PM, Yi-Hung Wei wrote:
Previously, --ct-next option in ofproto/trace only supports specifying
ct_state. This patch adds support of ct_mark and ct_label.
Signed-off-by: Yi-Hung Wei
---
lib/ct-dpif.c| 7
lib/ct-dpif.h| 3 ++
lib/netli
7;trk,est' --ct-next 'trk,est' ], [0], [stdout])
+AT_CHECK([ovs-appctl ofproto/trace br0 'in_port=1,tcp' --ct-next 'trk|est'
--ct-next 'trk|est' ], [0], [stdout])
AT_CHECK([tail -1 stdout], [0],
[Datapath actions: 3
])
LGTM.
Reviewed-by:
ER;
-if (!parse_ct_state(state_s_, CS_TRACKED, &state, &ds)) {
+if (!parse_ct_state(state_s_, CS_TRACKED, ", ", &state, &ds)) {
ovs_fatal(0, "%s", ds_cstr(&ds));
}
if (!validate_ct_state(state, &ds)) {
Other than my comment
On 08/25/2017 03:51 PM, Yi-Hung Wei wrote:
The ct_state of an uncommmited new flow is marked as related if the flow
is in the conntrack expectation table. In order for ofproto/trace to
identify the ct_state of a new related flow, this patch utilizes
NFNL_SUBSYS_CTNETLINK_EXP netlink subsystem to
On 08/25/2017 03:51 PM, Yi-Hung Wei wrote:
This patch implements ct_get_info() in dpif-netlink. It uses
NFNL_SUBSYS_CTNETLINK netlink subsystem to query conntrack info from
kernel datapath. Then, ofproto/trace can use the ct_get_info() to derive
the ct_state of the traced flow. System traffic tes
On 08/25/2017 03:51 PM, Yi-Hung Wei wrote:
Instead of using fixed default conntrack state 'trk|new' in
ofproto/trace for conntrack recirculation, this patch queries the
conntrack state from datapath using ct_dpif_get_info().
Signed-off-by: Yi-Hung Wei
---
lib/ct-dpif.c| 42 +++
, otherwise returns nonzero value. */
+int (*ct_get_info)(struct dpif *, struct ct_dpif_tuple *tuple,
+ const uint16_t zone, struct ct_dpif_info *info);
+
/* Meters */
/* Queries 'dpif' for supported meter features.
Seems fine to me.
Reviewed
t create a helper struct
to contain all the parameters and just pass a pointer. Personally I start
looking for ways to cut down on parameter
passing when a function gets to 4 or more parameters. Again - just a personal
predilection.
Otherwise the patch LGTM.
Reviewed-by: Greg Rose
struct ds s = DS_EMPTY_INITIALIZER;
format_flags(&s, ct_state_to_string, ct_state, '|');
ds_put_format(output, " - resume conntrack with ct_state=%s",
Besides the minor nit above it LGTM.
Reviewed-by: Greg Rose
ommit e8b91cf36769 " Merge branch
'dpdk_merge' of https://github.com/darball/ovs."; passes a travis build check.
Tested-by: Greg Rose
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
PP_LOCAL,
.flow_metadata.wc.masks.in_port.ofp_port
= u16_to_ofp(UINT16_MAX),
Reviewed-by: Greg Rose
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 08/28/2017 12:08 AM, Ilya Maximets wrote:
TIME_UPDATE_INTERVAL was removed long time ago.
Now each call leads to time update via syscall and it's
granularity is system dependent.
Fixes: 31ef9f5178de ("timeval: Remove CACHE_TIME scheme.")
Signed-off-by: Ilya Maximets
---
lib/timeval.c | 10
m 'dpif'.
*
* 'upcall->key' and 'upcall->userdata' point into data in the caller-provided
* 'buf', so their memory cannot be freed separately from 'buf'.
LGTM
Reviewed-by: Greg Rose
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
some other work and will get back to this afterwards. I'll just need to debug
the connection issue to the collector.
Thanks,
- Greg
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org
[mailto:ovs-dev-boun...@openvswitch.org] On Behalf Of Greg Rose
> Sent: Satur
ixes: ccea74457bbd ("openvswitch: include datapath actions with sampled-pac
Cc: Neil McKee
Signed-off-by: Liping Zhang
Acked-by: Pravin B Shelar
Signed-off-by: David S. Miller
Fixes: 0e469d3b380c ("datapath: Include datapath actions with sampled-packet
upcall to user
.
Signed-off-by: Joe Perches
Acked-by: Joe Stringer
Signed-off-by: David S. Miller
Signed-off-by: Greg Rose
---
datapath/conntrack.c| 14 +-
datapath/flow_netlink.c | 2 +-
2 files changed, 6 insertions(+), 10 deletions(-)
diff --git a/datapath/conntrack.c b/datapath
getting,
cleaning, and updating the flow_stats. Adding the cpu_used_mask to
sw_flow struct does’t increase the cacheline number.
Signed-off-by: Tonghao Zhang
Acked-by: Pravin B Shelar
Signed-off-by: David S. Miller
Signed-off-by: Greg Rose
---
datapath/flow.c | 7
is not a
common case, it is unnecessary to call the numa_node_id()
everytime. This patch is not a bugfix, but there maybe
a small increase.
Signed-off-by: Tonghao Zhang
Signed-off-by: David S. Miller
Signed-off-by: Greg Rose
---
datapath/flow.c | 3 +--
1 file changed, 1
upstream kernel. Use HAVE_SKB_GSO_UDP
define from acinclude to detect if SKB_GSO_UDP exists and if so apply
openvswitch section of this upstream patch.
Signed-off-by: Greg Rose
---
datapath/flow.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/datapath/flow.c b/datapath/flow.c
index
Removed in kernel 4.13
Signed-off-by: Greg Rose
---
acinclude.m4 | 3 +++
1 file changed, 3 insertions(+)
diff --git a/acinclude.m4 b/acinclude.m4
index 74cc046..9bd1c49 100644
--- a/acinclude.m4
+++ b/acinclude.m4
@@ -763,6 +763,9 @@ AC_DEFUN([OVS_CHECK_LINUX_COMPAT
On 08/23/2017 04:24 PM, Joe Stringer wrote:
On 23 August 2017 at 11:21, Greg Rose wrote:
> Upstream commit:
> commit c57c054eb5b1ccf230c49f736f7a018fcbc3e952
> Author: Tonghao Zhang
> Date: Mon Jul 17 23:28:05 2017 -0700
>
> openvswitch: Optimiz
On 08/23/2017 04:21 PM, Joe Stringer wrote:
On 23 August 2017 at 11:21, Greg Rose wrote:
> Upstream commit:
> commit 880388aa3c07fdea4f9b85e35641753017b1852f
> Author: David S. Miller
> Date: Mon Jul 3 07:29:12 2017 -0700
>
> net: Remove all referen
7bbd ("openvswitch: include datapath actions with sampled-pac
Cc: Neil McKee
Signed-off-by: Liping Zhang
Acked-by: Pravin B Shelar
Signed-off-by: David S. Miller
Fixes: 0e469d3b380c ("datapath: Include datapath actions with sampled-packet
upcall to userspace
.
Signed-off-by: Joe Perches
Acked-by: Joe Stringer
Signed-off-by: David S. Miller
Signed-off-by: Greg Rose
---
datapath/conntrack.c| 14 +-
datapath/flow_netlink.c | 2 +-
2 files changed, 6 insertions(+), 10 deletions(-)
diff --git a/datapath/conntrack.c b/datapath
getting,
cleaning, and updating the flow_stats. Adding the cpu_used_mask to
sw_flow struct does’t increase the cacheline number.
Signed-off-by: Tonghao Zhang
Acked-by: Pravin B Shelar
Signed-off-by: David S. Miller
Signed-off-by: Greg Rose
---
datapath/flow.c | 7
is not a
common case, it is unnecessary to call the numa_node_id()
everytime. This patch is not a bugfix, but there maybe
a small increase.
Signed-off-by: Tonghao Zhang
Signed-off-by: David S. Miller
Signed-off-by: Greg Rose
---
datapath/flow.c | 3 +--
1 file changed, 1
this upstream patch.
Signed-off-by: Greg Rose
---
datapath/flow.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/datapath/flow.c b/datapath/flow.c
index c4f63b0..9bf3eba 100644
--- a/datapath/flow.c
+++ b/datapath/flow.c
@@ -589,8 +589,7 @@ static int key_extract(struct
On 08/18/2017 02:41 PM, Joe Stringer wrote:
On 16 August 2017 at 15:48, Greg Rose wrote:
> Upstream commit:
> commit 494bea39f3201776cdfddc232705f54a0bd210c4
> Author: Liping Zhang
> Date: Wed Aug 16 13:30:07 2017 +0800
>
> For sw_flow_actions, th
On 08/16/2017 01:54 AM, Szczerbik, PrzemyslawX wrote:
Hi,
I haven't received any feedback on this patch for quite some time.
Is there anything that I can do to expedite review process?
Regards,
Przemek
Przemek,
I'm in the process of looking into this patch but I'm running into an issue
wit
On 08/16/2017 01:54 AM, Szczerbik, PrzemyslawX wrote:
Hi,
I haven't received any feedback on this patch for quite some time.
Is there anything that I can do to expedite review process?
Regards,
Przemek
[snip]
I'll have a look at it over the next few days and see if I can provide some
feedb
me) {
+tnl_port_map_delete_ipdev(change->ifname);
+}
+}
}
Works as advertised...
Tested-by: Greg Rose
Reviewed-by: Greg Rose
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
pled-"...)
Cc: Neil McKee
Signed-off-by: Liping Zhang
Acked-by: Pravin B Shelar
Signed-off-by: David S. Miller
Signed-off-by: Greg Rose
---
datapath/actions.c | 1 +
datapath/datapath.c | 7 ---
datapath/datapath.h | 2 ++
3 files changed, 7 insertions(+), 3 deletio
tics, only the values shown by the above
command.
For each pmd thread of the datapath \fIdp\fR shows list of queue-ids with
port names, which this thread polls.
+.IP "\fBdpif-netdev/pmd-rxq-rebalance\fR [\fIdp\fR]"
+Reassigns rxqs to pmds in the datapath \fIdp\fR based on their curren
[[0-9]]*\( core_id
\)[[0-9]]*:/\1\2:/;s/\(queue-id: \)1 2 5 6/\1/;s/\(queue-id: \)0 3 4
7/\1/"])
m4_define([DUMMY_NUMA], [--dummy-numa="0,0,0,0"])
Tested-by: Greg Rose
Reviewed-by: Greg Rose
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
xqs[i]->rx),
+ netdev_rxq_get_name(rxqs[i]->rx),
+ rxqs[i]->pmd->core_id, rxqs[i]->pmd->numa_id);
+} else {
+rxqs[i]->pmd = rr_numa_get_pmd(numa);
+VLOG_INFO("Core %d on numa node %d assigned port \'%s\' &quo
rxq_cyc_curr);
+dp_netdev_rxq_set_cycles(poll_list[i].rxq, RXQ_CYCLES_PROC_CURR,
+ 0);
+}
+/* Start new measuring interval */
+ pmd->rxq_interval = now + PMD_RXQ_INTERVAL;
+}
if (now > pmd->next_op
cycles_count_intermediate(pmd,
+cycles_count_intermediate(pmd, NULL,
process_packets ? PMD_CYCLES_PROCESSING
: PMD_CYCLES_IDLE);
Tested-by: Greg Rose
Reviewed-by: Greg Rose
___
dp_netdev_process_rxq_port(pmd, poll_list[i].rx,
+dp_netdev_process_rxq_port(pmd, poll_list[i].rxq->rx,
poll_list[i].port_no);
cycles_count_intermediate(pmd,
Tested-by: Greg Rose
Reviewed-by: Greg Rose
a);
+netdev_port_data_destroy(data);
ret = 0;
}
LGTM
Reviewed-by: Greg Rose
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 08/09/2017 08:47 AM, Kevin Traynor wrote:
On 08/08/2017 07:15 PM, Greg Rose wrote:
> On 08/01/2017 08:58 AM, Kevin Traynor wrote:
>> Previously rxqs were assigned to pmds by round robin in
>> port/queue order.
>>
>> Now that we have the processing cycles used for
On 08/01/2017 08:58 AM, Kevin Traynor wrote:
Previously rxqs were assigned to pmds by round robin in
port/queue order.
Now that we have the processing cycles used for existing rxqs,
use that information to try and produced a better balanced
distribution of rxqs across pmds. i.e. given multiple p
On 08/04/2017 02:56 PM, Kevin Traynor wrote:
On 08/04/2017 10:31 PM, Greg Rose wrote:
> On 08/01/2017 08:58 AM, Kevin Traynor wrote:
>> Previously rxqs were assigned to pmds by round robin in
>> port/queue order.
>>
>> Now that we have the processing cycles used for
On 08/01/2017 08:58 AM, Kevin Traynor wrote:
Previously rxqs were assigned to pmds by round robin in
port/queue order.
Now that we have the processing cycles used for existing rxqs,
use that information to try and produced a better balanced
distribution of rxqs across pmds. i.e. given multiple p
On 08/04/2017 01:07 AM, Bhanuprakash Bodireddy wrote:
Keepalive feature is aimed at achieving Fastpath Service Assurance
in OVS-DPDK deployments. It adds support for monitoring the packet
processing cores(PMD thread cores) by dispatching heartbeats at regular
intervals. Incase of heartbeat misses
>key_len) {
if (nl_attr_type(a) == OVS_KEY_ATTR_RECIRC_ID
&& nl_attr_get_u32(a) != 0) {
return EINVAL;
Reviewed-by: Greg Rose
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
}
I suppose we have to protect ourselves from malformed messages but I suppose
there might be some small impact on performance?
Reviewed by: Greg Rose
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
on the ovs-dev list.
Reviewed-by: Greg rose
-Original Message-
From: on behalf of Darrell Ball
Date: Thursday, July 27, 2017 at 4:50 PM
To: "d...@openvswitch.org"
Subject: [ovs-dev] [patch_v1] docs/dpdk: Consolidate pmd-cpu-mask references.
The DPDK introductory doc
On 07/28/2017 10:56 AM, Darrell Ball wrote:
Thanks for testing Greg
We are at DPDK 16.11.2 now
See this link
http://docs.openvswitch.org/en/latest/faq/releases/
Darrell
Well that explains things!
Thanks, I'll give it another go with 16.11.2.
- Greg
-Original Message-
From:
Bhanuprakash,
After applying your patch series on top of current master and building I
get the following error:
libtool: compile: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I ./include
-I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare
-Wpointer-arith -Wformat -Wformat
last_mod_time=log_last_mod_time)
-if not os.path.exists('/var/log/dmesg') and \
- not os.path.exists('/var/log/boot'):
-cmd_output(CAP_SYSTEM_LOGS, [DMESG])
+cmd_output(CAP_SYSTEM_LOGS, [DMESG])
cmd_output(CAP_SYSTEM_SERVICES, [CHKC
, CAP_NETWORK_CONFIG]
ovs_info_list = ['process-tree']
# We cannot use iteritems, since we modify 'data' as we pass through
for (k, v) in data.items():
Reviewed-by: Greg Rose
Tested-by: Greg Rose
___
dev
f rx queues. */
-bool need_reconfigure; /* True if we should reconfigure netdev. */
};
/* Contained by struct dp_netdev_flow's 'stats' member. */
Reviewed-by: Greg Rose
Tested-by: Greg Rose
___
dev mailing list
d...@openvswitch.
996b ("datapath: Add conntrack action")
Signed-off-by: Greg Rose
---
V2 - Add appropriate "Fixes" tag for OOT repository
---
datapath/conntrack.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/datapath/conntrack.c b/datapath/conntrack.c
index bba9bf
_ct_attr_lens's minlen and maxlen, else, out of bound access
may happen.
Fixes: 7f8a436eaa2c ("openvswitch: Add conntrack action")
Signed-off-by: Liping Zhang
Acked-by: Pravin B Shelar
Signed-off-by: David S. Miller
Pick up an upstream bug fix.
Signed-of
On 07/24/2017 10:19 AM, Joe Stringer wrote:
On 24 July 2017 at 08:31, Greg Rose wrote:
> On 07/21/2017 04:46 PM, Joe Stringer wrote:
>>
>> This series takes Greg's recent proposed series, rolls in a few missed
>> upstream commits, and orders them the same as
go ahead and backport patches even though the
kernel
they are targeted for has not been released yet.
Thank you Joe!
Regards,
- Greg
Greg Rose (7):
datapath: introduce nf_conntrack_helper_put function
datapath: Fix inconsistent teardown and release of private netdev
state.
compat:
On 07/21/2017 04:46 PM, Joe Stringer wrote:
From: Greg Rose
Upstream commit:
commit d91fc59cd77c719f33eda65c194ad8f95a055190
Author: Liping Zhang
Date: Sun May 7 22:01:55 2017 +0800
netfilter: introduce nf_conntrack_helper_put helper function
And convert
rly next week.
Thanks!
- Greg
>
> I've added my sign-off to all of the other patches, which I have reviewed.
>
> Greg Rose (7):
> datapath: introduce nf_conntrack_helper_put function
> datapath: Fix inconsistent teardown and release of private netdev
> state.
701 - 800 of 961 matches
Mail list logo
